Commit Graph

27949 Commits

Author SHA1 Message Date
Qwertytoforty
0caf77d272 Attack Chain Migration: /obj/item/card (#27556)
* the work so far

* She returns on my TRUE till I ITEM_INTERACT_SUCCESS

* do this too (rip good commit name)

* Did you know? You can stamp ID cards!
2024-12-15 21:06:48 +00:00
warriorstar-orion
87b91b1685 Move some per-tile tests to maplints. (#27645)
* Move some per-tile tests to maplints.

* ughghg

* death
2024-12-15 20:57:41 +00:00
Contrabang
0e765746b6 Adds a new TGUI Admin Antag Menu (#27545)
* Adds a new TGUI Admin Antag Menu

* Prettier

* fuck

* oops

* swap this shiiit

* Rebuild

* changes

* hate contractors, simple as

* welp forgot this

* fix

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-15 01:39:12 +00:00
DGamerL
2061e31512 Aaaaaaaaaaaa (#27648) 2024-12-15 01:14:49 +00:00
Contrabang
5568476574 Fixes some messages showing up in the Unsorted Chat Tab (#27614)
* Fixes some messages showing up in the Unsorted Chat Tab

* yes

* yes

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Signed-off-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-14 19:10:16 +00:00
Migratingcocofruit
e03352ddb9 Singulo Buffs - Again (#27361)
* iteration 1

* oops

* Okay now it actually works

* remove rad cap

* Adds a singulo monitor

* comments and other fixes

* rebuild tgui

* updates last size now. breach alerts now go before warnings

* oops

* fix console lables for the field gens

* New generator lookup algorithm

* comment added

* sort out the return and checks on temp_gens

* Adds sprites to the singulo monitor

* fix sprite stuff and singulo alert

* rebuild tgui

* Adds a singulo monitor board to RnD.  Uses the correct icon when no singulo is being monitored.

* give commas some space

* Adds a singulo console board to the singulo engine crate

* style fixes and fixes the check for singularity location and type

* Rebuild Tgui

* style fixes and a comment

* Removes redundant brackets

* Correct the check for there being containing generators

* Changes the generator_field variable to a more generic name

* adds a period to a comment

* Restore accidentally modified icons to their original state

* Rebuild TGUI

* Rebuild tgui

* rebuild tgui

* Rebuild TGUI

* rebuild tgui

* TGUI rebuild

* Style fixes

* TGUI rebuild

* rebuild tgui

* rebuild tgui

* Let's see if this works

* I didn't see that merge conflict. Rebuilding again

* rebuild tgui

* Rebuild TGUI

* Review changes

* Changes to the new variable name in the singulo monitor

* Adjusts bar values for each colour according to the reduced energy capacity of the new generators

* Rebuild TGUI

* Review changes

* missed a line

* improves a couple comments

* removes the pre loose warning from the singulo. It will now only alert the station once the singulo is loose. Fixes loose alerts being given repeatedly

* Update tgui.bundle.js

* TGUI rebuild

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Fixes a bug causing the console to announce a singuloose when selecting a singularity at level 2 or above

* Removes alerts from the singulo console

* Rebuild and Merge Master

* Change the name of the singulo gen crate to include the console board

* fixes a runtime that terminated the destructor prematurely when deconstructing a console that hasn't selected a singularity

* Removes generators from the interface when they become inactive

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-14 06:07:11 +00:00
Migratingcocofruit
7539308d89 SM no longer cools down gas (#27492) 2024-12-11 16:42:24 +00:00
1080pCat
9979f7c80d Buffs the radsuit slightly (#27570) 2024-12-11 16:18:26 +00:00
Migratingcocofruit
55ff05d57b Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient (#27168)
* Changes crush to per gas bonuses depending on amount in the chamber

* Undef the defines

* oops

* Make anomaly spawn threshold depend on power + bonus rather than power or crunch threshold.

* moves the crunch bonus outside the if scope

* Makes mole_crunch_bonus a variable of the SM

* adds mole_crunch_bonus to power on the top if of the arcs and anomaly section

* Adds mole count and the gas coefficient of the mix to the SM monitoring console

* Removes a redundant rounding

* Rebuild TGUI

* rebuild tgui

* Update tgui.bundle.js

* Update tgui.bundle.js

* Changes the variable name to gas coefficient

* oops

* Makes the uses of gas_coefficient a bit tidier

* Update tgui.bundle.js

* Update tgui.bundle.js

* Tgui rebuild

* Makes scaling below the old crush threshold quadratic, and makes GC scale with the square root of total moles above it.

* Uses linear scaling for the moles progress bar

* Corrects using the log scaled value of the moles for the bar

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-11 15:40:22 +00:00
Burzah
3ff1323453 Another one (#27606) 2024-12-10 18:50:49 +00:00
warriorstar-orion
5872c37175 Create directional helpers for newscasters. (#27583)
* Create directional helpers for newscasters.

* set script PR number
2024-12-09 20:41:42 +00:00
DGamerL
e2b0bac2b6 Proc to easy spawn in hallucinations (#27582)
* Proc to easy spawn in hallucinations

* Comment
2024-12-09 17:57:26 +00:00
DGamerL
79938b3cac Fixes managers runtiming on delete (#27585) 2024-12-08 16:04:32 +00:00
Mikhail Dzianishchyts
3336bfd43b Fix alien egg not being able to can (#27537)
* Force body eggs to call parent `on_life()`

* Force body eggs to call parent `dead_process()`

* Call parent
2024-12-08 00:50:23 +00:00
Toastical
aa140c1184 Tweak: Magma-ale and space beer are now a bottle subtype (#27407)
* makes magma-ale and space beer bottles instead of cans
replaced all occurences of the cans to the new type

* forgot to rever test_tiny

* path script + repathing

* space bar sleepy beer repath

* Update tools/UpdatePaths/Scripts/27407_ale_beer_repath.txt

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>

* Update code/game/objects/structures/crates_lockers/closets/secure/bar.dm

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>

---------

Signed-off-by: Toastical <vnndvp@gmail.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
2024-12-07 22:18:55 +00:00
Toastical
ca7b13fe99 legacyfies the slime console procs (#27576) 2024-12-07 22:11:12 +00:00
warriorstar-orion
9941066689 Fix negotiaton between attack chains causing issues with borgs (#27571)
* Attack chain: borg interactions and janicart migration

* redundant check
2024-12-07 21:43:33 +00:00
warriorstar-orion
d23c808e47 Fixes several attack chain call sites (#27553) 2024-12-06 22:20:12 +00:00
warriorstar-orion
af2a3daf22 Migrate /obj/effect/spawner/lootdrop to /obj/effect/spawner/random. (#27445)
* refactor: Migrate /obj/effect/spawner/lootdrop to /obj/effect/spawner/random.

* set script PR number

* fix broken updatepaths for three course meal

* make filenames unique

* goddamnit

* redirect incorrect icon states

* ugh

* fix typepath fixes
2024-12-06 15:05:38 +00:00
ExusA
584e6b26d5 Adds the RSF Executive Service Upgrade for cyborgs (#27371)
* Adds the Executive RSF cyborg upgrade.

First commit for the Executive RSF with basic functionality.

* Add cheese knife

Adds a cheese knife along with the RSF upgrade to cut the cheese.

* Executive RSF Upgrade functionality.

Adds cheeses, caviar, cheese knife, and reorders RSF code to be neater.

* Nerf cyborg cheeses

Nerfs cyborg cheeses to be worse than chef food.

* Resprites Smoked Cheese

* Fixes power cost calculation

* Cleanup

* Standardize tech and Materials cost

* Adds caviar trash

Adds an empty caviar can.

* Edam and flavor

Add Edam

Adjusts flavors to compete with cheese reagent

* Undo sprinkled donut

Undid changes to RSF donut

* Fix RSF icon missed pixel

* Boolean fix

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Signed-off-by: ExusA <67055922+ExusA@users.noreply.github.com>

* Resprites basic cheese

Resprites basic cheese at the request of @DGamerL

* Update new cheese sprite

Adds wax to the new cheese.

* Delete unused cheese icon

Deletes a prototype cheese icon.

* Readds normal cigarettes to the executive RSF

Adds normal cigarettes back to the RSF at Fordoxia's request.

* Turns caviar from red to black

Rebrands caviar into the fancier, black variety

* Deconflict

---------

Signed-off-by: ExusA <67055922+ExusA@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
2024-12-06 14:03:58 +00:00
SchrodingersWolf
ab0627b264 Paradise Station: Episode V - The Laserslug Strikes Back (#27457)
* (Laser) Slugs are BACK!

* The shotgun is the perfect home defense weapon
2024-12-06 13:54:48 +00:00
larentoun
513d7aa89a use initial values (#27552) 2024-12-06 08:15:52 +00:00
Qwertytoforty
9f01db07ef Rebalances the 3 least used non temp or illegal guns, + BSG (#27476)
* guns

* bsg fix, shield

* lwap scoped always hits crawling mobs

* decrease scope time

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>

---------

Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-05 22:07:33 +00:00
AffectedArc07
d663dfc3fb [READY FOR TM] R&D Rework Part 2 - Death to the experimentor (#27472)
* PT1 - Death to experimentor

* I cant fail CI this fast come on

* PT2 - DA -> SA

* CRLF to LF

* Strange icons in the SA now

* Lets give this a go

* AGH

* Dirt

* WORK

* Oops - cere was missing the RD locker

* Map fixes

* Adds delivery chute back

* Warrior review

* Also removes magnetics

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-12-04 17:55:39 +00:00
warriorstar-orion
525c68d617 Attack chain, initial setup. (pull *immediately* for *any* TM issues) (#26834)
* refactor: Attack chain, initial setup.

* migrate curtain to make dreamchecker happy

* update thurible

* don't call attacked_by separately for legacy attack chain

* remove duplicate proc

* condense similar code, put allowances for legacy code in new procs

* update docs, include diagram source

* add comment on how to update diagram

* fix admonition

* mindflayer updates

* remove commented out code

* clarify all steps

* after_attack should be overridable

* whoops

* retrofit recent changes

* duh, can't restrict this yet because of tool_acts

* i hate ore bags with the fire of a thousand suns

* return correct value for object attack logic

* Various cleanups.

We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.

I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.

* simplify some argument names

* fuck it

* make it do the thing

* Rename CI module call

* Prove that CI works

* improve test output

* aaand fix it again

* fix curtain tool interactions

* fix compile error

* fix compile error

* Better docs, introduce migration plan tool.
2024-12-02 23:36:36 +00:00
DGamerL
e9e16645e1 Adds hallucination managers (#27482)
* Adds hallucination managers

* Contra + Lewc review

* Contra review

* Initial comment enhancement
2024-12-02 21:41:42 +00:00
warriorstar-orion
2876d90815 Add ruin jump description messages back. (#27511) 2024-12-02 18:06:57 +00:00
Chap
e47700f4ad Right let us try this again shall we (#27451)
Co-authored-by: Adrer <adrermail@gmail.com>
2024-12-02 17:56:22 +00:00
Toastical
4cbab3c82c Tweak: NT Merch vendor can now be moved and adds it's circuit board to the Circuit Imprinter. (#27374)
* NT Merch vendor can now be moved

* Made the NT Merch vendor board printable in the Circuit Imprinter
2024-12-02 17:55:36 +00:00
Contrabang
e6c376bb20 Adds logging to Custom Tips (#27501) 2024-12-02 05:56:59 +00:00
Mikhail Dzianishchyts
8058cc7756 Fix invalid reagent id (#27517) 2024-12-01 23:23:05 +00:00
warriorstar-orion
0ffa8303a7 Rename all non-snake_case types. (#27268)
* refactor: Rename all non-snake_case types (not procs or vars (yet)).

* completely dynamic update script

* might help to include the data

* update aa's scuffed python

* oh

* set script PR number

* run updatepaths again

* Add other table updates with JSON columns

* bump SQL version

* just fucking end my life

* move JSON data
2024-11-30 19:08:45 +00:00
Contrabang
0c5fb4198d Fixes Cable Prefabs and adds some more mapping CI (#27386)
* Fixes Cable Prefabs and adds some more mapping CI

* yes

* test

* bam
2024-11-30 15:36:20 +00:00
Contrabang
eea4872e93 Fixes Stacking with the Check AI Laws verb (#27497) 2024-11-30 15:13:26 +00:00
ExusA
35450c8f71 Forbids medical rovers from wearing hats (#27500)
Medical rovers can no longer wear hats, as the system doesn't allow hat offsets per-direction.
2024-11-30 15:11:30 +00:00
Qwertytoforty
6444de4618 I'M TIRED OF SEEING IT (#27483) 2024-11-30 14:29:11 +00:00
Contrabang
734d0166a0 Removes some non-existant typepaths (#27362)
* Adds CI for missing icon_states

* yeah

* more fixes

* more fixes

* seems good

* moar

* fix

* yea

* hrtyhrt

* yeah

* WOE

* Removes some non-existant typepaths

* yes
2024-11-30 12:04:03 +00:00
Adri
fca84e2e7e Adds PDA ringtone to character preferences (#27365)
* Adds PDA ringtone to character preferences

* Two fixes

* Reset option

* Contra request

* DB update

* linter fix

* SQL update

* file rename

---------

Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-11-30 10:53:19 +00:00
Luc
8da12bc5e2 Makes playing cards playable -- significantly reworks card interactions (#26585)
* Basic card interactions

* initial interactions sorted

* nails down some interactions, radial menu

* Some more qol and keybind changes

* improves card interactions

* Unum decks can be flipped, showing the top card

* Decks can now be split and recombined

* minor tweaks to multi-deck stuff

* Clean up a bunch of interactions

* more cleanups

* more cleanups and documentation

* remote attacking looks pretty good

* minor cleanups

* ci

* parser errs

* Remove some debug things, re-add signal after merge

* Adds a whole bunch more qol.

* Improves examine messages

* ci

* concealed cards will now show properly in radial

* Fixes some weird proximity monitor and control issues

* Address reviews, clean up examine a bit more

* radial fixes

* remove todos

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>

* better documentation, adds label of who did what

* b etter grammar

* augh

* missing icon state

* Update code/game/gamemodes/wizard/magic_tarot.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>

* Add sleep on proximity monitor setup to hopefully avoid mapload issues

* been writing too much c lately

* Try late initialize

* late init

* 🧌

* map load

---------

Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-11-29 19:12:15 +00:00
ExusA
cf31fa098f Adds the Service and Medical versions of the "Rover" cyborg skin (#27395)
* Adds the Service rover cyborg

Adds a "Rover" style cyborg for the Service module.

* Update sprite

Adds the finished service rover sprite.

* No Hat

Adds service rover to the unhattable list

* Adds the medical rover module

Adds the medical rover module to the same branch, since they both rely on the same service panel logic.

* Update medical rover panels

* Deconflict
2024-11-29 17:07:01 +00:00
Bm0n
0b3f777f32 Fixes skin tones for syndibase spawner (#27299)
* woeuponspawners

* begone blank space

* Update code/modules/ruins/syndicate_space_base.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>

---------

Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>
Co-authored-by: Bmon <no@email.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-11-29 14:44:55 +00:00
Rowan Lea
9f26a62b30 Adds job overalls to the loadout menu (#27427)
* Adds janitor's overalls to the loadout menu

* Adds ALL the overalls

* Update code/modules/client/preference/loadout/loadout_uniform.dm

Yay formatting

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Rowan Lea <5251535+Screampuff@users.noreply.github.com>

---------

Signed-off-by: Rowan Lea <5251535+Screampuff@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-11-29 14:32:10 +00:00
Chap
3cc903c0e7 [FIX] Json serialization/deserialization for characters (#27454)
* Wrong branch again

* Corrected comment

* Requested changes

* Updated comment

* Update code/modules/mob/living/carbon/human/human_mob.dm

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Adrer <adrermail@gmail.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-11-29 11:02:31 +00:00
Migratingcocofruit
3be13c3997 Fixes some dyed items retaining their original appearance and adds plasmamen helmet dyeing (#27256)
* Fixes dying not changing the color or description of the dyed item, making it appear unchanged when worn.

* adds plasmaman helmet dyeing
2024-11-29 10:52:09 +00:00
Qwertytoforty
8ad28af470 GODHEAD has appeared in the basement! (#27470) 2024-11-29 10:51:39 +00:00
chuga-git
32b97afbec fixes some bad html (#27481) 2024-11-29 10:46:51 +00:00
Toastical
8cc162589b Adds a triple beep sound to a variety of assembly receivers (#27315)
* added a beep beep to signaler receivers

* new sound + attribution
2024-11-29 01:49:20 +00:00
Qwertytoforty
27fcd61ae0 [s] fix plasmapistol exploit (#27477) 2024-11-28 19:45:53 +00:00
Сиротка
422a48f85b Port TG Resonator so this is not a trash anymore (#27216)
* Port TG Resonator so this is not a trash anymore

* fix defines

* Update kinetic_accelerator.dm

* yeah yeah linter i love you too

* Update paradise.dme

* fix for matrix

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* remove useless signal

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

* Update code/modules/mining/equipment/resonator.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

---------

Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-11-28 15:28:06 +00:00
Qwertytoforty
5df5890251 Reviving the revival of revivers reviving. Revival edition. (#27436)
* reviver

* toxic

* more changes

* final changes

* I lied one more

* woe rename apon thee

* Update code/modules/surgery/organs/augments_internal.dm

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-11-28 14:14:40 +00:00