Commit Graph

27771 Commits

Author SHA1 Message Date
Qwertytoforty
1bec4cd8a7 fixes this bloody laser (#27167) 2024-10-22 17:36:30 +00:00
warriorstar-orion
5857035892 fix: polarized access helper false positives (#27146) 2024-10-22 15:57:43 +00:00
Contrabang
e3c0198737 Adds CI to prevent manual calls of update_icon_state, update_overlay, etc. (#27010)
* CI something something

* last fix
2024-10-22 12:46:00 +00:00
Contrabang
6325c6dd8b Adds a Ranked list input modal (#26926)
* lol

* yeah

* yes

* yes

* yeah

* merged

* tgui bundle
2024-10-22 12:44:16 +00:00
warriorstar-orion
f27feae258 blackbox: Record biohazard pop at intervals. (#26930)
* blackbox: Record biohazard pop at intervals.

* associative fine here

* don't use recursive timer callbacks
2024-10-22 12:09:36 +00:00
warriorstar-orion
b066c95bfc port: Aurora mapmanip library for map templates, and documentation. (#26803)
* refactor: wrap MILLA in general Rust library

* port: Aurora mapmanip library and documentation.

* update CI libs and TGS build rule

* pass filename properly, raise map helper layer

* Update rust/src/mapmanip/core/mod.rs

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* add a bit more documentation

* make doc more para-centric

* these don't need to be images at all

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-22 12:09:13 +00:00
DGamerL
f5a4bd0e4b Resprites shotgun shell boxes (with fancy storage!) (#27006)
* Idk what I'm gonna do with this

* This needs a lot of cleaning up

* Absolute hell

* Fixes and reverts

* Shhhhh

* SHHHHHHH

* Accepting my least atomic PR of the year award

* Fix rubbershot name

* Update code/game/objects/effects/spawners/lootdrop.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Contra review

* Contra review

---------

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-10-22 10:41:35 +00:00
Henri215
edfe42a14a old sprite fixes (#27115) 2024-10-22 10:40:52 +00:00
Aylong
955617fe18 Add images to the Mining Vendor (#26952)
* Add images to the MIning Vendor

* Fix lazarus belt icon

* Update code/modules/mining/machine_vending.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: Aylong <69762909+AyIong@users.noreply.github.com>

---------

Signed-off-by: Aylong <69762909+AyIong@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-10-22 09:50:15 +00:00
Kenionatus
b4d1bd1411 Fixes Newscaster Treatment of Wallets (#27121)
* move GetNameAndAssignmentFromId to cards_ids file

* simplyfiy and fix newscaster's get_scanned_user

Use human/get_id_card proc instead of custom solution.

* rename M to human_user

* Update code/modules/newscaster/obj/newscaster.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by:  Sean <12197162+S34NW@users.noreply.github.com>

---------

Signed-off-by: Sean <12197162+S34NW@users.noreply.github.com>
Co-authored-by: Sean <12197162+S34NW@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-10-22 09:47:12 +00:00
warriorstar-orion
4c937d62ff refactor: Only sort named machine lists at mapload end. (#27081) 2024-10-22 09:33:16 +00:00
DGamerL
0de5807260 Fixes inhands for fake artefacts (#27074) 2024-10-22 09:31:40 +00:00
Migratingcocofruit
4248eb735f Pins firefighting tank by default in atmos and advanced modsuits (#27048)
* Pins firefighting tank by default in atmos and advanced modsuits

* removes commas from the end of the list
2024-10-22 09:30:20 +00:00
Migratingcocofruit
646249c01d Modsuit pinned buttons now indicate whether the module is active (#27045)
* Pinned buttons now register signals for activating or deactivating their respective module.

* allows active modules like tether and firefighting tank
2024-10-22 09:29:54 +00:00
Aylong
4983270cef PDA Resprite (#27040)
* PDA Resprite

* UI PDA
2024-10-22 09:29:24 +00:00
Silverplate
099f119d02 Mole crush SMs now generate anomalies (#26998)
* Mole crushing the SM now generates anomalies

* other anomalies now spawn
2024-10-22 09:26:51 +00:00
Сиротка
551eb8ee76 TWEAK: Love pen now higly peaceful (#26995)
* TWEAK: Love pen now higly peaceful

* Update code/datums/uplink_items/uplink_traitor.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>

---------

Signed-off-by: Сиротка <114731039+ErdGinalD@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-22 09:26:36 +00:00
Christasmurf
4f684324bf Kidan gloves - Refitted sprites (#26986)
* kidangloves

* clothwrap
2024-10-22 09:26:22 +00:00
Qwertytoforty
7165e3ab41 adds strong arm to protolathe like all other cybernetic implants (#26968) 2024-10-22 09:25:31 +00:00
PopeDaveThe3th
6eb100c582 [LORE] Reasonably Sized ERT Lore Drop (#26964)
* ert lore

* vest changes

* modsuit changes

* suit changes

* Update helmet.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update helmet.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update helmet.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update helmet.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update helmet.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update ert_hardsuits.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update ert_hardsuits.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update ert_hardsuits.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update ert_hardsuits.dm

Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* helm

* naming

* Update mod_theme.dm

Co-authored-by: Gatchapod <20936555+Gatchapod@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* capitalized

* Update ert_hardsuits.dm

* Update code/modules/mod/mod_theme.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update code/modules/mod/mod_theme.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>

* Update armor_suits.dm

---------

Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Co-authored-by: Gatchapod <20936555+Gatchapod@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-10-22 09:25:12 +00:00
DGamerL
2049cf06c3 Improves the throwing capabilities of the Scrying orb (#26955)
* I cast ORB THROW

* Adds ran_zone

* Lewc review
2024-10-22 09:23:45 +00:00
leoworm
8576a81751 [FIX] Stopped Quantum Entanglement of Original Fax to Fax Panel (#26953)
* Added fax machines to admin room

* Made GLOB.adminfaxes hold the received fax, instead of the original

* Added an explicit return statement

* Remove trailing newline in core/modules/paperwork/faxmachine.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: leoworm <leo.charles.p@gmail.com>

---------

Signed-off-by: leoworm <leo.charles.p@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-22 09:23:38 +00:00
leoworm
69d3064acb [FIX] Prevent Shell Count From Appearing on DL-88 Speedcharger (#26954)
* Added check to prevent appearance of shell count on speedcharger

* Undo Added check to prevent appearance of shell count on speedcharger

* Correct undo of edgecase check

* Added proc override for update_desc() for speedcharger
2024-10-22 09:23:34 +00:00
1080pCat
cb0284a533 Fixes guns playing scredriver sounds when they shouldn't be. as well as adds sounds to attaching stuff (#26945)
* Fixes guns playing scredriver sounds when they shouldn't be

* Update code/modules/projectiles/gun.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>

---------

Signed-off-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-22 09:22:34 +00:00
Bm0n
ade220d0cb Ports Jumpskirts! (#26935)
* wip test 1

* sprites

* code added

* vendors and locker spawns set

* added to prisoner locker

* accidental deletion

* sprite fix

* Update code/modules/clothing/under/color.dm

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>
Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>

* new kidan sprites

* Update code/modules/clothing/under/color.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>

* Update code/modules/clothing/under/color.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>

---------

Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>
Co-authored-by: Bmon <no@email.com>
Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-10-22 09:22:00 +00:00
Migratingcocofruit
592b7c3ec3 Ports the Power Transmission Laser (#26928)
* wip

* some formatting and copying over UI

* it compiles now

* oops

* Moves WATT_TICK_TO_JOULE to the power defines file. fixes UI

* spelling and announcement fixes

* Handle offsets for different directions

* laser comes from the correct tile now

* Added north and south sprites for the laser

* Adjust offsets for north and south sprites

* finished all north and south sprites

* tgui rebuild. Also sprites and code begoon

* Rebuild TGUI

* put PTLs in maps

* Repositions PTL room door in cyberiad

* fix if spacing

* undef and unundeffed define

* Removed overlapping stuff in some maps

* Actually makes the changes to metastation

* Fixes more mapping stuff

* Fix more unit test failures

* unmirror multitile component grid

* Fixes multitile

* explosions no longer make a hole in the beam

* This should fix it

* Stray pipe begone!

* Ok I think I fiigured it out

* Rebuild Tgui

* removes redundant removals of components parts and a redundant check. various style fixes

* Adds blocking to the beam and objects other than living beings take damage now.

* not using kwargs now. should work.

* Style changes and fixes some mobs getting hit by the laser that shouldn't be.

* Review changes and fixes trying to access wall turf's location.

* allow the new wall turf to form to we can properly access it.

* Moves the ptl beam effect to an atom proc that is overriden by the different types of things that can end up in the beam.

* Fixes some comments, adds clarifications, removes redundant usage of src

* moves the announcement threshold to a global var. Fixes ghost interaction.

* Revert "moves the announcement threshold to a global var. Fixes ghost interaction."

This reverts commit 7916ee76a1.

* Makes announcement threshold a static variable of the PTL

* power safty check on the mob ptl function

* Rebuild TGUI
2024-10-22 09:20:19 +00:00
Spaghetti-bit
29409d3821 Adds functionality for placing hats on top of hats. Plasma-man hat accessory edition. (#26927)
* Init

* adds functionality for hats to be placed on hats.

* species sprites

* Removes modsuit stuff

* applies a bunch of suggestions from lewc

* batched suggestions (1/2)

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Spaghetti-bit <yumyumkillkill@gmail.com>

* typecasts loop
removes unnecessary length check
uses forceMove

* one more forgotten typecast

* turn-around city 3

* turnaround city 3.1

* : -> .

* removes if(length)

* Applies suggestions from @lewcc

---------

Signed-off-by: Spaghetti-bit <yumyumkillkill@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-22 09:19:13 +00:00
Chap
c4cc00400d [PORT/SPRITES] New BSA beam sprite (#26925)
* Better BSA beam sprite

* Changed front_turf finding

---------

Co-authored-by: Adrer <adrermail@gmail.com>
2024-10-22 09:18:24 +00:00
warriorstar-orion
1c994ad3d9 refactor: Eliminate text access fields. (#26907)
* refactor: Eliminate text access fields.

* set script PR number

* make diffstat delta exactly 0
2024-10-22 09:18:10 +00:00
Qwertytoforty
a243dae3d4 makes secbots / ed209's not stupid as a fucking rock (#27087)
* destupifies beepsky / ed209s

* make sure hands happen

* Update code/modules/mob/living/carbon/human/human_defense.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>

* lewcs stuff

---------

Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-22 01:31:31 +00:00
Qwertytoforty
1900bf6519 Fix 3 posibrain / robobrain bugs (#26950)
* gdn pls

* updates
2024-10-22 01:24:02 +00:00
warriorstar-orion
d1d9b54424 blackbox: improve lathe production feedback (#26992) 2024-10-22 01:13:09 +00:00
warriorstar-orion
8554e39d8b cleanup: remove unused mob spawners (#27144) 2024-10-22 01:12:50 +00:00
warriorstar-orion
5f814597a7 lint: forbid whitespace in empty list decls (#26972)
* lint: forbid whitespace in empty list decls

* Update tools/ci/check_grep2.py

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* close enough to grab a bunch

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-10-21 19:28:21 +00:00
warriorstar-orion
57e2d38e31 fix: TESTING-enabled admin rank helper procs (#27124) 2024-10-21 19:27:50 +00:00
warriorstar-orion
c7fda16033 fix: dupe corpse nullspace spawning (#27145)
* fix: dupe corpse nullspace spawning

* remove unused defines too
2024-10-21 15:32:22 +00:00
Chap
41bb6f27c9 No we don't (#27148)
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
2024-10-20 23:02:03 +00:00
BiancaWilkson
074da2b796 Datumizes microbatteries (#26900)
* Datumize microbattery

* comments + feedback when you're revivable

* More comment

* more datumization

* Explaining myself

* Being able to charge while not having a microbattery

* Better comment

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>

* Changes proc name to be more accurate

---------

Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
2024-10-18 23:30:04 +00:00
warriorstar-orion
20dfb3af69 refactor: Remove unused grill machine (#27122) 2024-10-17 11:16:41 +00:00
Chap
c3d773402c [REFACTOR] Remove the flying var, adds the flying trait. (#26881)
* Remove the flying var, adds the flying trait

* Remove flight when broomstick is unwielded

* Adds some comments

* tab indentation

* Fix carp flight

* Remove comment

---------

Co-authored-by: Adrer <adrermail@gmail.com>
2024-10-16 17:46:19 +00:00
Qwertytoforty
be2cdeb261 fixes deepfrier / cereal maker not transfering reagents (#27123) 2024-10-16 16:37:33 +00:00
Qwertytoforty
b0895a1c63 Update gun_attachments.dm (#26956) 2024-10-15 18:00:54 +00:00
Chap
344de8194a Fixes chat language colours (#27099)
Co-authored-by: Adrer <adrermail@gmail.com>
2024-10-15 13:56:23 +00:00
Spaghetti-bit
c1427a4565 Fixes a glowing eye issue and eye overlay issue (#26934)
* Reorders the layering, again. Fixes lighting issue with eyes.

* Update code/modules/mob/living/carbon/human/human_mob.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Spaghetti-bit <yumyumkillkill@gmail.com>

---------

Signed-off-by: Spaghetti-bit <yumyumkillkill@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-10-15 12:47:22 +00:00
Qwertytoforty
0973879763 save progress (#26976) 2024-10-15 00:55:41 +00:00
Contrabang
c15a5bbf59 Fixes invisible signs on mining shelters (#27073) 2024-10-14 15:05:50 +00:00
1080pCat
c901397163 Fixes combat pants not having a icon state (#27098) 2024-10-14 14:54:26 +00:00
Chap
b51cc0f31c [PORT/FEATURE] Animated closet doors (#26832)
* Adds animated closets

* Remove unecessary icon states and fixes secure closets

* Actually fixes secure closets

* Please our linting overlords.

* Fixes non-crate subtypes

* Update code/game/objects/structures/crates_lockers/closets.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Chap <erwin@lombok.demon.nl>

* Moved legacy closet icons to seperate file

* Remove some unused variables

* GC

* Moved to proper destroy

* It's good when code compiles

---------

Signed-off-by: Chap <erwin@lombok.demon.nl>
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-10-14 14:05:16 +00:00
datlo
eaec0c885d Fix malf AI getting org (#27025) 2024-10-12 17:09:36 +00:00
dj-34
84ff9d46b6 Fix floating animation (#27044) 2024-10-12 17:09:11 +00:00