Commit Graph

11072 Commits

Author SHA1 Message Date
AffectedArc07
1d008754da [READY] Bot Refactor (#18930)
* [WIP] Bot Refactor

* No more spawns, sleeps, and working EDs

* Mules

* GC fixing

* h
2022-09-17 12:46:25 +01:00
FloFluoro
15a0edc588 Fixes facehuggers facehugging forever (#19067)
* Fixes facehuggers facehugging forever

* Removed unnecessary "as mob", readded blindness because clothing-induced blindness doesn't fully mimic the status effect
2022-09-16 22:45:52 -05:00
Luc
346a1b8142 Yet Another Surgery Refactor (#18325)
* Initial commit

Fixes up surgery.dm
Adds some tool behavior

* More basic changes

* Checkpointing: this is a little gross right now

* Add signal COMPONENT_CANCEL_ATTACK_CHAIN

* Cleans up surgery initiator

* Mostly gets surgery (and canceling it) working

* Add abstract proxy surgery steps

Also adds them to organ manipulation

* Clean up most existing surgeries

* Rework organ openness, adds define for aborting a beginstep

* surgery works again, also implements retry defines

* fix surgery computer

* add limb repair to synth implant removal

* retry implant checks

* Clean up abductor surgeries as well as some other things

* A lot
- Reworks organ manipulation to use a series of surgery steps instead
- Fixes some runtimes with open hands
- Lets mito zero out the germ level while treating necrosis
- Adds a debug surgery tool

* add debug surgery tool, note some TODOs for later

* Add conditional check for surgeries repeating

* update surgery retry logic to make it more of a bonus

* Lets abductors automatically retry any failed surgery steps

* Rework robotic surgery to use abstract/proxy steps

* Bunch of bugfixes and more!
- Limb reattachment works properly now, you can just slap a limb onto a person
- If the limb isn't robotic, it'll be useless until the surgery is finished with a hemostat, though it might be enough to get the patient out of the OR.

* Remove more now-implicit checks

* Slight reorganization

* more fixes across the board

* Remove unused variable

* Trying not to lose my mind here
- Does away with can_run() entirely
- Cleans up visible messages in code
- begin steps should now all have ..() afterwards
- slime bone surgery should be fixed now
- more docs

* Robotic  surgery is stoppable with a crowbar, all surgery can_start now checks parent

* Fix some broken robotic typepaths

* Typepath fixes, do away with some last TODOs

* Forgor

* Last cleanups before we go gold

* jk lol

* Make early surgery termination clearer

* More "last" cleanups

* Fixes tool flags, surgery initiation

- Fixes surgery not being startable by sharp objects
- Moves surgical tool flags to item traits

* Clean up surgery cancellation, especially for borgos

* I think this should GC better

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Status is now step number

* Add a 20% chance to find nothing during organ manipulation

* Improve documentation, make forced_surgery a normal arg

* Charlie's reviews

* Why are abductors like this

* Little more verification, ensuring limb augmentation and organ manip healing work properly

* Fix torso organ manip being unfinishable

* Fix cavity implants, open-hand/any item steps

* Make sharp objects not try to start an operation with help intent

* Comments, quick target fix

* Re-order list so advanced bruise pack is pulled first

* Make surgical gripper function like an open hand

* Make mito only use one unit per organ for now

* Check if user is on operable surface before trying to operate

* Reduce admin logging

* Fix some bugs that appeared during the testmerge
- you can no longer start robotic surgeries with a scalpel (lol)
- you can now cancel surgeries on the first step after I fixed some bugs that I introduced (woo hoo)
- Synthetic limb attachment is now combined into a single startable surgery step, though still retains the fun flavor of both

* Swats some more bugs
- (hopefully) fixes a huge source of runtimes where we tried to check if we could run surgeries before checking if the surgery used an organ
- In doing so, moves the logic for determining if a surgery can start to the mob-level
- Fixes robotic reattachment surgery not working

* multi-bug drifting???

- Fixes a bug where a branching surgery with an any tool option could possibly override a step with a matching tool
- Fixes some intermediate surgeries failing due to not having specified possible_locs

* A few more fixes
- Fixes any surgery tool steps again
- Fixes cavity surgery again

* Hopefully fixes getting stuck in robotic organ manip

* Remove extra parent call

* Steel review

* Steel review

* Fix spacing for possible locs

* Roundstart traits

* Advanced surgical traits and other hal fixes

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-16 18:48:43 +01:00
Luc
686cd5fd79 Fixes emotes being displayed as the wrong type (#19026)
* Fixes some emote types, fixing the voice analyzer by proxy

* Remove unused utility function
2022-09-16 17:52:17 +01:00
Qwertytoforty
e275183ddd Xenomorphs can now stun borgs for practical ammounts of time. (#19050)
* god damn it.

* was cycles not seconds
2022-09-16 17:51:34 +01:00
FloFluoro
3974a98073 Facehuggers no longer instastun, removes some RNG (#19025)
* Facehuggers no longer instastun

* Changed egglaying time to actual seconds

* Code review

* Autodoc, typos, etc.
2022-09-13 23:22:39 +01:00
Qwertytoforty
ae0efa00b5 Ports the shuttle console hijack from TG. Tweaks malf AI hijack. (#19018)
* *puts on sunglasses* "I'm in."

* whoops

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Caching, danger, range, xenomorphs can no longer hijack

* Update code/modules/shuttle/emergency.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/shuttle/emergency.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-13 23:22:19 +01:00
FloFluoro
b8885719f4 Xenomorphs can now die (#19046) 2022-09-13 22:53:06 +01:00
FloFluoro
4c2da8fc28 Fixes Xenomorphs being able to build resin structures in space (#19028)
* Fixes Xenomorphs being able to build resin structures on turfless tiles

* powerc my beloathed

* When the return is indented!
2022-09-13 22:42:10 +01:00
Contrabang
e88b25bb24 wooohoo! I can see demons! (#19020) 2022-09-12 22:31:59 +01:00
AffectedArc07
279ee1dc12 Fixes a ton of security issues (#19005) 2022-09-10 14:12:16 +01:00
FloFluoro
1d6e105f8a check_id now checks for ID in the PDA slot (#18992) 2022-09-08 12:21:30 +01:00
Contrabang
fc4a0ea4d6 wow diagnostic hud (#18974) 2022-09-07 15:28:18 +01:00
GDN
c7bb5763d7 Removes weakens on tripping over simplebots (#18965)
title says all
2022-09-07 13:39:45 +01:00
Qwertytoforty
b1be1b5a36 Ports TG berserker armor from TG to replace champion hardsuit. (#18854)
* NT does not recommend punching fauna to death

* need x2, don't want reflection

* Armor -> brute burn resist, speed removed

* phys not species

* light em up

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* a hex on you

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* spacing, bolding, only stamina

* Apply suggestions from code review

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-06 00:05:36 +01:00
Edan
58f0419399 Legion Rework (#18819)
* initial changes

* crusher trophy + other changes

* oops

* status effect change

* charlie review 1

* spacing

* sentience type

* Update code/modules/mining/equipment/kinetic_crusher.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/hostile/megafauna/legion.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-05 01:11:49 +01:00
Octus
1c7882cb11 Ports the TG Dish Drive. A quality of life machine for service. (#18855)
* ILOVEBARTENDING

* improvements

* oopsie daisy

* Apply suggestions from code review

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: ElorgRHG <71735193+ElorgRHG@users.noreply.github.com>

* Update cable.dm

* fixes cable runtimes

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* applies for code critique

* steelslayerreview

* Update code/game/machinery/constructable_frame.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: ElorgRHG <71735193+ElorgRHG@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-04 10:36:11 +01:00
S34N
021fd9a416 adds implants and hair gradients to serialisation (#18934)
removes organ DNA from serialisation
2022-09-03 21:14:44 +01:00
S34N
08f36a9521 Admin QoL: Deletes stickybans, tidies mob VV menu (#18943)
* 1

* 2

* removes these too
2022-09-02 23:51:00 +01:00
alex-gh
7e3dda4556 Rework disease outbreak event (#18654)
* Rework disease outbreak

* Better dchat message

* Mary had a little lamb

* no symptoms for carriers

* Review Fixes part 1

* Review Fixes part 2

* Review Fixes part 3

* Lowers mundane disease probability

* Mundane disease can only happen once

* Improved naming/dchat message

* subtypes!

* space

* fix diseases overwriting each other

* SPAAAAAACE

* dchat message fix

* no initial
2022-09-01 12:49:27 +01:00
FloFluoro
92f6d88b35 Adds cooldown to Xenomorph neurotoxin, changes stun to knockdown (#18919)
* Adds cooldown to Xenomorph neurotoxin, changes stun to knockdown

* Neurotoxin now works when implanted in humans

* Tidying

* More tidying

* More tidying
2022-08-31 13:19:03 +01:00
AffectedArc07
629c099db7 Refactors status displays (#18811)
* Refactors status displays

* biggest commit
2022-08-29 16:45:29 +01:00
Kugamo
247c7239da InteliCard AI Core Display Sprites (#18821)
* hi

* bye

* hi again

* Sirryan2002 suggestion

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* adds unit test

idk what Im doing really here, so I hope this code works 😔 👍

* correction 1

* correction 2

kill me

* correction 3

im dead

* correction 4

big pepega moment

* correction 5

* correction 6

yep

* FINALE :D :D :D

* AffectedArc07 suggested change

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-08-28 14:37:08 +01:00
Qwertytoforty
5fd21ea339 fixes bubblegum / vetus hitting twice during charge (#18837) 2022-08-27 13:05:55 +01:00
SteelSlayer
f991ad2c07 fix failed give message appearing on success (#18894) 2022-08-26 19:29:49 +01:00
SteelSlayer
44af9906b9 fix give alert staying around (#18887) 2022-08-25 18:24:40 +01:00
Ordosian
9cf1e7e5a6 Large Plasma Tank (#18840)
* Large Plasma Tank

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Ordosian <Ordosian@gmail.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-08-25 17:42:17 +01:00
SteelSlayer
d355a60a2d Rework / refactor of how the Give verb works. Give now has a re-bindable hotkey for it (#18646)
* give verb rework ; adds a hotkey for give

* moxian review

* Adds new alert sprite shown to item giver
* Converts offering item trait to a status effect to facilitate the new alert

* Update screen_alert.dmi

* Add a `/datum/proc/signal_qdel()` helper

To cut down on copy and paste. Fixed alert flash icon not having transparency.

* lewcc review

* farie review and other fixes

For some reason my alert flash sprite no longer had an empty frame at the end so it would reach the end of the animation and be a solid yellow outline instead of invisible.

Touched screen_alert.dmi to fix that.

* reverts the addition of the give hud icon, restores give verb

I realized that making a new hud icon button would require multiple hud icons for each hud theme (the red one, green one, white one, etc.). I'm not prepared to do that much work right now.

* Update code/modules/mob/living/carbon/give.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-08-24 14:51:05 +02:00
GDN
28137689b8 Swarmer removal (#18873) 2022-08-22 19:50:18 +01:00
Qwertytoforty
afbae8af1b Makes anomalies deadlier (#18836)
* Makes anomalies deadlier

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* undodgeable to dodgeable

* requested changes

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-08-21 16:32:12 +01:00
AffectedArc07
400e9f8c65 Removes lavaland swarmer crash ruin (Its already disabled on the server anyway) (#18810)
* Removes lavaland swarmer crash

* Forgot the def
2022-08-20 17:48:52 -05:00
Edan
f82353421f i have made a severe and continuous lapse in my j (#18863) 2022-08-19 15:21:02 +01:00
Edan
87109a29d4 fix (#18856) 2022-08-19 13:11:53 +01:00
AffectedArc07
4140275ca8 Axes TS gateway (#18825)
* Axes TS gateway

* This too

* Commit for MDB

* This PR finna become my MDB2 test

* aaaaaaaaa
2022-08-18 23:48:29 +01:00
Vi3trice
f41e0f111d External organ icon handling tweak (#18826)
* Hm, let's try this

* Nevermind, a new proc is better than doing a bunch of early returned jumps
2022-08-18 23:24:24 +01:00
Qwertytoforty
7cd42a835e Elite balance tweaks (#18834)
* Elite tweaks

* sirryan changes

* a periodic issue

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-08-18 23:15:06 +01:00
SteelSlayer
358ff86ddb Removes the need for ComponentInitialize (#18833)
* removes `ComponentInitialize`

* mapload

* add back CRASH
2022-08-18 22:00:19 +01:00
Octus
0f9ef5962f vox mane (#18808) 2022-08-18 10:49:57 +01:00
AffectedArc07
e80f0e1d8d Revert "Adds animations for picking up and placing items. (#18702)" (#18824)
This reverts commit 2945bed697.
2022-08-17 16:18:12 +01:00
Qwertytoforty
6293bd1ed5 fixes tumors not reviving dead elites out of combat (#18832) 2022-08-16 08:40:13 +01:00
AffectedArc07
aba452f785 Refactors signallers, assemblies, electropacks (#18689)
* Refactors signalers, assemblies, electropacks

* Update code/game/objects/items/devices/radio/electropack.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-08-15 16:36:34 +01:00
Luc
2945bed697 Adds animations for picking up and placing items. (#18702)
* Add initial support for telegraphing item pickups

* Add interaction to lockers

* Undo some extraneous changes

* Make pickpocket gloves not show any animation on pickup
2022-08-14 15:52:04 +01:00
AffectedArc07
d688300c3a Upgrades the MC (#18769)
* Upgrades the MC

* More tweaks
2022-08-14 14:55:31 +01:00
AffectedArc07
34ed47ae74 Refactors stack traces, tiny bit of cleanup (#18773) 2022-08-14 02:11:40 +01:00
Qwertytoforty
13075349fa fixes pandora chasers going after dead mobs (#18783)
* fixes pandora chasers going after dead mobs

* Also fixes legionnare charge
2022-08-14 02:10:58 +01:00
HMBGERDO
744779d579 Fixing visible message being visible even if the mob is in the object (#18761)
* Fixing visible message being visible even if the mob is in the object

* Changing visible message logic to show action if you are in the same object

* Update code/modules/mob/mob.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-08-13 11:00:18 +01:00
Qwertytoforty
7276267a94 Replaces vox O2 downside with vox only blood. (#18523)
* Replaces vox brute downside with vox only blood.

* I'm dumb, but at least I am not stupid

* Update code/modules/reagents/chemistry/reagents/water.dm

Co-authored-by: Adri <jozsef.adrienn@gmail.com>

* Add to medbay, cargo, makes blood colour work

* more readable

* Update code/modules/reagents/chemistry/reagents.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* spacing, removes == "Vox"

* test time

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* makes it work and testing works

Co-authored-by: Adri <jozsef.adrienn@gmail.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-08-11 00:41:17 +01:00
Qwertytoforty
4c0842f95c bubblegum hallucinations no longer runtime on death (#18768) 2022-08-10 18:53:18 +01:00
FloFluoro
42ac758205 Xeno Larva burst out of the chest, instead of gibbing (#18745)
* Xeno Larva burst out of the chest, instead of gibbing

* Readability and cleanup

* Chest is guaranteed to fracture, use proper define for chest

* Update overlays
2022-08-10 16:54:35 +01:00
AffectedArc07
4ef0c1c84c Some more stats logging (#18700) 2022-08-09 18:45:57 +01:00