Commit Graph

11772 Commits

Author SHA1 Message Date
Charlie Nolan
7ae3bf6747 Stop using \improper improperly. (#24410) 2024-03-03 18:04:52 +00:00
Contrabang
87a318a7de Refactors screen objects to /atom/movable (#24068)
* introduce helper + remove unused proc

* we love compatibility

* Update code/_onclick/hud/action_button.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/action_button.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/alert.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/martial_arts/martial.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mining/lavaland/loot/tendril_loot.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/shadow.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/shadow.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/living_update_status.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/internal.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/camera_advanced.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/camera_advanced.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/internal.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/mecha/mecha.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* deconflict

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-03-03 17:37:51 +00:00
BiancaWilkson
cc433a3794 Fixes an exploit with robobrains (#24394)
* this hurts me more than it hurts you

* me when istype
2024-03-02 22:43:22 +00:00
Luc
06f89243f3 Spectral blade now shows orbs, not ghosts (#24124)
* Implements

* yeah I meant to do this

* this should probably be safer

* alpha

* Add some contingencies

* Update code/modules/mining/lavaland/loot/tendril_loot.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-01 20:07:19 +00:00
warriorstar-orion
0667f20681 move all EOL comments on typepath names to dmdoc (#23928)
* move all EOL comments on typepath names to dmdoc

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-01 20:05:49 +00:00
warriorstar-orion
e1614b9ecb Add DMI/JSON export to local client admins. (#23947)
* Add DMI/JSON export to local client admins.

* switch to log_world, add if paren
2024-03-01 13:59:56 +00:00
GDN
5e79ae0f69 fixes xenos being nullspaced in rare situations (#24362) 2024-03-01 12:48:49 +00:00
DGamerL
900d19369b Quick and easy replacing (#24352) 2024-03-01 12:47:07 +00:00
Nathan Winters
da34941fae Minor pill/patch application refactor (#23958)
* Refactor pill/patch application

* I will come back to this
2024-03-01 11:39:25 +00:00
cybercapitalism
a280b87103 Fixes #24198 (#24357)
* make reinforcing grab only check if mob is restrained

* restrained was false advertising
2024-02-28 21:07:22 +00:00
GDN
b7a88c6da4 fixes #24313 (#24315) 2024-02-27 18:27:27 -05:00
DGamerL
5d79d45279 Buffs Carpfu (#24120)
* Now just test

* Testing was necessary, should work now

* Update code/modules/mob/living/carbon/human/human_defense.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Fixes bolas not working

* Nullchecks

* Moar nullchecks

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-27 18:25:59 -05:00
Charlie Nolan
19cdfcdbef Set the kitten's resting sprite properly. (#24326) 2024-02-27 17:25:24 -05:00
Deniz
6dc19d2cd6 reverts isspace lmao (#24317) 2024-02-27 17:23:26 -05:00
Qwertytoforty
dd8cf5a92c Vampires can now gain blood for a minute after someone succumbs to death (#24236)
* Vampires can now gain blood for a minute after someone succumbs to death

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* status effect it

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-02-27 17:13:54 -05:00
GDN
5c2f3170f5 [S] fixes a headslug exploit (#24300)
* fixes headslugs being able to double up on the dead

* Update code/modules/mob/living/simple_animal/hostile/headslug.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-02-24 14:14:00 -06:00
Aylong
329398b4f0 Fixes some issues with TGUI Alerts, and Text Input (#24282)
* Well... maybe that's not better way

* PDA and all_channels encryptionkey

* Alert fixes

* Bad style
2024-02-24 18:28:26 +00:00
Mikhail Dzianishchyts
c761b48cef Fix invisible carp hologram for AI (#24264)
* Fix invisible carp hologram for AI

* Update code/modules/mob/living/silicon/ai/ai_mob.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply some formatting

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-24 18:21:57 +00:00
DGamerL
c41a803b9c Refactors one ventcrawl proc and fixes a bug (#24215)
* Refactoring and fixing a bug

* GDN review

* Contra review
2024-02-24 18:20:55 +00:00
13spacemen
fc52cf014a Repairs Vox Tail/Chest/Groin Sprites, Renames Skin Tones (#24097)
* repaired green tail e/w, changed green tail w to be mirror of e, added a proper green tail s sprite, repaired green chest e/w
added proper tail markings s sprites, tail markings w is now a mirror of e

* all vox tails done

* repaired all vox chests and groins

* replace all female torso/groin

* fixes more issues with vox tail sprites

* final sprite fixes for vox tails and tail markings, renamed "band" to "bands", deleted unused tail markings file
renamed vox "green" skin tone to "lime"
renamed vox "dark green" skin tone to "plum"

* edit icon_skin_tones
2024-02-24 18:15:27 +00:00
Aylong
f2223bb122 TGUI Input fixes (#24270)
* Some tgui input fixes and reverts

Add default to suit sensors and beaker transfer amount.
Revert languages list and paper text inputs

* Some tgui input fixes and reverts

Add default to suit sensors and beaker transfer amount.
Revert languages list and paper text inputs

* Meh
2024-02-24 18:14:03 +00:00
GDN
5ebefe9fa1 Reworks xenomorphs (#23054)
* reworks xenomorphs

* part 2 electric boogaloo

* more tweaks

* more tweaks

* lints

* Update code/modules/mob/living/carbon/alien/alien_death.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/surgery/organs/subtypes/xenos.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/game/objects/structures/stool_bed_chair_nest/alien_nests.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/datums/spells/alien_spells/transfer_plasma.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* reviews

* sprite fix

* high priority fix

* reverts most alien nerfs

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-24 18:13:31 +00:00
HMBGERDO
ba98eb4d16 Bots refactor (#23550)
* ugh... bots refactor

* everyone uses pathfind and eyes

* most hunt logic to proc

* Update code/modules/mob/living/simple_animal/bot/ed209bot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/ed209bot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Sirryan review

* Update code/modules/mob/living/simple_animal/bot/honkbot.dm

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>

* better var naming i guess?

* Update code/modules/mob/living/simple_animal/bot/ed209bot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/griefsky.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* review

* uh oh

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>

* return FALSE

---------

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
2024-02-21 23:01:48 +00:00
Qwertytoforty
ac32162dbc Adds the razorwire implant. Ready for review into merge (#23911)
* Please merge 23876 first thanks

* whoops / fix

* she snakes on my case till I

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* deconflicts, ready for TM

* Update code/_onclick/click.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* lewcs good to them

* icon move and changes

* almost forgot to save this

* Update augments_arms.dm

* Inverted it, it seems.

* fixes lockers

* razorwire failsafes

* fuck

* razorwire one hand

* removes 2hand implant stuff

* Apply suggestions from code review

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* s34ns changes

* Vampires can gain blood for a minute from people who succumb

* Revert "Vampires can gain blood for a minute from people who succumb"

This reverts commit 50a3cf87fe.

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-02-21 22:51:33 +00:00
GDN
335199b55b fixes new players getting an unusable verb (#24251) 2024-02-21 09:08:23 +00:00
DGamerL
766704700e Refactors the atmos watertank backpack (#24177)
* Refactors the atmos watertank backpack

* Update code/game/objects/items/weapons/tanks/watertank.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/game/objects/items/weapons/tanks/watertank.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Adds spans

* Henri review

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-19 19:07:11 +00:00
Aylong
ac5add482f [READY] TGUI Input Collection (#23891)
* List Input refresh

* Modal Alerts

* Text Input

* Number Input

* Split Button

* Renaming

* Alert converts

* Text Input Conversion (Part 1)

And TextArea Autofocus + maxLength

* Text Input Conversion (Part 2)

* AAAAAAAAAAAAAAAAAAAA

* I'm FUCKED

* @GDNgit review changes

* "&#39;" fixes

* Revert TGUI Alert from admin delete

* NumberInput Window size

* CRASH if empty list

* Update code/modules/tgui/tgui_input/list_input.dm

* TGUI Rebuild

* TGUI Rebuild

* Update code/modules/paperwork/faxmachine.dm

* _char

* compile

* Rebuild

---------

Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-02-19 11:55:01 +00:00
Luc
b279d3bd4a Shotglasses now go down in one sip (#24134)
* Shotglasses now actually let you shoot them down

* Update code/modules/food_and_drinks/drinks/drinks/shotglass.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* thanks snowball

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-02-19 11:43:40 +00:00
Deniz
a77eac915a process_type fix (#24136) 2024-02-19 11:43:17 +00:00
Deniz
fb75c9ae65 Fixed emagged secbots being broken (#24149)
* emagged == 2 begone

* one slipped by
2024-02-19 11:42:24 +00:00
GDN
d72d0aebb7 Removes unneeded verb settings (#24152) 2024-02-19 11:42:11 +00:00
Adrer
47a288f5a6 Cyborg now always updates damage when taking damage (#24194)
Co-authored-by: Adrer <adrermail@gmail.com>
2024-02-19 11:39:16 +00:00
GDN
883fd6881d camera bugs now stick to things they're thrown at (#24053)
* Implements camera fu

* camera bugs now stick on things they're thrown at

* removes dupe code
2024-02-17 14:30:34 -05:00
GDN
28b79dc91c fixes some pulse demon issues (#24129)
* fixes some pulse demon issues

* Update code/game/gamemodes/miniantags/pulsedemon/pulsedemon.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-02-16 20:15:56 -05:00
Contrabang
22728cf7b2 Fixes an issue with limited martial arts (#24187)
* GDNNNNNNNN

* This too
2024-02-15 19:47:37 -05:00
S34N
3be2d5f8b6 TGUI say: Upgrades chat input with modern features (#23907)
* initial stuff (broken)

* initial stuff (works)

* fix most other things

* fix thinking indicator

* file name moment

* contra review

* better logs

* snowball feedback

* expanded drag handles

* Update code/modules/tgui_input/say_modal/tgui_say_modal.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/tgui_input/say_modal/tgui_say_modal.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Drag handle

* fix missing colours

* TGUI rebuild (im clever)

* Make msay useable by admins again (i hope)

* fixed blacklist channel leaks due to lack of user eyes

* clear old TGUIsay macros on keybind update

* TGUI say tweaks

* Update code/modules/tgui_input/say_modal/tgui_say_modal.dm

* whisper is now a channel

* remove placeholder, shorten width

* tidies prefs, fix lightmode, refactor typing/thinking indicators

* clarify more prefs

* TG Typing Indicators and increace layer

* modifiers?

* makes the TGUI say macros serverside

* add checks for muted stuff

* dgamer review

* fix talk and type issue

* Update code/datums/keybindings/communication_keybinds.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* review and binary stuff

* Removes force say from TGUI say

* updated

* Apply suggestions from code review

Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com>

* remove verb

* le rebuild

* better behaviour on illegal entries

---------

Co-authored-by: Aylong <alexanderkitsa@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: GDN <Roanrichards1@Gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com>
2024-02-15 19:31:29 +01:00
GDN
82b863cefd Converts over the missing TGUI input lists (#23859)
* Converts over the missing TGUI input lists

* last fixes

* num revert
2024-02-14 21:17:29 +00:00
GDN
13a2630028 Removes comparisons to true and false (#24083)
* Removes comparisons to true and false

* Update .github/CONTRIBUTING.md

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-02-14 19:45:37 +00:00
PhantornRU
d2fd30e7b2 cyborg crowbar (#24014) 2024-02-14 19:43:10 +00:00
Qwertytoforty
c398e4a617 Adds 2 cybernetic implants, makes emag_act return TRUE (#23876)
* Adds 2 cybernetic implants, makes emag_act return TRUE

* the rest of the fucking owl

* yeah that would do it

* remove this

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* request changes, scaling burn damage, 3 tile range, lowers tech level

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/structures/crates_lockers/crates.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update scanners.dm

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Lewcs good to them?

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* fuck me

* there are no message admins in ba-sing

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-02-08 12:52:11 +00:00
Contrabang
848c717771 More CI for conditionals (#24050)
* yay

* and thus, it was fixed

* and this fix too, so that the lang server stops complaining

* warrior review
2024-02-06 18:29:33 +00:00
Qwertytoforty
ffdccb9383 fixes bubblegum phase 2 hardmode visual not going away (#23986) 2024-02-06 18:25:40 +00:00
Qwertytoforty
c66f31bd3d Ports / reworks roundstart blurbs (#23545)
* [BEGIN_MISSION]

* ai change

* also TCOMMS

* Update location_blurbs.dm

* Apply suggestions from code review

Co-authored-by: Gaxeer <44334376+Gaxeer@users.noreply.github.com>

* fixes tabbing

---------

Co-authored-by: Gaxeer <44334376+Gaxeer@users.noreply.github.com>
2024-02-05 17:18:38 -05:00
warriorstar-orion
ed9842b730 remove most top-level vardecls (#23946) 2024-02-05 17:12:08 -05:00
BiancaWilkson
78f3f9b1f9 Species with oldcrit no longer go unconcious at 0 HP (#23877)
* IPC + ABDUCTOR BUFF IN 2024???

* IM SORRY LINTER PLEASE DONT KILL ME
2024-02-04 22:07:22 +00:00
GDN
605abfc76d Adds runechat to the abductor mindlink (#23868)
* Adds runechat to the abductor mindlink

* Update code/game/gamemodes/miniantags/abduction/abduction_gear.dm
2024-02-04 21:59:52 +00:00
datlo
17e58231df Adds the pondering orb to the wizard den (#23861)
* Pondering orb

* fix

* reset map

* map merge fix test

* Update centcomm.dmm

* Revert "Update centcomm.dmm"

This reverts commit 1ff1a91c80.

* Revert "map merge fix test"

This reverts commit 0b4a71a365.

* update map

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* make ghostify more generic

* add proximity check

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-04 21:47:09 +00:00
Qwertytoforty
e2bdc3bfb9 Reboots the CNS implant (#23813)
* Reboots the CNS implant

* Update code/modules/surgery/organs/augments_internal.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* contra you nerd you forgot a bracket

* Apply suggestions from code review

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* requested changes

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-02-04 21:45:10 +00:00
AffectedArc07
3ab2a08d86 [TM prolly] Some init optimisationss (#23800)
* [TM prolly] Some init optimisationss

* Do this as well

* Sod it some runtime optimisations as well
2024-02-04 21:17:50 +00:00
PollardTheDragon
d10e1adcae Adds Malfunctioning AI Deploy Turret Ability (#23473)
* Adds Malf AI turret deployment ability

* Review Changes

* Check the Eye

* Do After Once check

* Turret Invisibility during Deploy, AI Control

* Reset to initial values on deploy

* Better Audio Booleans

* Helper Proc

* Alert Defaults to No

* Overhauled can_place_turret

* Modular Proc, Global to AI, Null Check

* Callback changes

* Autodoc, removed extraneous line

* Removed Extraneous QDEL
2024-02-04 21:16:21 +00:00