Players:
- The only thing that you should notice is that your backpack options
have changed. Instead of being "None", "Backpack", "Satchel", and
"Satchel Alt", there are 6 options:
- "Grey Backpack": Ensures you always recieve a plain grey backpack.
- "Grey Satchel": Same as the above, grey, plain, satchel.
- "Grey Dufflebag": So you don't have to rush the locker room, I
guess. Just kinda ransacked it from /tg/. Happy to revert it, please
do not post a five paragraph text wall calling me a shitlord
powergaming hitler-loving furry.
- "Leather Satchel": It's a leather satchel. What the hell did you
think it was?
- "Department Backpack": Gives you the department's default backpack.
Grey for most jobs.
- "Department Satchel": It gives you the department's default
satchel; A grey satchel if the department doesn't have one.
Coders:
- The above means this needs a minor SQL change:
```
SQL goes here
I'll write a query later
Can't be bothered now
Kill me please
```
- This is a cleaner method of handling job equipment than
"M.equip_or_collect" x 1000. Jobs specify a '/datum/outfit' datum,
which defines all of the things to equip to the user.
- Minor note: equip_or_collect will no longer ever generate a plastic
bag. It will instead just drop stuff on the floor if it can't stuff it
into a mob. If this is even slightly a point of contention, more than
happy to revert it; It was just requested by Fox.
- Addendum: This also has the effect of making it so that labcoats
are just thrown onto the floor if you have a loadout suit. It's not
really avoidable. Uniforms and suits are equipped before the
backpack.
- Changes from /tg/:
- Changed all of the "H.equip_to_slot_or_del" calls into invoking a
new "equip_item" proc; This is used to support a new variable called
"collect_not_del". Job outfits use this, it makes it so that the
system calls equip_or_collect instead of equip_to_slot_or_del. The
idea being that job items should never be lost to the void,
especially because they can conflict with loadout items.
TODO:
- Retrofit "Equip Mob" verb to use this for all of the non-job options
- Fully implement head announcements(?)
- May be best for a second PR that addresses all of the real issues
with our current job system
( Now go reread that SQL code block :) )
If you want to have a name like ARMA-420 in game you previously had to
manually set it every round because it wouldn't load properly from SQL
because reject_bad_name doesn't like no numbers.
Changes that.
By turning it into its own preference. The verb stays in the ghost tab, except it now operates by checking client preferences.
Needs
ALTER TABLE `player` ADD `ghost_anonsay` TINYINT(1) NOT NULL DEFAULT '0' AFTER `lastchangelog`;
to add it to the SQL
Allows eyes to track eye-dependent disabilities when removed from the mob.
Farwas and Wolpins are now incurably colourblind (non-genetics based), so going lesser-form and back won't wipe your colourblindness.
Eyes being straight-up deleted (as per how set_species() handles setting up the organs required for the species we're changing to) no longer wipes colourblindness.
Now with more helper procs, less unnecessary commenting, random changes and other cleanliness-related tweaks.
For Vulpkanin and Tajara, it gives them their species-specific
colourblindness but their excellent darksight, too. Otherwise it gives
noir vision.
You can choose this disability at character creation. It is off by
default. You can turn it off via genetics and mutadone.
Fixes Cling Transform&Lesser/Greater form & Darksight bugs
Transforming to an identity will now, with 100% reliability, give you
the exact appearance as that ability bar the body_accessory and the
secondary hair/facial hair colours. Same thing with going from lesser
form to an identity that was not the one you lesser formed with.
Fixes the darksight bug from the last commit, happened 'cause typo.
Woops.
Eye Transplantation Applies Eye-dependent Genes
Transplanting colourblind Vulpkanin/Tajara eyes into a Human gives the Human
the dark_view and unique colourblindness of said Vulpkanin eyes.
Removing colourblind eyes will take the disability with it, meaning the
person will have colour vision/low darksight.
Adds colourblindness for Vulpkanin and Tajara that can be turned on by a
preference in character creation. By default, Vulpkanin and Tajara still
see in full colour, however their darksight is reduced to Human levels
unless they choose the 'unaugmented' eyes option.
Refactors darksight so it's tied to the eye organ. Refactors noir
glasses.
You can now visually distinguish mechanical/mechassisted organs from
their organic counterparts due to their names and icons.
Resolves issue w/ Colour-vision after Cloning/Lesser-to-greater Formswapping.
Cloned Vulpkanin and Tajara get unaugmented vision (colourblind and
darksight) by default since the cloners can't administer the
eye-augmentation surgery. Same goes for swapping from lesser to greater
form as a Changeling.
The monkey-forms of Vulpkanin and Tajara now have almost the same organs as
their greater forms, meaning they get the same colourblindness but
excellent darksight.
- Improves formatting in the "check player playtime" panel, removing the
awkward "bulletpoint -" at the front, making the "?" link work, and
displaying "none" rather than "0h" for people with no playtime.
- Improves formatting when viewing the EXP report for a player, by not
showing the jobs unlocked/locked list when job locking is off (its
pointless in this case: they all count as unlocked)
- Fixes a (currently invisible) typo on preferences screen
Characters will now be correctly assigned their species' genetic quirks at spawn.
Cloning will now correctly assign a characters species' genetic quirks.
Changing a character's species (via C.M.A. or whatever might call the set_species proc) will now correctly assign their species' genetic quirks.
- Fixes a runtime in preferences.dm created by the Patreon PRs,
triggered when an ERT, SIT, or any other clientless mob uses
"var/datum/preferences/A = new()".
- Fixes a bug where, if a SIT is spawned with the 'choose manually'
option, one fewer person than intended is pulled in.
- Fixes syndicate headset not being included in the SIT member's notes.
- Deletes commented code.
- Adds a `donators` table for our patreon supporters.
- Intended to be half-automated, half-manual, in order to correlate
patreon accounts to ckeys. Uses the `active` field so that supporters
don't have to have their ckey associated every time they stop and
restart their donations.
- Current actions:
- Donators at tier 1 or greater get a palm tree next to their name in OOC
(toggleable)
- Donators at tier 1 or greater get +5 loadout points.
- Known issue: Loadout points will not update if the table is
modified during a round where the user has already logged in, due
to preference datum caching. There's not really any good way to fix
this, unfortunately.
