Commit Graph

26907 Commits

Author SHA1 Message Date
CRUNCH
8dc0120946 Rags can clean kitchen machines just like real life (#24748) 2024-03-27 05:53:03 +00:00
Luc
83f2e85b74 fixes bugs with observer crew monitor (#24828) 2024-03-27 03:40:54 +00:00
BiancaWilkson
f9e30f8e78 Cyborgs can now choose what type of brain they spawn with. (#23954)
* choose your own brainventure

* i kinda remember sql

* lets try on Login() instead

* wait its actually here

* Revert "lets try on Login() instead"

This reverts commit 6fd26912b1.

* hold on i gotta sort this out

* lol, lmao even

* i apparently do not remember sql

* Actually remember to switch to varchar

* aaaaaaaaaaaaaaaaaaaa

* does the comma fix it

* i am so fucking stupid lmao

* lmao i REALLY dont know sql, thanks AA

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

* the other place to fix a string

* sql is now 54, happy  birthday sql

* autodoc whitespace fix

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* maybe using the defines i made is a good idea

* AA's changes

---------

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-26 21:23:33 +00:00
Charlie Nolan
e2f6212656 Ahelp and Mhelp QOL (#24597)
* Bound ahelp/mhelp replies more tightly to their ticket.

* Hardened PMs further against missing data.

* Support expanding Discord notifications for ahelp/mhelp.

Functionality changes:
* Informs the user when their ticket is reopened.
* Informs other mentors/admins when tickets are converted.
* Discord messages now get a "Ticket 3, " or similar prefix.
  Not useful by itself, but will be with the following PR.

Code changes:
* When you create a ticket, you get the ticket object back.
* checkForTicket now allows you to fetch a ticket by number, and falls
  back to searching for open tickets if the ticket isn't found.
* Corrected and simplified the logic for adding PMs to tickets.
* Responses are now added through the ticket system, not the tickets
  directly.
2024-03-26 13:44:26 +00:00
Contrabang
e43ac6c665 epic PR review fail (my bad) (#24706)
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-26 10:56:33 +00:00
Contrabang
1afddd3b79 Makes RND and PDA servers quieter and not wall-penetrating (#24700)
* i prefer if my ears didnt bleed

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-26 10:56:17 +00:00
Charlie Nolan
e1303fe0ba Make the nuclear beer keg react to the NAD. (#24637)
* Make the nuclear beer keg react to the NAD.

* Made the beer keg nuke attackable again.

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Switched to addtimer per review suggestion.

* Update code/modules/reagents/reagent_dispenser.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-26 10:55:28 +00:00
Contrabang
b68b48e37e Makes stuttering actually legible (#24324)
* stutter but better

* good whitespace

* downstream support
2024-03-26 10:55:10 +00:00
Qwertytoforty
138fd7d1b1 fixes mod control icon being fucky (#24714) 2024-03-26 10:00:33 +00:00
PopGamer46
418a76fccb Fixes virology goals completing even if you delivered less than 15u (#24749)
* fix

* removes unnecessary else
2024-03-26 09:56:43 +00:00
dj-34
8981b491e0 Fix: Necropolis gate is now opens when Legion takes damage (#24768)
* Fix: Legion now triggers when taking damage

* Update by review

Co-Authored-By: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-26 09:56:11 +00:00
Charlie Nolan
fd6b2c32de White cables no longer spontaneously change color (#24763)
* Allow cables to be white.

* Allow cables to remain white.
2024-03-26 09:56:06 +00:00
Charlie Nolan
589f1e8ee7 Updated the ancient space station awakening text (#24760)
* Charlie knows the current year now.

* This change is apparent.
2024-03-26 09:55:25 +00:00
GDN
417914dc89 fixes bot menu jumpscares (#24780) 2024-03-26 09:53:39 +00:00
dj-34
34e56dd444 Directional sprites for library computer (#24794)
* Directional sprites for library computer

* Removes legacy sprite, fix direction screen
2024-03-26 09:49:43 +00:00
PopeDaveThe3th
7eacbf6ad7 updates the syndirifle's descirption (#24799) 2024-03-26 09:48:29 +00:00
PopeDaveThe3th
c2547ea741 modsuit desc updates (#24798) 2024-03-26 09:48:26 +00:00
Charlie Nolan
30b5c71ac0 Null-safe pockets. (#24812) 2024-03-26 09:46:07 +00:00
Charlie Nolan
b45ba0aff9 There can no longer be -1 admins/mentors online. (#24814) 2024-03-26 09:45:57 +00:00
Henri215
c74262fc25 Adjusts some borg hat offsets (#24816) 2024-03-26 09:45:45 +00:00
Mikhail Dzianishchyts
9dc9d47266 Show poll alert for admins anyway (#24817)
* Show poll alert for admins anyway

* Update comment
2024-03-26 09:41:12 +00:00
DGamerL
de1229b947 Removes various helpers that can be simplified in a single variable check (#24551)
* Removes the first weird helper

* Removes get_turf_or_move

* Slightly alters the sharp weapon proc

* Adds nullcheck to adjustBruteLossByPart

* Changes `is_dead`

* Adds `hasorgans` to the replaced list

* Update code/__HELPERS/unsorted.dm

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>

* Contra review

---------

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
2024-03-25 01:31:56 +00:00
chuga-git
19c0b70171 Slightly refactors storage item insertion (#24429)
* everything is on fire

* silent trait check

* how did it even become CRLF

* minor formatting

* fix icon updating and adds silent insertion to global trait list

* adds the new parameter to documentation - whoops!

* pain

* contra review

* contra review again, reduces amount of checks for user in the loops

---------

Co-authored-by: cybercapitalism <98280110+cybercapitalism@users.noreply.github.com>
2024-03-24 18:41:07 +00:00
DGamerL
f52b7a8c58 Thank you mhelp for showing this weird coding thing (#24717) 2024-03-24 18:13:37 +00:00
DGamerL
c9aa979e64 Rewrites + spellchecks the seed vault papers (#24747)
* Wow this was something

* Update code/modules/paperwork/paper.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Update code/modules/paperwork/paper.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Update code/modules/paperwork/paper.dm

Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>

* Update code/modules/paperwork/paper.dm

Co-authored-by: Charlie Nolan <funnyman3595@gmail.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Co-authored-by: Charlie Nolan <funnyman3595@gmail.com>
2024-03-24 18:12:19 +00:00
matttheficus
261b53d17c Adds Hand Raising (#24223)
* pick me pick me!

* quick fix

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* contra tweak

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* contra refactor help

* copy paste moment

* missed one lul

* contra review

* tab hell tab hell tab hell

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-24 18:10:21 +00:00
Luc
1fe7819c1b Ports action button refactor from /tg/ (#24482)
* add the new stuff

* guh

* add the brunt of it

* action button stuff

* adds a lot of other stuff

* careful find and replace

* it loads

* so many huds

* ehh yeah this kinda works

* fixes this runtime

* hacks in some DMI stuff, we'll fix it later

* Adds better mouse pointer for dragging buttons

* gets dragging into place working again, updates DMI

* moves define

* remove extra hud defines, now it compiles

* CHECK GREP

* owww

* rename action defines

* ticks

* are we good

* let's try that again

* renames mob vars

* renames

* fixes some hud issues with huds getting the wrong variable

* fixes some alignment issues

* Adds mouse-wheel scroll support

* left -> right

* I am the entire circus

* first self-review pass

* Another review pass -- just realized I need to fix keybinds

* more testing

* update icons

* oops

* Fix spell icons not appearing properly

* fixes some outstanding issues
- Action button backgrounds now work properly
- Fixes some runtimes on dropping
- Fixes some misplaced icons

* hmm

* weh

* again?

* nah?

* maybe this?

* asdf

* should finally fix CI

* add client check

* move the ?

* add missing override causing runtimes

* shift-clicking now doesn't trigger the button

* better docs
2024-03-24 17:38:53 +00:00
Contrabang
d5684cd59c great code :) (#24797) 2024-03-24 17:04:39 +00:00
Luc
6100c36987 Adds a crew monitor for observers (#24118)
* wheee

* ignoring sensors now actually gets all health info

* a

* this wasn't supposed to go here

* delete observer menu on mob del

* erm

* global on my datum

---------

Co-authored-by: github-actions <github-actions@github.com>
2024-03-23 22:51:55 +00:00
Qwertytoforty
00ce408dd2 ffixes smoke (#24775) 2024-03-23 18:52:29 +00:00
DGamerL
6cd2813150 Makes the isorgan() define more sane (#24738)
* Makes this define a bit more sane

* Why is this a proc!!!!

* Underscores

* Combines two uses into one define

* Contra review
2024-03-23 17:16:29 +00:00
1080pCat
8270f92d7e Adds a suicide act to the wormhome projector. (#24532)
* Update special_eguns.dm

* Update code/modules/projectiles/guns/energy/special_eguns.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* more feedback. plus a explanation on what SHAME does

* oops

* Update code/modules/projectiles/guns/energy/special_eguns.dm

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-22 16:39:59 +00:00
Qwertytoforty
9096c5f0b9 Ports the NTSS Raven from TG station. Slightly remaps delta escape / faragus escape (#24567)
* R A V E N

* docking ports. Delta needs  tweak

* yep

* raven generators, increased range / anchored

* names / fixes wrong generators

* decore / missing decal

* NTSSS RAVEN

* purge this

* oops

* should be good

* Update code/modules/mob/living/simple_animal/friendly/mouse.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-21 21:21:56 +00:00
warriorstar-orion
04011d8e43 remap: white ship to explorer ship (#24613)
* remap: white ship to explorer ship

* swap wide airlock with two 1x1 doors
2024-03-21 21:00:15 +00:00
Contrabang
323d23acc9 Datumizes Wizards (#24702)
* fucking wizards

* this too

* this

* i think thats it

* okay lets do this

* remove commented code

* gdn review

* welp

* fix runtime

* yes

* lewc review
2024-03-21 20:56:55 +00:00
Qwertytoforty
4caaceb9fe defogs mephedrone (#24713)
* defogs mephedrone

* fixes mod backpacks being fucky

* Revert "fixes mod backpacks being fucky"

This reverts commit f2df4809a5.
2024-03-21 20:53:57 +00:00
warriorstar-orion
35ca57c262 Add constructible transit tubes. (#24045)
* Add constructible transit tubes.

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* change construction type, add icon state

* don't give any glass back, support RPD recycling

* destroy/explode into glass decals

* Update code/game/objects/structures/transit_tubes/transit_tube_construction.dm

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* tube automatic orientation is unintuitive

* support manual flip/rotate like pipes

* better logic for installation

* better support for building in space

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* second half of review suggestions

* Update code/game/objects/structures/transit_tubes/transit_tube_construction.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-21 19:27:07 +00:00
PopGamer46
de894636f4 fixes a bug, sorry for that (#24734)
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-21 19:23:43 +00:00
warriorstar-orion
6a2d229795 Refactor Lavaland river spawner. (#24192)
* Refactor lavaland river generator.

* document var
2024-03-21 18:42:35 +00:00
PopGamer46
d6a48deac3 Adds virology goals! Something for the viro to do (Ready for review) (#23408)
* virus analyzer and WIP virology goals

* bug fixes but not all

* tgui update

* fixed bug

* runtime fix

* small fix

* misc

* virology goals not showing required symptoms fix

* virus analyzer code polish + animation tweak

* removes virus analyzer + tweaks

* adds the health analyzer back

* code polish

* comment edit

* oops, this time resolves merge conflicts

* bigger payout and more goals upon completion

* adds the until now unused vial lockbox

* more code tweaks

* also code tweaks

* yet another code polish

* merge conflict resolve

* virology job_objective

* merge conflict resolve

* grammar

* code polish

* another polish

* forgot these

* oops, how did i do this mapping error

* some but not all code polish and moves vials to fridge because i forgot on map queue, sorry

* finally merging some of the requested changes

* forgot this

* one reguested change left

* merges last reguested change

* failed check asks to rebuild tgui

* most of the reviews

* removes lazyremove, no idea why i used it there

* reviews

* grammar

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* more reviews

* forgot to undef

* deletes old tgui file

* Contrabang reviews

* some of DGamerL´s reviews

* oops

* DGamerL´s reviews

* Update tgui.bundle.js

* stealth virus virology goal now requires 4 symptoms instead of 5

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2024-03-21 16:23:08 +00:00
Aylong
38f009b763 [TGUI] Prize Counter (#24079)
* PrizeCounterUI 1.0

Update PrizeCounter.scss

Update prize_counter.dm

UI work

It just works

* Image layout fix

* Better names

* Tooltip

* Unused code and disable button

* That's not necessary either

* Search

* Maybe that's all

* Stack.Divider, wow, universal component

* Rebuild

* Rebuild

* Turn off auto-update

* Ooops

* Code style

* Rebuild

* Ah... yes... rebuild

* Ticket icon like on screenshot
2024-03-21 13:48:44 +00:00
BiancaWilkson
fa54eeebc5 [S] Fixes an exploit (#24721)
* fixes an exploit

* length
2024-03-21 06:08:28 +00:00
DGamerL
c96be1d6b7 This is the fix (#24710) 2024-03-20 21:52:19 +00:00
Henri215
765461f14a Bear update, part 2 (#24506)
* The bear update!

* more sprites

* more bearprites

* diversify

* removing comments

* description and mapping

* duplicate

* Update code/modules/mob/living/simple_animal/hostile/bear.dm

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-20 21:33:32 +00:00
BiancaWilkson
5a12934651 chat box red (#24663) 2024-03-20 21:03:55 +00:00
matttheficus
fac94d826c Adds Boot Knives (Combat + Mining Boots + Jump Boots) (#24530)
* stabbing time

* examine text

* oopsie

* spans

* add to jumpboots

* contra review

* henri/gdn reviews

* contra + burzah review

* span swap

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-20 20:55:21 +00:00
McRamon
d18cebac6e Cowboy hats resprite (#24611)
* human_mob

* items

* grey_mob

* drask_mob

* vox_mob

* code, lets fucking hope i didnt forget anything

* i forgot stupid fuckign shit

* also i love to delete wrong things

* Update code/modules/clothing/head/misc_hats.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/client/preference/loadout/loadout_hat.dm

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>

* moved to other cowboy hats

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
2024-03-20 20:23:54 +00:00
matttheficus
7b462f34b6 Increases Paper's Window Size (#24541)
* its time to PAPERWORK

* remove test item

* autodoc / henri

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-20 20:22:07 +00:00
Marm
a8f2d2f001 Gutlunches will no longer eat brains. (#24603)
* NO MORE EATING BRAINS

* Update code/modules/mob/living/simple_animal/hostile/mining/gutlunch.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-20 20:20:33 +00:00
Luc
9efffccd71 Adds CI checks forbidding certain kinds of world loops (#24454)
* Updates checkgrep to report unnecessary loops

* improved message

* global lists are better too

* much better

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* update to modern check_grep format

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-20 20:17:45 +00:00