* refactor: Movement cross/uncross implementation.
* wrong var name
* fix unit tests dropping PDAs into nowhere
* Add documentation.
* remove unused constants
* say which procs are off limits
* fix simpleanimal z change runtime
* helps not to leave merge conflicts
* kill me
* fix typecast
* fix projectile/table collision
* treadmills don't cause MC to crash anymore
* connect_loc is appropriate here
* fix windoors and teleporters
* fix bonfires and clarify docs
* fix proximity sensors
Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers
* lint
* fix: polarized access helper false positives
* Revert "fix: polarized access helper false positives"
This reverts commit 9814f98cf6.
* hopefully the right change for mindflayer steam
* Changes following cameras
* fix glass table collision
* appears to fix doorspam
* fix ore bags not picking up ore
* fix signatures of /Exited
* remove debug log
* remove duplicate signal registrar
* fix emptying bags into locations
* I don't trust these nested Move calls
* use connect_loc for upgraded resonator fields
* use moveToNullspace
* fix spiderweb crossing
* fix pass checking for windows from a tile off
* fix bluespace closet/transparency issues
* fix mechs not interacting with doors and probably other things
* fix debug
* fix telepete
* add some docs
* stop trying to shoehorn prox monitor into cards
* I should make sure things build
* kill override signal warning
* undef signal
* not many prox monitors survive going off like this
* small fixes to storage
* make moving wormholes respect signals
* use correct signals for pulse demon
* fix pulse heart too
* fix smoke signals
* may have fucked singulo projectile swerve
* fix singulo projectile arcing
* remove duplicate define
* just look at it
* hopefully last cleanups of incorrect signal usage
* fix squeaking
* may god have mercy on my soul
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* lewc review
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* burza review
* fix bad args for grenade assemblies
* Update code/__DEFINES/is_helpers.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
---------
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* makes magma-ale and space beer bottles instead of cans
replaced all occurences of the cans to the new type
* forgot to rever test_tiny
* path script + repathing
* space bar sleepy beer repath
* Update tools/UpdatePaths/Scripts/27407_ale_beer_repath.txt
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>
* Update code/game/objects/structures/crates_lockers/closets/secure/bar.dm
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>
---------
Signed-off-by: Toastical <vnndvp@gmail.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* refactor: Rename all non-snake_case types (not procs or vars (yet)).
* completely dynamic update script
* might help to include the data
* update aa's scuffed python
* oh
* set script PR number
* run updatepaths again
* Add other table updates with JSON columns
* bump SQL version
* just fucking end my life
* move JSON data
* IT WORKS UP UNTIL THIS POINT
* Consolidates SLOT_FLAG and SLOT_HUD into one
* Remove cover_both_ears
* SLOT_HUD to ITEM_SLOT
* Remove clothing_trait changes for the time being
* Remove accidental copy-paste
* Re-add no-slip var
* More failure to copy-paste correctly
* Leftover flag
* Combine left and right slot flags where possible
* UNGOOF MY DEFINES, PHAND IS NOT A THING
* Minor spacing changes
* Some more fixes from merge
* Seperates ITEM SLOT AMOUNT into two defines
* ON SECOND THOUGHT LETS NOT DO THAT.
* Addresses Contra's review
* Thank you GREP
* Rename ITEM_SLOT_FEET to ITEM_SLOT_SHOES
* Added a comment to the bitmasks in clothing defines
* Rename ITEM_SLOT_TIE to ITEM_SLOT_ACCESSORY
* These are for a seperate PR.
* Magboot fixes
* Requested changes
* Re-add accidental removal
* Wrong flags
* Update code/__DEFINES/clothing_defines.dm
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Chap <erwin@lombok.demon.nl>
* Requested changes
* Merge fixes
* Fix double headset
* Fixes multiple accessories
---------
Signed-off-by: Chap <erwin@lombok.demon.nl>
Co-authored-by: Adrer <adrermail@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
* Modified the RPD auto-wrenching behaviour
* Removed tool requirement for auto-wrenching
* Allowed the BRPD to auto-wrench remotely
* Added a TGUI toggle for auto-wrenching
* Added a Line of Sight check for the BRPD
* Readded missing UI buttons
* Tweaked disposals construction
* Disposals objects can't be anchored if there's floor tiles
* Bins, chutes and outlets now need a constructed trunk to be anchored.
* Changed LoS check, added sounds, stopped station auto-wrench.
* Final touches for the RPD
* Added sounds when wrenching occurs
* tgui bundle
* Consolidated all RPD related sounds to the RPD code
* removed some redundant things I forgot about
* tguibundle
* span classes and tgui bundle
* Applying lewcc's suggestion
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Toastical <vnndvp@gmail.com>
* applying lewcc's 2nd suggestion
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Toastical <vnndvp@gmail.com>
* Applying contrabang's suggestions + added marks in pipe.dm
* typos n stuff
* tgui bundle
* Update code/modules/recycling/disposal-construction.dm
Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
---------
Signed-off-by: Toastical <vnndvp@gmail.com>
Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* We can't have nice code
* Trailing newline
* Also fixes double closing sound
* Move invalid ID check all the way up
* Early return makes this if statement unnecessary.
---------
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
* Revert "fixes this bloody laser (#27167)"
This reverts commit 1bec4cd8a7.
* Revert "Ports the Power Transmission Laser (#26928)"
This reverts commit 592b7c3ec3.
* this lol
* TGUI
* wip
* some formatting and copying over UI
* it compiles now
* oops
* Moves WATT_TICK_TO_JOULE to the power defines file. fixes UI
* spelling and announcement fixes
* Handle offsets for different directions
* laser comes from the correct tile now
* Added north and south sprites for the laser
* Adjust offsets for north and south sprites
* finished all north and south sprites
* tgui rebuild. Also sprites and code begoon
* Rebuild TGUI
* put PTLs in maps
* Repositions PTL room door in cyberiad
* fix if spacing
* undef and unundeffed define
* Removed overlapping stuff in some maps
* Actually makes the changes to metastation
* Fixes more mapping stuff
* Fix more unit test failures
* unmirror multitile component grid
* Fixes multitile
* explosions no longer make a hole in the beam
* This should fix it
* Stray pipe begone!
* Ok I think I fiigured it out
* Rebuild Tgui
* removes redundant removals of components parts and a redundant check. various style fixes
* Adds blocking to the beam and objects other than living beings take damage now.
* not using kwargs now. should work.
* Style changes and fixes some mobs getting hit by the laser that shouldn't be.
* Review changes and fixes trying to access wall turf's location.
* allow the new wall turf to form to we can properly access it.
* Moves the ptl beam effect to an atom proc that is overriden by the different types of things that can end up in the beam.
* Fixes some comments, adds clarifications, removes redundant usage of src
* moves the announcement threshold to a global var. Fixes ghost interaction.
* Revert "moves the announcement threshold to a global var. Fixes ghost interaction."
This reverts commit 7916ee76a1.
* Makes announcement threshold a static variable of the PTL
* power safty check on the mob ptl function
* Rebuild TGUI
* Rework Lavaland tunnel themes.
* Fix deeprock mob density; ensure 1 vetus/bubblegum
* goddamnit
* bring spawn odds closer in line to head, fix tendril collapse range
* Move define to global dir
* don't need initial here
* define magic number properly
* make type of var clear
* CHECK_TICK during procgen
* less tendril cities, no tendrils in oasis centers
* revert no_lava helpers for now
* add NO_LAVA_GEN flag check back to safe_replace
* add blackbox feedback for themes
