Commit Graph

20793 Commits

Author SHA1 Message Date
BiancaWilkson
aa7fd4eaf8 BEGONE (#19560) 2022-11-11 14:13:56 +01:00
GDN
fde612de05 Initializes and fixes alien eggs (#19604)
* Initializes and fixes alien eggs

FIX: Fixes alien eggs not spawning facehuggers when a valid target is in range
FIX: Fixes alien eggs runtiming due to proximity monitor issues
REFACTOR: Refactors Spawn() into addtimer
REFACTOR: New() to initialize()

* standardization and removing unneeded checks

* 515 compliance

* just need PROC_REF for this
2022-11-10 17:05:22 -06:00
FloFluoro
ee99869869 Cloning pods can now be cmagged (#19329)
* Cloning pods can now be cmagged

* Early returns, added define for cmag source
2022-11-10 21:15:16 +01:00
S34N
0a441dc5d7 Revenant buff (#19577)
* spooky

* not yet tested

* i hate my life

* CI

* Update code/datums/spell.dm

* Update code/game/gamemodes/miniantags/revenant/revenant_abilities.dm

* review pass 1

* wise charlie words

* icons

* farie suggestion

* double vars

* haha oops

* bye you useless waste of space

* more damage

* farie review

* pass 2

* and this

* this is not a bool

* Apply suggestions from code review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* charlie review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-11-10 21:10:03 +01:00
S34N
667dd5d4ac 515 Compatibility (#19636)
* 515 compat

* double spaces

* Callback documentation, aa review

* spacing

* NAMEOF_STATIC

* big beta
2022-11-08 23:08:40 +00:00
matttheficus
8b1e66d389 cant reflect this (#19559) 2022-11-07 20:59:49 +01:00
warriorstar-orion
7867c51b52 Replace /proc/num2hex with a much faster macro. (#19600) 2022-11-06 13:11:32 +00:00
FloFluoro
332fc9193a Fixes description grammar in a few places (#19607)
* Fixes punctuation on clown box description

* Fixes grammar in a couple places
2022-11-06 10:43:20 +00:00
warriorstar-orion
4ace2d6c2b Implement map tests for catching common errors. (#19204)
* Implement map tests for catching common errors.

- Adds test runner:
	- to make it easier to track things across test types
	- for example to ensure a fully specified log can be emitted

- Adds map tile test type:
	- when writing a test, coders implement CheckTile, which is
	  handed a single turf
	- when the test runner runs these tests, it iterates over
	  all turfs in the specified z-level, and runs each test's
	  CheckTile on each turf in turn.

- Adds two sample map tile tests:
	- check to see if a pipe exists on the same tile as a scrubber
	  or vent
	- check to see if a tile contains two cables, each with a center
	  node

* Review #1:

- Replace nested loops over map tiles with `block`
- Remove check for valid turf in individual tests, I think it's safe to
  assume `block` will always return legit turfs
- Added proper duration tracking for old tests
- Gave log file an appropriate extension
- Actually use `Fail` for tests

* whoops

* add more tests suggested by @Vi3trice

* Add some more tests courtesy @Bm0n and @Vi3trice

* windows are okay in space as long as it's nearspace

* Add failure threshold to prevent excessive logging.

Once this threshold is reached, a test will stop being processed for
every tile.

Note that this applies to `log_world` and `text2file` equally when
logging large amounts of failures.

* Document each test.

* Remove unnecessary reboot

* Let all map tests run to completion in CI matrix.

* I know what alphabetical means
2022-11-05 15:32:17 +00:00
FloFluoro
923e4b933a Adds new lawset, "Pranksimov" (#19306)
* Adds new lawset, "Goofsimov"

* Goofsimov module now spawns at player's feet

* Module renamed to AsiFun

* Renamed... again!
2022-11-05 13:44:41 +00:00
Adri
62a4ddb174 Fixes the telecomms machine having "Noise" as a listed language (#19611) 2022-11-05 13:44:23 +00:00
AffectedArc07
21109f3be2 Improved antag fishing busting (#19542) 2022-11-03 18:05:43 +00:00
S34N
8e475415b1 Stops tree shadows from being part of their hitbox (#19543)
* unclickable shadows

* readability

* effect

* Update code/game/objects/structures/flora.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* order of operations

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-11-03 18:02:08 +00:00
Christasmurf
66e893ad2d Adds Suspicious Bomber Jacket (#19545)
* syndicatebomber

* armourmeup

* Update code/modules/clothing/suits/miscellaneous.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-11-03 18:01:31 +00:00
Coolrune206
e80ae1f95f Removes .357 Speed Loaders from Autolathe, replaces with .357 Ammo Boxes (#19553)
* revolvers are balanced now, right?

* decreases metal cost per bullet from 5000 to 4000

* converts bullets to a new ammo box

* shut up Marmite (makes the revolver unrecyclable)
2022-11-03 18:01:05 +00:00
GDN
00e33dd91a Fixes a DNA scanner stacktrace runtime (#19567)
* fixes a DNA scanner runtime

* Earlier return

* Code comment
2022-11-03 17:58:26 +00:00
Henri215
047727d575 safe no longer locked when repaired (#19569) 2022-11-03 17:58:05 +00:00
Sirryan2002
8dd4fe61be moving some returns around (#19591) 2022-11-03 17:55:47 +00:00
Henri215
d270ba10d6 shielding typo (#19589) 2022-11-03 17:55:27 +00:00
warriorstar-orion
8ea4da61f3 Rename IC announcement CSS class (#19580)
* Rename IC announcement CSS class

* fix ai mech takeover too
2022-11-02 20:54:08 +00:00
Contrabang
32146754c1 bye bye macro (#19574) 2022-11-02 20:52:22 +00:00
Bm0n
c4ded4b083 Ports TG direction signs (#19506)
* signs

* whoops forgot the desc

* evacfix
2022-11-02 21:03:05 +01:00
warriorstar-orion
85f4503d33 Refactor announcements. (#19459)
* Refactor announcements.

* Actually make this a unit test

* Dumb

* Remove unnecessary 'as text'

* Reviews:

- Make CSS class a recognizable word
- Flip the defaults for logging

Also:

- Style fixes (default null in fields)
- Fix emergency/crew-transfer shuttle announcement titles
2022-11-02 20:31:37 +01:00
Qwertytoforty
a7bef74380 Makes cult spear not an instant stun. (#19343)
* Makes cult spear not an instant stun.

* Apply suggestions from code review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* requested changes

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-11-02 20:23:40 +01:00
matttheficus
09948d54b2 Deputizing the Detective (#19558)
* Deputizing the Detective

* access giveth

* the gun now hurts you again

as per Hal's comment in discord

* add noir to detdrobe
2022-10-31 23:15:12 +00:00
Vi3trice
05d93f665a [TM] Port TG Jump Point Search and SSpathfinder (#18984)
* move along move along

* Update bot.dm

* Diagonals are now more expensive

* Update path.dm

* Update parrot.dm

* Update path.dm

* Tweaks

* Fix cleanbot, add path safety

* Tweaked, added a safety, removed the previous one

* Update medbot.dm

* path.len isn't very safe as a whole, floorbots also had order of operations wrong

* Update medbot.dm

* clings not even once

* Back to the drawing board

* Update path.dm

* Make mules actually clear the drawn path.

* Make bots use step_towards unconditionally instead of flipping between step_to and Move

* Making extra sure the path is cleared. Somehow path was left over.

* Check for length as get_path_to is always true

* This and that
2022-10-30 15:54:51 +00:00
Farie82
d253e13c35 Add a comment for item_state (#19534) 2022-10-30 15:52:21 +00:00
ElorgRHG
c456bdefdc [GBP NO UPDATE] Fixes the basetype of .../under/suit spawning (#19471)
* Fixes the basetype of .../under/suit spawning

* Suggestion

* The other way around
2022-10-28 20:20:01 +02:00
Henri215
473a46ff5a Tweaks to autolathe design costs (#19469)
* first wave of tweaks

* Update code/modules/power/cable.dm

Co-authored-by: Edan <29551695+Edan52@users.noreply.github.com>

* Edan52 review

* missed one

Co-authored-by: Edan <29551695+Edan52@users.noreply.github.com>
2022-10-28 20:05:46 +02:00
Henri215
0a3111f6cf Matter wont consume if theres a wall already (#19518) 2022-10-28 20:04:26 +02:00
Vi3trice
03ce2920e1 Defining Part 4 - Code cleanup toward defines (... and the rest) (#19388)
* I wasn't done

* nits
2022-10-28 19:28:23 +02:00
GDN
9400729a28 Removes some technical debt (#19220) 2022-10-28 19:09:21 +02:00
Henri215
47b3d08f04 Newscasters/camera monitors/displays tweaks (#19305)
* frames and autolathe

* final adjustment

* engine monitor

* circuit board selection and newscaster tweaks

* names adjustments

* entertainment frame icon adjustment

* moving to another PR

* forgot to move those

* added the other monitors circuit boards

* Update code/game/machinery/computer/camera.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* removed unnecessary flow

* display

* entertainment frame uses correct icon now

* merge conflcit part 2, do_build for newscasters

* moving var

* Sirryan suggestion and reverting piece of code removed by mistake

* Update code/game/machinery/computer/buildandrepair.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* added description

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* Sirryan suggestion and removed 1

* moved to on_deconstruction

* Removing unused arguments

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-10-28 19:00:03 +02:00
Henri215
7159b8e462 Fixes #12922 Malf AI camera upgrade is now giving the ai night vision (#19375)
* malf module lighting now updates properly

* not necessary
2022-10-27 22:42:29 -05:00
S34N
9f9f047ed3 Disposal sprite rework (#19238)
* initial

* 3/4ths

* pointers

* TCC disposal machine

* sprite update

* pacifistdalek

* pixel

* ticks one thing

* arrow

* darkened the disposal
2022-10-27 21:56:41 -05:00
Charlie
302a7598dc fix (#19513) 2022-10-26 19:19:20 +01:00
Contrabang
8b3c043746 cloth addition (#19480) 2022-10-26 00:25:11 +01:00
AzuleUtama
c8edc8c240 Syndi Bundle Rework (#19352)
* Syndi Bundle Rework

* Revised bundles based on feedback

* Reworked operative into grenadier

* Corrected payday value
2022-10-26 00:19:56 +01:00
Vi3trice
fc7e4847b3 Penlights are universally pens (#19498)
* You're a pen, you're a light

* Update code/__DEFINES/is_helpers.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* Might as well remove them

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-10-26 00:12:14 +01:00
Luc
fffecaa8de Add ghost follow links to blob telepathy (#19431)
* Add ghost follow links to blob speech

* Consistency

* Update code/game/gamemodes/blob/blobs/blob_mobs.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-10-25 20:39:54 +02:00
Henri215
499a0f3b9d Moved wood floor (#19487) 2022-10-25 20:35:28 +02:00
Contrabang
a6ba421e21 removes implantchair.dm (#19460) 2022-10-23 16:39:45 -05:00
ElorgRHG
574b012505 The (formal CC) blueshield drip is back in town (#19425) 2022-10-23 11:34:45 -05:00
roarbark
71bd40099c buffs the radio jammer (#19377)
* buffs the radio jammer

come on and jam and welcome to the jam

* come on and jam

the jam

* i never actually watched space jam i just thi

running outta jokes

* unjams the pr

im so fucking funny bro

* unfucks the pr for real (developers swearing bot hello)

worth a try
2022-10-23 11:20:20 -05:00
BiancaWilkson
21fc24a31c Ports Yogstation's version of CQC, adds it back to traitor uplink. (#19310)
* Changes most instances of brute to stamina, combos

* Adds CQC back into uplink

* Updates chokeholds so it takes time to knock out

* Adds cqc back to tot uplink, gives nukies discount

* Tweaks base grabs and disarms

* Tweaks combos some

* I am a mild idiot

* Charlie's suggestions

* I don't like these numbers, nerf head kick

* Removes blocking and countering

* More kicking tweaks

* Update code/datums/uplink_item.dm

commit charlie's changes pt. 2

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* stop kicking yourself

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-10-22 21:42:17 +01:00
Sirryan2002
0150e8dc05 barricade fix (#19479) 2022-10-22 12:56:07 -05:00
ElorgRHG
1660182d19 Paradise's soul removal part three: lawyers (#19376)
* Better Call Coderspriters

* This name looks better

* Turns out this is not a copy of an existing jumpsuit

* Minor drask sprite adjustment
2022-10-21 20:36:36 +02:00
GDN
7984a86d19 Blob report/CC detonation request is now logged (#19401)
* Blob report is now logged

* better punctuation

* Implements Ryan's suggestion
2022-10-21 20:05:12 +02:00
warriorstar-orion
c254efbcdf Remove unused newscast ability from announcements. (#19442)
* Remove unused newscast ability from announcements.

* Switch from 0/1 to FALSE/TRUE in modified code.
2022-10-21 19:59:36 +02:00
FloFluoro
acd1e96e29 Fixes typo in war declaration fail message (#19445) 2022-10-20 19:33:59 +01:00