* bring it back now y'all
* adds a bunch of other changes
* pretty much works at this point
* grep
* Fixes some bugs, still chasing some down
* Add observers to recursive mob check, ensuring they can see messages from their orbitted atom
* tidy some things up
* resolve
* remove unnecessary checks
* Address todos, minor cleanups
* oh dear
* initial testing
* Fix some vulnerabilities (oops)
* Fix some other bugs from testing
* ci fixes
* Add some contingencies against clicking things you shouldn't
* fix some noted bugs
* Add observe to admin jump, improve messaging
* add a few more fixes that should mostly address some runtimes
* oh this wasn't really great
* one last thing
* Fix suit inventory problem
* Remove merge artifact
* Add some missing parens
* Prevents you from observing other ghosts, and should fix the getting stuck outside of your body issue.
* we love testing
* adds to player panel
* Fix more bugs with observers getting stuck outside of their body
* cleans up player panel, verb offerings
* shit
* Update code/_onclick/hud/alert.dm
welp
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Fixes some targeting issues
* Fixes targeting on aobserve
* Fix some weird storage bugs
* clean up some doulbed up follow links
* Update code/modules/admin/player_panel.dm
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Adds some checks for ghost observe
* Remove mentor debug log
* ahhhhhhhhh that'll do it
* Cleans up some additional checks that were not quite what they should have been
* better logging, too
* mochi review
* one more thing
* Gets robot huds mostly working
* hopefully fix folks not getting observe
* Fix order of operations causing a runtime on qdeleting
* Remove some unnecessary stack traces
* Apply suggestions from code review
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Fix bug with items in your inventory disappearing on changing HUD modes
* Fix some bugs with the observe verbs
* possibly fix nullspace issues
* funny review
* missed one
---------
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Didn't work
* It works
* Emojipedia
* Some emoji sorting
* lol
* Remove a lot of shit emoji
* Update emojipedia.dm
* Observer and ghost-bar emoji
* Msay emoji
* Emoji sorting and updates
* Make emoji centered
* Clueless and trollface
* Mowzers
* +taa
* Another rebuild
* TRUE and Rebuild
* part 1
* these also
* fuckin nuke it
* more
* more stuff
* more crap
* wow
* holy fucking shit, it works
* thats a start
* oops
* fubing bundle
* hahah brrrrr
* I LITERALLY ADDED IT BACK, FUCK OFF GIT
* yeah more changes
* hide abstract
* blamo
* thats enough for today
* old code begone
* goodbye can_strip
* nearly there
* finally
* fuckin finally
* review
* tgui
* unbreak shit
* fix OD
* okay, that should fix the last thing
* remove hover on nodrop, fix early interacting
* Extract requests console message sending code.
* Add secondary goals
* Converted supply shuttle to a signal-based system.
* Lint.
* Review suggestions.
* Secondary goals can now check the supply shuttle for their requirements.
* Remove redundant completion variable, undef what we define.
* Made the request console refuse to issue a secondary goal until you finish the current one.
* Made the shuttle blacklist error more specific, added locked/manifest-attached crates to blacklist.
* Added round end secondary goal report.
* Lint
* Add tags to reagents for secondary goals to use.
* Extracted the reagent logic from the bar goal, used reagent tags.
* Added the Variety of Drinks Bar goal.
* Added variety drinks goal for the Bar.
* CC no longer complains about sending stuff in containers, but the shuttle will refuse lockboxes without goal items.
* Allow unlocked lockboxes on the shuttle.
* Added kitchen goals.
* Lint
* More lint
* Add goals for scichem and medchem, pending reagent labelling.
* Added Kudzu goal for botany.
* I forgot to rename them, oops.
* Lint
* Made mechs sellable, configurable goal rewards.
* Balancing changes.
* Added random Ripley goal.
* Add Clear Task Backlog station goal.
* Lint
* Oops.
* did i even do this right
* Lint
* Excluded drinks available from upgraded booze dispenser.
* Such bugs. Much fix. Wow.
* Goal notice formatting.
* Apply suggestions from code review
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
* Made storage nesting better, improved consistency between storage types.
* Out, er, space.
* Added a proc for sending a requests console message.
* Added error messages to Virology Goals.
Backported a few small things from Secondary Goals to make this easier.
* Extracted out the three-way reward code into a proc.
* Update code/__DEFINES/dcs/signals.dm
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Removed redundant SIGNAL_HANDLER labels.
* Yes, that should be a proc.
* Enforce important parent calls.
* Thank you, DreamChecker
* Undid accidental merge of #24699
* Removed a testing proc that wasn't intended for this PR.
* Removed parts of #24750 that also crept in.
* Made the variety of [x] goals more explicit that they want 50u of each.
* Reduced Kudzu trait requirement to 1.
* Request consoles now output the list of valid departments if you're at an unsupported one.
* Added personal crates.
* Added a supply pack of personal crates.
* Added special cargo handling for personal crates.
* Added automatic personal crate when requesting a goal.
* Required personal crates for most secondary goals.
* Add goal labels to the hand labeler, require them for mech goals.
* Made secondary goals one-per-person, not one-per-department.
* Added support for multi-line system messages to the request consoles.
* Made the RC message for goals nicer.
* Send goal crates even if no normal crates are ready, name and access-lock them properly.
* Don't double-label.
* Let's not use registered_account, names are fine.
* Add a ton of blackbox data to cargo and secondary goals.
* Fix a few bugs.
* More bugfixing, couple more stats.
* Even more stats.
* Text fix.
* Made cargo fines more consistent with other cargo feedback.
* Fixed a bug that prevented non-top-level items from being checked for CARGO_REQUIRE_PRIORITY.
* Blocked large crates from being sent back unopened.
* Enum values should probably be different from each other.
* Correct a bitflag mishap.
* Removed redundant supply shuttle docking and buy/sell attempts.
* Tweak message about personal crates to inlclude that they need to lock it.
* Add /Crates to the Personal Lockers description.
* Less pretty alignment, less complaining linters.
* Corrected a bad name in stats tracking.
* Reduced SciChem variety goal to 5 types.
* Toned down Task Backlog a bit.
* Fixed a bug that made unsellable items nested in containers be stolen by CC (qdeleted).
* Don't require bluespace 8, that's silly.
* Made secondary goals modifiable in the Modify Station Goals UI.
* Whoops, that was supposed to be 600u.
* i ded pls nerf
---------
Co-authored-by: synthtee <127706731+SynthTwo@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Bound ahelp/mhelp replies more tightly to their ticket.
* Hardened PMs further against missing data.
* Support expanding Discord notifications for ahelp/mhelp.
Functionality changes:
* Informs the user when their ticket is reopened.
* Informs other mentors/admins when tickets are converted.
* Discord messages now get a "Ticket 3, " or similar prefix.
Not useful by itself, but will be with the following PR.
Code changes:
* When you create a ticket, you get the ticket object back.
* checkForTicket now allows you to fetch a ticket by number, and falls
back to searching for open tickets if the ticket isn't found.
* Corrected and simplified the logic for adding PMs to tickets.
* Responses are now added through the ticket system, not the tickets
directly.
* fucking wizards
* this too
* this
* i think thats it
* okay lets do this
* remove commented code
* gdn review
* welp
* fix runtime
* yes
* lewc review
* cult 1
* massive data refactor
* progress
* More crap
* IM SCARED IT COMPILES
* oops
* more fixes
* good comment
* hell yeah, team control
* lol
* blamo
* blam
* More stuff
* team refactor
* epic merge fail
* src not _src_
* more
* progress
* cult
* more stuff
* water
* goodbye __IMPLIED_TYPE__
* time to undraft
* FUCK FUCK FUCK
* okay this is better
* goodbye todos
* fix
* order of operations
* last fix? maybe
* yeah
* oops
* okay this should be ALL the fixes
* wow
* hell yeah
* wow
* fixes duplicate teams + adds more team safeties
* how the fuck did this happen
* admin objective improvements
* wah more bullshit
* guh
* fuuuuck
* fucking hell
* fixes
* CI
* undef
* hooooly crap
* yeah
* false by default
* fixes
* alright, there we go
* oops lmao
* lol, lmao even
* proper programming
* fix
* losin my mind
* oops
* yeah coloring
* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
