Commit Graph

20183 Commits

Author SHA1 Message Date
Novacat
80c6493979 Medicine Tweaks (#8157)
* Medicine Tweaks

Mostly, these are based off of notes I have been collecting over the past year or so, and I just got the motivation to actually act on those notes.

- Adminordrazine buffed again
- Myelamine buffed slightly, to reduce the chances of a standard clotting injector failing to treat IB
- Bicaridine Overdose slightly more effective at treating IB
- Inaprovaline metabolizes slower, to make it more useful in its role of patient stabilization
- Bone repair autoinjector changed to a 5u autoinjector with 5u of osteodaxon. Considering how osteodaxon works, 10u is overkill and leaves the patient feeling the side effects for longer than they should.
- Clone loss autoinjector added, patterned off the new bone repair autoinjector. 5u of Rezadone to deal with clone loss. Added to uplink as well as random unknown autoinjector spawners.

* Adjusted percentages and comments

* More Tweaks
2021-06-27 20:49:52 -09:00
Neerti
6782e64891 Adds optional area-based definition for outdoors-ness. (#8155) 2021-06-27 20:46:10 -09:00
Atermonera
f97d1b884b Merge pull request #8152 from Hatterhat/wasted-waste
waste doesnt exist
2021-06-21 18:16:17 -07:00
MarinaGryphon
b634eb243f Removes unused var in select_recipe (#8151)
Iiiiiiiiiiiiiiiiiiiii should have caught this.
2021-06-20 17:11:14 -09:00
MarinaGryphon
593246b595 Linter diagnostics + bans non-var relative pathing (#8150)
* Linter diagnostics + bans non-var relative pathing

* Enable DreamChecker Annotations

* make it executable

* update hashFiles

* oops

* tries to fix it... again

* trying again

* path

* repath

* fix perms

* fixes weird capitalisation issue
2021-06-20 13:14:29 -09:00
Verkister
379479a423 Fixes synthetic var not getting cleared on load (#8148)
Fixes synthetic var not getting cleared when loading character slots. Due to the char setup mannequin's nature of being a single same mob just getting its properties loaded from save slots, loading/making a synth character would permanently mess up the var for all non-synth chars on the roster and cause issues with synth-related settings because there was nothing in the code to clear the var.
2021-06-20 11:51:52 -09:00
MarinaGryphon
4b964bb2da Indescribable! - A Food Flavor Fixing Pass (#8144)
* Indescribable! - A Food Flavor Fixing Pass
*You keep using that word. I do not think it means what you think it means.*
  - Food will no longer erroneously have double the nutriment it's supposed to.
  - Fixed a lot of invalid food nutriment tastes and spruced up some old ones.
  - Made all foods use `nutriment_amt` where applicable
  - Made those not applicable to the former use `nutriment_desc` when manually adding nutriment
  - Moved setting bitesize out of Initialize, because... why

* fixes stragglers
2021-06-20 11:49:14 -09:00
Hatterhat
11b810c262 waste doesnt exist 2021-06-20 08:20:22 -05:00
MarinaGryphon
c224b192a9 Improves select_recipe. (#8141)
* select_recipe improvement

Removes the call to Timsort and the recipe comparator proc;
uses a handrolled implementation of
`argmax(items + reagents + fruit)` instead.
This reduces the memory footprint of `select_recipe`
as well as the amount of processing needed to select the optimal recipe.

* angelogchay
2021-06-18 14:06:27 -09:00
MarinaGryphon
1672a51eff Refactors utensils to use weakrefs (#8140)
* Refactors utensils

* fixes + removes extraneous var

* fixes another missed arg
2021-06-18 14:01:35 -09:00
Atermonera
68eadcc100 Merge pull request #8138 from Verkister/patch-72
fixes coughs screaming in the chat
2021-06-18 15:37:29 -07:00
MarinaGryphon
f9613f24bc Removes Global Iterators (#8146)
* Removes global iterators

* fix dme?

* removes useless var, TRUE/FALSE for state/equip_ready
2021-06-18 09:06:17 -09:00
MarinaGryphon
626130a0a1 makes it actually work 2021-06-16 10:42:04 -05:00
MarinaGryphon
3fa0e5cec2 linter + refactors advancedwho/staffwho
This simplifies some very old and bad code, and unifies the admin/non-admin printing to avoid duplicate code.
Also fixes a number of bugs caused by ambiguous parens and various linter errors.
2021-06-15 13:49:58 -05:00
Verkister
c61917fb90 fixes coughs screaming in the chat 2021-06-14 23:44:28 +03:00
Atermonera
688b9f4037 Merge pull request #8135 from Ketrai/letthemeatcakeagain
Makes the chaos cake cheaper.
2021-06-14 00:34:09 -07:00
Hatterhat
185d7a1c81 clamps decon_mod between 0 and 1 (#8133)
* when the decon_mod is above 1 :sus:

* when the operator is mixed
2021-06-13 22:33:03 -09:00
Atermonera
f65c46bb32 Merge pull request #8126 from MistakeNot4892/chirp
Added unit test to ensure emote key uniqueness.
2021-06-14 00:29:07 -07:00
Atermonera
dabfdc14db Merge pull request #8122 from VOREStation/Arokha/access
Make req_[one_]access lazy
2021-06-14 00:22:04 -07:00
Aronai Sieyes
1fd1d84deb Runechat (#8121)
* Message piece combiner returns a list

* Emote formatter returns a list

* Port Runechat

* Various onamonapoea

* Suggested changes, small opts

* Fix chat message on different size mobs

* Couple more runefixes

* Enable encoding chat emphasis in runechat

* Remove extra asterisks from rune audible messages

* Fix runedefines
2021-06-13 22:18:43 -09:00
Verkister
c9873ff9ed Fixes some unseen combat ai jank (#8116)
* Fixes some unseen combat ai jank

haha lack of exit consition go brrrr

* wow the conflict resolve editor is a piece of crap
2021-06-13 20:31:27 -09:00
Aronai Sieyes
bac077a8ea Portable mapping devices (#8097)
* Refactor holomap generation

* Portable mapping units

* Fix misnamed state

* Make it small

* Reduce power usage

I didn't know you could use fractional amounts!

* Apply suggested changes, fix indent

* Fix icon_state bug
2021-06-13 20:30:00 -09:00
Ketrai
aea07924ef Makes the cake cheaper. 2021-06-12 12:40:54 +02:00
MistakeNot4892
14c125f41d Added unit test to ensure emote key uniqueness. 2021-06-07 00:16:58 +10:00
MarinaGryphon
f95bcd462d Fixes infinite loop following cooking error (#8118)
* Fixes infinite loop following cooking error

```
		while (select_recipe(available_recipes,C) == recipe)
			var/list/TR = list()
			TR += recipe.make_food(C)
```
This would never consume reagents due to an early return, meaning it would never terminate from the while loop. Clearing the reagents is an easy fix for something that will hopefully never happen, and avoids locking the server up if it does.
Also makes such failures obvious.
TODO: Unit test for recipes without results.

* Fixes/tweaks

* fix CI
2021-06-06 00:36:12 -09:00
Novacat
51011c9c5d Add Secret ZLevels (#8111)
* Add Secret ZLevels

Port of https://github.com/VOREStation/VOREStation/pull/10430

* Update observer.dm
2021-06-06 00:22:27 -09:00
Atermonera
cd50b5a4e7 Merge pull request #8099 from MistakeNot4892/chirp
Tweaks to emote system to avoid memory overhead and make runtime validation easier.
2021-06-06 02:13:39 -07:00
dwinters99
a23eccdfb4 Adds more winter coats + moves existing winter coats to the same file (#8086)
* code changes

* icon changes

* armor redefine fix
2021-06-05 22:51:39 -09:00
Atermonera
80d4493e9a Merge pull request #8080 from Atermonera/dbcon_onebuttonfix
Adds admin verb to hopefully fix database connection failures
2021-06-06 00:42:26 -07:00
Aronai Sieyes
e2c32cae91 Make req_[one_]access lazy 2021-05-31 22:43:11 -04:00
MistakeNot4892
3267ae47b7 Tweaks to emote system to avoid memory overhead and make runtime validation easier. 2021-05-30 23:08:24 +10:00
Atermonera
7aa86700dd Merge pull request #8114 from VOREStation/Arokha/langsani
Fix language sani on relogins
2021-05-29 12:10:04 -07:00
Aronai Sieyes
26940c7e12 Various small fixes (#8112)
* Make nurse spiders forget target

* Tweak or break AI

* Fixes ice edges

* Allow better mapped-in marker beacons

* Allow mapped-in graffiti

* Add spaceship hull corners

* Improve hull corner color finding slightly
2021-05-29 10:08:39 -09:00
Novacat
305473a76a Makes deepspace levels slightly more robust (#8110)
* Makes deepspace levels slightly more robust

Port of https://github.com/VOREStation/VOREStation/pull/10408

This is supposed to fix oddities with the overmap system where occasionally deepspace sectors are not generated properly.

* Ports another Fix
2021-05-29 09:47:18 -09:00
Atermonera
9c401124c7 Merge pull request #8107 from Novacat/nova-accessory
Autoinjectors are Autoinjectors
2021-05-29 11:40:15 -07:00
Novacat
be7e5898c3 Voidsuit Balance Overhaul (#8106)
* Voidsuit Balance Overhaul

Overhauls the stats of voidsuits and tries to put them into niches. So far, I decided to go with a tier-based system.

Tier 1: Basic voidsuits available to the station and can be purchased from Cargo fairly cheaply (35 points).
Tier 1.5: These are slightly improved over Tier 1, but not as good as Tier 2. Currently, only the exploration/exploration medic voidsuits fit the bill.
Tier 2: These voidsuits are available to the station, but can only be purchased from Cargo at higher prices (60 points).
Tier 3: Mercenary voidsuits.

One of the key factors in this overhaul is that the slowdown on voidsuits was made granular. Instead of all voidsuits having a slowdown of 1 or 0, most voidsuits will have a slowdown of 0.5, while voidsuits that have really good protective attributes (such as security voidsuits) will move slower.

As well as this, most higher end voidsuits were given better breach threshhold and resilience values, because even the most heavily armored voidsuits were way too easy to pincushion for some reason.

On top of this, most voidsuits were given niches.

Engineering Voidsuit (Tier 1): Moderate radiation protection, Slightly better pressure/heat protection. Moves slow (Slowdown 1)
Hazmat Voidsuit (Tier 1): Perfect Rad Protection, but loses pressure/heat protection of engineering voidsuit. Also Slow.
Construction Voidsuit (Tier 1): Lighter than Engineering/Hazmat suits, but lacks either radiation protection or pressure/temp protection. Has a bit of extra armor, too. Mostly for field use.

Reinforced Engineering Voidsuit (Tier 2): Has good pressure/temp protections, perfect radiation protection, and moves pretty well.
Salvage Voidsuit (Tier 2): Same as above.

Mining (Tier 1): Fairly decent melee/bomb armor, and slightly harder to breach. Also mild radiation protection. Heavy.

Frontier Mining (Tier 2): Same as above, except lighter.

Medical (Tier 1): Normal weight, has some radiation protection, but otherwise unremarkable.
EMT (Tier 1): Exchanges radiation shielding for additional armor. Normal weight.
Biohazard (Tier 1): Highish melee protection and high atmos protection. Designed for EMTs in extremely hazardous enviornments.

Vay-med (Tier 2): Zero weight, still made of paper mache.

Security (Tier 1): Moderate protection all round, heavy weight.
Crowd Control (Tier 2): Focus on melee/bomb protection, 
Security EVA (Tier 2): Focus on Ballistics/Laser protection.

Atmospherics (Tier 1): Pretty much the same. Super High atmos/fire protection. Extremely slow. Extremely hard to breach.
Heavy Duty Atmospherics (Tier 2): Same as above, except lighter.

Exploration (Tier 1.5): Normal weight and armored, but skimps on ballistic armor. Not quite as armored as security voidsuits. Above average rad protection.

Field Medic (Tier 1.5): Loses some of the armor, but gains more rad protection and some heat/atmos protection.

Pilot (Tier 1): Some very light armor plating, minor rad protection, otherwise unremarkable.

Blood-red (Tier 3): Mostly the same, except extremely hard to breach now.

Soot-covered Voidsuit (Tier 3): Heavier than the blood-red, but also pressure and fireproof. Loses a very little bit of ballistic/melee protection for excellent laser protection.

* Accidentally copypasta'd a bit too much

* Adjusts Breach Values
2021-05-29 09:39:52 -09:00
ShadowLarkens
d1a081033d Initialize all vending products on server start & fix multiple food icons (#8102)
* Add icons for crablegs and crabmeat

* Build all vending machine inventories on startup (cursed)

* Fix cookie having no icon (convert everything to cookiesnack)

* Remove kabob with no actual definition

* Fix spicy burrito having no icon
2021-05-29 09:24:22 -09:00
Atermonera
2941049404 Merge pull request #8101 from Neerti/resist_button_fix
Fixes Resist Button
2021-05-29 11:22:17 -07:00
Aronai Sieyes
d4552a1113 Fix language sani on relogins 2021-05-27 20:36:32 -04:00
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Unknown
63248bfd25 Autoinjectors are Autoinjectors
Autoinjectors are not hyposprays stop calling them hyposprays.
2021-05-25 00:47:37 -04:00
Atermonera
9667dad5ba Merge pull request #8098 from Neerti/webhook_no_meta
Makes roundstart webhook not metagame.
2021-05-23 12:40:16 -07:00
Atermonera
7b67601705 Merge pull request #8075 from Atermonera/revert_copper_recipes
Reverts recipe changes from Industrial Expansion
2021-05-23 12:39:50 -07:00
Atermonera
e7c00701b1 Merge pull request #8074 from Atermonera/unmap_tin
Removes tin for ore generation
2021-05-23 12:39:37 -07:00
Atermonera
080b856593 Merge pull request #8095 from KillianKirilenko/kk-ports
Wall-mounted Geiger Counters
2021-05-23 12:39:09 -07:00
Atermonera
b36e45f328 Merge pull request #8094 from Hatterhat/pbore-buff
phoron bore stock parts now affect range, along with other bits
2021-05-23 12:38:30 -07:00
Neerti
4ea9b1d32a Fixes Resist Button 2021-05-21 13:26:21 -04:00
Atermonera
4ccc12224f Merge pull request #8089 from TheFurryFeline/TFF-Possibly_Fix_Cleanbots
[Bugfix] Maybe Fix Cleanbots
2021-05-20 20:51:22 -07:00
Aronai Sieyes
9cd4a89782 SSpersistence tweaks (#8087)
* Add some 'lossy' smartfridges and options

* Convert persistence to JSON

* Update map_datum to specify persistence levels
2021-05-20 18:50:36 -09:00
klaasjared
1c7d9c4cba Food 4 thought (#8083)
* Adds Everything

* Small error fix

* Edit fix

* Update code/modules/food/food/snacks.dm

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>

* Update code/modules/food/food/snacks.dm

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>

* Edit Fix

* Vending Machine Fix

* More fixes

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>
2021-05-20 18:11:19 -09:00