Commit Graph

494 Commits

Author SHA1 Message Date
atermonera
6efdf7f1fd Fixes paper missing write links 2022-02-19 15:35:30 -08:00
Atermonera
9de7693210 Fixes ABS reports getting sanitized by initialize() (#8391)
* Fixes ABS reports getting sanitized by initialize()

* Linting
2022-02-13 20:49:37 -08:00
atermonera
762fd8591a Merge branch 'master' into cynosure_map 2022-01-25 20:17:56 -08:00
Atermonera
4d8c43f106 What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)
* get_tool_quality has numerical meaning

* Basic tools set tool quality

* Toolspeed is replaced by tool quality checks

* Addresses assorted results from live test

* Extra cleanup
2022-01-16 15:52:55 -08:00
MistakeNot4892
618082f500 /atom New() => Initialize() [MDB IGNORE] (#8298)
* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
2022-01-04 18:47:57 -08:00
Atermonera
85fa906f61 Removes suicide_act() 2022-01-04 18:46:21 -08:00
MistakeNot4892
2f0a618d45 /atom New() => Initialize() [MDB IGNORE] (#8298)
* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
2021-11-14 00:09:14 -08:00
PrismaticGynoid
c42b94aa98 Fix paper 2021-10-17 15:20:15 -07:00
PrismaticGynoid
8a96fd173e Map fixes and tweaks part 7
Fixes for:
Basic NTnet cards being unable to reach telecomms from the station
Shuttles not showing location details when landed
Ship sensors printing blank papers
Certain shuttles not clearing weather visuals on landing
Ninja/merc elite shuttles being unable to dock
Mislabeled west solar SMES
Engine flow/pump sensors not connected to cooling system computer
Fixes a few non-cold tiles in telecomms compartment
Adds a few missing rails
Also, tweaks surgery rooms a bit
2021-10-07 20:35:31 -07:00
Atermonera
9c4eceae2b Removes suicide_act() 2021-09-19 11:43:34 -08:00
Atermonera
959511918c Replaces DEFAULT_WALL_MATERIAL with MAT_STEEL, where applicable (#8156)
* Replaces DEFAULT_WALL_MATERIAL with MAT_STEEL, where applicable

* floorbot compiles
2021-06-29 20:28:16 -07:00
MarinaGryphon
593246b595 Linter diagnostics + bans non-var relative pathing (#8150)
* Linter diagnostics + bans non-var relative pathing

* Enable DreamChecker Annotations

* make it executable

* update hashFiles

* oops

* tries to fix it... again

* trying again

* path

* repath

* fix perms

* fixes weird capitalisation issue
2021-06-20 13:14:29 -09:00
Aronai Sieyes
1fd1d84deb Runechat (#8121)
* Message piece combiner returns a list

* Emote formatter returns a list

* Port Runechat

* Various onamonapoea

* Suggested changes, small opts

* Fix chat message on different size mobs

* Couple more runefixes

* Enable encoding chat emphasis in runechat

* Remove extra asterisks from rune audible messages

* Fix runedefines
2021-06-13 22:18:43 -09:00
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Neerti
4deffc7186 Ports Nebula's Discord Webhook Integration (#8071)
* Ports Nebula's Discord Webhook Integration

* Forgot the example .json file.
2021-05-12 21:22:25 -09:00
MistakeNot4892
92c6bead11 Added recon and cargo platforms. 2021-03-13 13:24:28 +11:00
MistakeNot4892
b22a0568a3 Sideports a couple of init unit tests from Neb. (#7893)
* Sideports a couple of init unit tests from Neb.

* Trying to unfuck initialize logic.

* Removing del()s.

* Adjusting return values to Initialize().

* Moving some dangerous object logic from obj onto the two types that use it.

* Rolling back some init changes and commenting out initialized atom unit test.

* this comment formatting is a minor war crime

* Removed sleep() from signaler circuit Initialize().

* Additional Init fixes post-rebase.

* Uncomments subsystem test since that's passing.
2021-02-21 12:03:34 -09:00
Cerebulon
0815a554c6 Tweaks to pickup/equip sounds. (#7651) 2020-09-20 03:56:41 -07:00
ShadowLarkens
44f65e2602 TGUI Medical Conversion 2020-09-04 16:25:32 -07:00
Atermonera
6d4d5d6efd Merge pull request #7571 from listerla/nomoresitemanager
Colony Director -> Site Manager
2020-08-27 17:41:52 -07:00
listerla
d56974cb92 Colony Director -> Site Manager 2020-08-25 20:12:29 -04:00
Rykka
0c7a7fd2b8 Massive Ambience and Sound Overhaul + Addition, Squashed Commit Edition 2020-08-21 06:53:05 -04:00
Rykka
2ad7b475ec Persistence Patch
- Fixes Paper and font tags stacking across rounds, as shown in: ![](https://cdn.discordapp.com/attachments/187013248309002240/741937939382141000/164fdd3a37fb22f18dfa9b5c431ffc04.png)

- Fixes Persistence being always-on because of if("persistence_enabled") config.persistence_enabled = 1. As explained: 
> it's on by default, which means config.txt will be read and if it's not there it stays at 1. If it is there,it gets set to 1. There is no way to disable it

- Adds config options to enable/disable **Persistence for Maploaded objects**, as well as a verb to toggle such.
- Adds Persistence to config.

Currently IGNORE_MAPLOAD for Persistance is **Disabled.**
Maploaded objects/dirt/etc will be saved by persistence, preserving current behavior.

You will need to update config.txt with the following lines:
\## Uncomment this to DISABLE persistence 
\#PERSISTENCE_DISABLED 
 
\## Uncomment this to DISABLE maploaded trash/paper/etc from being saved by the persistence system. 
\#PERSISTENCE_IGNORE_MAPLOAD
2020-08-16 09:58:57 -04:00
Cerebulon
21aa0b962b code improvement. descy desc. also paperbins since the weird bracket code was from there. 2020-08-08 02:15:15 +01:00
Cerebulon
858b8ad497 Stickynote fixes 2020-07-31 03:54:39 +01:00
Cerebulon
03b7a0ea0d Persistent Trash/Dirt/Graffiti/Notices (#7337)
* Port Trash/Writing Persistence from World

* stuff beyond straight portin

* Fixed admin menu

* Config, cigbutts, blood exceptions, offices....

* mapped butts
2020-07-24 02:23:34 -07:00
Atermonera
6ab622a2b5 Merge pull request #7205 from VOREStation/Arokha/playsound
Alter playsound paradigm
2020-05-28 16:05:59 -07:00
Atermonera
d2d67d65ce Merge pull request #7153 from Rykka-Stormheart/shep-dev-photocopier-improvements
Photocopier improvements and NanoUI fixes!
2020-05-21 11:22:37 -07:00
Aronai Sieyes
ad75bb86bd Alter playsound paradigm 2020-05-19 11:06:28 -04:00
Atermonera
c4403dd738 Merge pull request #7095 from VOREStation/pol-penspam
Add cooldown to pen clicks
2020-05-17 20:57:57 -07:00
Rykka
8aa0bcb289 Photocopier improvements and NanoUI fixes!
Upstream port of https://github.com/VOREStation/VOREStation/pull/7825 with all the butts + butt-copying removed.
2020-05-13 07:11:55 -04:00
Cyantime
bfd93a9f3f Allows fax machine toner replacement 2020-05-11 17:00:25 -04:00
Aronai Sieyes
b7aae34335 Merge branch 'master' into pol-defaultparts 2020-05-05 22:51:02 -04:00
Aronai Sieyes
175a0d0384 Add cooldown to pen clicks
Fixes https://github.com/VOREStation/VOREStation/issues/7000
2020-05-04 23:07:26 -04:00
Aronai Sieyes
6c6644f86c Rewrite examine() to pass a list around (#7038) 2020-04-29 13:42:16 -07:00
Aronai Sieyes
b3e9960029 Move machines to use default_apply_parts() 2020-04-27 11:57:43 -04:00
listerla
646cc20f7f BUREAUCRACY TIME (#6851)
* BUREAUCRACY TIME

* Missing white folder

* Sounds are already in. Oops.

* Removes clone of paper_taped

* branch update, hopefully

* pen-x states

* Restores paper bins

* Revert "Restores paper bins"

This reverts commit 2dd29478a4.

* Reverts bins for real?
2020-04-05 19:15:40 -07:00
Leshana
938384cb1b In fact lets use the constants instead of bare numbers for use_power everywhere. 2020-03-21 19:41:01 -04:00
Mechoid
c7ba2a8e4b Antag Uplink Expansion (#6788)
* Adds Energy Daggerpens, Thieves gloves and Buzzer Ring.

* Updoot

* fixfix weakfire

* Extra Touches

* chlgongog

* Fix antag injector cases.
2020-03-16 21:21:41 -07:00
Atermonera
22e28f29fe Merge pull request #6804 from Cerebulon/bigsounds
Big Bastard Incidental Sound Port
2020-03-15 11:38:44 -07:00
Neerti
e8c51b9291 Makes R_EVENT go everywhere. 2020-03-11 23:17:24 -04:00
Cerebulon
52e6669bf9 Big Bastard Incidental Sound Port 2020-03-08 23:25:45 +00:00
lemon
c6e82de1cd Makes pen click when you click on them 2020-02-23 16:10:16 -05:00
Arokha Sieyes
5b15917d32 to_chat replacing stream operator 2020-02-17 13:14:08 -05:00
Atermonera
9684db1fe4 Merge pull request #6636 from SpaceManiac/patch/syntax
Fix various syntactic problems
2020-01-20 22:05:25 -08:00
Atermonera
5d5e361649 Merge pull request #6621 from Shadow-Quill/Desc-Adds
Moar descriptions for things
2020-01-20 19:48:57 -08:00
Tad Hardesty
d8a64c83dc Use compatible var statements 2020-01-18 23:01:36 -08:00
Tad Hardesty
6ed5f8de4b Replace () with null where appropriate 2020-01-18 23:01:36 -08:00
Shadow-Quill
1f77cba62f Alert Revert (#6631) 2020-01-17 00:48:27 -08:00
Shadow
36d10010dc Overtext Alert 2020-01-15 21:41:29 -06:00