Commit Graph

19139 Commits

Author SHA1 Message Date
ShadowLarkens
abfc89982d Fix HTML Injection bug in saycode 2020-04-24 16:17:51 -07:00
Atermonera
a1b8a3006d Merge pull request #7023 from Mechoid/FixAndTweakRoiling
Roiling Mold Blob Fix/Tweak
2020-04-22 12:53:41 -07:00
Atermonera
e575e9c7d5 Merge pull request #7009 from atlantiscze/2020_04_17_EPRFix
Fixes supermatter monitoring EPR indicator showing Undefined
2020-04-22 12:46:47 -07:00
Leshana
092f415375 Fix Sundry Runtime Errors XII (#7007)
* Fix Runtime in atoms_movable.dm,597: list index out of bounds

* Fix Runtime in floor_attackby.dm,118: Cannot execute 0.is crowbar().

* Fix null values being present in mob_list.

* Another fix for Runtime in update_icons.dm,254: Cannot execute null.GetUIState().

- This time lets just ensure dna is instantiated no matter who is calling dress_preview_mob().

* Fix Runtime in suit_storage_unit.dm,792: Cannot execute null.set machine().

- Also fixed other mixups of usr vs. user that I found in the same file.

* Fixes Runtime in find_spawning.dm,688: Cannot read null.origin_tech

- if this else if block is reached, new_item must not exist, so we obviously can't set origin_tech on it. Examination of the code seems to suggest the original author intended that for any "talking" items to have arcane and precursor tech; since src is now being made talking, src should get the tech.

* Fix talking artifacts downgrading arcane/precursor tech

- Bump up the values by one for talking artifact items instead of overwriting whatever the value was.
2020-04-22 12:44:35 -07:00
Mechoid
e83c013948 Roiling Mold blob projectiles fly in shorter arcs. Fix projectile targeting recursion. 2020-04-20 22:38:55 -07:00
ShadowLarkens
54a8a5823d Saycode Overhaul -- Multilingualism (#6956)
* Port ParadiseSS13/Paradise#2100 - Saycode refactor

* Removed unused old carbon slimes code

* Port ParadiseSS13/Paradise#5099 - Saycode part 2

* Ported ParadiseSS13/Paradise#7170's /datum/browser Check Known Languages

* Port ParadiseSS13/Paradise#9240 - Get rid of alt_name in favor of GetAltName()

* Port ParadiseSS13/Paradise#10330 - You can now use multiple languages in one message

* Addressed Atermonera's review.

Translators now print the full message if they find any languages within the
message that the user doesn't understand, minus languages it cannot translate.

Additionally, the combine_message proc has been significantly simplified
by eliminating an ugly tree structure with the help of a little helper
proc.

The removal of the extra span inside each piece doesn't seem to have
visually changed the messages in any other way than changing where the
wordwrap happens, strangely enough. Must be something in IE's code being
picky about invisible elements. On the bright side, it splits *later*
than it did before, thus reducing the lines a message will take up by a
tiny amount.

Also, a bunch of things now have the 'filter_say' class from
PolarisSS13/Polaris#6998. Since span classes with no definition are
totally valid and just don't do anything, this PR does **not** depend on
that PR being merged first.

* Always gotta be one
2020-04-20 01:11:53 -07:00
Atermonera
1ed5556b8f Adds empty filter classes to send messages to particular vchat filters. (#6998)
* Adds empty filter classes to send messages to particular vchat filters.
Adds combat log (playerside X hit Y) filter
Adds admin log, attack log, and debug log filters (Admin side)
Moves many unfiltered admin verb outputs to admin log filter

* unmatched tags
2020-04-20 00:28:16 -07:00
Atermonera
6a15586a74 Replaces toy waterflower with spraybottle waterflower (#6997) 2020-04-20 00:24:53 -07:00
Atermonera
0b03209c66 Merge pull request #6996 from VOREStation/vplk-ssopenspace
[PORT] Refactor the Open Space controller into MC Subsystem
2020-04-19 14:36:22 -07:00
Atermonera
a92650b07d Merge pull request #6991 from VOREStation/pol-jobsplit
Allow 'offmap spawn' jobs to be isolated from station employees
2020-04-19 14:23:49 -07:00
Killian
58ac25157b Security Voidsuit Overhaul Redux (#6985)
* security voidsuit overhaul redux

* svo2 - small desc update

* update inhands for secEVA suits
2020-04-19 13:20:39 -07:00
Atlantiscze
56e28ec2aa Fixes supermatter monitoring EPR indicator showing Undefined
- This mirrors original sources from Bay. Nano file was apparently moved from there, but code file was not.
- As for intent of this function (i coded it originally on Bay), EPR can be considered "Amount of canisters worth of gas in the core chamber", hence the weird 23.1 constant. Unlike pressure reading, this does not change with temperature, so it can be used to accurately monitor actual amount of gas in the chamber without having to take temperature in effect.
- I know the constant is kind of shady. It could possibly be recalculated using atmos constants, but i suck at math too much to do that. If anyone who knows atmos math can find a better alternative, i will gladly toss it in instead.
2020-04-17 06:06:06 +02:00
Leshana
f8755f2de5 Fix openspace redering of under-objects that have no main icon (only over/underlays)
In particular stops manifolds from getting the openspace "map" icon state as its main icon instead of null.
2020-04-14 09:40:19 -04:00
Leshana
5dbf08b462 Refactor the Open Space controller into MC Subsystem
- Basically just refactor doWork() into fire() with the capablity to return in the middle with MC_TICK_CHECK.
- Move some vars around to be more organized.
- Only functional change is that when a turf is queued twice in one cycle, the second queue moves it to the end of the list instead of it being in the queue twice
2020-04-14 09:38:23 -04:00
Leshana
2d37c09d12 Commit move of open_space_controller.dm to subsystems folder to track history through rename. 2020-04-14 09:37:58 -04:00
Atermonera
742d4002f8 Merge pull request #6987 from VOREStation/vplk-adminload-atmos
[PORT] Fix offline vent pumps and scrubbers on loaded maps.
2020-04-12 23:21:24 -07:00
Atermonera
28bede5936 Merge pull request #6977 from VOREStation/vplk-remove-ss-references
Remove non-global references to SSgameMaster and SSevent_ticker
2020-04-12 23:14:20 -07:00
Atermonera
974919151b Merge pull request #6967 from VOREStation/pol-pipes
Add 2 new pipe types
2020-04-12 23:00:41 -07:00
Atermonera
32a573f5cc Merge pull request #6878 from Mechoid/ATaleofBlobsandMen
A Tale of Blobs and Man
2020-04-12 22:34:33 -07:00
Atermonera
ca6cf9e938 Adds pref to toggle vchat without 60s wait for linux users (#6980) 2020-04-11 21:50:51 -07:00
Atermonera
1cae548d08 Merge pull request #6966 from VOREStation/vplk-bye-area-new
Refactor away area/New()
2020-04-11 21:40:51 -07:00
Aronai Sieyes
cfd052a977 Allow 'offmap spawn' jobs to be isolated from station employees 2020-04-11 13:38:13 -04:00
Atermonera
8fe72d24f9 Merge pull request #6983 from Novacat/nova-alerts
Fixes deadringer decloaking
2020-04-10 23:56:54 -07:00
Atermonera
527370ca4f Merge pull request #6982 from VOREStation/vplk-fix-vv-lists
Fix VV on lists
2020-04-10 23:56:38 -07:00
Leshana
bfa14f2c25 Cause the maploader to log an error if dmm file contains an undefined type.
This will greatly ease debugging as otherwise the only error you might get is Runtime in reader.dm,370: list index out of bounds, and even then only if the turf has no objects.
2020-04-10 19:49:43 -04:00
atermonera
7d959c5602 Adheres to byond's ridiculous list indexing convention in carp_migration.dm, line 44 2020-04-10 16:19:41 -07:00
atermonera
e8c70a9f63 PRIORITY CRITICAL: Fix infinite loop in carp_migration.dm, line 44 2020-04-10 16:13:43 -07:00
Mechoid
1520c2d190 S l e e p, and split to Ater's request. 2020-04-10 15:54:50 -07:00
Leshana
520d5de7bd Suspend SSmachines subsystem while we are initializing map templates.
- Adds the capability to "suspend" a subsystem while we're loading something.
2020-04-10 17:54:01 -04:00
Leshana
890fdcb0c2 all_areas fixup 2020-04-10 14:58:59 -04:00
Leshana
2c13bee848 Replace global all_areas list with world.
It ends up having similar performance, so might as well not bother with all_areas.
2020-04-10 14:58:59 -04:00
Mechoid
001d5b091f Merge branch 'master' of https://github.com/PolarisSS13/Polaris into ATaleofBlobsandMen
# FixConflicts:
#	polaris.dme
2020-04-09 22:55:42 -07:00
Atermonera
e5a68312af Ingested ethylredox removes ingested alcohol (#6973) 2020-04-09 22:21:47 -07:00
Atermonera
94178864cf Adds preference to output description_info with examine text (#6969)
* Adds preference to output description_info with examine text

* includes the defines file
2020-04-09 22:20:45 -07:00
Atermonera
26f52042d9 Splits circuit clothes IC interaction to ctrl-shift-click (#6968) 2020-04-09 22:19:33 -07:00
Aronai Sieyes
6055fdcd22 Fix timer oversight with regards to grenades 2020-04-09 23:30:10 -04:00
Aronai Sieyes
91f457eed1 Merge branch 'master' into pol-assemblies 2020-04-09 23:29:31 -04:00
Atermonera
e399e21434 Merge pull request #6950 from VOREStation/pol-maphelp
Improves space edge-of-map behavior and add mapping tools
2020-04-08 23:09:56 -07:00
Unknown
83d1e845bb Fixes deadringer decloaking 2020-04-08 15:10:13 -04:00
Aronai Sieyes
765e6cb1a0 Looking glass holodeck (#6958)
* Fix mines qdel

* Looking Glass Holodecks

* Fix console html tag

* DME update
2020-04-08 11:57:15 -07:00
Atermonera
58479507c3 Merge pull request #6916 from VOREStation/vplk-port-overmap-events
[PORT] Overmap Events (and updates)
2020-04-06 23:07:08 -07:00
Leshana
d7e4c0d90d Cleanup code and comments.
- Refactor ion_storm to actually operate using start()/end()/announce()
- Remove unused variable and enhance comments.
2020-04-07 01:38:40 -04:00
Novacat
94c3f9dbef Port: Merge pull request #6980 from VOREStation/aro-dust
Fix dust zlevel choice
2020-04-07 01:08:20 -04:00
Atermonera
6e1282a802 Merge pull request #6951 from VOREStation/pol-accountdb
Account DB console icon fix
2020-04-06 21:40:51 -07:00
Neerti
8a03168d95 Stasis QoL (#6923) 2020-04-06 21:38:22 -07:00
Leshana
5c12bd5dea Fix links and options on VV list page.
- Fixes the dropdown options of the /list VV page to actually do anything.
- Fixes the E,C,- links next to each list entry on the /list VV page to actually do anything.
- Fixes the Refresh link on the /list VV page to actually refresh.
2020-04-07 00:32:13 -04:00
Leshana
85ebeeef1f Fix VV editing numeric entries in lists
- Previously attempting to edit a list entry with a Number value would runtime.  Unless you were in a particular set of circumstances, which could lead to even weirder effects like unexpected associatead values being set.
- Also cleaned up the experience by removing options from popup prompts that would inevitably lead to runtime errors.
2020-04-07 00:31:05 -04:00
Aronai Sieyes
12d4530de8 Port: Merge pull request 7018 from VOREStation/aro-overmapwrap
Move overmap wrapping onto edge turfs
2020-04-06 17:54:33 -04:00
Aronai Sieyes
255a2fdf03 Port: Merge pull request 7010 from VOREStation/aro-lessdoom
Fix the doom asteroid waves
2020-04-06 17:54:33 -04:00
Aronai Sieyes
e8bdadd0ab Port: Merge pull request 7007 from VOREStation/aro-teleshuttle
Adds an overmap shuttle to medical
2020-04-06 17:54:33 -04:00