using a shared renderer image was breaking things that used their own
images, if they set properties on those images - this resolves that by
removing the shared renderer and instead using a fresh image when a
cache entry is created, or by simply using the raw appearance of
uncacheable things like atoms and images without passing them through
another image for no real reason anyway.
NB. In some cases we go from a more complex image() to a single icon_state string and I assume this works for every case but do not care to check because of the sheer scale of extra fiddly effort. Buyer beware, not my code.
* Decl music + ported music
* Bugfixes and not
* unit test
* debug shit + some fixes
* More Changes
* Removes some unused/extra songs in case it was a file size issue
* Nuke crash-prone songs
* Add cynosure defines
* It Just Works Now + Finished Headphone code/sprites
* requested tweaks/debug removal
* recheck dme
* Adds antag subsystem to handle antag datum init. Moves antag datum defines to a module. Antagging new_players via traitor panel moves their created bodies to appropriate spawnpoints.
* Un-oopsies some unnecessary init order changes
* Adds linter defines to repo.
* Uncomments linter defines already in the code.
* Resolves unreachable code linter errors.
* Nukes decade+ old syndie specops code except for computer since that's mapped in?????
* Resolves procs has no parent linter error.
* Proc signature fixes
* Bad comments
* "In" danger
* Type safety
* Implied nested list abuse
* Top level ..() usage
* Sleepy coder typos
* Invalid kwargs calls
* Pointless returns
* Linter hacks (see full message)
Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.
Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.
* WHATEVER THIS IS
* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars
* Fix list decoration syntax - Its a list, not list of lists
- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax. Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`
* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.
* Fixes unwrapped negated object in list linter error.
* Resolves colon-like list accessing linter error.
* Turns linter on in linter config.
* Fixes closet indentation properly and cleans up suit storage unit switch.
Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
