cyberpresidentvanellope/VOREStation
1
0
Fork 0
mirror of https://github.com/VOREStation/VOREStation.git synced 2026-08-25 21:19:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15253 from ItsSelis/sql-injection-fix

Browse Source 
Bugfix for the Bugfix
This commit is contained in:
Casey
2023-08-13 19:18:23 -04:00
committed by GitHub
parent c372f5354f 4b6aa323e9
commit da845841f5
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/IsBanned.dm
+5 -1
View File
@@ -50,7 +50,11 @@
if(computer_id)
failedcid = 0
cidquery = " OR computerid = '[sanitizeSQL(computer_id)]' "
if(isnum(text2num(computer_id)))
cidquery = " OR computerid = '[computer_id]' "
else
log_misc("Key [ckeytext] cid not checked. Non-Numeric: [computer_id]")
failedcid = 1
var/DBQuery/query = dbcon.NewQuery("SELECT ckey, ip, computerid, a_ckey, reason, expiration_time, duration, bantime, bantype FROM erro_ban WHERE (ckey = '[ckeytext]' [ipquery] [cidquery]) AND (bantype = 'PERMABAN' OR (bantype = 'TEMPBAN' AND expiration_time > Now())) AND isnull(unbanned)")
code/modules/vchat/vchat_client.dm
+1 -1
View File
@@ -266,7 +266,7 @@ GLOBAL_DATUM_INIT(iconCache, /savefile, new("data/iconCache.sav")) //Cache of ic
if(cid && !isnum(cid) && !(cid == ""))
log_and_message_admins("[key_name(owner)] - bancheck with invalid cid! ([cid])")
if(ip && !findtext(ip, new/regex("^((25[0-5]|(2[0-4]|1\\d|[1-9]|)\\d)\\.?\\b){4}$")) && !(ip == ""))
if(ip && !findtext(ip, new/regex(@"^((25[0-5]|(2[0-4]|1\d|[1-9]|)\d)\.?\b){4}$")) && !(ip == ""))
log_and_message_admins("[key_name(owner)] - bancheck with invalid ip! ([ip])")
var/list/ban = world.IsBanned(key = ckey, address = ip, computer_id = cid)