96 Commits

Author SHA1 Message Date
Will
b16ee4683c Handles duped reagent names more strictly (#17906)
Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>
2025-06-27 17:56:57 +02:00
Will
3cfc2c6e76 Bingle them viruses (#17881)
* viruspage creation

* virus unit testing

* oop

* tweaks

* as check

* use glob list

* new data

* scan data proper

* counting

* constructing lists

* fix

* wikicomp side

* basictgui

* list fix

* tweaks

* virus tgui page

* .

* .

* .

* unused

* .

* .

* stack item it

* genes

* show gene conflicts

* no static tags

* fixed conflict gene report

* tgui foundation for genes

* handle gene conflicts once

* .bingle page

* .

* .

* import order fix

* traits names must be unique

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-06-19 15:46:02 +02:00
Will
969c1caa39 Signal Handler Preperation (#17681)
* FIrst pass

* signal handler only on base proc

* missing signal_handlers

* windoor to timers

* Testing a really dumb fix
2025-05-17 06:44:56 -07:00
Will
05e75a2614 Modular Code Compatible Posters (#17703)
* poster modularity

* access control, documentation

* properly exclude lewd

* unittest too

* fix

* poster test fix
2025-05-15 13:20:20 -07:00
eghughguhhhhhh
e639def0aa Recycler hotfix 1 (#17620)
* whoopsies

* Makes PAIs nice children by making them never call their parents.

* FUCK

* Move unit tests to unit test folder
2025-04-28 00:51:04 +02:00
SatinIsle
152118c1d4 adds missing SIGNAL_HANDLERs (#17585)
* adds missing SIGNAL_HANDLERs

Added missing SIGNAL_HANDLER lines to many RegisterSignal() proc refs.

* Oopsies
2025-04-26 21:50:50 +02:00
Will
af7eee3fbc Ported Autohisses and Autohiss Unit Test (#17575)
* autohiss exclusion test

* show how many hisses

* weird list

* fixed check

* paths are not datums lol

* consolidate check

* use trait global

* another check

* nullchecking

* more type stuff

* type needed

* restored a missing autohiss, and fixed exclusions

* more missing exclusions

* more missing

* yingish from outpost

* don't exclude self
2025-04-25 21:42:05 +02:00
Asher 49
abe23fe918 fixes code that makes resting borgs show missing sprite error (#17578)
* borg missing sprite error fix(sorry)

* fix

* forgot to push these

* Update robot_sprites.dm

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-04-23 23:46:44 +02:00
Selis
21dcf0555b Conversion many Globals to Managed Globals (Part 1) (#17121)
* Conversion of some Globals to Managed Globals

* Fix

* for later

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-04-17 14:16:53 -04:00
Cameron Lennox
c42610c5ae Have you bingled that (#17407)
* Initial wiki system

* wiki organization and spoilers

* hide belly chems

* move ads to tgui

* add search

* .

* load screen

* error screen

* 8

* center

* .

* .

* make this more realistic

* tgui errro col

* move search to top

* .

* non NT theme

* logo to common

* base custom theme

* .

* wip refactor

* almost halfway

* reworked wiki data

* easy fix

* get data fix

* Material Page in tgui

* catch null supply points

* .

* forward crash

* reset pages

* .

* canvas prep

* fix icon stacking

* .

* colored outlined images

* fix sm datum

* fix material names

* subType prep

* only on crash

* fix null crash

* .

* fix solgov

* clean hiding

* .

* implement catalog page

* .

* particle smasher page

* I'm lazy

* unfuck some sins

* ore page

* botany page

* allergen list

* allergen returns null too

* slime injection var

* slime core data

* fixed warning

* wip

* proper data list for chems

* pass is_slime as null

* chems

* split that

* .

* .

* .

* .

* donation for bingle, some cleanup

* return types

* partially colord icons for chemistry

* .

* more sillies

* donation page

* thaler

* needs some variation

* .

* this will crash until implemented

* handle it

* fix that

* dismiss donation banner button

* .

* fix that

* donating procs

* donation stuff for comp

* -

* drink glass for drinks

* illegal iconstate pass

* fixes

* .

* nuke drink fix

* .

* .

* .

* Drink reagent fix

* more cleanup

* adjust

* .

* simple food

* .

* food list

* sending nulls, removed flavor from recipes

* .

* .

* get_donation_current added

* .

* missing key

* .

* duped recipes fixed

* .

* .

* wiki food reagent recipes

* double list add

* properly forbid remaining bad reagent

* hide this too

* stacky

* enable eslint const

* fix typing

* update that

* use proper donation proc

* printing fixes

* grinding

* .

* beaker fill volume

* plant ore and mat grinding results

* duped recipes fixed, unit test tweak

* yes this is terrible

* .

* .

* .

* chem analyzer tgui mode, some subsystem changes to support it

* redoce

* .

* ,

* .

* small fixes, missing reagent volume

* push

* sort

* catalog entries unlocked by explo

* new chem stuff

* .

* fix byond code

* fix scroll tracking

* comment

* alphabetical

* also this

* .

* fallback icon

* .

* ...

* rel path

* that too

* to defines

* organ to define

* .

* .

* .

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-03-28 19:00:50 +01:00
Kashargul
2556102719 only tab indentation (#17408)
* only tab indentation

* .
2025-03-23 15:28:15 +01:00
Cameron Lennox
e31df5e920 Recipie conflict unit test + Chemanalyzer PRO (#17270)
* conflict test

* crash fix

* test bad chem

* tweaked

* is this even working

* what?

* is this broken?

* test fix

* force reactions

* Another attempt

* oop

* another

* oop

* actual check

* inverted

* distilling pain

* backward

* attempting again

* slime rules

* wrong path

* fix for slime

* no test chem

* oops lol

* inhibitor test

* var

* another fix

* what is going on

* oh that's how that works

* this?

* again...

* better inhibitors

* fixed order

* clear beaker

* lets try this, plus cleanup

* comments

* another test

* fix

* stale ref?

* more logs

* round and round

* keycheck

* reverse lookup lists

* chemanalyzer update

* addiction code commented out

* span cleanup, downstream code commented out

* debug cleanup

* reaction fixing

* reduced scale again

* another wrapper

* more info in test

* document reagents

* scaling dynamic

* check single inhibitors too

* oop

* using unittest data signal

* fixes

* this is still needed

* broken reactions, and bad id reactions

* oops

* this too actually

* single chems are illegal

* validity on lists

* oops again

* invalid key check, fixed invalid reactions

* test remove

* pretty chat messages

* spanred

* slimecore results

* grinding unit test and grinding results in chem analyzer

* ore check

* fluid pump info

* correct id

* enforce id case

* compliance

* it makes no sense that this machine gives no feedback that you need to reanchor it after construction

* lets not unseal either

* display chems produced

* notify players of belly liquids, as they do not react with anything

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-03-21 04:36:06 -04:00
Kashargul
6fafd033e3 adds animation flicks to robots (#17381) 2025-03-20 14:49:50 -04:00
Cameron Lennox
2f71aeb924 Robot offset unittest (#17346)
* robot offset added to unit test

* another test and fix

* forbid no icons

* another fix

* fixed math

* wrong var

* legal offset

* Fixes offsets

* more

* gwah

* whoop

* y

* m

* expand

* earth to raptor, wake up

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-03-15 17:23:15 +01:00
Cameron Lennox
ce8b46fb92 Adds Gooborgs & Toggleable Stomach Glowing for Borgs (#17280)
* Gooborgs!

add: Adds gooborgs! Sprites from Toriate
code: Robotic eswords and batons now count as robotic weapons and trigger appropriate sprites.

* shocker

* cargofix

* some more

* sendit

* rest sprites

* mmoree

* Glowy tummies

Will make all the catborg sprites scream, but let's see what the UT says

* FIXES MORE SPRITES AAAAAAAAAAAAAAAA

* License

* fixed sprites

* better handling

* rewrite

* bonus damage

* Fixes stunbaton

* status check

* Makes BCS remove the charge properly

* charge

* subsystem
2025-03-14 15:19:20 +01:00
Kashargul
075edb616d up port map tests (#17222)
* up port map tests

* missed lines

* .
2025-03-13 01:16:33 +01:00
Kashargul
1def015bad end of file Fix (#17308)
* end of file Fix

* fix those lints too
2025-03-10 16:15:35 -04:00
Kashargul
7fb1f9594f fix robot linting [IDB IGNORE] (#17260)
* fix robot linting

* Fixes the broken sprites

* Combat Medic Catborg

Original sprites by Toriate. Modifications curtesy of @tacoguy7765093

Including in this PR since it's going to be merged but might as well be included in this one w/ the fixed borg linter to see what it catches

* more sprite fixes

---------

Co-authored-by: C.L. <killer65311@gmail.com>
2025-03-04 02:58:03 +01:00
Cameron Lennox
6a157d8614 Rig glovefix and Clothing protection fix (#17118)
* Fixes RIG gear to not drop your equipped items

Fixes the rig gear to not drop your equipped gear after undeployment

* better fix

* Fixes suits and RIGS

- Makes rigsuits no longer eat your gloves
- Allows you to properly wear a ring under a rigsuit
- Gets rid of a LOT of duplicate var  = XYZ in places
- Makes it so clothing actually properly provide protection to the areas they're covering. (This doesn't change anything unless their actual min_cold_protection or max_heat_protection is adjusted!)
- Adds a define for CHEST which is just UPPER_TORSO|LOWER_TORSO to make it clear it's protecting your WHOLE chest at a glance.
- Gives some things like knee-high and thigh-high boots proper leg protection

* Clothing unit test

* fixes

* oops

* hoods are snowflakes

* hood fix

* path fix

* no nullspace turf

* nullcheck

* don't test devwarning cloths

* ignore this too

* more exclusions

* more exclusions, disabled species test

* Changes So Far

* holding/wearing icons for clothing

* fixed

* more fixes

* lets try this again

* go

* tesh cloak

* some more

* devwarning

* the cursed one

* oops

* fixed species scan

* Update clothing.dm

* restrict this down a bit more, we don't want unit-test to choke

* no more CI killer

* suit defined name twice

* suit

* some more exclusions

* etc

* gwah

* gwah

* clarifying exclusions

* yet more exclusions

* another set of exclusions

* ranger

* compile

* more bitflag

* yet more exclusions

* more

* more missing

* Update sifguard.dm

comment (also to wake up travis)

* more exclusions

* sifguard

* more exclusions

* more

* send help, yes more exclusions

* lost to time

* skrell stuff

* offear is special

* fixes more and unbreaks protean rigs

* The big one

* wrong ifdef

* more

* boots

* Update accessory.dm

* small object fix

* lets be more careful

* Does this fix the signal

* is it the signal?

* FIXES THE REST OF THEM

* wah

* disable test

* the last one

* fix signal check

* fixes

* ignore storage

* teshari blacklist

* tesh

* God speed

* fixed progression removed lizard

* fixes some i guess but what's the point

* disable indepth check

* START ROBOT SPRITE VALIDITY

* Revert "START ROBOT SPRITE VALIDITY"

This reverts commit c9bfb7e9ce.

* consistency with another test

* yuh uh

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-03-01 11:56:30 -05:00
Cameron Lennox
e3409de8b9 Robot Sprite Unit test, Robot Upports, Robot Sprite Fixes [MDB IGNORE] [IDB IGNORE] (#17139)
* Robot sprite validity

* key instead of index

* kash additions

* missing tag

* fail out on no name

* fixes

* let the dance commence

* rest style

* Fixes some of the sprites

Merging so I can see what else it wants

* check belly stages too not just max

* this too

* fixes

* fixes

* Adds variant catborgs

- Adds variant carborgs. These are the older models. Upport from CS.

NEEDS REMOVAL:
DMI FILE: modular_chomp/icons/mob/catborg/catborg.dmi

SPECIFIC REMOVAL IN FILES:
modular_chomp/code/modules/mob/living/silicon/robot/sprites/mining.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/medical.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/janitor.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/science.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/security.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/civilian.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/engineering.dm

* DULLAHAN BORGS

Up-ported dullahan borgs.
Makes it so proteans can choose dullahans as their sprite blob sprite.
NOTE: DULLAHAN-NINJA (V3) DOES NOT HAVE A SIT SPRITE. IT'S ALSO UNUSED. SYNDI SPRITE WAS PUT TO ACT AS A STANDIN

TO BE REMOVED DOWNSTREAM:
modular_chomp/icons/mob/dullahanborg

modular_chomp/code/modules/mob/living/silicon/robot/sprites/civilian.dm (dullahan/service & dullahan/servicealt)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/engineering.dm
(dullahan/engineerv1 & dullahan/envingeerv2)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/janitor.dm
(dullahan/janitor & dullahan/janitoralt)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/medical.dm
(dullahan/crisis & dullahan/crisisalt)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/mining.dm
(dullahan, dullahan/miner, dullahan/mineralt, dullahancarg, dullahancarg/cargo, dullahancarg/cargoalt

modular_chomp/code/modules/mob/living/silicon/robot/sprites/syndicate.dm
(Delete the entire file)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/security.dm
(security/dullahan dullahan/sec dullahan/secalt)

* Update science.dm

* fixes dead overlays

* Update mining.dm

* more borgs

DOWNSTREAM REMOVAL:
code/modules/mob/living/silicon/robot/robot_modules/Widerobot_Clown_ch.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/clown.dm
code/modules/mob/living/silicon/robot/robot_modules/Widerobot_Standard_ch.dm (This file was unticked. It was placed in standard.dm)
modular_chomp/code/modules/mob/living/silicon/robot/sprites/combat.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/medical.dm
code/modules/mob/living/silicon/robot/subtypes/boozeborg_ch.dm (Unticked in the DMI. Moved to subtypes/boozeborg.dm)
modular_chomp/code/modules/mob/living/silicon/robot/dogborg/dog_sleeper.dm
modular_chomp/icons/mob/raptorborg/raptor.dmi - Unused
All the worm borg overrides

Downstream as well:
/obj/item/robot_tongue/examine(user) in code\modules\mob\living\silicon\robot\dogborg\dog_modules_vr.dm needs to be enabled.

* whew

* gwah

* SAVE

* fixes

* fixes sprites more

* Adds Outpost Borgs

Stoat and Possum.
Other versions of possum WIP

* no wreck overlay

* gwah

* decals to list

* fixing

* .

* fixes there 3 being 3

* fix decal resting

* sleeper fix

* fix struggle resting

* puts surgery module in its place

* no CE

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-02-27 13:00:02 -05:00
Cameron Lennox
b949f63d27 Reagent unit testing (#17080)
* initial port

* first ignore batch

* second exclusions

* Tequila fix

* Fixes Changeling Sting

* Virgin Mojito fix

* fixes Love Potion

* Rest of love potion

* Various fixes

* tweaks to unit test

* fix for decl

* get decl properly

* fixie

* put the box back

* tequila fix

* fixes tequila

* check dispenser carts too

* name not id

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>
2025-02-13 23:12:48 +01:00
Cameron Lennox
cdafe425a5 Adds Trait Genetics (#16921)
* Adds Trait Genetics from Outpost21

Adds trait genetics from Outpost 21
- Tried to update each file it touched to be equivalent to their Chomp specific variants in order to maintain functionality and make sure no oddities would happen due to code differences. (Some things like the eardeaf loop were left there but commented out)

* Morph trait

* Fixes a server crashing bug with flip

aa

* flip

* Makes morph superpower better

- Makes it use the appearance_changer instead of 1000 different  procs

- Makes cocoon weaver able to change eye and skin color.

I did NOT select you. BAD

* begone

* fix dna modifier

* Fixes massive memory leak

* Brain Runtime Fix

* There was no reason for this to be a spawn(0)

And no I didn't spawn with no blood - https://i.imgur.com/vPizqCD.png

* revert

revert the dna changes there

* Deconf

* gets rid of unused proc vars that did nothing

* expects enough free slots

* glob

* fixed and added two other tests

* another few tests

* this is a list

* fixed bad injector

* lets wrap these for sanity

* better feedback

* wrong name

* don't allow multiple occupants into the dna pod

* future traits will have activation levels instead of binary on/off

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-02-11 02:01:27 -05:00
Cameron Lennox
e5befdf43e More cosmetic strictness (#17116)
* prevent illegal BPs

* illegal test

* Revert "illegal test"

This reverts commit 12df56498f.

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-02-10 17:51:00 -05:00
Cameron Lennox
eeefd4ef3f Fixes the body designer [WIP] (#17062)
* designer

* finished off remaining body designer stuff, name etc

* merged _vr file, added note to use this

* harddel fix

* this one too

* unifies subtabs, adds search and improves layout

* fixes a longstanding issue with marking color appearance changer

It was feeding a /list (The object) to the color picker and the color picker just rolled with it and said 'sure'.

Now with actual sanity TGUI color picker freaks out and goes 'wtf'

This makes it actually feed a color input into the color picker.

* quick push

* adds hair grad to body designer

* push

* color works again

* hair gradient for body designer

* deconf

* Gets rid of duplicate datum

* no test tonight

* spotty fat

* Condenses hair_extras. Fixes a few missing.

Also adds a new cosmetics_tests unit test.

* fixes the rest of the sprites

* lets try this test

* why did that test compile

* another test ENHANCEMENT(fix)

* More aggressive unittest

* fixie

* invisible tail has snowflake handling

* fix for invis check

* oops

* validate existence of icon in unit test

* unittest checks marking and hair icons properly

* fixing bad unit testing again

* fixed marking icon check

* get rid of unused datum, markings show

* fixes things

* you too

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-02-07 20:57:25 -05:00
Cameron Lennox
2e4f1ce642 (Partially) Fixes Out Of Memory crashes (#17043)
* Fixes massive memory leak

* Brain Runtime Fix

* There was no reason for this to be a spawn(0)

And no I didn't spawn with no blood - https://i.imgur.com/vPizqCD.png

* Fixes deadringer not properly deathgasping the right entity

* Wounds properly get delted off destroyed limbs

* Update vorestation.dme

* Runtime fix & DNA lock fix

* More qdels

* qdel

* comment out
2025-02-05 14:02:17 -05:00
Kashargul
da3710df9b adds another unit test, bumps nvmrc (#17010) 2025-02-01 01:19:01 +01:00
ShadowLarkens
ec18de7d79 Replace all air_master nonsense with SSair 2024-10-23 05:47:09 -07:00
Guti
409aaba802 Remove 2024-09-09 02:36:53 +02:00
Drathek
7c8bb85de3 Whitespace Standardization [MDB IGNORE] (#15748)
* Update settings

* Whitespace changes

* Comment out merger hooks in gitattributes

Corrupt maps would have to be resolved in repo before hooks could be updated

* Revert "Whitespace changes"

This reverts commit afbdd1d844.

* Whitespace again minus example

* Gitignore example changelog

* Restore changelog merge setting

* Keep older dmi hook attribute until hooks can be updated

* update vscode settings too

* Renormalize remaining

* Revert "Gitignore example changelog"

This reverts commit de22ad375d.

* Attempt to normalize example.yml (and another file I guess)

* Try again
2024-02-20 11:28:51 +01:00
Selis
d99321bfdf Cleaning up defines 2024-02-10 16:44:44 +01:00
ItsSelis
0680645556 Weakref refactor 2023-06-01 20:31:54 +02:00
ItsSelis
c2b084ebfa Resolves sdmm warnings 2023-03-08 19:06:01 +01:00
Novacat
1aa4c73e8d Revert "[MIRROR] /atom New() => Initialize() [MDB IGNORE]" 2022-08-27 08:49:56 -04:00
MistakeNot4892
d717a4b50a Merge branch 'master' of https://github.com/VOREStation/VOREStation into upstream-merge-8298 2022-08-25 14:26:20 +10:00
ItsSelis
1d5f2b5b37 Wires Colors & Exemptions 2022-07-04 00:06:02 +02:00
ItsSelis
2a07a98cd1 /area/groundbase/civilian/bar/upper in exemption
Its only really that one open part
2022-07-02 21:16:35 +02:00
ItsSelis
9dbb6fdd66 Testing Wires, Coordinates & Fixed Science Wall Area 2022-07-02 21:02:13 +02:00
ItsSelis
b820e18abc Updated title 2022-07-02 16:53:16 +02:00
MistakeNot4892
3f9af78f3a /atom New() => Initialize() [MDB IGNORE] 2021-11-14 03:09:51 -05:00
VerySoft
81824e692f Miscellaneous updates
makes it so some areas aren't required to be mapped in for unit tests

Area!


Attempt to fix active edge


Add/update planet art


Telecomms airlock fixed


Fixes the starstuff

now it brings both areas with it
Admin fluff

Some stuff for helping events happen, also makes the bluespace and redspace shimmers have a skybox icon
2021-10-27 19:55:53 -04:00
Aronai Sieyes
d6c8450ef1 Update vore space prot test 2021-08-02 12:49:40 -04:00
Aronai Sieyes
7551c94d95 Create a new empty zlevel for testing suffocation 2021-08-02 12:17:24 -04:00
Aronai Sieyes
669d23322c Change various things to subtypesof() 2021-07-20 12:54:59 -04:00
Aronai Sieyes
34982728cb Add 'as anything' to various for loops 2021-07-20 12:39:59 -04:00
MarinaGryphon
d0d8e42edc unify crash_with and stack_trace 2021-07-13 15:46:52 -05:00
MarinaGryphon
7820442652 Fix log examine being weird. 2021-07-09 08:35:11 -05:00
Aronai Sieyes
a42526dc85 Fix ZAS insane pathing, add logging 2021-06-17 10:58:26 -04:00
Atermonera
fec4ba87e2 Added unit test to ensure emote key uniqueness. 2021-06-14 03:30:01 -04:00
MarinaGryphon
f13665269d Adds unit test for invalid recipes (#8119)
* Adds invalid recipe unit test

Checks for:
- Missing result type
- Result type is not /atom/movable (mob or obj)
- Result quantity unset
- Quantity less than or equal to zero
- Quantity is not an integer

* Update recipe_tests.dm

* adds tests to dme

* dont code at night (remix)

* Update recipe_tests.dm
2021-06-06 05:37:34 -04:00
Atermonera
45ad945a12 Ported updated decls repository from Neb. 2021-03-25 22:27:54 -04:00