Commit Graph

78 Commits

Author SHA1 Message Date
Cameron Lennox
6a157d8614 Rig glovefix and Clothing protection fix (#17118)
* Fixes RIG gear to not drop your equipped items

Fixes the rig gear to not drop your equipped gear after undeployment

* better fix

* Fixes suits and RIGS

- Makes rigsuits no longer eat your gloves
- Allows you to properly wear a ring under a rigsuit
- Gets rid of a LOT of duplicate var  = XYZ in places
- Makes it so clothing actually properly provide protection to the areas they're covering. (This doesn't change anything unless their actual min_cold_protection or max_heat_protection is adjusted!)
- Adds a define for CHEST which is just UPPER_TORSO|LOWER_TORSO to make it clear it's protecting your WHOLE chest at a glance.
- Gives some things like knee-high and thigh-high boots proper leg protection

* Clothing unit test

* fixes

* oops

* hoods are snowflakes

* hood fix

* path fix

* no nullspace turf

* nullcheck

* don't test devwarning cloths

* ignore this too

* more exclusions

* more exclusions, disabled species test

* Changes So Far

* holding/wearing icons for clothing

* fixed

* more fixes

* lets try this again

* go

* tesh cloak

* some more

* devwarning

* the cursed one

* oops

* fixed species scan

* Update clothing.dm

* restrict this down a bit more, we don't want unit-test to choke

* no more CI killer

* suit defined name twice

* suit

* some more exclusions

* etc

* gwah

* gwah

* clarifying exclusions

* yet more exclusions

* another set of exclusions

* ranger

* compile

* more bitflag

* yet more exclusions

* more

* more missing

* Update sifguard.dm

comment (also to wake up travis)

* more exclusions

* sifguard

* more exclusions

* more

* send help, yes more exclusions

* lost to time

* skrell stuff

* offear is special

* fixes more and unbreaks protean rigs

* The big one

* wrong ifdef

* more

* boots

* Update accessory.dm

* small object fix

* lets be more careful

* Does this fix the signal

* is it the signal?

* FIXES THE REST OF THEM

* wah

* disable test

* the last one

* fix signal check

* fixes

* ignore storage

* teshari blacklist

* tesh

* God speed

* fixed progression removed lizard

* fixes some i guess but what's the point

* disable indepth check

* START ROBOT SPRITE VALIDITY

* Revert "START ROBOT SPRITE VALIDITY"

This reverts commit c9bfb7e9ce.

* consistency with another test

* yuh uh

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-03-01 11:56:30 -05:00
Cameron Lennox
e3409de8b9 Robot Sprite Unit test, Robot Upports, Robot Sprite Fixes [MDB IGNORE] [IDB IGNORE] (#17139)
* Robot sprite validity

* key instead of index

* kash additions

* missing tag

* fail out on no name

* fixes

* let the dance commence

* rest style

* Fixes some of the sprites

Merging so I can see what else it wants

* check belly stages too not just max

* this too

* fixes

* fixes

* Adds variant catborgs

- Adds variant carborgs. These are the older models. Upport from CS.

NEEDS REMOVAL:
DMI FILE: modular_chomp/icons/mob/catborg/catborg.dmi

SPECIFIC REMOVAL IN FILES:
modular_chomp/code/modules/mob/living/silicon/robot/sprites/mining.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/medical.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/janitor.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/science.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/security.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/civilian.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/engineering.dm

* DULLAHAN BORGS

Up-ported dullahan borgs.
Makes it so proteans can choose dullahans as their sprite blob sprite.
NOTE: DULLAHAN-NINJA (V3) DOES NOT HAVE A SIT SPRITE. IT'S ALSO UNUSED. SYNDI SPRITE WAS PUT TO ACT AS A STANDIN

TO BE REMOVED DOWNSTREAM:
modular_chomp/icons/mob/dullahanborg

modular_chomp/code/modules/mob/living/silicon/robot/sprites/civilian.dm (dullahan/service & dullahan/servicealt)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/engineering.dm
(dullahan/engineerv1 & dullahan/envingeerv2)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/janitor.dm
(dullahan/janitor & dullahan/janitoralt)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/medical.dm
(dullahan/crisis & dullahan/crisisalt)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/mining.dm
(dullahan, dullahan/miner, dullahan/mineralt, dullahancarg, dullahancarg/cargo, dullahancarg/cargoalt

modular_chomp/code/modules/mob/living/silicon/robot/sprites/syndicate.dm
(Delete the entire file)

modular_chomp/code/modules/mob/living/silicon/robot/sprites/security.dm
(security/dullahan dullahan/sec dullahan/secalt)

* Update science.dm

* fixes dead overlays

* Update mining.dm

* more borgs

DOWNSTREAM REMOVAL:
code/modules/mob/living/silicon/robot/robot_modules/Widerobot_Clown_ch.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/clown.dm
code/modules/mob/living/silicon/robot/robot_modules/Widerobot_Standard_ch.dm (This file was unticked. It was placed in standard.dm)
modular_chomp/code/modules/mob/living/silicon/robot/sprites/combat.dm
modular_chomp/code/modules/mob/living/silicon/robot/sprites/medical.dm
code/modules/mob/living/silicon/robot/subtypes/boozeborg_ch.dm (Unticked in the DMI. Moved to subtypes/boozeborg.dm)
modular_chomp/code/modules/mob/living/silicon/robot/dogborg/dog_sleeper.dm
modular_chomp/icons/mob/raptorborg/raptor.dmi - Unused
All the worm borg overrides

Downstream as well:
/obj/item/robot_tongue/examine(user) in code\modules\mob\living\silicon\robot\dogborg\dog_modules_vr.dm needs to be enabled.

* whew

* gwah

* SAVE

* fixes

* fixes sprites more

* Adds Outpost Borgs

Stoat and Possum.
Other versions of possum WIP

* no wreck overlay

* gwah

* decals to list

* fixing

* .

* fixes there 3 being 3

* fix decal resting

* sleeper fix

* fix struggle resting

* puts surgery module in its place

* no CE

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-02-27 13:00:02 -05:00
Cameron Lennox
b949f63d27 Reagent unit testing (#17080)
* initial port

* first ignore batch

* second exclusions

* Tequila fix

* Fixes Changeling Sting

* Virgin Mojito fix

* fixes Love Potion

* Rest of love potion

* Various fixes

* tweaks to unit test

* fix for decl

* get decl properly

* fixie

* put the box back

* tequila fix

* fixes tequila

* check dispenser carts too

* name not id

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>
2025-02-13 23:12:48 +01:00
Cameron Lennox
cdafe425a5 Adds Trait Genetics (#16921)
* Adds Trait Genetics from Outpost21

Adds trait genetics from Outpost 21
- Tried to update each file it touched to be equivalent to their Chomp specific variants in order to maintain functionality and make sure no oddities would happen due to code differences. (Some things like the eardeaf loop were left there but commented out)

* Morph trait

* Fixes a server crashing bug with flip

aa

* flip

* Makes morph superpower better

- Makes it use the appearance_changer instead of 1000 different  procs

- Makes cocoon weaver able to change eye and skin color.

I did NOT select you. BAD

* begone

* fix dna modifier

* Fixes massive memory leak

* Brain Runtime Fix

* There was no reason for this to be a spawn(0)

And no I didn't spawn with no blood - https://i.imgur.com/vPizqCD.png

* revert

revert the dna changes there

* Deconf

* gets rid of unused proc vars that did nothing

* expects enough free slots

* glob

* fixed and added two other tests

* another few tests

* this is a list

* fixed bad injector

* lets wrap these for sanity

* better feedback

* wrong name

* don't allow multiple occupants into the dna pod

* future traits will have activation levels instead of binary on/off

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-02-11 02:01:27 -05:00
Cameron Lennox
e5befdf43e More cosmetic strictness (#17116)
* prevent illegal BPs

* illegal test

* Revert "illegal test"

This reverts commit 12df56498f.

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-02-10 17:51:00 -05:00
Cameron Lennox
eeefd4ef3f Fixes the body designer [WIP] (#17062)
* designer

* finished off remaining body designer stuff, name etc

* merged _vr file, added note to use this

* harddel fix

* this one too

* unifies subtabs, adds search and improves layout

* fixes a longstanding issue with marking color appearance changer

It was feeding a /list (The object) to the color picker and the color picker just rolled with it and said 'sure'.

Now with actual sanity TGUI color picker freaks out and goes 'wtf'

This makes it actually feed a color input into the color picker.

* quick push

* adds hair grad to body designer

* push

* color works again

* hair gradient for body designer

* deconf

* Gets rid of duplicate datum

* no test tonight

* spotty fat

* Condenses hair_extras. Fixes a few missing.

Also adds a new cosmetics_tests unit test.

* fixes the rest of the sprites

* lets try this test

* why did that test compile

* another test ENHANCEMENT(fix)

* More aggressive unittest

* fixie

* invisible tail has snowflake handling

* fix for invis check

* oops

* validate existence of icon in unit test

* unittest checks marking and hair icons properly

* fixing bad unit testing again

* fixed marking icon check

* get rid of unused datum, markings show

* fixes things

* you too

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-02-07 20:57:25 -05:00
Cameron Lennox
2e4f1ce642 (Partially) Fixes Out Of Memory crashes (#17043)
* Fixes massive memory leak

* Brain Runtime Fix

* There was no reason for this to be a spawn(0)

And no I didn't spawn with no blood - https://i.imgur.com/vPizqCD.png

* Fixes deadringer not properly deathgasping the right entity

* Wounds properly get delted off destroyed limbs

* Update vorestation.dme

* Runtime fix & DNA lock fix

* More qdels

* qdel

* comment out
2025-02-05 14:02:17 -05:00
Kashargul
da3710df9b adds another unit test, bumps nvmrc (#17010) 2025-02-01 01:19:01 +01:00
ShadowLarkens
ec18de7d79 Replace all air_master nonsense with SSair 2024-10-23 05:47:09 -07:00
Guti
409aaba802 Remove 2024-09-09 02:36:53 +02:00
Drathek
7c8bb85de3 Whitespace Standardization [MDB IGNORE] (#15748)
* Update settings

* Whitespace changes

* Comment out merger hooks in gitattributes

Corrupt maps would have to be resolved in repo before hooks could be updated

* Revert "Whitespace changes"

This reverts commit afbdd1d844.

* Whitespace again minus example

* Gitignore example changelog

* Restore changelog merge setting

* Keep older dmi hook attribute until hooks can be updated

* update vscode settings too

* Renormalize remaining

* Revert "Gitignore example changelog"

This reverts commit de22ad375d.

* Attempt to normalize example.yml (and another file I guess)

* Try again
2024-02-20 11:28:51 +01:00
Selis
d99321bfdf Cleaning up defines 2024-02-10 16:44:44 +01:00
ItsSelis
0680645556 Weakref refactor 2023-06-01 20:31:54 +02:00
ItsSelis
c2b084ebfa Resolves sdmm warnings 2023-03-08 19:06:01 +01:00
Novacat
1aa4c73e8d Revert "[MIRROR] /atom New() => Initialize() [MDB IGNORE]" 2022-08-27 08:49:56 -04:00
MistakeNot4892
d717a4b50a Merge branch 'master' of https://github.com/VOREStation/VOREStation into upstream-merge-8298 2022-08-25 14:26:20 +10:00
ItsSelis
1d5f2b5b37 Wires Colors & Exemptions 2022-07-04 00:06:02 +02:00
ItsSelis
2a07a98cd1 /area/groundbase/civilian/bar/upper in exemption
Its only really that one open part
2022-07-02 21:16:35 +02:00
ItsSelis
9dbb6fdd66 Testing Wires, Coordinates & Fixed Science Wall Area 2022-07-02 21:02:13 +02:00
ItsSelis
b820e18abc Updated title 2022-07-02 16:53:16 +02:00
MistakeNot4892
3f9af78f3a /atom New() => Initialize() [MDB IGNORE] 2021-11-14 03:09:51 -05:00
VerySoft
81824e692f Miscellaneous updates
makes it so some areas aren't required to be mapped in for unit tests

Area!


Attempt to fix active edge


Add/update planet art


Telecomms airlock fixed


Fixes the starstuff

now it brings both areas with it
Admin fluff

Some stuff for helping events happen, also makes the bluespace and redspace shimmers have a skybox icon
2021-10-27 19:55:53 -04:00
Aronai Sieyes
d6c8450ef1 Update vore space prot test 2021-08-02 12:49:40 -04:00
Aronai Sieyes
7551c94d95 Create a new empty zlevel for testing suffocation 2021-08-02 12:17:24 -04:00
Aronai Sieyes
669d23322c Change various things to subtypesof() 2021-07-20 12:54:59 -04:00
Aronai Sieyes
34982728cb Add 'as anything' to various for loops 2021-07-20 12:39:59 -04:00
MarinaGryphon
d0d8e42edc unify crash_with and stack_trace 2021-07-13 15:46:52 -05:00
MarinaGryphon
7820442652 Fix log examine being weird. 2021-07-09 08:35:11 -05:00
Aronai Sieyes
a42526dc85 Fix ZAS insane pathing, add logging 2021-06-17 10:58:26 -04:00
Atermonera
fec4ba87e2 Added unit test to ensure emote key uniqueness. 2021-06-14 03:30:01 -04:00
MarinaGryphon
f13665269d Adds unit test for invalid recipes (#8119)
* Adds invalid recipe unit test

Checks for:
- Missing result type
- Result type is not /atom/movable (mob or obj)
- Result quantity unset
- Quantity less than or equal to zero
- Quantity is not an integer

* Update recipe_tests.dm

* adds tests to dme

* dont code at night (remix)

* Update recipe_tests.dm
2021-06-06 05:37:34 -04:00
Atermonera
45ad945a12 Ported updated decls repository from Neb. 2021-03-25 22:27:54 -04:00
MistakeNot4892
3e804dc799 Sideports a couple of init unit tests from Neb. 2021-02-27 13:05:16 -05:00
ShadowLarkens
3d7b051f2b Convert /material to /datum/material 2020-09-27 16:16:44 -07:00
Neerti
bc1db6310e Adds Modifier Armor (#7416) 2020-08-07 00:25:15 -04:00
Leshana
262faa38e4 Replace global all_areas list with world.
It ends up having similar performance, so might as well not bother with all_areas.
2020-04-12 18:04:54 -04:00
Atermonera
6c94faa167 Makes Travis fail PRs that runtime during init/unit testing. 2020-03-24 17:29:09 -04:00
Atermonera
e3a67b3050 Makes language keys case sensitive, adds unit tests for language conflicts, fixes some language conflicts 2020-03-17 00:22:05 -04:00
Leshana
c837078105 Replaced "area" shuttles with "landmark" shuttles.
Largely ported from the work done at Baystation in https://github.com/Baystation12/Baystation12/pull/17460 and later commits.

 - Shuttles no longer require a separate area for each location they jump to.
   Instead destinations are indicated by landmark objects, which are not necessarily exclusive to that shuttle.
   This means that more than one shuttle could use the same docking port (not at the same time of course).
 - Enhanced shuttle control computers to use nanoui if they didn't.
 - Organizes shuttle datum code a bit better so there is less re-inventing the wheel in subtypes.
 - Allows the possibility of shuttles (or destinations) that start on late-loaded maps.
 - Deprecate the "extra" shuttle areas that are no longer needed and update shuttle areas in unit tests

This all required a bit of infrastructure improvements.

 - ChangeArea proc, for changing the area of a turf.
 - Fixed lighting overlays actually being able to be destroyed.
 - Added a few utility macros and procs.
 - Added "turf translation" procs which are like move_contents_to but more flexible.
2020-03-05 10:29:08 -05:00
Atermonera
772a95c68e Adds an In-game Feedback System 2020-02-24 16:35:08 -05:00
Novacat
466516b066 Revert "Un-kevinzes nanoui and chemistry subsystems back into processes for greater good" 2019-04-08 15:24:27 -04:00
Heroman
b11015107c REVERT of nanoui/chemistry becoming subsystems (temp) 2019-04-05 13:30:32 +10:00
kevinz000
6415e4193f [READY]Makes a bunch of processes subsystems instead 2019-03-27 16:03:51 -04:00
Arokha Sieyes
2d89d63c09 Merge branch 'master' of https://github.com/PolarisSS13/Polaris into aro-sync-05-27-2018
# Conflicts:
#	code/game/objects/structures/crates_lockers/closets/l3closet.dm
#	code/game/objects/structures/crates_lockers/closets/secure/engineering.dm
#	code/game/objects/structures/crates_lockers/closets/secure/medical.dm
#	code/game/objects/structures/crates_lockers/closets/secure/scientist.dm
#	code/game/objects/structures/crates_lockers/closets/secure/security.dm
#	code/game/objects/structures/crates_lockers/closets/utility_closets.dm
#	maps/southern_cross/structures/closets/misc.dm
#	maps/submaps/surface_submaps/wilderness/DoomP.dmm
#	vorestation.dme
2018-05-27 19:26:12 -04:00
Arokha Sieyes
c31ac4866d Active edge canary PR
Plus free unit test upgrade
2018-05-26 12:03:35 -04:00
Arokha Sieyes
6b42df0685 Merge branch 'master' of https://github.com/VOREStation/Polaris into aro-sync-05-25-2018
# Conflicts:
#	code/__defines/misc.dm
#	code/controllers/master_controller.dm
#	code/game/machinery/computer3/computers/card.dm
#	code/game/objects/items/devices/communicator/UI.dm
#	code/game/objects/items/stacks/medical.dm
#	code/game/objects/structures/signs.dm
#	code/modules/admin/admin_verbs.dm
#	code/modules/client/client defines.dm
#	code/modules/client/client procs.dm
#	code/modules/clothing/clothing.dm
#	code/modules/clothing/under/accessories/holster.dm
#	code/modules/events/radiation_storm.dm
#	code/modules/mining/machine_processing.dm
#	code/modules/mob/living/carbon/human/species/station/prometheans.dm
#	code/modules/mob/living/living.dm
#	code/modules/mob/living/simple_animal/animals/bear.dm
#	code/modules/mob/living/simple_animal/animals/cat.dm
#	code/modules/mob/living/simple_animal/animals/parrot.dm
#	code/modules/mob/mob.dm
#	code/modules/reagents/Chemistry-Reagents/Chemistry-Reagents-Core.dm
#	code/modules/reagents/Chemistry-Reagents/Chemistry-Reagents-Food-Drinks.dm
#	code/modules/reagents/Chemistry-Reagents/Chemistry-Reagents-Medicine.dm
#	code/modules/reagents/reagent_dispenser.dm
#	config/example/config.txt
#	html/changelogs/.all_changelog.yml
#	interface/skin.dmf
#	maps/southern_cross/southern_cross-1.dmm
#	vorestation.dme
2018-05-25 13:23:47 -04:00
Neerti
62ce4196e5 Bonus: Make Travis Show the Active Edges 2018-04-29 18:43:02 -04:00
Neerti
be73b8c36a for(var/bad_code in world)
Removes a very large amount of world loops.
Adds a macro to painlessly generate a global list, and the needed code to modify the list when an object is made or deleted automatically.
Cleans up some commented out code.
2018-04-29 17:55:04 -04:00
Arokha Sieyes
f04c58f202 VS: Rewrites basically all of how bellies work
And cleans up a ton of stuff.
2018-02-27 13:29:45 -05:00
Leshana
a33792e5e5 Make scheduler and Master init order predictable and make unit tests wait until init is done before starting. 2018-02-05 15:50:13 -05:00