Commit Graph

241 Commits

Author SHA1 Message Date
Kashargul fa113ea3f5 next set of globals (#19131) 2026-02-09 00:36:52 +01:00
Kashargul fdfb49012b some more globals (#19098)
* some more globals

* .
2026-01-29 09:21:58 -08:00
Kashargul de17517e42 bunch of global vars (#19091)
* bunch of global vars

* .
2026-01-25 13:18:03 -08:00
Kashargul c7c3a151ec up ports the TG overlays subsystem update (#18945)
* up ports the TG overlays subsystem update

* .

* .

* .

* .

* for spell

* .

* cutting

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>
2026-01-06 13:50:28 +01:00
Cameron Lennox 656597529b Fixes some places that paralyze should KO as well (#18973)
* Fixes some places that paralyze should KO as well

* this too
2026-01-04 15:46:03 +01:00
Cameron Lennox d5849910e5 Begin clickcode attack_self fix (#18797)
* Begin clickcode attack_self fix

Begins the work to make everything call back to parent for attack_self so that signals are sacred.

* Makes MORE things call the attack_self() parent

Yes, I could make special_handling a var on obj/item HOWEVER i want it to be specific so it can be tracked down later and ONLY the objects that use it can be refactored instead of sitting there literally forever and it just becoming 'a thing'.

* Finishes making the rest of attack_self call parent.

As mentioned, things such as 'specialty_goggles' 'special_handling' and the such are only there to help with attack_self until the attack_self is recoded for those items.

* begone foul demon

* some more cleanup

* These

* GOD this was annoying

* yeh

* Fix this

* fLARES

* Thesee too

* toys!

* Even more!

* More fixes

* Even more

* rest of em

* these too

* Update syndie.dm

* hardref clear

* Update code/game/gamemodes/nuclear/pinpointer.dm

* Update code/game/objects/effects/mines.dm

* Update code/game/objects/items/blueprints_vr.dm

* Update code/game/objects/items/blueprints_vr.dm

* Update code/game/objects/items/contraband_vr.dm

* Update code/game/objects/items/crayons.dm

* Update code/game/objects/items/crayons.dm

* Update code/game/objects/items/gunbox.dm

* Update code/game/objects/items/gunbox.dm

* Update code/game/objects/items/gunbox_vr.dm

* Update code/game/objects/items/gunbox_vr.dm

* Update code/game/objects/items/weapons/gift_wrappaper.dm

* Update code/game/objects/items/crayons.dm

* Update code/game/objects/items/crayons.dm

* Update code/game/objects/items/gunbox.dm

* these too

* Update maintpanel_stack.dm

* angry warning

* Fixes packaged snacks.

Fixes improper var default.

* Special handling for these

* proper poly types

* Fixes magclaws

Makes the 'features' it had just part  of base magboots that can be adjusted via varswap.

* Fixes jackets

Fixes https://github.com/VOREStation/VOREStation/issues/18941

* Small bugfix

Makes p_Theyre properly capitialize
Makes examine show proper wording

* Update gift_wrappaper.dm
2025-12-29 13:21:10 -05:00
Guti d59ad9df0c Ports TG Anomalies (#18794)
* Anomalies

* Tiles

* Automatic changelog compile [ci skip]

* Bioscramble

* Reactive armour

* Reactive

* .

* Automatic changelog compile [ci skip]

* hallucination

* Snowy

* Bit of polishing

* change

* Cargo & Research

* fimx

* Anomaly stuffs

* Bioscrambler + Terrible fire armour

* Adjustment

* Less spammy

* Changes

---------

Co-authored-by: vorestation-ci[bot] <199609141+vorestation-ci[bot]@users.noreply.github.com>
2025-12-11 06:47:48 -05:00
Cameron Lennox 5886dd5dfa Swaps species.total_health for getMaxHealth() (#18702)
* Swaps species.total_health for getMaxHealth()

* fix this as well

shock_stage is what they want to increase, NOT traumatic val as it gets reeset as soon as we have a shock tick
2025-11-08 02:11:29 +01:00
Kashargul 45bd1930ec obj screen to atom movable screen (#18434)
* obj screen to atom movable screen

* .
2025-09-22 00:31:30 +02:00
Will 1fe94df762 Moves destroy_on_drop to TG style and adds signal (#18454)
* to tg style

* unify drop proc

* protection and logging on qdeleted item pickup

* prevent stripping items from the inventory menu too

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>
2025-09-14 05:27:24 -04:00
Kashargul e956d13a6b jobs, access and radio to defines (#18297)
* jobs, access and radio to defines

* .

* .

* urg

* .

* .

* finish the radio freqs

* why

* .

* .

* ticker initial

* eh

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>
2025-08-31 01:32:36 +02:00
Cameron Lennox f10117777d sleeps (#18335) 2025-08-29 14:36:26 +02:00
Kashargul 39a0bcd60e Encode changes (#18052)
* change encode

* guhh

* .

* .

* .

* Update code/game/antagonist/antagonist_objectives.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

* Update code/modules/clothing/spacesuits/rig/modules/specific/voice.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

* Update code/modules/news/new_newspaper.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

* Update code/modules/admin/DB ban/functions.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

* Update code/modules/tgui/modules/communications.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>

---------

Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>
2025-08-05 00:19:22 +02:00
Cameron Lennox 84dc5535dc var/global/list -> GLOB. conversion (#17928)
* These two are easy

* !!!runlevel_flags

the fact it was global.runlevel_flags.len has me a bit...iffy on this.

* !!!json_cache

Same as above. used global.

* player_list & observer_mob_list

* mechas_list

* this wasn't even used

* surgery_steps

* event_triggers

* landmarks_list

* dead_mob_list

* living_mob_list

* ai_list

* cable_list

* cleanbot_reserved_turfs

* listening_objects

* silicon_mob_list

* human_mob_list

* Update global_lists.dm

* joblist

* mob_list

* Update global_lists.dm

* holomap_markers

* mapping_units

* mapping_beacons

* hair_styles_list

* facial_hair_styles_list

* Update global_lists.dm

* facial_hair_styles_male_list

* facial_hair_styles_female_list

* body_marking_styles_list

* body_marking_nopersist_list

* ear_styles_list

* hair_styles_male_list

* tail_styles_list

* wing_styles_list

* escape_list & rune_list & endgame_exits

these were all really small

* endgame_safespawns

* stool_cache

* emotes_by_key

* random_maps & map_count

* item_tf_spawnpoints

* narsie_list

* active_radio_jammers

* unused

* paikeys

* pai_software_by_key & default_pai_software

* plant_seed_sprites

* magazine_icondata_keys  & magazine_icondata_states

* unused

* ashtray_cache

* light_type_cache

* HOLIDAY!!!

this one was annoying

* faction stuff (red?!)

* Update preferences_factions.dm

* vs edit removal

* backbaglist, pdachoicelist, exclude_jobs

* item_digestion_blacklist, edible_tech, blacklisted_artifact_effect, selectable_footstep, hexNums, syndicate_access

* string_slot_flags and hexdigits->hexNums

* possible_changeling_IDs

* vr_mob_tf_options

* vr_mob_spawner_options

* pipe_colors

* vr_mob_spawner_options

* common_tools

* newscaster_standard_feeds

* Update periodic_news.dm

* changeling_fabricated_clothing

* semirandom_mob_spawner_decisions

* id_card_states

* Update syndicate_ids.dm

* overlay_cache & gear_distributed_to

* more

* radio_channels_by_freq

* Update global_lists.dm

* proper

* default_medbay_channels & default_internal_channels

default_internal_channels is weird as it has a mapbased proc() but that proc is never called...

* valid_ringtones

* move this

* possible_plants

* more

* separate these

moves xeno2chemlist from a hook to a new global list.

* tube_dir_list

* valid_bloodreagents & monitor_states

* Junk

* valid_bloodtypes

* breach_burn_descriptors & burn

* more!!

appliance_available_recipes seems uber cursed, re-look at later

* Appliance code is cursed

* wide_chassis & flying_chassis

* allows_eye_color

* all_tooltip_styles

* direction_table

* gun_choices

* severity_to_string

* old event_viruses

* description_icons

* MOVE_KEY_MAPPINGS

* more more

* pai & robot modules

* Update global_lists.dm

* GEOSAMPLES

Also swaps a .len to LAZYLEN()

* shieldgens

* reagent recipies

* global ammo types

* rad collector

* old file and unused global

* nif_look_messages

* FESH

* nifsoft

* chamelion

* the death of sortAtom

* globulins

* lazylen that

* Update global_lists.dm

* LAZY

* Theese too

* quick fix

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-07-14 20:14:31 +02:00
Kashargul 3735a31e05 Fix a bunch of issues and runtimes (#17951)
* selection target

* ugh

* fix deadmin

* larger

* fix paper icons

* those are inverted

* don't miss that

* fix all

* point transfer

* add nostrip flag to items

* un....  teppi

* .

* end life proc after qdel

* this could be null in very rare cases

* this has a lot of sleeps, someday should be refactored and check for qdeleted

* needs to be an object

* qdel check this

* use the rsc properly

* wtf?

* .

* fix narrate

* .

* push

* inform user, null it

* .

* can be null

* fix maint lurkers

* .

* spans

* .

* fix that too

* urg

* fix distillery

* don't wrap them

* needs usr

* Update cash_register.dm

* quick hook cleanup

* lots of fixes

* .

* clean that up for reasons
2025-07-05 00:45:18 -04:00
Cameron Lennox 86a21e9578 Properly paths sound files and folders (#17604)
* bye

* hello

* hi

* hi

* bye

* hi

* bye

* hi

* Replace em

* bye

* hi

* bye

* Hi

* bye

* hi

* bye

* hi

* bye

* hi

* bye

* hi

* bye

* hi

* bye

* hi

* bye

* hi

* hi

* hi

* hi

* hi

* gwah
2025-05-15 20:14:50 -07:00
Cameron Lennox 40861f50e0 Proper MaxHealth checks and Crit Point (#17704)
* Fixes maxhealth checks not including modifiers and mxHP

Death at:
W/ 100max hp: https://i.imgur.com/nR8DtzG.png
W/ 125max hp: https://i.imgur.com/87eD2hW.png
W/ 25max hp: https://i.imgur.com/SP6rPWc.png

* Crit Point

* small xenochimera fix

* Update game_options.txt
2025-05-15 00:25:30 -07:00
Cameron Lennox 4c6eb631c9 Rx AR Hud and slight loadout cleanup (#17682)
* Hud cleanup

Combines Hud_vr into hud.dm
Clears up incorrect prescription values
Sets pres =1 to pres=TRUE. Sets pres=0 to pres=FALSE
Adds RX variants of AR huds to the loadout as a geartweak
ARglasses and rx AR glasses combined into one single loadout selector
Contaminant HUD and rx Contaminant HUD combined into one single loadout selector

* less bloat
2025-05-08 21:52:51 +02:00
Kashargul f6a99359a9 move invisibility to defines (#17612)
* move Invisibility to defines

* .

* .
2025-04-27 16:47:53 +02:00
Selis 28e969778c code/global.dm => code/_global_vars/ (#17244)
* 1

* Full conversion

* .

* .

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-04-21 05:55:25 -04:00
Selis 21dcf0555b Conversion many Globals to Managed Globals (Part 1) (#17121)
* Conversion of some Globals to Managed Globals

* Fix

* for later

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-04-17 14:16:53 -04:00
SatinIsle 94e61bdfc0 Fixes some bad Destroy()s (#17511)
* Fixes some bad Destroy()s

Fixes some bad destroys on request of Kash, will need checking over that I've not misunderstood the instructions! This is all I had time to look through for now. Checked around 200-ish files.

* The rest of them

Found a quick way to look through them all

* Update chicken.dm

* fix that

* don't abuse destroy

* .

* move this up

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-04-12 00:15:42 +02:00
Kashargul 47b71270a9 fix some issues (#17362)
* fix some issues

* .
2025-03-16 16:01:30 +01:00
Kashargul 4d36cfdaeb Finish Machinery new to init (#17334)
* Finish Machinery new to init

* fix that

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>
2025-03-16 03:57:48 -04:00
Cameron Lennox b36e238cd1 Cleaned up every clothing item to use defined pocket lists #35 (#17235)
* cleaned up every clothing item to use defined pocket lists

* oop, changeling armor weird

* invalid prybar

* allow any emergency tank, for non-oxy breathers

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-03-12 16:32:55 -04:00
Kashargul 1def015bad end of file Fix (#17308)
* end of file Fix

* fix those lints too
2025-03-10 16:15:35 -04:00
Kashargul 46bea7cfa2 Initialize fixing (#17279)
* Initialoize fixing

* diff fix

* add init grep test

* fixed missed ones

* .

* some more

* ,
2025-03-08 13:59:29 -05:00
Cameron Lennox cc4e7cae40 Fixes accessories and a few others not showing properly (#17255)
* better fix

Also fixes it in a few other places

* fix that

* gloves

* no doublechecking H

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-03-02 19:45:46 -05:00
Kashargul 4f8e9f7ef8 some more new to init (#17231)
* some more new to init

* rigs

* rigs

* intellisense moment

* telcoms and landmarks

* fix that as well

* some more minor things

* re add missing message

* fix trash eating...
2025-03-01 13:39:52 -05:00
Kashargul cb56adaa37 more font tag replacements (#17123)
* more font tag replacements

* few more

* more span conversion (#9)

---------

Co-authored-by: Nadyr <41974248+Darlantanis@users.noreply.github.com>
2025-03-01 11:58:58 -05:00
Cameron Lennox 6a157d8614 Rig glovefix and Clothing protection fix (#17118)
* Fixes RIG gear to not drop your equipped items

Fixes the rig gear to not drop your equipped gear after undeployment

* better fix

* Fixes suits and RIGS

- Makes rigsuits no longer eat your gloves
- Allows you to properly wear a ring under a rigsuit
- Gets rid of a LOT of duplicate var  = XYZ in places
- Makes it so clothing actually properly provide protection to the areas they're covering. (This doesn't change anything unless their actual min_cold_protection or max_heat_protection is adjusted!)
- Adds a define for CHEST which is just UPPER_TORSO|LOWER_TORSO to make it clear it's protecting your WHOLE chest at a glance.
- Gives some things like knee-high and thigh-high boots proper leg protection

* Clothing unit test

* fixes

* oops

* hoods are snowflakes

* hood fix

* path fix

* no nullspace turf

* nullcheck

* don't test devwarning cloths

* ignore this too

* more exclusions

* more exclusions, disabled species test

* Changes So Far

* holding/wearing icons for clothing

* fixed

* more fixes

* lets try this again

* go

* tesh cloak

* some more

* devwarning

* the cursed one

* oops

* fixed species scan

* Update clothing.dm

* restrict this down a bit more, we don't want unit-test to choke

* no more CI killer

* suit defined name twice

* suit

* some more exclusions

* etc

* gwah

* gwah

* clarifying exclusions

* yet more exclusions

* another set of exclusions

* ranger

* compile

* more bitflag

* yet more exclusions

* more

* more missing

* Update sifguard.dm

comment (also to wake up travis)

* more exclusions

* sifguard

* more exclusions

* more

* send help, yes more exclusions

* lost to time

* skrell stuff

* offear is special

* fixes more and unbreaks protean rigs

* The big one

* wrong ifdef

* more

* boots

* Update accessory.dm

* small object fix

* lets be more careful

* Does this fix the signal

* is it the signal?

* FIXES THE REST OF THEM

* wah

* disable test

* the last one

* fix signal check

* fixes

* ignore storage

* teshari blacklist

* tesh

* God speed

* fixed progression removed lizard

* fixes some i guess but what's the point

* disable indepth check

* START ROBOT SPRITE VALIDITY

* Revert "START ROBOT SPRITE VALIDITY"

This reverts commit c9bfb7e9ce.

* consistency with another test

* yuh uh

---------

Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
2025-03-01 11:56:30 -05:00
Kashargul 2ae6355aff more new to Init (#17147)
* more new to Init

* fix pumps

* style update

* fix atmos memory leak

* fix mech

* qdel in here

* Update hands.dm

* Update rings.dm
2025-02-16 00:16:15 +01:00
Kashargul f9e7b44dae cleans up INIT (#17130)
Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>
2025-02-13 23:28:01 +01:00
Kashargul 9a6f44b850 some more NEW to init (#17093)
* some more NEW to init

* Fixes cloning disk

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>
2025-02-12 07:51:26 -05:00
Kashargul bbed406b2e remove old inputs (#17008) 2025-02-01 14:23:25 -05:00
Kashargul a9a045a741 Moves UIs to TGUI core (#16940)
* up to modify robot

* also version up here

* Switch tgui-dev-server to edge mode

* Folders through Sleeper

* finish the folders

* move all uis, some will likely have errors

* Remove size={} on table cells

* Change a bunch of <Flex>

* chat to tgui core and typescript

* chat Flex to Stack

* Update APC.tsx

* Update APC.tsx

* Make ICAssembly wires all work

* More Flex to Stack

* some html

* this half was easy...

* some more

* some more

* fix those up

* few more

* few more

* this should be fine

* convert those, mark the anys to be reaplced

* Down to 118 Flex results

* Down to 104

* Down to 75

* bunch of fixes

* few more

* all except power monitor

* push for now, tgui core issue

* component props

* 32 only

* grow

* those need a param now

* function imports

* dependencies up

* finish those

* finish up

* this

* also those for now

* typescript up

* proper typing

* convert all chat files

* keys

* oups

* Update package.json

* massively improve color picker perf

* this needs to update

* Tgui core

* add those to the panel jsut in case

* dependencies up

* Rename colorpicker.tsx to colorpicker.ts

---------

Co-authored-by: ShadowLarkens <shadowlarkens@gmail.com>
2025-01-28 15:23:29 +01:00
Kashargul 7266c4c5dc more missing tags (#16937)
* more missing tags

* only some books have...

* .

* some more

* Update admin.dm

* finish it up
2025-01-21 18:27:01 -05:00
Kashargul d9fc7dac70 should call parent 2025-01-06 21:25:36 +01:00
Kashargul 0436afea65 some dropped sanity 2025-01-06 21:14:40 +01:00
Kashargul 59b9802628 some istype to macros (#16826) 2025-01-06 06:45:02 +10:00
Kashargul df9b71e402 Adds SHOULD_CALL_PARENT to examine (#16822)
* Another one I'm curious about

* those don't

* this should call parent

* beds need to be fully moved due to fantasy gateway

* fix that

* finish beds
2025-01-03 08:27:02 +01:00
Kashargul 987be6070d bunch of inits without return and a few easy new to init (#16815)
* bunch of inits withou return

* Update cans.dm

* bunch of New to Init

* fix that

* .

* .

* move black hole to init and callbacks

* .

* oups, should not do that late at night

* some more without returns
2025-01-02 18:31:38 +01:00
Kashargul a88c58dde7 Merge branch 'master' into reagentToDefines 2024-12-08 15:41:21 +01:00
Killian 525905a086 traffic updates 2024-12-06 22:19:57 +00:00
Kashargul 429398bdd7 some moire 2024-12-06 21:54:05 +01:00
Kashargul 80edcd2c3d Converts gas, mat and reagent strings to defines 2024-12-06 17:26:00 +01:00
Killian e9aafd2826 Merge remote-tracking branch 'upstream/master' into kk-spacetraffic 2024-12-02 06:08:55 +00:00
Killian 9d3a7986d8 traffic update
more khi cleanup
2024-12-01 18:37:08 +00:00
Kashargul 49d89c0059 usr to user up to player effects 2024-11-12 00:10:20 +01:00
ShadowLarkens dc3fd79427 The final action buttons PR (#16514)
* Make action button target datum

* Initial working action palette

* Action related refactors

* tgstation/tgstation/pull/71339
2024-10-26 13:20:54 +02:00