cyberpresidentvanellope/Yogstation
1
0
Fork 0
mirror of https://github.com/yogstation13/Yogstation.git synced 2025-02-26 09:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ports #59750 from TG: Adds configs to disable hard deletes (#11622)

Browse Source 
* Adds configs to disable hard deletes

* Apply suggestions from code review

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: MrStonedOne <kyleshome@gmail.com>
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com>
This commit is contained in:
alexkar598
2021-06-26 07:12:06 -04:00
committed by GitHub
parent 77aa205e6b
commit 1c611b9cff
3 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
code/controllers/configuration/entries/general.dm
View File

@@ -499,4 +499,8 @@
/datum/config_entry/string/centcom_ban_db // URL for the CentCom Galactic Ban DB API
/datum/config_entry/flag/auto_profile
/datum/config_entry/flag/auto_profile
/datum/config_entry/flag/disable_gc_failure_hard_deletes
/datum/config_entry/flag/disable_all_hard_deletes

7
code/controllers/subsystem/garbage.dm
View File

@@ -162,7 +162,8 @@ SUBSYSTEM_DEF(garbage)
testing("GC: -- \ref[src] | [type] was unable to be GC'd --")
I.failures++
if (GC_QUEUE_HARDDELETE)
HardDelete(D)
if (!CONFIG_GET(flag/disable_gc_failure_hard_deletes))
HardDelete(D)
if (MC_TICK_CHECK)
return
continue
@@ -200,8 +201,8 @@ SUBSYSTEM_DEF(garbage)
++totaldels
var/type = D.type
var/refID = "\ref[D]"
del(D)
if (!CONFIG_GET(flag/disable_all_hard_deletes))
del(D)
tick = (TICK_USAGE-tick+((world.time-ticktime)/world.tick_lag*100))

6
config/config.txt
View File

@@ -436,3 +436,9 @@ DEFAULT_VIEW_SQUARE 15x15
CENTCOM_BAN_DB https://centcom.melonmesa.com/ban/search
AUTO_PROFILE
## Uncomment to disable hard deleting garbage collection failures. (Hard deleting GC failures causes lag in order to bring memory usage down and keep bugged objects from hanging around and causing bugs in other things.) You can safely enable this for performance on production if the lag spikes are too disruptive)
#DISABLE_GC_FAILURE_HARD_DELETES
## Uncomment to disable hard deletes entirely, even things that explicitly request. This is not recommended unless you have a need for it during events or other high pop times where performance is key.
#DISABLE_ALL_HARD_DELETES