Update CONTRIBUTING.md

This commit is contained in:
Jordie
2017-08-25 09:59:00 +10:00
committed by GitHub
parent d48e325690
commit 28835beef7

View File

@@ -233,6 +233,8 @@ This prevents nesting levels from getting deeper then they need to be.
* All changes to the database's layout(schema) must be specified in the database changelog in SQL, as well as reflected in the schema files
* Any time the schema is changed the `schema_revision` table and `DB_MAJOR_VERSION` or `DB_MINOR_VERSION` defines must be incremented.
* Queries must never specify the database, be it in code, or in text files in the repo.
@@ -246,6 +248,8 @@ This prevents nesting levels from getting deeper then they need to be.
* Do not divide when you can easily convert it to multiplication. (ie `4/2` should be done as `4*0.5`)
* If you used regex to replace code during development of your code, post the regex in your PR for the benefit of future developers and downstream users.
#### Enforced not enforced
The following coding styles are not only not enforced at all, but are generally frowned upon to change for little to no reason: