Removes several unused properties which had types that don't even exist, picked up by OpenDream (#16648)

* Makes OpenDream compilation ignore the max BYOND version stuff

OD doesn't really have a consistent, exact BYOND version it's even trying to mimic, necessarily, so

* Removes dead members with types that don't even exist

OpenDream picked these up after I made it actually require that typed members actually get their type defined at any point.

Some interesting examples include a riding_datum member that is some left-over before we moved riding into a component, and a reference to some old aspect of goonchat.
This commit is contained in:
Altoids1
2022-11-26 08:30:14 -06:00
committed by GitHub
parent 04f3f7cf7f
commit 926e8e98e7
7 changed files with 6 additions and 11 deletions

View File

@@ -63,8 +63,12 @@
#define MAX_BYOND_MAJOR 514
#define MAX_BYOND_MINOR 1589
///Uncomment to bypass the max version check. Note: This will likely break the game, only use if you know what you're doing
//#define IGNORE_MAX_BYOND_VERSION
// You can define IGNORE_MAX_BYOND_VERSION to bypass the max version check.
// Note: This will likely break the game, especially any extools/auxtools linkage. Only use if you know what you're doing!
#ifdef OPENDREAM // Thanks, Altoids!
#define IGNORE_MAX_BYOND_VERSION
#endif
#if ((DM_VERSION > MAX_BYOND_MAJOR) || (DM_BUILD > MAX_BYOND_MINOR)) && !defined(IGNORE_MAX_BYOND_VERSION)
#error Your version of BYOND is too new to compile this project. Download version 514.1589 at www.byond.com/download/build/514/514.1589_byond.exe
#endif

View File

@@ -52,7 +52,6 @@
var/cur_category = CAT_NONE
var/cur_subcategory = CAT_NONE
var/datum/action/innate/crafting/button
var/display_craftable_only = FALSE
var/display_compact = TRUE

View File

@@ -854,7 +854,6 @@
flags = HIGH_IMPACT_RULESET
minimum_players = 30
antag_cap = 3
var/datum/team/shadowling/shadowling
/datum/dynamic_ruleset/roundstart/shadowling/ready(population, forced = FALSE)
required_candidates = get_antag_cap(population)

View File

@@ -106,9 +106,6 @@
///Used for limiting the rate of clicks sends by the client to avoid abuse
var/list/clicklimiter
///goonchat chatoutput of the client
var/datum/chatOutput/chatOutput
///lazy list of all credit object bound to this client
//var/list/credits

View File

@@ -18,7 +18,6 @@ GLOBAL_VAR_INIT(observer_default_invisibility, INVISIBILITY_OBSERVER)
hud_type = /datum/hud/ghost
movement_type = GROUND | FLYING
var/can_reenter_corpse
var/datum/hud/living/carbon/hud = null // hud
var/bootime = 0
var/started_as_observer //This variable is set to 1 when you enter the game as an observer.
//If you died in the game and are a ghsot - this will remain as null.

View File

@@ -120,8 +120,6 @@
var/list/implants = null
var/datum/riding/riding_datum
var/last_words //used for database logging
var/list/obj/effect/proc_holder/abilities = list()

View File

@@ -31,7 +31,6 @@
stat_attack = UNCONSCIOUS
move_resist = MOVE_FORCE_EXTREMELY_STRONG
var/combatant_state = SEEDLING_STATE_NEUTRAL
var/obj/seedling_weakpoint/weak_point
var/mob/living/beam_debuff_target
var/solar_beam_identifier = 0