Merge branch 'V6' into 1578-Net8Migration

.github/workflows/ci-pipeline.yml

@@ -265,6 +265,13 @@ jobs:
     - name: Build
       run: dotnet build -c ${{ matrix.configuration }}NoWindows
 
+    - name: Cache BYOND .zips
+      uses: actions/cache@v3
+      id: cache-byond
+      with:
+        path: ~/byond-zips-cache
+        key: byond-zips
+
     - name: Run Unit Tests
       run: sudo dotnet test --no-build --logger "GitHubActions;summary.includePassedTests=true;summary.includeSkippedTests=true" --filter TestCategory!=RequiresDatabase -c ${{ matrix.configuration }}NoWindows --collect:"XPlat Code Coverage" --settings build/ci.runsettings --results-directory ./TestResults tgstation-server.sln
 
@@ -308,6 +315,13 @@ jobs:
     - name: Build
       run: dotnet build -c ${{ matrix.configuration }}NoWix
 
+    - name: Cache BYOND .zips
+      uses: actions/cache@v3
+      id: cache-byond
+      with:
+        path: ~/byond-zips-cache
+        key: byond-zips
+
     - name: Run Unit Tests
       run: dotnet test --no-build --logger "GitHubActions;summary.includePassedTests=true;summary.includeSkippedTests=true" --filter TestCategory!=RequiresDatabase -c ${{ matrix.configuration }}NoWix --collect:"XPlat Code Coverage" --settings build/ci.runsettings --results-directory ./TestResults tgstation-server.sln
 

src/Tgstation.Server.Host/Database/DatabaseConnectionFactory.cs

@@ -1,7 +1,7 @@
 using System;
 using System.Data.Common;
-using System.Data.SqlClient;
 
+using Microsoft.Data.SqlClient;
 using Microsoft.Data.Sqlite;
 
 using MySqlConnector;

src/Tgstation.Server.Host/Setup/SetupWizard.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Data.Common;
-using System.Data.SqlClient;
 using System.Globalization;
 using System.IO;
 using System.Linq;
@@ -11,6 +10,7 @@ using System.Text.RegularExpressions;
 using System.Threading;
 using System.Threading.Tasks;
 
+using Microsoft.Data.SqlClient;
 using Microsoft.Data.Sqlite;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Hosting;

src/Tgstation.Server.Host/Tgstation.Server.Host.csproj

@@ -110,8 +110,6 @@
     <PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
     <!-- Usage: Newtonsoft.Json plugin for OpenAPI spec generator -->
     <PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" Version="6.5.0" />
-    <!-- Usage: Access to raw database connectors primarily for setup wizard -->
-    <PackageReference Include="System.Data.SqlClient" Version="4.8.5" />
     <!-- Usage: Windows authentication plugin allowing searching for users by name -->
     <PackageReference Include="System.DirectoryServices.AccountManagement" Version="8.0.0-preview.6.23329.7" />
     <!-- Usage: JWT plugin needed to undo some Microsoft meddling in the HTTP pipeline -->

tests/Tgstation.Server.Host.Tests/Database/TestDatabaseConnectionFactory.cs

@@ -1,10 +1,10 @@
-using Microsoft.VisualStudio.TestTools.UnitTesting;
+using System;
+
+using Microsoft.Data.SqlClient;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 using MySqlConnector;
 
-using System;
-using System.Data.SqlClient;
-
 using Tgstation.Server.Host.Configuration;
 
 namespace Tgstation.Server.Host.Database.Tests

tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Data.SqlClient;
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
@@ -14,6 +13,7 @@ using System.Reflection;
 using System.Threading;
 using System.Threading.Tasks;
 
+using Microsoft.Data.SqlClient;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.VisualStudio.TestTools.UnitTesting;