cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-08-26 14:37:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Trace log these exceptions

Browse Source
This commit is contained in:
Dominion
2023-06-08 03:45:36 -04:00
parent db32ca5f29
commit 2e02c1a239
4 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/Controllers/ApiController.cs
+6 -1
View File
@@ -219,8 +219,13 @@ namespace Tgstation.Server.Host.Controllers
/// <summary>
/// Generic 501 response.
/// </summary>
/// <param name="ex">The <see cref="NotImplementedException"/> that was thrown.</param>
/// <returns>An <see cref="ObjectResult"/> with <see cref="HttpStatusCode.NotImplemented"/>.</returns>
protected ObjectResult RequiresPosixSystemIdentity() => StatusCode(HttpStatusCode.NotImplemented, new ErrorMessageResponse(ErrorCode.RequiresPosixSystemIdentity));
protected ObjectResult RequiresPosixSystemIdentity(NotImplementedException ex)
{
Logger.LogTrace(ex, "System identities not implemented!");
return StatusCode(HttpStatusCode.NotImplemented, new ErrorMessageResponse(ErrorCode.RequiresPosixSystemIdentity));
}
/// <summary>
/// Strongly type calls to <see cref="ControllerBase.StatusCode(int)"/>.
src/Tgstation.Server.Host/Controllers/ConfigurationController.cs
+10 -10
View File
@@ -97,9 +97,9 @@ namespace Tgstation.Server.Host.Controllers
AdditionalData = e.Message,
});
}
catch (NotImplementedException)
catch (NotImplementedException ex)
{
return RequiresPosixSystemIdentity();
return RequiresPosixSystemIdentity(ex);
}
}
@@ -142,9 +142,9 @@ namespace Tgstation.Server.Host.Controllers
AdditionalData = e.Message,
});
}
catch (NotImplementedException)
catch (NotImplementedException ex)
{
return RequiresPosixSystemIdentity();
return RequiresPosixSystemIdentity(ex);
}
}
@@ -188,10 +188,10 @@ namespace Tgstation.Server.Host.Controllers
.AsQueryable()
.OrderBy(x => x.Path));
}
catch (NotImplementedException)
catch (NotImplementedException ex)
{
return new PaginatableResult<ConfigurationFileResponse>(
RequiresPosixSystemIdentity());
RequiresPosixSystemIdentity(ex));
}
catch (UnauthorizedAccessException)
{
@@ -262,9 +262,9 @@ namespace Tgstation.Server.Host.Controllers
Message = e.Message,
});
}
catch (NotImplementedException)
catch (NotImplementedException ex)
{
return RequiresPosixSystemIdentity();
return RequiresPosixSystemIdentity(ex);
}
catch (UnauthorizedAccessException)
{
@@ -302,9 +302,9 @@ namespace Tgstation.Server.Host.Controllers
? NoContent()
: Conflict(new ErrorMessageResponse(ErrorCode.ConfigurationDirectoryNotEmpty)));
}
catch (NotImplementedException)
catch (NotImplementedException ex)
{
return RequiresPosixSystemIdentity();
return RequiresPosixSystemIdentity(ex);
}
catch (UnauthorizedAccessException)
{
src/Tgstation.Server.Host/Controllers/HomeController.cs
+1 -1
View File
@@ -241,7 +241,7 @@ namespace Tgstation.Server.Host.Controllers
}
catch (NotImplementedException ex)
{
Logger.LogTrace(ex, "System identities not implemented!");
RequiresPosixSystemIdentity(ex);
}
using (systemIdentity)
src/Tgstation.Server.Host/Controllers/UserController.cs
+2 -2
View File
@@ -127,9 +127,9 @@ namespace Tgstation.Server.Host.Controllers
dbUser.Name = sysIdentity.Username;
dbUser.SystemIdentifier = sysIdentity.Uid;
}
catch (NotImplementedException)
catch (NotImplementedException ex)
{
return RequiresPosixSystemIdentity();
return RequiresPosixSystemIdentity(ex);
}
else if (!(model.Password?.Length == 0 && model.OAuthConnections?.Any() == true))
{