Implement PosixByondInstaller

src/Tgstation.Server.Host/Components/PosixByondInstaller.cs

@@ -0,0 +1,93 @@
+using Microsoft.Extensions.Logging;
+using System;
+using System.Globalization;
+using System.Net;
+using System.Threading;
+using System.Threading.Tasks;
+using Tgstation.Server.Host.IO;
+
+namespace Tgstation.Server.Host.Components
+{
+	/// <summary>
+	/// <see cref="IByondInstaller"/> for Posix systems
+	/// </summary>
+	sealed class PosixByondInstaller : IByondInstaller
+	{
+		/// <summary>
+		/// The URL format string for getting BYOND linux version {0}.{1} zipfile
+		/// </summary>
+		const string ByondRevisionsURL = "https://secure.byond.com/download/build/{0}/{0}.{1}_byond_linux.zip";
+		/// <summary>
+		/// Path to the BYOND cache
+		/// </summary>
+		const string ByondCachePath = "~/.byond";	//TODO: Verify this is correct!!!!!
+
+		/// <inheritdoc />
+		public string DreamDaemonName => "DreamDaemon";
+
+		/// <inheritdoc />
+		public string DreamMakerName => "DreamMaker";
+
+		/// <summary>
+		/// The <see cref="IIOManager"/> for the <see cref="PosixByondInstaller"/>
+		/// </summary>
+		readonly IIOManager ioManager;
+
+		/// <summary>
+		/// The <see cref="ILogger"/> for the <see cref="PosixByondInstaller"/>
+		/// </summary>
+		readonly ILogger<PosixByondInstaller> logger;
+
+		/// <summary>
+		/// Construct a <see cref="WindowsByondInstaller"/>
+		/// </summary>
+		/// <param name="ioManager">The value of <see cref="ioManager"/></param>
+		/// <param name="logger">The value of <see cref="logger"/></param>
+		public PosixByondInstaller(IIOManager ioManager, ILogger<PosixByondInstaller> logger)
+		{
+			this.ioManager = ioManager ?? throw new ArgumentNullException(nameof(ioManager));
+			this.logger = logger ?? throw new ArgumentNullException(nameof(logger));
+		}
+
+		/// <inheritdoc />
+		public async Task CleanCache(CancellationToken cancellationToken)
+		{
+			try
+			{
+				await ioManager.DeleteDirectory(ByondCachePath, cancellationToken).ConfigureAwait(false);
+			}
+			catch (Exception e)
+			{
+				logger.LogWarning("Error deleting BYOND cache! Exception: {0}", e);
+			}
+		}
+
+		/// <inheritdoc />
+		public async Task<byte[]> DownloadVersion(Version version, CancellationToken cancellationToken)
+		{
+			var ourVersion = version;
+			//lummox is annoying and doesn't like to post linux versions if nothing changed in DreamDaemon/DM
+			//if this for's exit condition ever triggers, i get to say I told you so
+			Exception lastException = null;
+			for (var I = 0; I < 5 && ourVersion.Minor >= 1; ++I, ourVersion = new Version(ourVersion.Major, ourVersion.Minor))
+			{
+				try
+				{
+					var url = String.Format(CultureInfo.InvariantCulture, ByondRevisionsURL, ourVersion.Major, ourVersion.Minor);
+
+					return await ioManager.DownloadFile(new Uri(url), cancellationToken).ConfigureAwait(false);
+				}
+				catch (WebException e)
+				{
+					if (!(e.Status == WebExceptionStatus.ProtocolError && e.Response is HttpWebResponse response && response.StatusCode == HttpStatusCode.NotFound))
+						throw;
+					lastException = e;
+				}
+			}
+			throw lastException;
+		}
+
+		/// <inheritdoc />
+		public Task InstallByond(string path, Version version, CancellationToken cancellationToken) => Task.CompletedTask;
+	}
+}

src/Tgstation.Server.Host/Components/WindowsByondInstaller.cs

@@ -1,4 +1,5 @@
-using System;
+using Microsoft.Extensions.Logging;
+using System;
 using System.Diagnostics;
 using System.Globalization;
 using System.Text;
@@ -41,6 +42,11 @@ namespace Tgstation.Server.Host.Components
 		/// </summary>
 		readonly IIOManager ioManager;
 
+		/// <summary>
+		/// The <see cref="ILogger"/> for the <see cref="WindowsByondInstaller"/>
+		/// </summary>
+		readonly ILogger<WindowsByondInstaller> logger;
+
 		/// <summary>
 		/// If DirectX was installed
 		/// </summary>
@@ -50,20 +56,32 @@ namespace Tgstation.Server.Host.Components
 		/// Construct a <see cref="WindowsByondInstaller"/>
 		/// </summary>
 		/// <param name="ioManager">The value of <see cref="ioManager"/></param>
-		public WindowsByondInstaller(IIOManager ioManager)
+		/// <param name="logger">The value of <see cref="logger"/></param>
+		public WindowsByondInstaller(IIOManager ioManager, ILogger<WindowsByondInstaller> logger)
 		{
 			this.ioManager = ioManager ?? throw new ArgumentNullException(nameof(ioManager));
+			this.logger = logger ?? throw new ArgumentNullException(nameof(logger));
 
 			installedDirectX = false;
 		}
 
 		/// <inheritdoc />
-		public Task CleanCache(CancellationToken cancellationToken) => ioManager.DeleteDirectory(ioManager.ConcatPath(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), "byond/cache"), cancellationToken);
+		public async Task CleanCache(CancellationToken cancellationToken)
+		{
+			try
+			{
+				await ioManager.DeleteDirectory(ioManager.ConcatPath(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), "byond/cache"), cancellationToken).ConfigureAwait(false);
+			}
+			catch (Exception e)
+			{
+				logger.LogWarning("Error deleting BYOND cache! Exception: {0}", e);
+			}
+		}
 
 		/// <inheritdoc />
 		public Task<byte[]> DownloadVersion(Version version, CancellationToken cancellationToken)
 		{
-			var url = String.Format(CultureInfo.InvariantCulture, ByondRevisionsURL, version.Major, version.Major);
+			var url = String.Format(CultureInfo.InvariantCulture, ByondRevisionsURL, version.Major, version.Minor);
 
 			return ioManager.DownloadFile(new Uri(url), cancellationToken);
 		}

src/Tgstation.Server.Host/Core/Application.cs

@@ -160,6 +160,7 @@ namespace Tgstation.Server.Host.Core
 			{
 				services.AddSingleton<ISystemIdentityFactory, PosixSystemIdentityFactory>();
 				services.AddSingleton<ISymlinkFactory, PosixSymlinkFactory>();
+				services.AddSingleton<IByondInstaller, PosixByondInstaller>();
 			}
 
 			services.AddSingleton<IExecutor, Executor>();