cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-08-29 16:11:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #1354

Browse Source 
- Cloning with credentials now requires the ability to change credentials.
- Committer details set on clone now save.
This commit is contained in:
Jordan Brown
2022-02-15 16:28:30 -05:00
parent 8f27f2f9de
commit 3e5352c434
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/Controllers/RepositoryController.cs
+10 -1
View File
@@ -91,6 +91,11 @@ namespace Tgstation.Server.Host.Controllers
if (model.AccessUser == null ^ model.AccessToken == null)
return BadRequest(ErrorCode.RepoMismatchUserAndAccessToken);
var userRights = (RepositoryRights)AuthenticationContext.GetRight(RightsType.Repository);
if (((model.AccessUser ?? model.AccessToken) != null && !userRights.HasFlag(RepositoryRights.ChangeCredentials))
|| ((model.CommitterEmail ?? model.CommitterName) != null && !userRights.HasFlag(RepositoryRights.ChangeCommitter)))
return Forbid();
#pragma warning disable CS0618 // Support for obsolete API field
model.UpdateSubmodules ??= model.RecurseSubmodules;
#pragma warning restore CS0618
@@ -107,7 +112,11 @@ namespace Tgstation.Server.Host.Controllers
currentModel.UpdateSubmodules = model.UpdateSubmodules ?? true;
currentModel.AccessToken = model.AccessToken;
currentModel.AccessUser = model.AccessUser; // intentionally only these fields, user not allowed to change anything else atm
currentModel.AccessUser = model.AccessUser;
currentModel.CommitterEmail = model.CommitterEmail ?? currentModel.CommitterEmail;
currentModel.CommitterName = model.CommitterName ?? currentModel.CommitterName;
var cloneBranch = model.Reference;
var origin = model.Origin;