Merge branch 'master' into dev

src/Tgstation.Server.Host/Swarm/SwarmService.cs

@@ -1117,7 +1117,13 @@ namespace Tgstation.Server.Host.Swarm
 				currentSwarmServers = swarmServers.ToList();
 			}
 
-			logger.LogDebug("Sending updated server list to all {nodeCount} nodes...", currentSwarmServers.Count);
+			if (currentSwarmServers.Count == 1)
+			{
+				logger.LogTrace("Skipping server list broadcast as no nodes are connected!");
+				return;
+			}
+
+			logger.LogDebug("Sending updated server list to all {nodeCount} nodes...", currentSwarmServers.Count - 1);
 
 			using var httpClient = httpClientFactory.CreateClient();
 			async Task UpdateRequestForServer(SwarmServerResponse swarmServer)

tests/Tgstation.Server.Host.Tests/Swarm/SwarmRpcMapper.cs

@@ -67,7 +67,7 @@ namespace Tgstation.Server.Host.Swarm.Tests
 			if (config == default)
 				Assert.Fail($"Invalid node address: {request.RequestUri}");
 
-			if (!node.Initialized)
+			if (!node.WebServerOpen)
 			{
 				throw new HttpRequestException("Can't connect to uninitialized node!");
 			}

tests/Tgstation.Server.Host.Tests/Swarm/TestableSwarmNode.cs

@@ -36,7 +36,7 @@ namespace Tgstation.Server.Host.Swarm.Tests
 		public ServerUpdateResult UpdateResult { get; set; }
 		public Task<SwarmCommitResult?> UpdateTask { get; private set; }
 
-		public bool Initialized { get; private set; }
+		public bool WebServerOpen { get; private set; }
 
 		public bool Shutdown { get; private set; }
 
@@ -128,7 +128,7 @@ namespace Tgstation.Server.Host.Swarm.Tests
 			{
 				logger.LogTrace("RecreateControllerAndService...");
 				var run = ++runCount;
-				Initialized = false;
+				WebServerOpen = false;
 				Shutdown = false;
 
 				CriticalCancellationTokenSource?.Dispose();
@@ -193,7 +193,7 @@ namespace Tgstation.Server.Host.Swarm.Tests
 		public async Task<SwarmRegistrationResult?> TryInit(bool cancel = false)
 		{
 			logger.LogTrace("TryInit...");
-			if (Initialized)
+			if (WebServerOpen)
 				Assert.Fail("Initialized twice!");
 
 			if (!cancel)
@@ -211,8 +211,16 @@ namespace Tgstation.Server.Host.Swarm.Tests
 			}
 			else
 			{
-				result = await Invoke();
-				Initialized = true;
+				try
+				{
+					WebServerOpen = true;
+					result = await Invoke();
+				}
+				catch
+				{
+					WebServerOpen = false;
+					throw;
+				}
 			}
 
 			if (Config.ControllerAddress == null)