Merge pull request #697 from Cyberboss/FixProviderFactory [NugetDeploy]

Test and fix IrcConnectionStringBuilder

src/Tgstation.Server.Api/Models/IrcConnectionStringBuilder.cs

@@ -74,8 +74,8 @@ namespace Tgstation.Server.Api.Models
 			if (splits.Length < 4)
 				return;
 
-			if (Boolean.TryParse(splits[3], out var useSsl))
-				UseSsl = useSsl;
+			if (Int32.TryParse(splits[3], out var intSsl))
+				UseSsl = Convert.ToBoolean(intSsl);
 
 			if (splits.Length < 5)
 				return;

src/Tgstation.Server.Api/Tgstation.Server.Api.csproj

@@ -17,7 +17,7 @@
     <FileVersion>4.0.0.0</FileVersion>
     <PackageTags>json web api tgstation-server tgstation ss13 byond</PackageTags>
     <PackageReleaseNotes>Prototype release</PackageReleaseNotes>
-    <Version>4.0.0.0-preview6005</Version>
+    <Version>4.0.0.0-preview6006</Version>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">

src/Tgstation.Server.Client/Tgstation.Server.Client.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <DebugType>Full</DebugType>
-    <Version>4.0.0.0-preview9112</Version>
+    <Version>4.0.0.0-preview9113</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Cyberboss</Authors>
     <Company>/tg/station 13</Company>

tests/Tgstation.Server.Api.Tests/Models/TestIrcConnectionStringBuilder.cs

@@ -0,0 +1,25 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace Tgstation.Server.Api.Models.Tests
+{
+	[TestClass]
+	public sealed class TestIrcConnectionStringBuilder
+	{
+		[TestMethod]
+		public void TestBasicParseAndBuild()
+		{
+			const string exampleString = "server;1234;nick;1;2;asdf";
+			var builder = new IrcConnectionStringBuilder(exampleString);
+
+			Assert.IsTrue(builder.Valid);
+			Assert.AreEqual("server", builder.Address);
+			Assert.AreEqual((ushort)1234, builder.Port);
+			Assert.AreEqual("nick", builder.Nickname);
+			Assert.IsTrue(builder.UseSsl.Value);
+			Assert.AreEqual(IrcPasswordType.NickServ, builder.PasswordType);
+			Assert.AreEqual("asdf", builder.Password);
+
+			Assert.AreEqual(exampleString, builder.ToString());
+		}
+	}
+}