cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-08-24 21:46:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix bad test mutation operation invocations

Browse Source
This commit is contained in:
Jordan Dominion
2024-10-21 07:04:54 -04:00
parent 6d391a5eb7
commit 6ad80095ff
3 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Tgstation.Server.Tests/Live/ApiAssert.cs
+3
View File
@@ -11,6 +11,8 @@ using StrawberryShake;
using Tgstation.Server.Client;
using Tgstation.Server.Client.GraphQL;
using static HotChocolate.ErrorCodes;
namespace Tgstation.Server.Tests.Live
{
/// <summary>
@@ -78,6 +80,7 @@ namespace Tgstation.Server.Tests.Live
var payload = payloadSelector(operationResult.Data);
Assert.AreNotSame<object>(operationResult.Data, payload, "Select the mutation payload from the operation result!");
var payloadErrors = (IEnumerable<object>)payload.GetType().GetProperty("Errors").GetValue(payload);
var error = payloadErrors.Single();
tests/Tgstation.Server.Tests/Live/GraphQLServerClientExtensions.cs
+1
View File
@@ -33,6 +33,7 @@ namespace Tgstation.Server.Tests.Live
var result = await serverClient.RunOperation(operationExecutor, cancellationToken);
result.EnsureNoErrors();
var data = payloadSelector(result.Data);
Assert.AreNotSame<object>(result.Data, data, "Select the mutation payload from the operation result!");
var errorsObject = data.GetType().GetProperty("Errors").GetValue(data);
if (errorsObject != null)
{
tests/Tgstation.Server.Tests/Live/TestLiveServer.cs
+10 -10
View File
@@ -361,7 +361,7 @@ namespace Tgstation.Server.Tests.Live
},
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RepositoryBasedServerUpdate.ExecuteAsync(TestUpdateVersion, cancellationToken),
result => result,
result => result.ChangeServerNodeVersionViaTrackedRepository,
cancellationToken));
try
@@ -549,7 +549,7 @@ namespace Tgstation.Server.Tests.Live
},
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RepositoryBasedServerUpdate.ExecuteAsync(TestUpdateVersion, cancellationToken),
result => result,
result => result.ChangeServerNodeVersionViaTrackedRepository,
cancellationToken));
await Task.WhenAny(Task.Delay(TimeSpan.FromMinutes(2)), serverTask);
@@ -737,7 +737,7 @@ namespace Tgstation.Server.Tests.Live
cancellationToken),
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RepositoryBasedServerUpdate.ExecuteAsync(TestUpdateVersion, cancellationToken),
result => result,
result => result.ChangeServerNodeVersionViaTrackedRepository,
cancellationToken));
await Task.WhenAny(Task.Delay(TimeSpan.FromMinutes(2)), serverTask);
Assert.IsTrue(serverTask.IsCompleted);
@@ -786,7 +786,7 @@ namespace Tgstation.Server.Tests.Live
async gqlClient => await ApiAssert.OperationFails(
gqlClient,
gql => gql.RepositoryBasedServerUpdate.ExecuteAsync(TestUpdateVersion, cancellationToken),
result => result,
result => result.ChangeServerNodeVersionViaTrackedRepository,
Client.GraphQL.ErrorCode.SwarmIntegrityCheckFailed,
cancellationToken));
@@ -988,7 +988,7 @@ namespace Tgstation.Server.Tests.Live
restClient => restClient.Administration.Restart(cancellationToken),
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RestartServer.ExecuteAsync(cancellationToken),
result => result,
result => result.RestartServerNode,
cancellationToken));
await Task.WhenAny(
@@ -1016,7 +1016,7 @@ namespace Tgstation.Server.Tests.Live
restClient => restClient.Administration.Restart(cancellationToken),
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RestartServer.ExecuteAsync(cancellationToken),
result => result,
result => result.RestartServerNode,
cancellationToken));
await Task.WhenAny(
node2Task,
@@ -1042,7 +1042,7 @@ namespace Tgstation.Server.Tests.Live
async gqlClient => await ApiAssert.OperationFails(
gqlClient,
gql => gql.RepositoryBasedServerUpdate.ExecuteAsync(TestUpdateVersion, cancellationToken),
result => result,
result => result.ChangeServerNodeVersionViaTrackedRepository,
Client.GraphQL.ErrorCode.SwarmIntegrityCheckFailed,
cancellationToken));
@@ -1685,7 +1685,7 @@ namespace Tgstation.Server.Tests.Live
restClient => restClient.Administration.Restart(cancellationToken),
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RestartServer.ExecuteAsync(cancellationToken),
result => result,
result => result.RestartServerNode,
cancellationToken));
}
catch
@@ -1835,7 +1835,7 @@ namespace Tgstation.Server.Tests.Live
restClient => restClient.Administration.Restart(cancellationToken),
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RestartServer.ExecuteAsync(cancellationToken),
result => result,
result => result.RestartServerNode,
cancellationToken));
}
@@ -1907,7 +1907,7 @@ namespace Tgstation.Server.Tests.Live
restClient => restClient.Administration.Restart(cancellationToken),
async gqlClient => await gqlClient.RunMutationEnsureNoErrors(
gql => gql.RestartServer.ExecuteAsync(cancellationToken),
result => result,
result => result.RestartServerNode,
cancellationToken));
}