cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-08-29 08:00:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Better guards against the flakiness of the GitHub releases API

Browse Source
This commit is contained in:
Dominion
2023-06-04 09:30:19 -04:00
parent 078775c8a3
commit 6b2731e5e0
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/Utils/GitHub/GitHubService.cs
+18 -5
View File
@@ -83,20 +83,33 @@ namespace Tgstation.Server.Host.Utils.GitHub
logger.LogTrace("{totalReleases} total releases", allReleases.Count);
var releases = allReleases
.Select(release =>
.Where(release =>
{
if (!release.TagName.StartsWith(updatesConfiguration.GitTagPrefix, StringComparison.InvariantCulture))
return null;
if (!release.PublishedAt.HasValue)
{
logger.LogDebug("Release tag without PublishedAt: {releaseTag}", release.TagName);
return false;
}
if (!release.TagName.StartsWith(updatesConfiguration.GitTagPrefix, StringComparison.InvariantCulture))
return false;
return true;
})
.GroupBy(release =>
{
if (!Version.TryParse(release.TagName.Replace(updatesConfiguration.GitTagPrefix, String.Empty, StringComparison.Ordinal), out var version))
{
logger.LogDebug("Unparsable release tag: {releaseTag}", release.TagName);
return null;
}
return Tuple.Create(version, release);
return version;
})
.Where(tuple => tuple != null)
.Where(grouping => grouping.Key != null)
// GitHub can return the same result twice or some other nonsense
.Select(grouping => Tuple.Create(grouping.Key, grouping.OrderBy(x => x.PublishedAt.Value).First()))
.ToDictionary(tuple => tuple.Item1, tuple => tuple.Item2);
logger.LogTrace("{parsedReleases} parsed releases", releases.Count);