cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-07-20 20:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Mitigate a race condition

Browse Source
This commit is contained in:
Jordan Dominion
2025-08-05 10:40:14 -04:00
parent b3b963d59a
commit 80a19a1e86
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Tgstation.Server.Tests/Live/UsersTest.cs
+4 -2
View File
@@ -264,8 +264,10 @@ namespace Tgstation.Server.Tests.Live
var result = await client.RunOperation(gql => gql.ListUsers.ExecuteAsync(cancellationToken), cancellationToken);
result.EnsureNoErrors();
var users = result.Data.Swarm.Users.QueryableUsers;
Assert.IsTrue(users.TotalCount > 0);
Assert.AreEqual(Math.Min(ApiController.DefaultPageSize, users.TotalCount), users.Nodes.Count);
Assert.IsTrue(users.Nodes.Count > 0);
// Can't assert this, there's a race condition
// Assert.AreEqual(Math.Min(ApiController.DefaultPageSize, users.TotalCount), users.Nodes.Count);
Assert.IsTrue(Math.Min(ApiController.DefaultPageSize, users.TotalCount) >= users.Nodes.Count);
var tgsUserResult = await client.RunOperation(gql => gql.GetUserNameByNodeId.ExecuteAsync(gqlUser.Swarm.Users.Current.CreatedBy.Id, cancellationToken), cancellationToken);
tgsUserResult.EnsureNoErrors();