Replace ifs with ArgumentNullException.ThrowIfNull

This commit is contained in:
Dominion
2023-06-12 20:43:29 -04:00
parent 9303486b1e
commit 8af2ff539e
225 changed files with 530 additions and 1060 deletions
@@ -91,8 +91,7 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public async Task<MemoryStream> DownloadVersion(Version version, CancellationToken cancellationToken)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
ArgumentNullException.ThrowIfNull(version);
Logger.LogTrace("Downloading BYOND version {major}.{minor}...", version.Major, version.Minor);
var url = String.Format(CultureInfo.InvariantCulture, ByondRevisionsUrlTemplate, version.Major, version.Minor);
@@ -105,8 +105,7 @@ namespace Tgstation.Server.Host.Components.Byond
/// <param name="version">The <see cref="Version"/> to validate.</param>
static void CheckVersionParameter(Version version)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
ArgumentNullException.ThrowIfNull(version);
if (version.Build == 0)
throw new ArgumentException("version.Build cannot be 0!", nameof(version));
@@ -207,8 +206,7 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public async Task DeleteVersion(JobProgressReporter progressReporter, Version version, CancellationToken cancellationToken)
{
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(progressReporter);
CheckVersionParameter(version);
@@ -70,8 +70,7 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public override string GetDreamDaemonName(Version version, out bool supportsCli)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
ArgumentNullException.ThrowIfNull(version);
supportsCli = true;
return DreamDaemonExecutableName + ShellScriptExtension;
@@ -80,10 +79,8 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public override Task InstallByond(Version version, string path, CancellationToken cancellationToken)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
if (path == null)
throw new ArgumentNullException(nameof(path));
ArgumentNullException.ThrowIfNull(version);
ArgumentNullException.ThrowIfNull(path);
// write the scripts for running the ting
// need to add $ORIGIN to LD_LIBRARY_PATH
@@ -118,10 +115,8 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public override Task UpgradeInstallation(Version version, string path, CancellationToken cancellationToken)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
if (path == null)
throw new ArgumentNullException(nameof(path));
ArgumentNullException.ThrowIfNull(version);
ArgumentNullException.ThrowIfNull(path);
return Task.CompletedTask;
}
@@ -106,8 +106,7 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public override string GetDreamDaemonName(Version version, out bool supportsCli)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
ArgumentNullException.ThrowIfNull(version);
supportsCli = version.Major >= 515 && version.Minor >= 1598;
return supportsCli ? "dd.exe" : "dreamdaemon.exe";
@@ -131,10 +130,8 @@ namespace Tgstation.Server.Host.Components.Byond
/// <inheritdoc />
public override async Task UpgradeInstallation(Version version, string path, CancellationToken cancellationToken)
{
if (version == null)
throw new ArgumentNullException(nameof(version));
if (path == null)
throw new ArgumentNullException(nameof(path));
ArgumentNullException.ThrowIfNull(version);
ArgumentNullException.ThrowIfNull(path);
if (generalConfiguration.SkipAddingByondFirewallException)
return;
@@ -143,8 +143,7 @@ namespace Tgstation.Server.Host.Components.Chat
{
this.providerFactory = providerFactory ?? throw new ArgumentNullException(nameof(providerFactory));
this.commandFactory = commandFactory ?? throw new ArgumentNullException(nameof(commandFactory));
if (serverControl == null)
throw new ArgumentNullException(nameof(serverControl));
ArgumentNullException.ThrowIfNull(serverControl);
this.loggerFactory = loggerFactory ?? throw new ArgumentNullException(nameof(loggerFactory));
this.logger = logger ?? throw new ArgumentNullException(nameof(logger));
activeChatBots = initialChatBots?.ToList() ?? throw new ArgumentNullException(nameof(initialChatBots));
@@ -179,8 +178,7 @@ namespace Tgstation.Server.Host.Components.Chat
/// <inheritdoc />
public async Task ChangeChannels(long connectionId, IEnumerable<Models.ChatChannel> newChannels, CancellationToken cancellationToken)
{
if (newChannels == null)
throw new ArgumentNullException(nameof(newChannels));
ArgumentNullException.ThrowIfNull(newChannels);
logger.LogTrace("ChangeChannels {connectionId}...", connectionId);
var provider = await RemoveProviderChannels(connectionId, false, cancellationToken);
@@ -263,8 +261,7 @@ namespace Tgstation.Server.Host.Components.Chat
/// <inheritdoc />
public async Task ChangeSettings(Models.ChatBot newSettings, CancellationToken cancellationToken)
{
if (newSettings == null)
throw new ArgumentNullException(nameof(newSettings));
ArgumentNullException.ThrowIfNull(newSettings);
logger.LogTrace("ChangeSettings...");
@@ -326,10 +323,8 @@ namespace Tgstation.Server.Host.Components.Chat
/// <inheritdoc />
public void QueueMessage(MessageContent message, IEnumerable<ulong> channelIds)
{
if (message == null)
throw new ArgumentNullException(nameof(message));
if (channelIds == null)
throw new ArgumentNullException(nameof(channelIds));
ArgumentNullException.ThrowIfNull(message);
ArgumentNullException.ThrowIfNull(channelIds);
QueueMessageInternal(message, () => channelIds, false);
}
@@ -337,8 +332,7 @@ namespace Tgstation.Server.Host.Components.Chat
/// <inheritdoc />
public void QueueWatchdogMessage(string message)
{
if (message == null)
throw new ArgumentNullException(nameof(message));
ArgumentNullException.ThrowIfNull(message);
message = String.Format(CultureInfo.InvariantCulture, "WD: {0}", message);
@@ -121,8 +121,7 @@ namespace Tgstation.Server.Host.Components.Chat
/// <inheritdoc />
public void SetChannelSink(IChannelSink channelSink)
{
if (channelSink == null)
throw new ArgumentNullException(nameof(channelSink));
ArgumentNullException.ThrowIfNull(channelSink);
lock (synchronizationLock)
{
@@ -291,8 +291,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// <inheritdoc />
public override async Task SendMessage(Message replyTo, MessageContent message, ulong channelId, CancellationToken cancellationToken)
{
if (message == null)
throw new ArgumentNullException(nameof(message));
ArgumentNullException.ThrowIfNull(message);
Optional<IMessageReference> replyToReference = default;
Optional<IAllowedMentions> allowedMentions = default;
@@ -391,14 +390,10 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
bool localCommitPushed,
CancellationToken cancellationToken)
{
if (revisionInformation == null)
throw new ArgumentNullException(nameof(revisionInformation));
if (byondVersion == null)
throw new ArgumentNullException(nameof(byondVersion));
if (gitHubOwner == null)
throw new ArgumentNullException(nameof(gitHubOwner));
if (gitHubRepo == null)
throw new ArgumentNullException(nameof(gitHubRepo));
ArgumentNullException.ThrowIfNull(revisionInformation);
ArgumentNullException.ThrowIfNull(byondVersion);
ArgumentNullException.ThrowIfNull(gitHubOwner);
ArgumentNullException.ThrowIfNull(gitHubRepo);
localCommitPushed |= revisionInformation.CommitSha == revisionInformation.OriginCommitSha;
@@ -518,8 +513,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// <inheritdoc />
public async Task<Result> RespondAsync(IMessageCreate messageCreateEvent, CancellationToken cancellationToken)
{
if (messageCreateEvent == null)
throw new ArgumentNullException(nameof(messageCreateEvent));
ArgumentNullException.ThrowIfNull(messageCreateEvent);
if ((messageCreateEvent.Type != MessageType.Default
&& messageCreateEvent.Type != MessageType.InlineReply)
@@ -631,8 +625,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// <inheritdoc />
public Task<Result> RespondAsync(IReady readyEvent, CancellationToken cancellationToken)
{
if (readyEvent == null)
throw new ArgumentNullException(nameof(readyEvent));
ArgumentNullException.ThrowIfNull(readyEvent);
Logger.LogTrace("Gatway ready. Version: {version}", readyEvent.Version);
gatewayReadyTcs?.TrySetResult();
@@ -727,8 +720,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// <inheritdoc />
protected override async Task<Dictionary<Models.ChatChannel, IEnumerable<ChannelRepresentation>>> MapChannelsImpl(IEnumerable<Models.ChatChannel> channels, CancellationToken cancellationToken)
{
if (channels == null)
throw new ArgumentNullException(nameof(channels));
ArgumentNullException.ThrowIfNull(channels);
var remapRequired = false;
var guildsClient = serviceProvider.GetRequiredService<IDiscordRestGuildAPI>();
@@ -113,8 +113,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
Models.ChatBot chatBot)
: base(jobManager, asyncDelayer, logger, chatBot)
{
if (assemblyInformationProvider == null)
throw new ArgumentNullException(nameof(assemblyInformationProvider));
ArgumentNullException.ThrowIfNull(assemblyInformationProvider);
var builder = chatBot.CreateConnectionStringBuilder();
if (builder == null || !builder.Valid || builder is not IrcConnectionStringBuilder ircBuilder)
@@ -167,8 +166,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// <inheritdoc />
public override Task SendMessage(Message replyTo, MessageContent message, ulong channelId, CancellationToken cancellationToken)
{
if (message == null)
throw new ArgumentNullException(nameof(message));
ArgumentNullException.ThrowIfNull(message);
return Task.Factory.StartNew(
() =>
@@ -230,14 +228,10 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
bool localCommitPushed,
CancellationToken cancellationToken)
{
if (revisionInformation == null)
throw new ArgumentNullException(nameof(revisionInformation));
if (byondVersion == null)
throw new ArgumentNullException(nameof(byondVersion));
if (gitHubOwner == null)
throw new ArgumentNullException(nameof(gitHubOwner));
if (gitHubRepo == null)
throw new ArgumentNullException(nameof(gitHubRepo));
ArgumentNullException.ThrowIfNull(revisionInformation);
ArgumentNullException.ThrowIfNull(byondVersion);
ArgumentNullException.ThrowIfNull(gitHubOwner);
ArgumentNullException.ThrowIfNull(gitHubRepo);
var commitInsert = revisionInformation.CommitSha[..7];
string remoteCommitInsert;
@@ -55,8 +55,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// <inheritdoc />
public IProvider CreateProvider(Models.ChatBot settings)
{
if (settings == null)
throw new ArgumentNullException(nameof(settings));
ArgumentNullException.ThrowIfNull(settings);
return settings.Provider switch
{
ChatProvider.Irc => new IrcProvider(
@@ -130,8 +130,7 @@ namespace Tgstation.Server.Host.Components.Deployment
/// <inheritdoc />
public async Task LoadCompileJob(CompileJob job, CancellationToken cancellationToken)
{
if (job == null)
throw new ArgumentNullException(nameof(job));
ArgumentNullException.ThrowIfNull(job);
var newProvider = await FromCompileJob(job, cancellationToken);
if (newProvider == null)
@@ -216,8 +215,7 @@ namespace Tgstation.Server.Host.Components.Deployment
#pragma warning disable CA1506 // TODO: Decomplexify
public async Task<IDmbProvider> FromCompileJob(CompileJob compileJob, CancellationToken cancellationToken)
{
if (compileJob == null)
throw new ArgumentNullException(nameof(compileJob));
ArgumentNullException.ThrowIfNull(compileJob);
// ensure we have the entire metadata tree
logger.LogTrace("Loading compile job {0}...", compileJob.Id);
@@ -199,12 +199,9 @@ namespace Tgstation.Server.Host.Components.Deployment
JobProgressReporter progressReporter,
CancellationToken cancellationToken)
{
if (job == null)
throw new ArgumentNullException(nameof(job));
if (databaseContextFactory == null)
throw new ArgumentNullException(nameof(databaseContextFactory));
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(job);
ArgumentNullException.ThrowIfNull(databaseContextFactory);
ArgumentNullException.ThrowIfNull(progressReporter);
lock (deploymentLock)
{
@@ -57,10 +57,8 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
CompileJob compileJob,
CancellationToken cancellationToken)
{
if (remoteInformation == null)
throw new ArgumentNullException(nameof(remoteInformation));
if (compileJob == null)
throw new ArgumentNullException(nameof(compileJob));
ArgumentNullException.ThrowIfNull(remoteInformation);
ArgumentNullException.ThrowIfNull(compileJob);
Logger.LogTrace("Starting deployment...");
@@ -187,12 +185,9 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
RevisionInformation revisionInformation,
CancellationToken cancellationToken)
{
if (repository == null)
throw new ArgumentNullException(nameof(repository));
if (repositorySettings == null)
throw new ArgumentNullException(nameof(repositorySettings));
if (revisionInformation == null)
throw new ArgumentNullException(nameof(revisionInformation));
ArgumentNullException.ThrowIfNull(repository);
ArgumentNullException.ThrowIfNull(repositorySettings);
ArgumentNullException.ThrowIfNull(revisionInformation);
if (revisionInformation.ActiveTestMerges?.Any() != true)
{
@@ -311,8 +306,7 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
DeploymentState deploymentState,
CancellationToken cancellationToken)
{
if (compileJob == null)
throw new ArgumentNullException(nameof(compileJob));
ArgumentNullException.ThrowIfNull(compileJob);
if (!compileJob.GitHubRepoId.HasValue || !compileJob.GitHubDeploymentId.HasValue)
{
@@ -38,12 +38,9 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
RevisionInformation revisionInformation,
CancellationToken cancellationToken)
{
if (repository == null)
throw new ArgumentNullException(nameof(repository));
if (repositorySettings == null)
throw new ArgumentNullException(nameof(repositorySettings));
if (revisionInformation == null)
throw new ArgumentNullException(nameof(revisionInformation));
ArgumentNullException.ThrowIfNull(repository);
ArgumentNullException.ThrowIfNull(repositorySettings);
ArgumentNullException.ThrowIfNull(revisionInformation);
if (revisionInformation.ActiveTestMerges?.Any() != true)
{
@@ -62,8 +62,7 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
/// <inheritdoc />
public IRemoteDeploymentManager CreateRemoteDeploymentManager(Api.Models.Instance metadata, RemoteGitProvider remoteGitProvider)
{
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(metadata);
logger.LogTrace("Creating remote deployment manager for remote git provider {remoteGitProvider}...", remoteGitProvider);
return remoteGitProvider switch
@@ -84,8 +83,7 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
/// <inheritdoc />
public IRemoteDeploymentManager CreateRemoteDeploymentManager(Api.Models.Instance metadata, Models.CompileJob compileJob)
{
if (compileJob == null)
throw new ArgumentNullException(nameof(compileJob));
ArgumentNullException.ThrowIfNull(compileJob);
RemoteGitProvider remoteGitProvider;
@@ -33,8 +33,7 @@ namespace Tgstation.Server.Host.Components.Events
/// <inheritdoc />
public async Task HandleEvent(EventType eventType, IEnumerable<string> parameters, CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
ArgumentNullException.ThrowIfNull(parameters);
if (watchdog == null)
throw new InvalidOperationException("EventConsumer used without watchdog set!");
@@ -51,8 +50,7 @@ namespace Tgstation.Server.Host.Components.Events
public void SetWatchdog(IWatchdog watchdog)
{
#pragma warning disable IDE0016 // Use 'throw' expression
if (watchdog == null)
throw new ArgumentNullException(nameof(watchdog));
ArgumentNullException.ThrowIfNull(watchdog);
#pragma warning restore IDE0016 // Use 'throw' expression
if (this.watchdog != null)
throw new InvalidOperationException("watchdog already set!");
@@ -249,8 +249,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public IIOManager CreateGameIOManager(Models.Instance metadata)
{
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(metadata);
var instanceIoManager = CreateInstanceIOManager(metadata);
return CreateGameIOManager(instanceIoManager);
@@ -260,10 +259,8 @@ namespace Tgstation.Server.Host.Components
#pragma warning disable CA1506 // TODO: Decomplexify
public async Task<IInstance> CreateInstance(IBridgeRegistrar bridgeRegistrar, Models.Instance metadata)
{
if (bridgeRegistrar == null)
throw new ArgumentNullException(nameof(bridgeRegistrar));
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(bridgeRegistrar);
ArgumentNullException.ThrowIfNull(metadata);
// Create the ioManager for the instance
var instanceIoManager = CreateInstanceIOManager(metadata);
@@ -218,8 +218,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public IInstanceReference GetInstanceReference(Api.Models.Instance metadata)
{
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(metadata);
lock (instances)
{
@@ -233,8 +232,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public async Task MoveInstance(Models.Instance instance, string oldPath, CancellationToken cancellationToken)
{
if (oldPath == null)
throw new ArgumentNullException(nameof(oldPath));
ArgumentNullException.ThrowIfNull(oldPath);
using var lockContext = await SemaphoreSlimContext.Lock(instanceStateChangeSemaphore, cancellationToken);
using var instanceReferenceCheck = GetInstanceReference(instance);
@@ -305,8 +303,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public async Task OfflineInstance(Models.Instance metadata, Models.User user, CancellationToken cancellationToken)
{
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(metadata);
using (await SemaphoreSlimContext.Lock(instanceStateChangeSemaphore, cancellationToken))
{
@@ -372,8 +369,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public async Task OnlineInstance(Models.Instance metadata, CancellationToken cancellationToken)
{
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(metadata);
using var lockContext = await SemaphoreSlimContext.Lock(instanceStateChangeSemaphore, cancellationToken);
lock (instances)
@@ -471,8 +467,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public async Task<BridgeResponse> ProcessBridgeRequest(BridgeParameters parameters, CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
ArgumentNullException.ThrowIfNull(parameters);
IBridgeHandler bridgeHandler = null;
for (var i = 0; bridgeHandler == null && i < 30; ++i)
@@ -501,8 +496,7 @@ namespace Tgstation.Server.Host.Components
/// <inheritdoc />
public IBridgeRegistration RegisterHandler(IBridgeHandler bridgeHandler)
{
if (bridgeHandler == null)
throw new ArgumentNullException(nameof(bridgeHandler));
ArgumentNullException.ThrowIfNull(bridgeHandler);
var accessIdentifier = bridgeHandler.DMApiParameters.AccessIdentifier;
lock (bridgeHandlers)
@@ -76,8 +76,7 @@ namespace Tgstation.Server.Host.Components.Interop.Bridge
bool apiValidateOnly)
: base(chatTrackingContext?.Channels ?? throw new ArgumentNullException(nameof(chatTrackingContext)))
{
if (dmbProvider == null)
throw new ArgumentNullException(nameof(dmbProvider));
ArgumentNullException.ThrowIfNull(dmbProvider);
ServerVersion = serverVersion ?? throw new ArgumentNullException(nameof(serverVersion));
@@ -47,8 +47,7 @@ namespace Tgstation.Server.Host.Components.Repository
{
this.gitHubServiceFactory = gitHubServiceFactory ?? throw new ArgumentNullException(nameof(gitHubServiceFactory));
if (remoteUrl == null)
throw new ArgumentNullException(nameof(remoteUrl));
ArgumentNullException.ThrowIfNull(remoteUrl);
RemoteRepositoryOwner = remoteUrl.Segments[1].TrimEnd('/');
RemoteRepositoryName = remoteUrl.Segments[2].TrimEnd('/');
@@ -48,8 +48,7 @@ namespace Tgstation.Server.Host.Components.Repository
public GitRemoteFeaturesBase(ILogger<GitRemoteFeaturesBase> logger, Uri remoteUrl)
{
Logger = logger ?? throw new ArgumentNullException(nameof(logger));
if (remoteUrl == null)
throw new ArgumentNullException(nameof(remoteUrl));
ArgumentNullException.ThrowIfNull(remoteUrl);
cachedLookups = new Dictionary<TestMergeParameters, Models.TestMerge>();
}
@@ -60,10 +59,8 @@ namespace Tgstation.Server.Host.Components.Repository
RepositorySettings repositorySettings,
CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
if (repositorySettings == null)
throw new ArgumentNullException(nameof(repositorySettings));
ArgumentNullException.ThrowIfNull(parameters);
ArgumentNullException.ThrowIfNull(repositorySettings);
Models.TestMerge result;
lock (cachedLookups)
@@ -44,8 +44,7 @@ namespace Tgstation.Server.Host.Components.Repository
/// <inheritdoc />
public IGitRemoteFeatures CreateGitRemoteFeatures(IRepository repository)
{
if (repository == null)
throw new ArgumentNullException(nameof(repository));
ArgumentNullException.ThrowIfNull(repository);
var primaryRemote = repository.Origin;
var remoteGitProvider = ParseRemoteGitProviderFromOrigin(primaryRemote);
@@ -66,8 +65,7 @@ namespace Tgstation.Server.Host.Components.Repository
/// <inheritdoc />
public RemoteGitProvider ParseRemoteGitProviderFromOrigin(Uri origin)
{
if (origin == null)
throw new ArgumentNullException(nameof(origin));
ArgumentNullException.ThrowIfNull(origin);
switch (origin.Host.ToUpperInvariant())
{
@@ -20,11 +20,9 @@ namespace Tgstation.Server.Host.Components.Repository
FetchOptions fetchOptions,
string logMessage)
{
if (libGit2Repo == null)
throw new ArgumentNullException(nameof(libGit2Repo));
ArgumentNullException.ThrowIfNull(libGit2Repo);
if (remote == null)
throw new ArgumentNullException(nameof(remote));
ArgumentNullException.ThrowIfNull(remote);
Commands.Fetch((LibGit2Sharp.Repository)libGit2Repo, remote.Name, refSpecs, fetchOptions, logMessage);
}
@@ -40,8 +40,7 @@ namespace Tgstation.Server.Host.Components.Repository
/// <inheritdoc />
public async Task<LibGit2Sharp.IRepository> CreateFromPath(string path, CancellationToken cancellationToken)
{
if (path == null)
throw new ArgumentNullException(nameof(path));
ArgumentNullException.ThrowIfNull(path);
var repo = await Task.Factory.StartNew<LibGit2Sharp.IRepository>(
() =>
@@ -111,8 +110,7 @@ namespace Tgstation.Server.Host.Components.Repository
/// <inheritdoc />
public void CheckBadCredentialsException(LibGit2SharpException exception)
{
if (exception == null)
throw new ArgumentNullException(nameof(exception));
ArgumentNullException.ThrowIfNull(exception);
if (exception.Message == "too many redirects or authentication replays")
throw new JobException("Bad git credentials exchange!", exception);
@@ -154,8 +154,7 @@ namespace Tgstation.Server.Host.Components.Repository
this.eventConsumer = eventConsumer ?? throw new ArgumentNullException(nameof(eventConsumer));
this.credentialsProvider = credentialsProvider ?? throw new ArgumentNullException(nameof(credentialsProvider));
this.postWriteHandler = postWriteHandler ?? throw new ArgumentNullException(nameof(postWriteHandler));
if (gitRemoteFeaturesFactory == null)
throw new ArgumentNullException(nameof(gitRemoteFeaturesFactory));
ArgumentNullException.ThrowIfNull(gitRemoteFeaturesFactory);
this.logger = logger ?? throw new ArgumentNullException(nameof(logger));
this.generalConfiguration = generalConfiguration ?? throw new ArgumentNullException(nameof(generalConfiguration));
@@ -192,14 +191,10 @@ namespace Tgstation.Server.Host.Components.Repository
JobProgressReporter progressReporter,
CancellationToken cancellationToken)
{
if (testMergeParameters == null)
throw new ArgumentNullException(nameof(testMergeParameters));
if (committerName == null)
throw new ArgumentNullException(nameof(committerName));
if (committerEmail == null)
throw new ArgumentNullException(nameof(committerEmail));
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(testMergeParameters);
ArgumentNullException.ThrowIfNull(committerName);
ArgumentNullException.ThrowIfNull(committerEmail);
ArgumentNullException.ThrowIfNull(progressReporter);
logger.LogDebug(
"Begin AddTestMerge: #{prNumber} at {targetSha} ({comment}) by <{committerName} ({committerEmail})>",
@@ -394,10 +389,8 @@ namespace Tgstation.Server.Host.Components.Repository
JobProgressReporter progressReporter,
CancellationToken cancellationToken)
{
if (committish == null)
throw new ArgumentNullException(nameof(committish));
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(committish);
ArgumentNullException.ThrowIfNull(progressReporter);
logger.LogDebug("Checkout object: {committish}...", committish);
await eventConsumer.HandleEvent(EventType.RepoCheckout, new List<string> { committish }, cancellationToken);
await Task.Factory.StartNew(
@@ -424,8 +417,7 @@ namespace Tgstation.Server.Host.Components.Repository
/// <inheritdoc />
public async Task FetchOrigin(string username, string password, JobProgressReporter progressReporter, CancellationToken cancellationToken)
{
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(progressReporter);
logger.LogDebug("Fetch origin...");
await eventConsumer.HandleEvent(EventType.RepoFetch, Enumerable.Empty<string>(), cancellationToken);
await Task.Factory.StartNew(
@@ -472,8 +464,7 @@ namespace Tgstation.Server.Host.Components.Repository
JobProgressReporter progressReporter,
CancellationToken cancellationToken)
{
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(progressReporter);
if (!Tracking)
throw new JobException(ErrorCode.RepoReferenceRequired);
logger.LogTrace("Reset to origin...");
@@ -496,10 +487,8 @@ namespace Tgstation.Server.Host.Components.Repository
public Task ResetToSha(string sha, JobProgressReporter progressReporter, CancellationToken cancellationToken) => Task.Factory.StartNew(
() =>
{
if (sha == null)
throw new ArgumentNullException(nameof(sha));
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(sha);
ArgumentNullException.ThrowIfNull(progressReporter);
logger.LogDebug("Reset to sha: {sha}", sha[..7]);
@@ -524,8 +513,7 @@ namespace Tgstation.Server.Host.Components.Repository
/// <inheritdoc />
public async Task CopyTo(string path, CancellationToken cancellationToken)
{
if (path == null)
throw new ArgumentNullException(nameof(path));
ArgumentNullException.ThrowIfNull(path);
logger.LogTrace("Copying to {path}...", path);
await ioMananger.CopyDirectory(
new List<string> { ".git" },
@@ -564,8 +552,7 @@ namespace Tgstation.Server.Host.Components.Repository
JobProgressReporter progressReporter,
CancellationToken cancellationToken)
{
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(progressReporter);
MergeResult result = null;
Branch trackedBranch = null;
@@ -636,12 +623,9 @@ namespace Tgstation.Server.Host.Components.Repository
bool synchronizeTrackedBranch,
CancellationToken cancellationToken)
{
if (committerName == null)
throw new ArgumentNullException(nameof(committerName));
if (committerEmail == null)
throw new ArgumentNullException(nameof(committerEmail));
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(committerName);
ArgumentNullException.ThrowIfNull(committerEmail);
ArgumentNullException.ThrowIfNull(progressReporter);
if (username == null && password == null)
{
@@ -651,10 +635,8 @@ namespace Tgstation.Server.Host.Components.Repository
logger.LogTrace("Begin Synchronize...");
if (username == null)
throw new ArgumentNullException(nameof(username));
if (password == null)
throw new ArgumentNullException(nameof(password));
ArgumentNullException.ThrowIfNull(username);
ArgumentNullException.ThrowIfNull(password);
var startHead = Head;
@@ -834,8 +816,7 @@ namespace Tgstation.Server.Host.Components.Repository
public Task<DateTimeOffset> TimestampCommit(string sha, CancellationToken cancellationToken) => Task.Factory.StartNew(
() =>
{
if (sha == null)
throw new ArgumentNullException(nameof(sha));
ArgumentNullException.ThrowIfNull(sha);
var commit = libGitRepo.Lookup<Commit>(sha) ?? throw new JobException($"Commit {sha} does not exist in the repository!");
return commit.Committer.When.ToUniversalTime();
@@ -126,10 +126,8 @@ namespace Tgstation.Server.Host.Components.Repository
bool recurseSubmodules,
CancellationToken cancellationToken)
{
if (url == null)
throw new ArgumentNullException(nameof(url));
if (progressReporter == null)
throw new ArgumentNullException(nameof(progressReporter));
ArgumentNullException.ThrowIfNull(url);
ArgumentNullException.ThrowIfNull(progressReporter);
logger.LogInformation("Begin clone {url} (Branch: {initialBranch})", url, initialBranch);
lock (semaphore)
@@ -93,8 +93,7 @@ namespace Tgstation.Server.Host.Components.Session
/// <param name="runtimeInformation">The <see cref="Interop.Bridge.RuntimeInformation"/>.</param>
public void SetRuntimeInformation(RuntimeInformation runtimeInformation)
{
if (runtimeInformation == null)
throw new ArgumentNullException(nameof(runtimeInformation));
ArgumentNullException.ThrowIfNull(runtimeInformation);
lock (runtimeInformationLock)
{
@@ -220,12 +220,10 @@ namespace Tgstation.Server.Host.Components.Session
this.byondLock = byondLock ?? throw new ArgumentNullException(nameof(byondLock));
this.byondTopicSender = byondTopicSender ?? throw new ArgumentNullException(nameof(byondTopicSender));
this.chatTrackingContext = chatTrackingContext ?? throw new ArgumentNullException(nameof(chatTrackingContext));
if (bridgeRegistrar == null)
throw new ArgumentNullException(nameof(bridgeRegistrar));
ArgumentNullException.ThrowIfNull(bridgeRegistrar);
this.chat = chat ?? throw new ArgumentNullException(nameof(chat));
if (assemblyInformationProvider == null)
throw new ArgumentNullException(nameof(assemblyInformationProvider));
ArgumentNullException.ThrowIfNull(assemblyInformationProvider);
this.asyncDelayer = asyncDelayer ?? throw new ArgumentNullException(nameof(asyncDelayer));
@@ -310,8 +308,7 @@ namespace Tgstation.Server.Host.Components.Session
/// <inheritdoc />
public async Task<BridgeResponse> ProcessBridgeRequest(BridgeParameters parameters, CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
ArgumentNullException.ThrowIfNull(parameters);
using (LogContext.PushProperty(SerilogContextHelper.InstanceIdContextProperty, metadata.Id))
{
@@ -346,8 +343,7 @@ namespace Tgstation.Server.Host.Components.Session
/// <inheritdoc />
public async Task<TopicResponse> SendCommand(TopicParameters parameters, CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
ArgumentNullException.ThrowIfNull(parameters);
if (Lifetime.IsCompleted)
{
@@ -390,8 +390,7 @@ namespace Tgstation.Server.Host.Components.Session
ReattachInformation reattachInformation,
CancellationToken cancellationToken)
{
if (reattachInformation == null)
throw new ArgumentNullException(nameof(reattachInformation));
ArgumentNullException.ThrowIfNull(reattachInformation);
logger.LogTrace("Begin session reattach...");
var byondTopicSender = topicClientFactory.CreateTopicClient(reattachInformation.TopicRequestTimeout);
@@ -67,8 +67,7 @@ namespace Tgstation.Server.Host.Components.Session
/// <inheritdoc />
public Task Save(ReattachInformation reattachInformation, CancellationToken cancellationToken) => databaseContextFactory.UseContext(async (db) =>
{
if (reattachInformation == null)
throw new ArgumentNullException(nameof(reattachInformation));
ArgumentNullException.ThrowIfNull(reattachInformation);
logger.LogDebug("Saving reattach information: {info}...", reattachInformation);
@@ -19,8 +19,7 @@ namespace Tgstation.Server.Host.Components.Session
/// <param name="logger">The value of <see cref="logger"/>.</param>
public TopicClientFactory(ILogger<TopicClient> logger)
{
if (logger == null)
throw new ArgumentNullException(nameof(logger));
ArgumentNullException.ThrowIfNull(logger);
// Don't want the debug logs Topic client spits out either, they're too verbose
if (logger.IsEnabled(LogLevel.Trace))
@@ -550,8 +550,7 @@ namespace Tgstation.Server.Host.Components.StaticFiles
/// <inheritdoc />
public async Task HandleEvent(EventType eventType, IEnumerable<string> parameters, CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
ArgumentNullException.ThrowIfNull(parameters);
await EnsureDirectories(cancellationToken);
@@ -214,8 +214,7 @@ namespace Tgstation.Server.Host.Components.Watchdog
this.metadata = metadata ?? throw new ArgumentNullException(nameof(metadata));
this.autoStart = autoStart;
if (serverControl == null)
throw new ArgumentNullException(nameof(serverControl));
ArgumentNullException.ThrowIfNull(serverControl);
chat.RegisterCommandHandler(this);
@@ -452,8 +451,7 @@ namespace Tgstation.Server.Host.Components.Watchdog
/// <inheritdoc />
async Task IEventConsumer.HandleEvent(EventType eventType, IEnumerable<string> parameters, CancellationToken cancellationToken)
{
if (parameters == null)
throw new ArgumentNullException(nameof(parameters));
ArgumentNullException.ThrowIfNull(parameters);
// Method explicitly implemented to prevent accidental calls when this.eventConsumer should be used.
var activeServer = GetActiveController();
@@ -63,12 +63,9 @@ namespace Tgstation.Server.Host.Configuration
IAssemblyInformationProvider assemblyInformationProvider,
IPlatformIdentifier platformIdentifier)
{
if (ioManager == null)
throw new ArgumentNullException(nameof(ioManager));
if (assemblyInformationProvider == null)
throw new ArgumentNullException(nameof(assemblyInformationProvider));
if (platformIdentifier == null)
throw new ArgumentNullException(nameof(platformIdentifier));
ArgumentNullException.ThrowIfNull(ioManager);
ArgumentNullException.ThrowIfNull(assemblyInformationProvider);
ArgumentNullException.ThrowIfNull(platformIdentifier);
var directoryToUse = platformIdentifier.IsWindows
? Environment.GetFolderPath(Environment.SpecialFolder.CommonApplicationData) // C:/ProgramData
@@ -139,8 +139,7 @@ namespace Tgstation.Server.Host.Configuration
/// <param name="logger">The <see cref="ILogger"/> to use.</param>
public void CheckCompatibility(ILogger logger)
{
if (logger == null)
throw new ArgumentNullException(nameof(logger));
ArgumentNullException.ThrowIfNull(logger);
if (ConfigVersion == null)
logger.LogCritical(
@@ -30,8 +30,7 @@ namespace Tgstation.Server.Host.Configuration
/// <param name="oAuthConfiguration">The <see cref="OAuthConfigurationBase"/> to copy settings from.</param>
public OAuthConfigurationBase(OAuthConfigurationBase oAuthConfiguration)
{
if (oAuthConfiguration == null)
throw new ArgumentNullException(nameof(oAuthConfiguration));
ArgumentNullException.ThrowIfNull(oAuthConfiguration);
ClientId = oAuthConfiguration.ClientId;
ClientSecret = oAuthConfiguration.ClientSecret;
}
@@ -202,8 +202,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ErrorMessageResponse), 429)]
public async Task<IActionResult> Update([FromBody] ServerUpdateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var attemptingUpload = model.UploadZip == true;
if (attemptingUpload)
@@ -326,8 +325,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ErrorMessageResponse), 409)]
public async Task<IActionResult> GetLog(string path, CancellationToken cancellationToken)
{
if (path == null)
throw new ArgumentNullException(nameof(path));
ArgumentNullException.ThrowIfNull(path);
path = HttpUtility.UrlDecode(path);
@@ -91,8 +91,7 @@ namespace Tgstation.Server.Host.Controllers
bool requireHeaders)
{
DatabaseContext = databaseContext ?? throw new ArgumentNullException(nameof(databaseContext));
if (authenticationContextFactory == null)
throw new ArgumentNullException(nameof(authenticationContextFactory));
ArgumentNullException.ThrowIfNull(authenticationContextFactory);
Logger = logger ?? throw new ArgumentNullException(nameof(logger));
AuthenticationContext = authenticationContextFactory.CurrentAuthenticationContext;
Instance = AuthenticationContext?.InstancePermissionSet?.Instance;
@@ -103,8 +102,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1506 // TODO: Decomplexify
public override async Task OnActionExecutionAsync(ActionExecutingContext context, ActionExecutionDelegate next)
{
if (context == null)
throw new ArgumentNullException(nameof(context));
ArgumentNullException.ThrowIfNull(context);
// ALL valid token and login requests that match a route go through this function
// 404 is returned before
@@ -245,8 +243,7 @@ namespace Tgstation.Server.Host.Controllers
/// <returns>A <see cref="HttpStatusCode.TooManyRequests"/> <see cref="ObjectResult"/>.</returns>
protected ObjectResult RateLimit(RateLimitExceededException rateLimitException)
{
if (rateLimitException == null)
throw new ArgumentNullException(nameof(rateLimitException));
ArgumentNullException.ThrowIfNull(rateLimitException);
Logger.LogWarning(rateLimitException, "Exceeded GitHub rate limit!");
@@ -357,8 +354,7 @@ namespace Tgstation.Server.Host.Controllers
int? pageSizeQuery,
CancellationToken cancellationToken)
{
if (queryGenerator == null)
throw new ArgumentNullException(nameof(queryGenerator));
ArgumentNullException.ThrowIfNull(queryGenerator);
if (pageQuery <= 0 || pageSizeQuery <= 0)
return BadRequest(new ErrorMessageResponse(ErrorCode.ApiInvalidPageOrPageSize));
@@ -62,8 +62,7 @@ namespace Tgstation.Server.Host.Controllers
public BridgeController(IBridgeDispatcher bridgeDispatcher, IHostApplicationLifetime applicationLifetime, ILogger<BridgeController> logger)
{
this.bridgeDispatcher = bridgeDispatcher ?? throw new ArgumentNullException(nameof(bridgeDispatcher));
if (applicationLifetime == null)
throw new ArgumentNullException(nameof(applicationLifetime));
ArgumentNullException.ThrowIfNull(applicationLifetime);
this.logger = logger ?? throw new ArgumentNullException(nameof(logger));
@@ -133,8 +133,7 @@ namespace Tgstation.Server.Host.Controllers
public async Task<IActionResult> Update([FromBody] ByondVersionRequest model, CancellationToken cancellationToken)
#pragma warning restore CA1506
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var uploadingZip = model.UploadCustomZip == true;
@@ -269,8 +268,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ErrorMessageResponse), 410)]
public async Task<IActionResult> Delete([FromBody] ByondVersionDeleteRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.Version == null
|| model.Version.Revision != -1)
@@ -106,8 +106,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ChatBotResponse), 201)]
public async Task<IActionResult> Create([FromBody] ChatBotCreateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var earlyOut = StandardModelChecks(model, true);
if (earlyOut != null)
@@ -279,8 +278,7 @@ namespace Tgstation.Server.Host.Controllers
public async Task<IActionResult> Update([FromBody] ChatBotUpdateRequest model, CancellationToken cancellationToken)
#pragma warning restore CA1502, CA1506
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var earlyOut = StandardModelChecks(model, false);
if (earlyOut != null)
@@ -88,8 +88,7 @@ namespace Tgstation.Server.Host.Controllers
/// <returns><see langword="true"/> if an unsaved DB update was made, <see langword="false"/> otherwise.</returns>
protected bool ValidateInstanceOnlineStatus(Api.Models.Instance metadata)
{
if (metadata == null)
throw new ArgumentNullException(nameof(metadata));
ArgumentNullException.ThrowIfNull(metadata);
bool online;
using (var instanceReferenceCheck = instanceManager.GetInstanceReference(metadata))
@@ -119,8 +118,7 @@ namespace Tgstation.Server.Host.Controllers
/// <remarks>The context of <paramref name="action"/> should be as small as possible so as to avoid race conditions. This function can return a <see cref="ConflictResult"/> if the requested instance was offline.</remarks>
protected async Task<IActionResult> WithComponentInstance(Func<IInstanceCore, Task<IActionResult>> action)
{
if (action == null)
throw new ArgumentNullException(nameof(action));
ArgumentNullException.ThrowIfNull(action);
using var instanceReference = instanceManager.GetInstanceReference(Instance);
using (LogContext.PushProperty(SerilogContextHelper.InstanceReferenceContextProperty, instanceReference.Uid))
@@ -69,8 +69,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ConfigurationFileResponse), 202)]
public async Task<IActionResult> Update([FromBody] ConfigurationFileRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (ForbidDueToModeConflicts(model.Path, out var systemIdentity))
return Forbid();
@@ -234,8 +233,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ConfigurationFileResponse), 201)]
public async Task<IActionResult> CreateDirectory([FromBody] ConfigurationFileRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (ForbidDueToModeConflicts(model.Path, out var systemIdentity))
return Forbid();
@@ -285,8 +283,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(204)]
public async Task<IActionResult> DeleteDirectory([FromBody] ConfigurationFileRequest directory, CancellationToken cancellationToken)
{
if (directory == null)
throw new ArgumentNullException(nameof(directory));
ArgumentNullException.ThrowIfNull(directory);
if (directory.Path == null)
return BadRequest(new ErrorMessageResponse(ErrorCode.ModelValidationFailure));
@@ -88,8 +88,7 @@ namespace Tgstation.Server.Host.Controllers
/// <inheritdoc />
public override Task OnActionExecutionAsync(ActionExecutingContext context, ActionExecutionDelegate next)
{
if (context == null)
throw new ArgumentNullException(nameof(context));
ArgumentNullException.ThrowIfNull(context);
var newValues = new List<string> { FetchChannelVaryHeader };
var headers = context.HttpContext.Response.Headers;
@@ -158,8 +158,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1506
public async Task<IActionResult> Update([FromBody] DreamDaemonRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.SoftShutdown == true && model.SoftRestart == true)
return BadRequest(new ErrorMessageResponse(ErrorCode.DreamDaemonDoubleSoft));
@@ -177,8 +177,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ErrorMessageResponse), 410)]
public async Task<IActionResult> Update([FromBody] DreamMakerRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.ApiValidationPort == 0)
throw new InvalidOperationException("ApiValidationPort cannot be 0!");
@@ -129,8 +129,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(InstanceResponse), 201)]
public async Task<IActionResult> Create([FromBody] InstanceCreateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (String.IsNullOrWhiteSpace(model.Name))
return BadRequest(new ErrorMessageResponse(ErrorCode.InstanceWhitespaceName));
@@ -328,8 +327,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1502 // TODO: Decomplexify
public async Task<IActionResult> Update([FromBody] InstanceUpdateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
IQueryable<Models.Instance> InstanceQuery() => DatabaseContext
.Instances
@@ -63,8 +63,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1506
public async Task<IActionResult> Create([FromBody] InstancePermissionSetRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var existingPermissionSet = await DatabaseContext
.PermissionSets
@@ -127,8 +126,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1506 // TODO: Decomplexify
public async Task<IActionResult> Update([FromBody] InstancePermissionSetRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var originalPermissionSet = await DatabaseContext
.Instances
@@ -38,8 +38,7 @@ namespace Tgstation.Server.Host.Controllers
/// <inheritdoc />
public override Task ExecuteResultAsync(ActionContext context)
{
if (context == null)
throw new ArgumentNullException(nameof(context));
ArgumentNullException.ThrowIfNull(context);
var executor = context
.HttpContext
@@ -26,11 +26,9 @@ namespace Tgstation.Server.Host.Controllers
/// <inheritdoc />
public async Task ExecuteAsync(ActionContext context, LimitedStreamResult result)
{
if (context == null)
throw new ArgumentNullException(nameof(context));
ArgumentNullException.ThrowIfNull(context);
if (result == null)
throw new ArgumentNullException(nameof(result));
ArgumentNullException.ThrowIfNull(result);
await using (result)
{
@@ -82,8 +82,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(ErrorMessageResponse), 410)]
public async Task<IActionResult> Create([FromBody] RepositoryCreateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.Origin == null)
return BadRequest(ErrorCode.ModelValidationFailure);
@@ -310,8 +309,7 @@ namespace Tgstation.Server.Host.Controllers
public async Task<IActionResult> Update([FromBody] RepositoryUpdateRequest model, CancellationToken cancellationToken)
#pragma warning restore CA1502
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.AccessUser == null ^ model.AccessToken == null)
return BadRequest(new ErrorMessageResponse(ErrorCode.RepoMismatchUserAndAccessToken));
@@ -91,8 +91,7 @@ namespace Tgstation.Server.Host.Controllers
[HttpPost(SwarmConstants.RegisterRoute)]
public async Task<IActionResult> Register([FromBody] SwarmRegistrationRequest registrationRequest, CancellationToken cancellationToken)
{
if (registrationRequest == null)
throw new ArgumentNullException(nameof(registrationRequest));
ArgumentNullException.ThrowIfNull(registrationRequest);
if (registrationRequest.ServerVersion != assemblyInformationProvider.Version)
return StatusCode((int)HttpStatusCode.UpgradeRequired);
@@ -150,8 +149,7 @@ namespace Tgstation.Server.Host.Controllers
[HttpPost]
public IActionResult UpdateNodeList([FromBody] SwarmServersUpdateRequest serversUpdateRequest)
{
if (serversUpdateRequest == null)
throw new ArgumentNullException(nameof(serversUpdateRequest));
ArgumentNullException.ThrowIfNull(serversUpdateRequest);
if (!ValidateRegistration())
return Forbid();
@@ -169,8 +167,7 @@ namespace Tgstation.Server.Host.Controllers
[HttpPut(SwarmConstants.UpdateRoute)]
public async Task<IActionResult> PrepareUpdate([FromBody] SwarmUpdateRequest updateRequest, CancellationToken cancellationToken)
{
if (updateRequest == null)
throw new ArgumentNullException(nameof(updateRequest));
ArgumentNullException.ThrowIfNull(updateRequest);
if (!ValidateRegistration())
return Forbid();
@@ -84,8 +84,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1502, CA1506
public async Task<IActionResult> Create([FromBody] UserCreateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.OAuthConnections?.Any(x => x == null) == true)
return BadRequest(new ErrorMessageResponse(ErrorCode.ModelValidationFailure));
@@ -171,8 +170,7 @@ namespace Tgstation.Server.Host.Controllers
#pragma warning disable CA1506
public async Task<IActionResult> Update([FromBody] UserUpdateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (!model.Id.HasValue || model.OAuthConnections?.Any(x => x == null) == true)
return BadRequest(new ErrorMessageResponse(ErrorCode.ModelValidationFailure));
@@ -67,8 +67,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(UserGroupResponse), 201)]
public async Task<IActionResult> Create([FromBody] UserGroupCreateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
if (model.Name == null)
return BadRequest(new ErrorMessageResponse(ErrorCode.ModelValidationFailure));
@@ -112,8 +111,7 @@ namespace Tgstation.Server.Host.Controllers
[ProducesResponseType(typeof(UserGroupResponse), 200)]
public async Task<IActionResult> Update([FromBody] UserGroupUpdateRequest model, CancellationToken cancellationToken)
{
if (model == null)
throw new ArgumentNullException(nameof(model));
ArgumentNullException.ThrowIfNull(model);
var currentGroup = await DatabaseContext
.Groups
+6 -12
View File
@@ -126,8 +126,7 @@ namespace Tgstation.Server.Host.Core
{
ConfigureServices(services, assemblyInformationProvider, ioManager);
if (postSetupServices == null)
throw new ArgumentNullException(nameof(postSetupServices));
ArgumentNullException.ThrowIfNull(postSetupServices);
// configure configuration
services.UseStandardConfig<UpdatesConfiguration>(Configuration);
@@ -405,24 +404,19 @@ namespace Tgstation.Server.Host.Core
IOptions<SwarmConfiguration> swarmConfigurationOptions,
ILogger<Application> logger)
{
if (applicationBuilder == null)
throw new ArgumentNullException(nameof(applicationBuilder));
if (serverControl == null)
throw new ArgumentNullException(nameof(serverControl));
ArgumentNullException.ThrowIfNull(applicationBuilder);
ArgumentNullException.ThrowIfNull(serverControl);
this.tokenFactory = tokenFactory ?? throw new ArgumentNullException(nameof(tokenFactory));
if (serverPortProvider == null)
throw new ArgumentNullException(nameof(serverPortProvider));
if (assemblyInformationProvider == null)
throw new ArgumentNullException(nameof(assemblyInformationProvider));
ArgumentNullException.ThrowIfNull(serverPortProvider);
ArgumentNullException.ThrowIfNull(assemblyInformationProvider);
var controlPanelConfiguration = controlPanelConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(controlPanelConfigurationOptions));
var generalConfiguration = generalConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(generalConfigurationOptions));
var swarmConfiguration = swarmConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(swarmConfigurationOptions));
if (logger == null)
throw new ArgumentNullException(nameof(logger));
ArgumentNullException.ThrowIfNull(logger);
logger.LogDebug("Content Root: {contentRoot}", hostingEnvironment.ContentRootPath);
logger.LogTrace("Web Root: {webRoot}", hostingEnvironment.WebRootPath);
@@ -32,8 +32,7 @@ namespace Tgstation.Server.Host.Core
ILogger<ServerPortProivder> logger)
{
generalConfiguration = generalConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(generalConfigurationOptions));
if (configuration == null)
throw new ArgumentNullException(nameof(configuration));
ArgumentNullException.ThrowIfNull(configuration);
var httpEndpoint = configuration
.GetSection("Kestrel")
@@ -94,11 +94,9 @@ namespace Tgstation.Server.Host.Core
/// <inheritdoc />
public async Task<ServerUpdateResult> BeginUpdate(ISwarmService swarmService, IFileStreamProvider fileStreamProvider, Version version, CancellationToken cancellationToken)
{
if (swarmService == null)
throw new ArgumentNullException(nameof(swarmService));
ArgumentNullException.ThrowIfNull(swarmService);
if (version == null)
throw new ArgumentNullException(nameof(version));
ArgumentNullException.ThrowIfNull(version);
if (!swarmService.ExpectedNumberOfNodesConnected)
return ServerUpdateResult.SwarmIntegrityCheckFailed;
@@ -109,8 +107,7 @@ namespace Tgstation.Server.Host.Core
/// <inheritdoc />
public async Task<bool> ExecuteUpdate(string updatePath, CancellationToken cancellationToken, CancellationToken criticalCancellationToken)
{
if (updatePath == null)
throw new ArgumentNullException(nameof(updatePath));
ArgumentNullException.ThrowIfNull(updatePath);
var serverUpdateOperation = this.serverUpdateOperation;
if (serverUpdateOperation == null)
@@ -18,8 +18,7 @@ namespace Tgstation.Server.Host.Database
/// <inheritdoc />
public DbConnection CreateConnection(string connectionString, DatabaseType databaseType)
{
if (connectionString == null)
throw new ArgumentNullException(nameof(connectionString));
ArgumentNullException.ThrowIfNull(connectionString);
return databaseType switch
{
@@ -285,8 +285,7 @@ namespace Tgstation.Server.Host.Database
/// <inheritdoc />
public async Task<bool> Migrate(ILogger<DatabaseContext> logger, CancellationToken cancellationToken)
{
if (logger == null)
throw new ArgumentNullException(nameof(logger));
ArgumentNullException.ThrowIfNull(logger);
var migrations = await Database.GetAppliedMigrationsAsync(cancellationToken);
var wasEmpty = !migrations.Any();
@@ -306,8 +305,7 @@ namespace Tgstation.Server.Host.Database
/// <inheritdoc />
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
if (modelBuilder == null)
throw new ArgumentNullException(nameof(modelBuilder));
ArgumentNullException.ThrowIfNull(modelBuilder);
base.OnModelCreating(modelBuilder);
@@ -404,10 +402,8 @@ namespace Tgstation.Server.Host.Database
DatabaseType currentDatabaseType,
CancellationToken cancellationToken)
{
if (logger == null)
throw new ArgumentNullException(nameof(logger));
if (targetVersion == null)
throw new ArgumentNullException(nameof(targetVersion));
ArgumentNullException.ThrowIfNull(logger);
ArgumentNullException.ThrowIfNull(targetVersion);
if (targetVersion < new Version(4, 0))
throw new ArgumentOutOfRangeException(nameof(targetVersion), targetVersion, "Cannot migrate below version 4.0.0!");
@@ -28,8 +28,7 @@ namespace Tgstation.Server.Host.Database
/// <inheritdoc />
public async Task UseContext(Func<IDatabaseContext, Task> operation)
{
if (operation == null)
throw new ArgumentNullException(nameof(operation));
ArgumentNullException.ThrowIfNull(operation);
await using var scope = scopeFactory.CreateAsyncScope();
await operation(scope.ServiceProvider.GetRequiredService<IDatabaseContext>());
@@ -104,8 +104,7 @@ namespace Tgstation.Server.Host.Database
/// <inheritdoc />
public async Task Initialize(IDatabaseContext databaseContext, CancellationToken cancellationToken)
{
if (databaseContext == null)
throw new ArgumentNullException(nameof(databaseContext));
ArgumentNullException.ThrowIfNull(databaseContext);
if (databaseConfiguration.DropDatabase)
{
@@ -134,10 +133,8 @@ namespace Tgstation.Server.Host.Database
/// <inheritdoc />
public Task Downgrade(IDatabaseContext databaseContext, Version downgradeVersion, CancellationToken cancellationToken)
{
if (databaseContext == null)
throw new ArgumentNullException(nameof(databaseContext));
if (downgradeVersion == null)
throw new ArgumentNullException(nameof(downgradeVersion));
ArgumentNullException.ThrowIfNull(databaseContext);
ArgumentNullException.ThrowIfNull(downgradeVersion);
return databaseContext.SchemaDowngradeForServerVersion(
databaseLogger,
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.CreateTable(
name: "Users",
@@ -594,8 +593,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_Jobs_Instances_InstanceId",
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.CreateTable(
name: "Users",
@@ -591,8 +590,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_Jobs_Instances_InstanceId",
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<int>(
name: "ApiValidationSecurityLevel",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ApiValidationSecurityLevel",
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<int>(
name: "ApiValidationSecurityLevel",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ApiValidationSecurityLevel",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_Instances_WatchdogReattachInformations_WatchdogReattachInfor~",
@@ -120,8 +119,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_TestMerges_RevisionInformations_PrimaryRevisionInformationId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_Instances_WatchdogReattachInformations_WatchdogReattachInformationId",
@@ -118,8 +117,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_TestMerges_RevisionInformations_PrimaryRevisionInformationId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ReattachInformations_CompileJobs_CompileJobId",
@@ -38,8 +37,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ReattachInformations_CompileJobs_CompileJobId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ReattachInformations_CompileJobs_CompileJobId",
@@ -38,8 +37,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ReattachInformations_CompileJobs_CompileJobId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<bool>(
name: "PostTestMergeComment",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "PostTestMergeComment",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<bool>(
name: "PostTestMergeComment",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "PostTestMergeComment",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropIndex(
name: "IX_RevisionInformations_CommitSha",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropIndex(
name: "IX_RevisionInformations_InstanceId_CommitSha",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_RevisionInformations_Instances_InstanceId",
@@ -45,8 +44,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_RevisionInformations_Instances_InstanceId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<long>(
name: "ReconnectionInterval",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ReconnectionInterval",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<long>(
name: "ReconnectionInterval",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ReconnectionInterval",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ChatBots_Instances_InstanceId",
@@ -99,8 +98,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ChatBots_Instances_InstanceId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ChatBots_Instances_InstanceId",
@@ -98,8 +97,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_ChatBots_Instances_InstanceId",
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<int>(
name: "ChatBotLimit",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ChatBotLimit",
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<ushort>(
name: "ChatBotLimit",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ChatBotLimit",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ServerCommandsJson",
@@ -38,8 +37,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "DMApiMajorVersion",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ServerCommandsJson",
@@ -38,8 +37,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "DMApiMajorVersion",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ChatChannelsJson",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "LaunchSecurityLevel",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ChatChannelsJson",
@@ -33,8 +32,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "LaunchSecurityLevel",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<long>(
name: "ErrorCode",
@@ -24,8 +23,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ErrorCode",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<uint>(
name: "ErrorCode",
@@ -24,8 +23,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "ErrorCode",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_CompileJobs_Jobs_JobId",
@@ -65,8 +64,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_CompileJobs_Jobs_JobId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_CompileJobs_Jobs_JobId",
@@ -65,8 +64,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_CompileJobs_Jobs_JobId",
@@ -14,8 +14,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.CreateTable(
name: "Instances",
@@ -591,8 +590,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropTable(
name: "ChatChannels");
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<long>(
name: "HeartbeatSeconds",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "HeartbeatSeconds",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<uint>(
name: "HeartbeatSeconds",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "HeartbeatSeconds",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<uint>(
name: "HeartbeatSeconds",
@@ -25,8 +24,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.RenameTable(
name: "DreamDaemonSettings",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.RenameTable(
name: "DreamDaemonSettings",
@@ -55,8 +54,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<string>(
name: "AccessToken",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "AccessToken",
@@ -35,8 +34,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<string>(
name: "AccessToken",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "AccessToken",
@@ -35,8 +34,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<string>(
name: "AccessToken",
@@ -13,8 +13,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.CreateTable(
name: "Instances",
@@ -588,8 +587,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropTable(
name: "ChatChannels");
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_CompileJobs_RevisionInformations_RevisionInformationId",
@@ -31,8 +30,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropForeignKey(
name: "FK_CompileJobs_RevisionInformations_RevisionInformationId",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<long>(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings",
@@ -24,8 +23,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings");
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<uint>(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings",
@@ -24,8 +23,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings");
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<uint>(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings",
@@ -24,8 +23,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.RenameTable(
name: "DreamDaemonSettings",
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.AddColumn<long>(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings",
@@ -24,8 +23,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropColumn(
name: "TopicRequestTimeout",
table: "DreamDaemonSettings");
@@ -12,8 +12,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.DropTable(
name: "WatchdogReattachInformations");
@@ -35,8 +34,7 @@ namespace Tgstation.Server.Host.Database.Migrations
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
if (migrationBuilder == null)
throw new ArgumentNullException(nameof(migrationBuilder));
ArgumentNullException.ThrowIfNull(migrationBuilder);
migrationBuilder.RenameColumn(
name: "Port",

Some files were not shown because too many files have changed in this diff Show More