cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-08-30 00:22:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove support for SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE

Browse Source
This commit is contained in:
Jordan Brown
2018-10-20 14:49:21 -04:00
parent d5a175b834
commit 8e728c3497
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/IO/WindowsSymlinkFactory.cs
+8 -9
View File
@@ -22,19 +22,18 @@ namespace Tgstation.Server.Host.IO
//check if its not a file
var flags = File.Exists(targetPath) ? NativeMethods.CreateSymbolicLinkFlags.None : NativeMethods.CreateSymbolicLinkFlags.Directory;
flags |= NativeMethods.CreateSymbolicLinkFlags.AllowUnprivilegedCreate;
//no don't fucking use this
//sure it works in SOME cases
//i.e. win10 1803+ and IN DEVELOPER MODE
//other times it throws ERROR_INVALID_PARAMETER
//but the fucking worst is there is some configuration of windows that accept the argument and allow the function to succeed
//BUT IT DOESN'T CREATE THE FUCKING LINK
//I AM NOT DEBUGGING THAT SHIT AGAIN AHHH
//flags |= NativeMethods.CreateSymbolicLinkFlags.AllowUnprivilegedCreate;
cancellationToken.ThrowIfCancellationRequested();
if (!NativeMethods.CreateSymbolicLink(linkPath, targetPath, flags))
{
if (Win32Exception.GetLastWin32Error() == Win32Error.ERROR_INVALID_PARAMETER) //SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE isn't supported
{
flags &= ~NativeMethods.CreateSymbolicLinkFlags.AllowUnprivilegedCreate;
if (NativeMethods.CreateSymbolicLink(linkPath, targetPath, flags))
return;
}
throw new Win32Exception();
}
}, cancellationToken, TaskCreationOptions.LongRunning, TaskScheduler.Current);
}
}