Merge pull request #1048 from tgstation/AntiDiscordEmbedSuppoty

Anti discord embed support

build/Version.props

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <!-- This is the authorative version list -->
     <!-- Integration tests will ensure they match across the board -->
-    <TgsCoreVersion>4.3.3</TgsCoreVersion>
+    <TgsCoreVersion>4.3.4</TgsCoreVersion>
     <TgsApiVersion>6.6.0</TgsApiVersion>
     <TgsClientVersion>7.2.0</TgsClientVersion>
     <TgsDmapiVersion>5.2.2</TgsDmapiVersion>

src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs

@@ -337,7 +337,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
 				Title = "Code Deployment",
 				Footer = new EmbedFooterBuilder
 				{
-					Text = "In progress... ETA"
+					Text = $"In progress...{(estimatedCompletionTime.HasValue ? " ETA" : String.Empty)}"
 				},
 				Timestamp = estimatedCompletionTime
 			};
@@ -350,7 +350,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
 			}
 
 			var message = await channel.SendMessageAsync(
-				String.Empty,
+				"DM: Deployment in Progress...",
 				false,
 				builder.Build(),
 				new RequestOptions
@@ -361,7 +361,8 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
 
 			return async (errorMessage, dreamMakerOutput) =>
 			{
-				builder.Footer.Text = errorMessage == null ? "Succeeded" : "Failed";
+				var completionString = errorMessage == null ? "Succeeded" : "Failed";
+				builder.Footer.Text = completionString;
 				builder.Color = errorMessage == null ? Color.Green : Color.Red;
 				builder.Timestamp = DateTimeOffset.Now;
 				builder.Description = errorMessage == null
@@ -394,7 +395,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
 					try
 					{
 						await channel.SendMessageAsync(
-							String.Empty,
+							$"DM: Deployment {completionString}!",
 							false,
 							builder.Build())
 							.ConfigureAwait(false);