cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-08-30 00:22:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve job exception logging

Browse Source
This commit is contained in:
Cyberboss
2018-09-27 15:44:12 -04:00
parent eb8fcc1900
commit b4ebb265ba
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/Core/JobManager.cs
+10 -2
View File
@@ -76,6 +76,7 @@ namespace Tgstation.Server.Host.Core
{
async Task HandleExceptions(Task task)
{
void LogRegularException() => logger.LogDebug("Job {0} exited with error! Exception: {1}", job.Id, job.ExceptionDetails);
try
{
await task.ConfigureAwait(false);
@@ -85,10 +86,17 @@ namespace Tgstation.Server.Host.Core
logger.LogDebug("Job {0} cancelled!", job.Id);
job.Cancelled = true;
}
catch (JobException e)
{
job.ExceptionDetails = e.Message;
LogRegularException();
if (e.InnerException != null)
logger.LogDebug("Inner exception for job {0}: {1}", job.Id, e.InnerException);
}
catch (Exception e)
{
job.ExceptionDetails = e is JobException ? e.Message : e.ToString();
logger.LogDebug("Job {0} exited with error! Exception: {1}", job.Id, job.ExceptionDetails);
job.ExceptionDetails = e.ToString();
LogRegularException();
}
finally
{