cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-07-19 12:04:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix bad GitHub token expiry logic

Browse Source
This commit is contained in:
Jordan Dominion
2026-01-11 15:25:34 -05:00
parent 6649f0f078
commit de9207fb33
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/Utils/GitHub/GitHubClientFactory.cs
+2 -2
View File
@@ -31,7 +31,7 @@ namespace Tgstation.Server.Host.Utils.GitHub
const uint ClientCacheHours = 1;
/// <summary>
/// Minutes before tokens expire before not using them.
/// Minutes before tokens expire before we stop using them for safety.
/// </summary>
const uint AppTokenExpiryGraceMinutes = 15;
@@ -144,7 +144,7 @@ namespace Tgstation.Server.Host.Utils.GitHub
var now = DateTimeOffset.UtcNow;
cacheHit = clientCache.TryGetValue(cacheKey, out var tuple);
var tokenValid = cacheHit && (!tuple.Expiry.HasValue || tuple.Expiry.Value <= now);
var tokenValid = cacheHit && (!tuple.Expiry.HasValue || tuple.Expiry.Value > now);
if (!tokenValid)
{
if (cacheHit)