Fixed warnings from SpacemanDMM (#23123)

code/ATMOSPHERICS/datum_pipe_network.dm

@@ -122,7 +122,7 @@
 
 	return 1
 
-/proc/equalize_gases(datum/gas_mixture/list/gases)
+/proc/equalize_gases(list/datum/gas_mixture/gases)
 	//Perfectly equalize all gases members instantly
 
 	var/datum/gas_mixture/temp = new()

code/WorkInProgress/Cael_Aislinn/scp_173.dm

@@ -216,7 +216,6 @@
 			return
 		visible_message("<span class='danger'>\The [src] starts trying to slide itself into the vent!</span>")
 		sleep(50) //Let's stop SCP-173 for five seconds to do his parking job
-		..()
 		if(entry_vent.network && entry_vent.network.normal_members.len)
 			var/list/vents = list()
 			for(var/obj/machinery/atmospherics/unary/vent_pump/temp_vent in entry_vent.network.normal_members)

code/controllers/garbage.dm

@@ -138,7 +138,7 @@ world/loop_checks = 0
 		return
 
 	if(istype(D, /atom) && !istype(D, /atom/movable))
-		WARNING("qdel() passed object of type [D.type]. qdel() cannot handle unmovable atoms.")
+		warning("qdel() passed object of type [D.type]. qdel() cannot handle unmovable atoms.")
 		del(D)
 		garbageCollector.hard_dels++
 		garbageCollector.dels_count++

code/game/dna/dna2.dm

@@ -389,7 +389,7 @@ var/global/list/facial_hair_styles_female_list	= list()
 
 /proc/EncodeDNABlock(var/value)
 	if(!isnum(value))
-		WARNING("Expected a number, got [value]")
+		warning("Expected a number, got [value]")
 		return 0
 	return num2hex(value, 3)
 

code/game/machinery/computer/communications.dm

@@ -337,7 +337,7 @@ var/global/ports_open = TRUE
 			if (I || isAdminGhost(usr))
 				if(isAdminGhost(usr) || (access_hos in I.access) || (access_heads in I.access && security_level >= SEC_LEVEL_RED))
 					if(ports_open)
-						var/reason = stripped_input(usr, "Please input a concise justification for port closure. This reason will be transmitted to the trader shuttle.", "Nanotrasen Anti-Comdom Systems") as null|text
+						var/reason = stripped_input(usr, "Please input a concise justification for port closure. This reason will be transmitted to the trader shuttle.", "Nanotrasen Anti-Comdom Systems")
 						if(!reason || !(usr in view(1,src)))
 							return
 						log_game("[key_name(usr)] closed the port to traders for [reason].")

code/game/objects/items/stacks/stack.dm

@@ -78,7 +78,7 @@
 		if(istype(E, /datum/stack_recipe))
 			var/datum/stack_recipe/R = E
 			var/max_multiplier = round(src.amount / R.req_amount)
-			var/title as text
+			var/title
 			var/can_build = 1
 			can_build = can_build && (max_multiplier>0)
 
@@ -258,7 +258,7 @@
 		if (amount >= max_amount)
 			to_chat(user, "\The [src] cannot hold anymore [CORRECT_STACK_NAME(src)].")
 			return 1
-		var/to_transfer as num
+		var/to_transfer
 		if (user.get_inactive_hand()==S)
 			to_transfer = 1
 		else

code/game/objects/structures/docking_port.dm

@@ -162,7 +162,7 @@ var/global/list/all_docking_ports = list()
 
 	origin_turf = get_turf(src)
 	//The following few lines exist to make shuttle corners and the syndicate base Less Shit :*
-	if(src.z in (1 to map.zLevels.len))
+	if(src.z in 1 to map.zLevels.len)
 		base_turf_type = get_base_turf(src.z)
 
 	var/datum/zLevel/L = get_z_level(src)

code/modules/admin/topic.dm

@@ -328,7 +328,7 @@
 			if("1")
 				if ((!( ticker ) || emergency_shuttle.location))
 					return
-				var/justification = stripped_input(usr, "Please input a reason for the shuttle call. You may leave it blank to not have one.", "Justification") as text|null
+				var/justification = stripped_input(usr, "Please input a reason for the shuttle call. You may leave it blank to not have one.", "Justification")
 				emergency_shuttle.incall()
 				captain_announce("The emergency shuttle has been called. It will arrive in [round(emergency_shuttle.timeleft()/60)] minutes.[justification ? " Justification : '[justification]'" : ""]")
 				log_admin("[key_name(usr)] called the Emergency Shuttle")

code/modules/admin/verbs/mapping.dm

@@ -41,8 +41,6 @@ var/intercom_range_display_status = 0
 	set category = "Mapping"
 	set name = "-None of these are for ingame use!!"
 
-	..()
-
 /client/proc/camera_view()
 	set category = "Mapping"
 	set name = "Camera Range Display"

code/modules/admin/verbs/randomverbs.dm

@@ -294,7 +294,7 @@ Ccomp's first proc.
 	var/list/mobs = list()
 	var/list/ghosts = list()
 	var/list/sortmob = sortNames(mob_list)                           // get the mob list.
-	/var/any=0
+	var/any=0
 	for(var/mob/dead/observer/M in sortmob)
 		mobs.Add(M)                                             //filter it where it's only ghosts
 		any = 1                                                 //if no ghosts show up, any will just be 0
@@ -912,7 +912,7 @@ Traitors and the like can also be revived with the previous role mostly intact.
 		else
 			return
 
-	var/justification = stripped_input(usr, "Please input a reason for the shuttle call. You may leave it blank to not have one.", "Justification") as text|null
+	var/justification = stripped_input(usr, "Please input a reason for the shuttle call. You may leave it blank to not have one.", "Justification")
 	var/confirm = alert(src, "Are you sure you want to call the shuttle?", "Confirm", "Yes", "Cancel")
 	if(confirm != "Yes")
 		return

code/modules/assembly/logic/comparison.dm

@@ -171,7 +171,7 @@ var/global/list/comparison_circuit_operations = list("EQUAL TO", "LESS THAN", "M
 
 			to_chat(usr, "<span class='info'>Value #1 set to be [check_this]</span>")
 		else if(choice == "Constant string")
-			var/new_txt = stripped_input(usr, "Please type in a string that will be used as value #1.", "\The [src]", max_length = MAX_TEXT_VALUE_LEN) as null|text
+			var/new_txt = stripped_input(usr, "Please type in a string that will be used as value #1.", "\The [src]", max_length = MAX_TEXT_VALUE_LEN)
 
 			if(isnull(new_txt)) return
 			if(..()) return
@@ -237,7 +237,7 @@ var/global/list/comparison_circuit_operations = list("EQUAL TO", "LESS THAN", "M
 
 			to_chat(usr, "<span class='info'>Value #2 set to be [check_against]</span>")
 		else if(choice == "Constant string")
-			var/new_txt = stripped_input(usr, "Please type in a string that will be used as value #2.", "\The [src]", max_length = MAX_TEXT_VALUE_LEN) as null|text
+			var/new_txt = stripped_input(usr, "Please type in a string that will be used as value #2.", "\The [src]", max_length = MAX_TEXT_VALUE_LEN)
 
 			if(isnull(new_txt)) return
 			if(..()) return

code/modules/assembly/logic/write.dm

@@ -106,7 +106,7 @@
 
 		stored_num = choice
 	if(href_list["set_txt_value"])
-		var/choice = stripped_input(usr, "Select a new string value to be stored in \the [src].", "\The [src]", max_length = MAX_TEXT_VALUE_LEN) as null|text
+		var/choice = stripped_input(usr, "Select a new string value to be stored in \the [src].", "\The [src]", max_length = MAX_TEXT_VALUE_LEN)
 
 		if(isnull(choice))
 			return

code/modules/assembly/signaler.dm

@@ -130,9 +130,9 @@
 	if(!radio_connection)
 		return
 
-	if(!(frequency in (MINIMUM_FREQUENCY to MAXIMUM_FREQUENCY)))
+	if(!(frequency in MINIMUM_FREQUENCY to MAXIMUM_FREQUENCY))
 		return
-	if(!(code in (1 to 100)))
+	if(!(code in 1 to 100))
 		return
 
 	var/datum/signal/signal = getFromPool(/datum/signal)

code/modules/atmos_automation/implementation/assemblies.dm

@@ -22,7 +22,7 @@
 /datum/automation/pulse_assembly/GetText()
 	var/T = null
 
-	if(assembly_num in (1 to parent.max_linked_assembly_amount))
+	if(assembly_num in 1 to parent.max_linked_assembly_amount)
 		var/obj/item/device/assembly/A = parent.linked_assemblies[assembly_num]
 
 		if(istype(A))

code/modules/mob/death.dm

@@ -57,7 +57,6 @@
 			L.adjustOxyLoss(max(L.health,200))	//if you die while transmogrified, you die for real
 			L.updatehealth()
 		return
-	return ..(gibbed)
 
 //This proc should be used when you're restoring a guy to life. It will remove him from the dead mob list, and add him to the living mob list. It will also remove any verbs
 //that his dead body has

code/modules/mob/living/carbon/combat.dm

@@ -14,7 +14,7 @@
 			to_chat(src, "<span class='warning'>You fail to catch \the [I]!")
 	return ..()
 
-/mob/living/carbon/proc/can_catch(var/item/I, var/speed)
+/mob/living/carbon/proc/can_catch(var/obj/item/I, var/speed)
 	if(restrained() || get_active_hand())
 		return FALSE
 	if(speed > EMBED_THROWING_SPEED) //Can't catch things going too fast unless you're a special boy

code/modules/mob/living/silicon/silicon.dm

@@ -281,7 +281,7 @@
 	return universal_speak || (speaking in src.speech_synthesizer_langs)	//need speech synthesizer support to vocalize a language
 
 /mob/living/silicon/add_language(var/language_name, var/can_speak=1)
-	var/var/datum/language/added_language = all_languages[language_name]
+	var/datum/language/added_language = all_languages[language_name]
 	if(!added_language) //Are you trying to pull my leg? This language does not exist.
 		return
 
@@ -291,7 +291,7 @@
 		return 1
 
 /mob/living/silicon/remove_language(var/rem_language, var/can_understand=0)
-	var/var/datum/language/removed_language = all_languages[rem_language]
+	var/datum/language/removed_language = all_languages[rem_language]
 	if(!removed_language) //Oh, look. Now you're trying to remove what does not exist.
 		return
 

code/modules/mob/mob_defines.dm

@@ -217,7 +217,7 @@
 	var/mob/living/carbon/LAssailant = null
 
 //Wizard mode, but can be used in other modes thanks to the brand new "Give Spell" badmin button
-	var/spell/list/spell_list = list()
+	var/list/spell/spell_list = list()
 
 //Changlings, but can be used in other modes
 //	var/obj/effect/proc_holder/changpower/list/power_list = list()

code/modules/organs/blood.dm

@@ -12,7 +12,7 @@ var/const/BLOOD_VOLUME_BAD = 224
 var/const/BLOOD_VOLUME_SURVIVE = 122
 
 /mob/living/carbon/human/var/datum/reagents/vessel/vessel	//Container for blood and BLOOD ONLY. Do not transfer other chems here.
-/mob/living/carbon/human/var/var/pale = 0			//Should affect how mob sprite is drawn, but currently doesn't.
+/mob/living/carbon/human/var/pale = 0			//Should affect how mob sprite is drawn, but currently doesn't.
 
 /datum/reagents/vessel/update_total() //Version of this that doesn't call del_reagent
 	total_volume = 0