Merge conflicts, procs instead of macros, mood signals.

code/datums/skills/_skill.dm

@@ -37,6 +37,8 @@ GLOBAL_LIST_INIT_TYPED(skill_datums, /datum/skill, init_skill_datums())
 	var/list/competency_thresholds = list(0, 0, 0)
 	/// Multiplier of the difference of the holder skill value and the selected threshold.
 	var/list/competency_mults = list(0, 0, 0)
+	/// In which way this skil can affect or be affected through actions.
+	var/skill_flags = SKILL_USE_MOOD|SKILL_TRAIN_MOOD
 
 /**
   * Ensures what someone's setting as a value for this skill is valid.

code/datums/skills/_skill_holder.dm

@@ -39,12 +39,16 @@
   * Grabs our affinity for a skill. !!This is a multiplier!!
   */
 /datum/skill_holder/proc/get_skill_affinity(skill)
+	. = 1
 	if(!ispath(skill, /datum/skill))
 		CRASH("Invalid get_skill_affinity call. Use skill typepaths.")	//until a time when we somehow need text ids for dynamic skills, I'm enforcing this.
 	var/affinity = LAZYACCESS(skill_affinities, skill)
-	if(isnull(affinity))
-		return 1
-	return affinity
+	if(!isnull(affinity))
+		. = affinity
+	var/list/wrapped = list(.)
+	SEND_SIGNAL(owner.current, COMSIG_MOB_SKILL_GET_AFFINITY, skill, wrapped)
+	. = wrapped[1]
+
 
 /**
   * Sets the value of a skill.
@@ -89,6 +93,70 @@
 			return
 	boost_skill_value_to(skill, target_value, silent)
 
+/**
+  * Generic value modifier proc that uses one skill.
+  * Args:
+  * * value : the value to modify, may be a delay, damage, probability.
+  * * threshold : The difficulty of the action, in short. Refer to __DEFINES/skills/defines.dm for the defines.
+  * * modifier_is_multiplier : wheter the modifier is a multiplier or a divisor.
+  */
+/datum/skill_holder/proc/action_skills_mod(skill, value, threshold, modifier_is_multiplier = TRUE)
+	var/mod
+	var/datum/skill/S = GLOB.skill_datums[skill]
+	if(!S)
+		return
+	switch(S.progression_type)
+		if(SKILL_PROGRESSION_LEVEL)
+			mod = LAZYACCESS(skill_levels, S.type)
+		else
+			mod = LAZYACCESS(skills, S.type)
+	mod = (1+(mod-S.competency_thresholds[threshold])*S.competency_mults[threshold])
+
+	var/list/comsig_values = list(mod)
+	SEND_SIGNAL(owner.current, COMSIG_MOB_ACTION_SKILL_MOD, args, comsig_values)
+	mod = comsig_values[MOD_VALUES_SKILL_MOD]
+
+	. = modifier_is_multiplier ? value*mod : value/mod
+
+/**
+  * Generic value modifier proc that uses several skills, intended for items.
+  * Args:
+  * * item/I : the item used in this action. its used_skills list variable contains the skills exercised with it.
+  * * value : the value to modify, may be a delay, damage, probability.
+  * * flags : the required flags that each skill (either in I.used_skills or the skill datum skill_flags) must have to influence
+  * * 			the value.
+  * * bad_flags : the opposite of the above, skills that must not be present to impact the value.
+  * * modifier_is_multiplier : wheter the modifier is a multiplier or a divisor.
+  */
+/datum/skill_holder/proc/item_action_skills_mod(obj/item/I, value, flags = NONE, bad_flags = NONE, modifier_is_multiplier = TRUE)
+	. = value
+	var/sum = 0
+	var/divisor = 0
+	var/list/checked_skills
+	for(var/k in I.used_skills)
+		var/datum/skill/S = GLOB.skill_datums[k]
+		if(!S)
+			continue
+		var/our_flags = (I.used_skills[k]|S.skill_flags)
+		if((flags && !(our_flags & flags)) || (bad_flags && our_flags & bad_flags))
+			continue
+		var/mod
+		switch(S.progression_type)
+			if(SKILL_PROGRESSION_LEVEL)
+				mod = LAZYACCESS(skill_levels, S.type)
+			else
+				mod = LAZYACCESS(skills, S.type)
+		sum += 1+(mod - S.competency_thresholds[I.skill_difficulty])*S.competency_mults[I.skill_difficulty]
+		LAZYADD(checked_skills, S)
+
+	var/list/comsig_values = list(sum, divisor, checked_skills)
+	SEND_SIGNAL(owner.current, COMSIG_MOB_ITEM_ACTION_SKILLS_MOD, args, comsig_values)
+	sum = comsig_values[MOD_VALUES_ITEM_SKILLS_SUM]
+	divisor = comsig_values[MOD_VALUES_ITEM_SKILLS_DIV]
+
+	if(divisor)
+		. = modifier_is_multiplier ? value*(sum/divisor) : value/(sum/divisor)
+
 /**
   * Generates a HTML readout of our skills.
   * Port to tgui-next when?

code/datums/skills/engineering.dm

@@ -2,3 +2,4 @@
 	name = "Wiring"
 	desc = "How proficient and knowledged you are at wiring beyond laying cables on the floor."
 	competency_thresholds = list(JOB_SKILL_BASIC, JOB_SKILL_EXPERT, JOB_SKILL_MASTER)
+	skill_flags = SKILL_USE_MOOD|SKILL_TRAIN_MOOD|SKILL_USE_TOOL|SKILL_TRAINING_TOOL