Alt-title access fixes (#17091)

* Alt-title access fixes

* Makes life harder for learners

code/datums/outfits/outfit.dm

@@ -542,10 +542,10 @@
 /datum/outfit/proc/get_id_access(mob/living/carbon/human/H)
 	return list()
 
-/datum/outfit/proc/get_id_assignment(mob/living/carbon/human/H)
+/datum/outfit/proc/get_id_assignment(mob/living/carbon/human/H, var/ignore_suffix = FALSE)
 	. = GetAssignment(H)
 
-	if (. && . != "Unassigned" && H?.mind?.selected_faction)
+	if (. && . != "Unassigned" && H?.mind?.selected_faction && !ignore_suffix)
 		if (H.mind.selected_faction.title_suffix)
 			. += " ([H.mind.selected_faction.title_suffix])"
 

code/game/jobs/job/job.dm

@@ -239,7 +239,7 @@
 	var/datum/job/J = SSjobs.GetJobType(jobtype)
 	if(!J)
 		J = SSjobs.GetJob(H.job)
-	return J.get_access(get_id_assignment(H))
+	return J.get_access(get_id_assignment(H, TRUE))
 
 /datum/outfit/job/get_id_rank(mob/living/carbon/human/H)
 	var/datum/job/J = SSjobs.GetJobType(jobtype)

html/changelogs/doxxmedearly-alt_title_access_fix.yml

@@ -0,0 +1,5 @@
+author: Doxxmedearly
+delete-after: True
+changes:
+  - bugfix: "Corporate reporters once again have their intended basic access to most departments."
+  - bugfix: "Fixed an issue with tech support being unable to access certain program functions."