This has zero reason to exist in our code base. We have no procs or
variables tied to this. I removed it to make future modifications
cleaner.
---------
Signed-off-by: Cody Brittain <1779662+Generalcamo@users.noreply.github.com>
## Description
Hello! First PR here so I figured I'd do a big one ~~and stress out the
maintainers as quickly as possible~~. :)
While going through the process of creating a character the 'faction
select' UI stuck out to me as *functional*, but difficult to parse
visually and pretty dated looking by modern SS13 standards. (Not too
bad, but you know what I mean)
The new version is realistically *bit* too flashy for what it is (a
single-use interface hidden away in the character creation menu), but it
was very good practise for me to get back into DM/TGUI programming so it
works out either way.
I'm very happy to implement any feedback or suggested changes that could
help improve it.
## Actual Description
This PR replaces the old HTML 'faction select' interface with a new TGUI
one, and also cleans up and fixes some adjacent code I bumped into while
working on it.
A couple of notes about the current version:
* The 'Citizenship Check' line is currently non-functional and will
always show a checkmark. I know a lot of the corporations have specific
backgrounds/origins they won't hire people from, but I wasn't sure where
exactly that's enforced in code, if at all.
(I noticed `/datum/faction` has a `blacklisted_citizenship_types`
variable, but it's currently unused.)
* De-adminning or changing species doesn't immediately update the UI to
reflect the changes, you have to click on something new to trigger an
update manually. This doesn't have any actual consequences since I made
sure to sanitise everything, but it is a visual thing.
## Screenshots
<details><summary><b>Collapsed so it doesn't take up so much
room:</b></summary>
### Before
<img width="752" height="482" alt="xziPCYXbkn"
src="https://github.com/user-attachments/assets/334e0609-c2e3-4a33-92ad-15120b78ab35"
/>
### After
<img width="900" height="645" alt="NT"
src="https://github.com/user-attachments/assets/476702c7-c83c-4fee-a2cd-34d912468903"
/>
### Unathi attempting to join Zeng-Hu (Button disabled)
<img width="900" height="645" alt="Unathi fail"
src="https://github.com/user-attachments/assets/c5a256c1-5531-4cbe-8198-27411c1aab9a"
/>
### Faction Pages
<details><summary><b>Stellar Corporate Conglomerate</b></summary>
<img width="900" height="645" alt="SCC"
src="https://github.com/user-attachments/assets/6e8bdb64-a220-41d4-a503-1268f9f93a30"
/>
</details>
<details><summary><b>Nanotrasen</b></summary>
<img width="900" height="645" alt="NT"
src="https://github.com/user-attachments/assets/1ff107b5-7b3e-40e2-8f86-390ce29e165b"
/>
</details>
<details><summary><b>Hephaestus Industries</b></summary>
<img width="900" height="645" alt="HI"
src="https://github.com/user-attachments/assets/6fc23159-990d-4de2-9745-827e11ca0442"
/>
</details>
<details><summary><b>Idris Incorporated</b></summary>
<img width="900" height="645" alt="II"
src="https://github.com/user-attachments/assets/366a9824-81f1-4dd1-b385-4fa3968e39e0"
/>
</details>
<details><summary><b>Orion Express</b></summary>
<img width="900" height="645" alt="OE"
src="https://github.com/user-attachments/assets/5588f0fe-d6c3-44b4-8297-cca4ed991bd8"
/>
</details>
<details><summary><b>Private Military Contracting Group</b></summary>
<img width="900" height="645" alt="PMCG"
src="https://github.com/user-attachments/assets/a3dc6540-bfde-4fb2-939d-11e066b1e316"
/>
</details>
<details><summary><b>Zavodskoi Interstellar</b></summary>
<img width="900" height="645" alt="ZI"
src="https://github.com/user-attachments/assets/a8c2c33d-7138-4164-a9f1-6a2dc3eb3e61"
/>
</details>
<details><summary><b>Zeng-Hu Pharmaceuticals</b></summary>
<img width="900" height="645" alt="ZHP"
src="https://github.com/user-attachments/assets/4535ba80-efcb-4e50-9396-299bc16db2b5"
/>
</details>
<details><summary><b>Independent</b></summary>
<img width="900" height="645" alt="Independent"
src="https://github.com/user-attachments/assets/dcf7b46c-edce-4104-a4f5-000479a9f963"
/>
</details>
<hr>
</details>
## Changelog
- rscadd: "Revamped the 'Faction Select' UI in the occupation menu of
character setup."
- bugfix: "Fixed changing species in character setup not resetting your
faction if it became invalid."
- Not player-facing:
- Fixed the TGUI dev server not working by bumping up the 'source-map'
version. You still have to manually refresh the interface with Ctrl+R or
Ctrl+F5 but it actually links now.
- Added a `wiki_page` variable to each faction to allow for it to be
manually set rather than being exclusively based on the name. (Mostly
just futureproofing)
- Added some line breaks to the faction descriptions to make them more
easily readable.
---------
Signed-off-by: SabreML <57483089+SabreML@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Nothing player-facing in this one, for now. This adds the ability for
factions to be unavailable for certain citizenships.
It has been implemented as a blacklist due to the variety of
citizenships in the game. An example would be if the DPRA was added to
the list for Idris, then anybody with a DPRA citizenship would be unable
to select Idris as their faction.
This was done for the taj lore team.
---------
Signed-off-by: Casper3667 <8396443+Casper3667@users.noreply.github.com>
Co-authored-by: SleepyGemmy <99297919+SleepyGemmy@users.noreply.github.com>
FORUM THREAD:
https://forums.aurorastation.org/topic/20580-assistant-overhaul/#comment-179129
This one will probably need a wiki change or two.
The Assistant Overhaul! A.K.A "FlamingLily commits to coding something
and forgets for six months"
Also, the "Lab Assistant" (Science's learner role) has been renamed to
"Research Intern" with alt-titles to match, in the same vein as the
medical intern. This serves the dual role of clarifying the role's
nature as a departmental learner, AND makes space for the assistant alt
title.
This PR adds four new titles to the Assistant role, complete with access
and loadouts to match.
* Wait Staff: This one's pretty self explanatory. They haul food and
drinks FROM the kitchen and bar TO customers. They do not cook, and do
not get kitchen or bar access.
* Technical Assistant: This one's job is to haul crates and parts for
engineers. They get access to engineering's lobby and main hallways (as
far as a Janitor can get), but otherwise get nothing. They CANNOT start
the engines, shields, atmosphere, or anything. They spawn with a
high-vis vest and a debugger, for token vending-machine fixing efforts.
* Lab Assistant: This one's job is to haul crates and equipment for
scientists. They get access to ACCESS_RESEARCH which is like, two doors
in the research meeting room and not even the hallway outside I think
(idk). They also get a labcoat and safety goggles. For safety.
* Medical Orderly: This one's job is to haul equipment and corpses,
clean up a messy GTR, and stay out of medical's way when an alert is
called. Maybe they can man the reception as well. They spawn with a
labcoat and sterilizine (not even cleaner, because it's funnier that
way.)
I want to insist that these are assistant alt titles, and not roles with
responsibilities. They cannot do repairs, they cannot do science, they
cannot do surgery, and they CERTAINLY can't cook.
Changelog:
- rscadd: "Added four new assistant alt titles: Wait Staff, Technical
Assistant, Lab Assistant, and Medical Orderly (These are still
ASSISTANTS, and cannot perform the relevant departmental skills. These
are also different from learner roles, such as the Interns.)"
- rscadd: "Renamed the existing "Lab Assistant" (The learner role) to
"Research Intern" to better represent the intent for the role and to
make space for the alt title."
---------
Signed-off-by: FlamingLily <80451102+FlamingLily@users.noreply.github.com>
Assistants can take faction coloured items from the loadout, so I don't
see why they shouldn't be able to have faction coloured backpacks as
well.
---------
Signed-off-by: Tag114 <118570749+Tag114@users.noreply.github.com>
This resolves every issue I could eyeball with Vaurca Attendants.
Added to every ghostrole where they're appropriate, mostly wherever
warriors are. Included as non-combatants in the TCAF ghostspawn.
Added to every list for species-specific loadout items and augments, so
they should be able to select them now.
Added to every job blacklist warriors were already on, most notably so
you can't join as a consular officer or corporate representative.
Accounts for attendants with a lot of admin outfits and ERT spawns.
Resolves https://github.com/Aurorastation/Aurora.3/issues/19974
Basically, Attendants are now a subspecies of Warriors instead of a
subspecies of Workers, meaning they carry most of the traits over from
Warriors aside from the ones that have been modified by me. They also
have a unique appearance that should still work with Vaurca clothing,
instead of needing adjustments a la Bulwark. Hopefully, an acceptable
alternative to the Attendant subspecies that was previously offered in
#17550.
@desvenlafaxine
Adds the event service job used in New Blades so far, as well as unique
outfits for event jobs to make giving them different gear easier for
future devs.
This re-adds the Anomalist alt-title for Xenoarchaeologist, alongside
some uniforms for them (They're just Xenoarch radios and uniforms which
are renamed to say "Anomalist")
The justification for this is that Xenoarchaeology and Anomaly research
are pretty distinct mechanically and lorewise. This isn't to say
necessarily that a Xenoarchaeologist is incapable of doing research on
anomalies or vise versa, and I don't want to tell people that they
can't!
However, I would like to have a way for Science characters with
specialisations in anomaly research to be able to distinguish themselves
from Xenoarchaeology, because their field wouldn't really have much to
do with doing anthropological research or fossils or archaeology,
really.
This PR brings back the more accurate title for First Responders, of
Paramedic, to bring it in line with some snippets of the SOP and to be
more accurate to the role itself, as both Security Officers and the rare
and elusive Firefighting Atmospherics Technician can be considered first
responders.
also I just like it better.
Changes any mentions of first responder in gear/access/etc to Paramedic
or PARAMEDIC where applicable.
* SSatlas.current_map
* hardsuit spell tab appears to clear correctly
* sdfsa
* from the moment i understood the weakness of my flesh, it disgusted me
* sdf
* The Pumped Up Kicks Update
Shoes. New shoes. Look at them.
* WELCOME TO THE UNDERGROUND
* for the love of crust
* turns out a var already existed for that but was never implemented ffs
* face it you're never going to make it
* these are winter boots
* removes Paradox's Thinly Veiled Fetish
* shiit
* Apply suggestions from code review
* Update code/modules/clothing/shoes/oxfords.dm
Co-authored-by: Cody Brittain <cbrittain10@yahoo.com>
* oops
* fuck this file
* nice balls, bro
* check out how hard i can pee
* pissing on the moon
* caligaeae
* pee pee poo poo man
* fixes
* damn you
* merge fixes
* knees more
* damn you merge conflict
* fix
* fixes 2
* riding boots
* truly, this fixes things
* dammit ctrl s
---------
Co-authored-by: Cody Brittain <cbrittain10@yahoo.com>
* Added apprentice alt-titles for Security and Engineering
* CL
* Update html/changelogs/GeneralCamo - Cadet Alt Titles.yml
* Fix build
* Added age restrictions for intern alt-titles per code review
* Fix missing parameter in character setup (broke per-species alt title age restrictions)
