Fixes the /client/Move check for zoomed entities to check for pixel displacement, and not just view displacement itself (since the binoculars don't change view size)
Fixes#5689
Adds atmos_canpass = CANPASS_NEVER to the emergency shields you put up to seal breaches.
Converts a bunch of 0's and 1's to TRUE and FALSE for easier readability.
First, the bugfixes:
Ovens, fryers, and similar devices that "require preheat" now actually require preheat before cooking.
Oven trays no longer duplicate messages when inserted.
Oven/fryer temperature efficiency now correctly plays a role in time-to-cook.
Ovens and fryers now draw the correct amount of power.
Upgrading an oven or fryer's scanner module no longer reduces its heat output.
While not exactly a bug, removed an unneeded proc here and there as well as replaced most initial vars with initial() counterparts
Now, the tweaks - I tried to keep these light, since I was really just here to fix bugs and get the existing functionality working. However, compared to the status quo of cooking, actually getting the intended system working would have basically been a massive nerf; before now, cooking_power was locked at 1.4 throughout the "heating process"; now, after tweaks, you start at around 0.48 and end at 1.2.
Heating power increased and resistance reduced so that both machines should preheat in about ten minutes, as opposed to 30-60.
In addition, once they are usable, ovens and fryers will start at 40% efficiency, rather than climbing from 0% after the initial time-lock.
Efficiency is now based on a linear scale of temperature to optimal temperature. This is mostly because it was the simplest way to implement the starting efficiency once preheating is finished.
Upgrading oven/fryer components is now much more rewarding. I may have overdone the numbers a bit, but on the other hand - there should probably be some reward for bothering to upgrade the stove of all things.
The other conclusion I came to (but didn't implement) was the thought that one time-lock should go; either efficiency starts at 0% but you can cook from the beginning, or you have to wait for the preheat cycle and then there's no efficiency to worry about. Obviously, I prefer the former.
Resolves#2836, resolves#4226, resolves#4266, and resolves#4366.
Race condition between copying and printing solved, no longer does the photocopier print half the requested copies.
You can no longer infinitely tear off copies of carbon copies. Additionally, copies have their remove-copy verb removed.
Copying paper bundles in the photocopier now works at the correct speed. Additionally, the bug mentioned in #4266 has been removed.
You can now write to papers inside paper bundles once again.
Most of this section could honestly do with a revamp, but I'm not exactly the person to do that, and we are talking about paperwork of all things. This just gets the functionality working again, more or less.
Fixes#7122 - basically just makes IsJobAvailable() check for the player's selected alt-title rather than just the main title, so you can late-join as an 18-year-old medical intern again for example
Also first PR apologies in advance
Zeng-Hu xenobiology outfits didn't inherit properly from normal station xenobiologists, meaning they spawned with standard, non-science headsets and no labcoats. This PR fixes that.
Closes#7111
Job age requirements now take into account alt titles. Alt titles are automatically limited to only ones a character is old enough for.
The latejoin screen now shows what alt-title you have selected.
The occupation preferences screen now functions differently if only one alt-title is available, or if the base job is not available.
Tidies up the job age requirement system.
Revives #5809
Chances of getting antag:
Security Officer: 50% chance to get antag.
Security Cadet: 75% chance to get antag.
Warden: 40% chance to get antag.
Detective: 50% chance to get antag.
Forensic Technician 50% chance to get antag.
Heads of Staff: 25% chance to get antag.
Antags affected:
Changeling
Traitor
Vampire
Cultist
Revolutionary
Loyalist
tweak: "You can finally move through medical laptops. They're no longer impenetrable, indestructable anchors."
imageadd: "Updates sprites of medical laptops and guest pass terminals."
Adds Dominia, SOL, The Frontier Alliance, and Moghes as citizenship choices for Dionae.
Adds The Tribunal, Th'akh, and Sk'akh as religion choices for Dionae.
Shocker circuits had a complexity of 10, zero power draw per use, and general crap that allowed you to stack 9 of them inside a single device. Did they need a straight deleted from the code? Nah. They need some adjustment and I'll figure out how to do that.
They should be at least somewhat better then a stun baton, but they'll be a pain in the ass to keep charged if you're using them. Perhaps I'll figure out how to limit it by only allowing a single of these circuits into a device.
