mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-08-25 05:51:56 +01:00
0a16ab6564
* Please describe the intent of your changes in a clear fashion. This PR addresses issue SERVER-PROD-12K by correcting a hard delete warning related to `/mob/living/simple_animal/hostile/carp` during the carp migration event. Previously, in `code/modules/events/carp_migration.dm`, the `end()` proc was calling `qdel(carp_weakref)` instead of `qdel(fish)`. This meant the weakref datum was being deleted, but the actual carp mob was left without a proper `qdel()` call, leading to BYOND's garbage collector performing a 'hard delete' and logging a warning. The fix changes `qdel(carp_weakref)` to `qdel(fish)` on line 103, ensuring the carp mob is correctly soft-deleted when the event ends. * Please make sure that, in the case of mapping changes, you include images of these changes in the PR's description. (No mapping changes in this PR) * Please make sure to mark your PR as wip or review required by making a comment with !wip or !review required * If you include sprites/sounds/... (assets) that you have not created yourself specify the license and original author below. * Ensure that you also credit them in the appropriate location / changelog as specified in the contributor guidelines ### Asset Licenses The following assets that **have not** been created by myself are included in this PR: | Path | Original Author | License | | --- | --- | --- | | icons/example.dmi | ExamplePerson (Example Station) | CC0 | (No new assets included in this PR) Fixes [SERVER-PROD-12K](https://aurorastation.sentry.io/issues/7522667244/?seerDrawer=true) --------- Co-authored-by: VMSolidus <evilexecutive@gmail.com>