[MIRROR] Fixes a bug with drifting improperly stopping [MDB IGNORE] (#18626)

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 20:48:56 +01:00

* Fixes a bug with drifting improperly stopping (#72588)

## About The Pull Request

You would hold a direction when you hit a wall, step, have the newt move
blocked by your still living component, and then sit there floating In
the last fix I did here I removed an unregister off loop pausing, which
was leading to conflicting component additions and so runtimes.

I've moved it to an unreg off loop deletion only, to avoid the old
runtime and still preserve the existing desired behavior

## Why It's Good For The Game

Fixes stepping after a drift movement. It looked really dumb and now
it's gone
Fixes https://github.com/tgstation/tgstation/issues/71454

## Changelog
🆑
fix: You can now properly start drifting after moving out of a drift
/🆑

* Fixes a bug with drifting improperly stopping

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>

This commit is contained in:

SkyratBot

2023-01-10 07:33:18 -08:00

committed by

GitHub

co-authored by

LemonInTheDark

parent fe6547cf49

commit 581b38c1a8

1 changed files with 1 additions and 0 deletions

code/datums/components/drift.dm

View File

@@ -127,6 +127,7 @@
 /datum/component/drift/proc/loop_death(datum/source)
 	SIGNAL_HANDLER
 	drifting_loop = null
 	UnregisterSignal(parent, COMSIG_MOVABLE_NEWTONIAN_MOVE) // We won't block a component from replacing us anymore
 /datum/component/drift/proc/handle_move(datum/source, old_loc)
 	SIGNAL_HANDLER