Apply suggestions from code review

thanks rohesie

Co-Authored-By: Rohesie <rohesie@gmail.com>
This commit is contained in:
Fikou
2020-03-19 22:17:42 +01:00
committed by GitHub
co-authored by Rohesie
parent ad30ba217c
commit 604a331213
3 changed files with 8 additions and 7 deletions
+1 -1
View File
@@ -3,7 +3,7 @@
desc = "Exosuit"
icon = 'icons/mecha/mecha.dmi'
density = TRUE //Dense. To raise the heat.
opacity = 1 //opaque. Menacing.
opacity = TRUE //opaque. Menacing.
move_force = MOVE_FORCE_VERY_STRONG
move_resist = MOVE_FORCE_EXTREMELY_STRONG
resistance_flags = FIRE_PROOF | ACID_PROOF
+5 -5
View File
@@ -21,7 +21,7 @@
/obj/mecha/working/clarke/Initialize()
. = ..()
box = new /obj/structure/ore_box(src)
var/obj/item/mecha_parts/mecha_equipment/ME = new /obj/item/mecha_parts/mecha_equipment/orebox_manager(src)
var/obj/item/mecha_parts/mecha_equipment/orebox_manager/ME = new(src)
ME.attach(src)
/obj/mecha/working/clarke/Destroy()
@@ -39,7 +39,7 @@
var/mob/living/L = occupant
var/datum/atom_hud/hud = GLOB.huds[DATA_HUD_DIAGNOSTIC_ADVANCED]
hud.remove_hud_from(L)
..()
return ..()
/obj/mecha/working/clarke/mmi_moved_inside(obj/item/mmi/M, mob/user)
. = ..()
@@ -68,13 +68,13 @@
/obj/item/mecha_parts/mecha_equipment/orebox_manager/detach()
hostmech = null //just in case
. = ..()
return ..()
/obj/item/mecha_parts/mecha_equipment/orebox_manager/Topic(href,href_list)
..()
. = ..()
if(!hostmech || !hostmech.box)
return
hostmech.box.dump_box_contents()
/obj/item/mecha_parts/mecha_equipment/orebox_manager/get_equip_info()
return "[..()] [hostmech?.box?"<a href='?src=[REF(src)];mode=0'>Unload Cargo</a>":"Error"]"
return "[..()] [hostmech?.box ? "<a href='?src=[REF(src)];mode=0'>Unload Cargo</a>" : "Error"]"
+2 -1
View File
@@ -196,7 +196,8 @@
if(lavaland_equipment_pressure_check(T))
step_in = fast_pressure_step_in
for(var/obj/item/mecha_parts/mecha_equipment/drill/drill in equipment)
drill.equip_cooldown = initial(drill.equip_cooldown)/2
drill.equip_cooldown = initial(drill.equip_cooldown) * 0.5
else
step_in = slow_pressure_step_in
for(var/obj/item/mecha_parts/mecha_equipment/drill/drill in equipment)