cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 05:00:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix random job assignments occasionally assigning to roles that were already filled (#64734)

Browse Source 
Missing continue in the random job assignment code meant an if statement was ineffective, code fell through and assigned roles to jobs that were already full.
This commit is contained in:
Timberpoes
2022-02-09 17:46:27 -06:00
committed by GitHub
parent 9d2cba67db
commit 9220e5ef71
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/controllers/subsystem/job.dm
+1
View File
@@ -241,6 +241,7 @@ SUBSYSTEM_DEF(job)
if((job.current_positions >= job.spawn_positions) && job.spawn_positions != -1)
JobDebug("GRJ job lacks spawn positions to be eligible, Player: [player], Job: [job]")
continue
if(istype(job, GetJobType(overflow_role))) // We don't want to give him assistant, that's boring!
JobDebug("GRJ skipping overflow role, Player: [player], Job: [job]")