[MIRROR] Fiox firebots extinguishing themselves while also not on fire (fixes #71390) [MDB IGNORE] (#18825)

Fiox firebots extinguishing themselves while also not on fire (fixes #71390) (#72707)

Firebots returned themselves if they found themselves in the
`process_scan()` override. The override usually checks to see if the
found target is on fire, to then extinguish it. This leads to the
firebots attempting to constantly extinguish themselves.

I'm not sure why this behaviour was here, as the other bots don't seem
to return themselves in their `process_scan()` overrides. If someone has
any insights on why this should be here and I should fix it differently,
go ahead. The only alternative I see right now would be to return `null`
on finding that the current scan object is `src`, which would shorten
the program path a little.

Co-authored-by: Inari-Whitebear <inari_whitebear@fastmail.jp>
This commit is contained in:
SkyratBot
2023-01-19 16:11:23 -05:00
committed by GitHub
co-authored by Inari-Whitebear
parent c760326d93
commit d01ee3e7a6
@@ -253,8 +253,6 @@
//Look for burning people or turfs around the bot
/mob/living/simple_animal/bot/firebot/process_scan(atom/scan_target)
if(scan_target == src)
return src
if(!is_burning(scan_target))
return null