queued_rulesets list uses proc to unqueue (#94843)

## About The Pull Request

Makes unqueue'ing rulesets use a `unqueue_ruleset()` proc, just like
`queue_ruleset()`
Takes singletons instead of type paths.

## Why It's Good For The Game

Consistently uses these procs when adding or removing rulesets from the
queue. There was already a proc for adding, so having one for removing
suits. This PR removes any case of directly editing the
`queued_rulesets` list. This should make the code cleaner, among other
things.

## Changelog

🆑
code: Adding or removing rulesets from the queue list is done by procs
instead of directly editing the list.
/🆑

code/controllers/subsystem/dynamic/dynamic.dm

@@ -140,7 +140,8 @@ SUBSYSTEM_DEF(dynamic)
 	// put rulesets in the queue (if admins didn't)
 	// this will even handle the case in which the tier wants 0 roundstart rulesets
 	if(!length(queued_rulesets))
-		queued_rulesets += pick_roundstart_rulesets(antag_candidates)
+		for(var/ruleset_typepath in pick_roundstart_rulesets(antag_candidates))
+			queue_ruleset(ruleset_typepath)
 	// we got what we needed, reset so we can do real job selection later
 	// reset only happens AFTER roundstart selection so we can verify stuff like "can we get 3 heads of staff for revs?"
 	SSjob.reset_occupations()
@@ -150,7 +151,7 @@ SUBSYSTEM_DEF(dynamic)
 		// NOTE: !! THIS CAN SLEEP !!
 		if(!ruleset.prepare_execution( num_real_players, antag_candidates ))
 			log_dynamic("Roundstart: Selected ruleset [ruleset.config_tag], but preparation failed! [ruleset.log_data]")
-			queued_rulesets -= ruleset
+			unqueue_ruleset(ruleset)
 			qdel(ruleset)
 			continue
 
@@ -459,7 +460,7 @@ SUBSYSTEM_DEF(dynamic)
 			continue
 		message_admins("Latejoin (forced): [ADMIN_LOOKUPFLW(latejoiner)] has been selected for [queued.config_tag].")
 		log_dynamic("Latejoin (forced): [key_name(latejoiner)] has been selected for [queued.config_tag].")
-		queued_rulesets -= queued
+		unqueue_ruleset(queued)
 		executed_rulesets += queued
 		queued.execute()
 		return
@@ -539,6 +540,15 @@ SUBSYSTEM_DEF(dynamic)
 
 	queued_rulesets += new ruleset_typepath(dynamic_config)
 
+/**
+ * Unqueues a ruleset because it has executed
+ */
+/datum/controller/subsystem/dynamic/proc/unqueue_ruleset(datum/dynamic_ruleset/ruleset)
+	if(!istype(ruleset, /datum/dynamic_ruleset/latejoin) && !istype(ruleset, /datum/dynamic_ruleset/roundstart))
+		CRASH("queue_ruleset() was called with an invalid type: [ruleset.type]")
+
+	queued_rulesets -= ruleset
+
 /**
  * Get the cooldown between attempts to spawn a ruleset of the given type
  */
@@ -638,7 +648,7 @@ SUBSYSTEM_DEF(dynamic)
 		var/datum/dynamic_ruleset/to_remove = locate(href_list["admin_dequeue"]) in queued_rulesets
 		if(!istype(to_remove))
 			return
-		queued_rulesets -= to_remove
+		unqueue_ruleset(to_remove)
 		qdel(to_remove)
 		message_admins(span_adminnotice("[key_name_admin(usr)] [to_remove.config_tag] from the latejoin queue."))
 		log_admin("[key_name(usr)] removed [to_remove.config_tag] from the latejoin queue.")

code/controllers/subsystem/dynamic/dynamic_admin.dm

@@ -116,7 +116,7 @@ ADMIN_VERB(dynamic_panel, R_ADMIN, "Dynamic Panel", "Mess with dynamic.", ADMIN_
 			var/datum/dynamic_ruleset/ruleset = SSdynamic.queued_rulesets[index]
 			if(!ruleset)
 				return
-			SSdynamic.queued_rulesets -= ruleset
+			SSdynamic.unqueue_ruleset(ruleset)
 			message_admins("[key_name_admin(ui.user)] removed [ruleset.config_tag] from the dynamic ruleset queue.")
 			log_admin("[key_name_admin(ui.user)] removed [ruleset.config_tag] from the dynamic ruleset queue.")
 			qdel(ruleset)

code/controllers/subsystem/ticker.dm

@@ -303,7 +303,7 @@ SUBSYSTEM_DEF(ticker)
 	// Spawn traitors and stuff
 	for(var/datum/dynamic_ruleset/roundstart/ruleset in SSdynamic.queued_rulesets)
 		ruleset.execute()
-		SSdynamic.queued_rulesets -= ruleset
+		SSdynamic.unqueue_ruleset(ruleset)
 		SSdynamic.executed_rulesets += ruleset
 	// Queue roundstart intercept report
 	if(!CONFIG_GET(flag/no_intercept_report))