Weather has been refactored from a weather control machine on the lavaland z-level into a subsystem. All existing weather has been changed to accommodate this change, and their code has been optimized by using addtimer() instead of sleep().
The new subsystem also supports adding weather to any z-level; for instance, if you made a weather called /datum/weather/rain_storm and made it target z-level 3 with a 100% probability, the rain storm would occur as much as possible with 5-10 minute intermissions. These intermissions take into account the weather's duration.
I see people saying that they often miss the actual question, even if they see the action button later.
This should make the action button more actionable.
Basically, they key difference between StonedMC and CarnMC is that when multiple ticks want to run at the same byond tick, we divvy up the tick between the subsystems, rather then allow one subsystem to hog it all.
The key difference between StonedMC and GoonPS is that we allow the subsystems to tell us how to divvy up the tick using flags and priority.
The new SS_ flags allows us to select behaviors that used to be piggybacked as side effects of dynamic wait or default but sometimes unneeded behavior.
Dynamic wait is 100% gone, lower priority and SS_BACKGROUND are better more refined ways of doing this when combined with MC_TICK_CHECK
I have by design never looked at the inners of goonPS, so this is all original code but I know it uses two loops because of comments by goon devs on reddit threads, that design didn't make sense before, but when I can tell a SS how much of a byond tick it is allowed to have, knowing how many need to run this tick is helpful I also know a bit more about how it works from piecing together comments in #vgstation.
Detailed list of changes:
Subsystems now have flags, allowing fine grain control over things like rather or not it processes, inits, rather it's wait is how long between runs (post run timing) or how long between starts, and rather or not late fires should cause the next fire to be earlier.
Mc now has two loops One loop handles queuing shit, one loop handles running shit.
MC now splits up tick allotment rather than first come first serve Subsystems can even request a bigger share using higher priorities. (It will even resume subsystems it paused if other subsystems hadn't used as much as it predicted they might need)
Default fps is now 20 This is related enough to the MC and it's a change that's really long since over due
All code oddities are most likely to be necessities to lower overhead on the mc since it runs every tick
* Starting out on our tgui journey
* God tgui, why do you need to be updated
You're dynamically generated anyway
* Commit of stuff
* Further progress is being made
* Everyone loves buildscripts
* Further modifications to my incredible running script
* Starting to modify the minimap code to be better
* It's going well thusfar, I guess
* What have I done
* RIP minimap
* FUN FUN FUN FUN FUN
* Adds shuttle_manipulator.dmi
MUH HOLOGRAMS
* Is it done? IS IT OVER
* Peer review
* Some bug fixes
* Makes that damn greentext shut up
* Shuttle registration
* Made the Emergency Escape Bar more robust
No climbing on the bar.
* Do not stare into the operation end of the device
* Compile shame
* THE MOST DUMB
* Passive barmaiden
* Emergency shuttle memes
* MORE SAFETY CODE
* Fancy shuttle manipulator icons
* Smoothing it out
* We are going to have a lot of fun with this one
* Independent blobbernauts
* WABBAJACK WABBAJACK
* Message for attempting to authenticate old style
* Angry alert noise is back
* Revert "Independent blobbernauts"
This reverts commit 34d6af7c9c88cfc2864990cb37b586bb90163dd3.
* No parrot sleep plz
* Moves the special shuttle stuff to special.dm
* No Bartender like a Centcom Bartender
* Non-controversial map changes
- Backup shuttle moved closer to Centcom main structure, docking tube
created
- Moved shuttle import landmark to above Centcom main building
- Added shuttle displays to Conference Room
- Squashed the Chapel a bit in Metastation
- Made the docking port on Z2 massive
- Made the docking port on Metastation a lot larger
* Hacks and slashes at Box
A bunch of things are extended and squashed so Box shuttle dock can
support the MetaStation emergency shuttle.
* Some Metastationshit
* Never ending changes
* Wabbajack to TGM
* Modified the bar, I think that's all of them
* Stops Barmaiden wandering around
* More code review
* Whitspace, the bane of us all
* DIE WHITESPACE DIE
* Added a simple bar-theme escape shuttle
Features include a very tough Bardrone, with laws to be a good
bartender, bathroom, a quality lounge for the heads, and a small
gambling table.
* Changed drone's health to 3000
Bardrone is now strong, to cope from stray gunfire.
* Replaces banned variables with alternates
Step_[xy] is bad, mkay?
* Added STV5, the cramped transport shuttle
Well, looks like Centcom only had this ship ready for evacuation. I hope
you're friendly with your coworkers!
* Removed shuttle area from empty space on STV5
* Added cult shuttle
Looks like this automated shuttle may have wandered into the darkness
between the stars on route to the station. Let's not think too hard
about where all the bodies came from.
* Include the Narnar Shuttle
* Meat ferry added
Very basic, could probably use some love from a map wizard.
* Moved shuttle files to shuttles/ directory
* MAPS MOVED AND RENAMED
* Hyperfractal Gigashuttle
"I dunno, this seems kinda needlessly complicated."
"This shuttle has very a very high safety record, according to Centcom
Officer Cadet Yins."
"Are you sure?"
"Yes, it has a safety record of N-A-N, which is apparently larger than
100%."
* I REGRET ADDING THESE
* Into templates you go
* Changed floors
* Hugbox supermatter, for map making
* Shuttles KINDA delete themselves
* Hats in hats in hats in hats in hats
* Use the hugbox supermatter in the shuttle
* Include the new verbs
* Include our new verbs
* Fixed runtime when deleting emergency shuttle
* Added to verb list
* Fixes more runtimes with deleting the shuttle
* Shuttle Destroy verb now functions
* Moved them out of the shuttles/ folder
* We'll need these docks later
* shuttle_import landmark datum made
* Changes z2 to TGM format and adds shuttle_import landmark
* SHUTTLE IMPORT VERB
Is this it? Are we there?
* Some compile fixes
* Emergency bar map updated
* Updated cramped shuttle
* Updated narnar shuttle
* Supermatter shuttle updated
* Meat ferry updated
* Debugging information included
* Debug code, QDEL hints
* Minor updates to collection of maps
* May as well use the snowflake drone code
PICK YOUR OWN BARKEEPING HAT.
* The Lighthouse
*static*... part of a much larger vessel, possibly military in origin.
The weapon markings aren't anything we've seen ... *static* ... by
almost never the same person twice, possible use of unknown storage ...
*static* ... seeing ERT officers onboard, but no missions are on file
for ... *static* ... *static* ... *annoying jingle* ... only at The
LIGHTHOUSE! Fulfilling needs you didn't even know you had. We've got
EVERYTHING, and something else!
* Made supermatter hallucination too powerful
* Added force argument for docking testing
* Added emergency backup shuttle
Hopefully it will never be seen or used. But means that provided it's
there and untouched, even with the accidental deletion of a shuttle,
round will still be able to end as normal.
* Added templates for existing shuttles
* Backup shuttle used if emergency shuttle deleted
* Added backup shuttle transit space
Don't know why transit spaces aren't dynamically generated, to be
honest.
* Hyperfractal Gigashuttle improved
More radiation lockers, chairs which makes it "safer".
* Added Shuttle Under Construction
The documentation hasn't been finished yet for this shuttle. Break glass
in case of emergency.
* Added warnings for shuttle interaction
ARE YOU SURE YOU WANT TO DELETE THE EMERGENCY SHUTTLE?
I mean, I really don't know what will happen, and it's probably
nothing good.
* Snappop(tm)!
Hey kids and grownups! Are you bored of DULL and TEDIOUS shuttle
journeys after you're evacuating for probably BORING reasons. Well then
order the Snappop today! We've got fun activities for everyone, an all
access cockpit, and no boring security brig! Boo! Play dress up with
your friends! Collect all the bedsheets before your neighbour does so!
Check if the AI is watching you with our patent pending "Peeping Tom AI
Multitool Detector" or PEEEEEETUR for short. Have a fun ride!
* Fixed horrific experiment icon, added gambling spawner
* Candle changes
Infinite candles start fires but don't run out.
Infinite candles don't make messages when created.
* Shuttle can dock if already docked
* Fixing bugs with shuttle import
Also, some minor bugs with hugbox supermatter still consuming
gas moles and slowly depressurising the area.
* Admin notice, unload bad template
* Fixes problems with some shuttles
* Warning message if roundstart dock failed
* Compiles.
* Inform admins of shuttle problems
* Names for shuttles, minor tweaks
* Moved shuttle templates to shuttles/
* Version numbers are lame
* Shuttle datums
* Shuttle manipulator barebones
It doesn't do anything at the moment.
* Added shuttle manipulator to Z2
It still doesn't do anything yet, but it looks pretty.
* Use GetAllContents(), don't delete ghosts
* Fixes bug where nothing would actually load
* Cancel button on Destroy Shuttle
* Fixed birdboat shuttle overwriting bar shuttle
(and other changes like recording the longest delete so i can figure out if handle_queue is getting called a lot or if something actually is taking forever to hard delete)
