Commit Graph
2929 Commits
Author SHA1 Message Date
SmArtKarandGitHub 0516c95ecf Closing mind transfer popup does not transfer your mind anymore (#85119)
## About The Pull Request

Closes #85116

## Changelog
🆑
fix: Closing mind transfer popup does not transfer your mind anymore
/🆑
2024-07-21 01:30:08 +02:00
carlarctgandGitHub 9ea062e4a2 Fixed null description in cerulean regenerative extract (#85089)
## About The Pull Request

Fixed null description in cerulean regenerative extract

## Why It's Good For The Game

Bugge

## Changelog

🆑
fix: Fixed null description in cerulean regenerative extract
/🆑
2024-07-20 02:24:58 +02:00
GPeckmanandGitHub 753a9cf5fa Adds a standalone Civilian Modsuit model, available from robotics (#84806)
## About The Pull Request

I talked with Fikou on discord about #84801, and he said that it would
be fine to make a standalone suit that is slowdown-free but also not
spaceproof. So yeah, that's what this is. The civilian skin for the
standard modsuit has been turned into a standalone model. It is similar
to the loader modsuit that cargo has, in that it has no slowdown while
active but doesn't protect you from space. It also has only a complexity
limit of 12 instead of the usual 15, and it has abysmal armor values. It
also doesn't protect you from pepper spray and the helmet doesn't allow
you to use internals or block you from eating.

I tweaked the sprites for it as well, removing the visor from the inhand
and mob overlay sprites, to better reflect it's lack of spaceproofing. I
also whipped up a quick sprite for the civilian mod plating, based off
of the medical mod plating since they have similar color schemes.
## Why It's Good For The Game

I'm going to just copy and paste what I said in the last PR, because all
of it still applies to this one. There are a lot of really cool modsuit
modules that are hampered by the other drawbacks that modsuits have.
These drawbacks exist for a good reason; space proof suits should have
tradeoffs, especially ones available at the start of the round like
modsuits are. But that doesn't really solve the problem with the
modules.

One of the biggest examples of this problem is the pepper shoulders
module that comes on security modsuits. It's a very cool module
conceptually, but it tends to have limited usefulness in practice. Out
in space, whoever you're fighting is likely wearing a spacesuit of their
own, which will make them completely immune to the pepper spray. On the
station, the person wearing the suit has to deal with the slowdown from
it, which will far outweigh any advantage granted by the pepper
shoulders module.

Another good example is the medical modules, like the surgical
processor, organ thrower/organizer, and thread ripper modules. All of
these are great for a medical player trying to perform surgery, but who
is going to be doing surgery in a depressurized room? All these modules
don't mesh well with the design of modsuits as special spacesuits, and
the new civilian model will hopefully give them more room to be used.
## Changelog
🆑
add: Added the civilian modsuit module as a standalone model. It offers
no slowdown while activated but does NOT protect you from the void of
space. You can print the plating from an exosuit fabricator and build it
like a normal modsuit.
del: Removed the civilian skin from the standard modsuit, as it is now a
standalone model.
image: Tweaked the sprites for the civilian modsuit head, both in-hand
and on the mob. Also added a civilian mod plating sprite.
/🆑
2024-07-19 18:40:32 +02:00
129c61b77e Experimentor Strange Object Tweaks (#84982)
## About The Pull Request

De-costumed highlander skirts

Fixed bioscramble function not working for strange objects unless
dropped

Fixed the disguiser cardboard ID not overlaying propery

## Why It's Good For The Game

Guys I think I'm not good at testing (why doesnt range() work like that)

Please stop using a COSTUME subtype for NOT COSTUMES.

## Changelog

🆑

fix: Fixed sometimes obtaining the nodrop highlander kilt with relics
fix: Fixed bioscramble function not working for strange objects unless
dropped
fix: Fixed the disguiser cardboard ID not overlaying properly
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-07-18 23:58:12 +00:00
OdairuandGitHub 3f9f949a77 Fixes a typo I noticed when working elsewhere in borg stuff (#85016)
## About The Pull Request
Title
## Why It's Good For The Game
Fixing typos - Untility Cyborg Upgrades -> Utility Cyborg Upgrades
## Changelog
🆑
spellcheck: fixed a typo in borg research
/🆑
2024-07-17 20:13:06 +02:00
AndrewandGitHub 41ff0fbb40 Research queue (#84731)
## About The Pull Request

<img alt="2dZbpr8MK1"
src="https://github.com/tgstation/tgstation/assets/3625094/dd78feba-224a-41a1-8d4a-83af3a8b68df">


Added an ability to queue up to one node per player in a techweb for an
automatic research.

You can queue up a node only when all requirements are met, but there
are not enough points.

People can't research when there is something in the queue, only add
things to the queue. So a 40 points node can't be researched if someone
queued up a 200 points node ahead of it.

When a node is enqueued by RD, it is placed in front of the queue.

The research button is available when the queue is empty.

TODO:

- [x] Bypass queue when the node cost is zero

## Why It's Good For The Game

No need to stay at the console to wait for the points. No "Research"
button spamming.

## Changelog

🆑
qol: Research nodes can be queued, one per player. RDs can place their
node at the beginning of the queue.
/🆑
2024-07-15 14:03:24 +12:00
89cf4c7787 The Voidwalker | New Midround Antagonist (#84674)
## The Voidwalker

Adds a new antagonist, the Voidwalker! 
It's a rare antag that spawns in space when there's at least 40 people
Design doc is here: https://hackmd.io/jE4YScP8RPykXo37rTBV2Q (there's
some deviations)
No biddle

## Summary
Spooky space antag that moves around space, ambushing people either in
space or near space. They can move through glass, have an ability to
stamina drain you if they remain in your vision for 8 seconds, can
temporarily remove glass windows to drag you through them and deal
~~stamina damage~~ incredibly violence. Upon being taken, they can be
kidnapped and cursed, muting and pacifying the person and sending them
to the void.

## Passive

![image](https://github.com/tgstation/tgstation/assets/7501474/e2bbac33-bac8-4eb9-9042-994904ebec18)

![image](https://github.com/tgstation/tgstation/assets/7501474/b76df700-84d4-4722-bf6f-2e2049c345b3)

Passive abilities:

- Permanent space flight and indoor flight
- Space regen
- Slowdown when in gravity
- Space camo (very low alpha when in space
- Can freely move through unshocked glass
- Mute, but can hear all station frequencies (excluding binary)
- Will quickly die when on planets or moons (obviously can't roll on
icebox)
- 10 brute armor and 20 burn armor. They can't wear any form of armor
and don't have any get out of jail free cards, so I think it'll help
with their survivability a slight bit

## Abilities
**Void eater:** Literally just a light-eater but instead of eating light
it instantly shatters windows, but restores them after a few seconds

**Space Dive:** New ability that lets you move under the station with a
2 second do_after, so they can still get to closed of space spots
without being as annoying as heretic space shift

**Unsettle:** Remain in view of the target for 8 seconds to give them a
short stun, slurring and 80 stamina damage, but announce your presence
and location to them. Both you and your target can move, as long as you
remain in their view.

**Space Kidnap:** When your target is incapacitated and in space, you
can drag them into the cosmic void. They'll be returned cursed after
undergoing a sort of reverse heretic sacrifice (more on that in the next
section).

[Showcase of all the above abilities!](https://youtu.be/NJ01H28PV9w)

## Voided Crew
A brain trauma received when you get kidnapped. While under it's
influence, you are muted and pacified. You will die in planetary gravity
and cannot enter space.


![image](https://github.com/tgstation/tgstation/assets/7501474/ea90bf9b-b8d1-4d46-8c69-7b0900e8e50c)

It can be cured with a lobotomy or by dying in planetary gravity. 
You get warned to avoid the Voidwalker. The voidwalker now does extra
damage and gets the option to glass gib you if you die, leaving just a
brain

## Loot
On death, the Voidwalker shatters into glass and drops a cosmic skull.
Looking into the skull gives you a stable version of the Voided brain
trauma. It doesn't give you pacifism and doesn't ban you from space. It
also makes you space immune and gives you the ability to walk through
unshocked glass after 2 seconds do_after.

Sprites for the cosmic skull by Justice12354 and Rex9001! I'll throw up
a video showcasing death and their sprites on Sunday

## Why It's Good For The Game
We don't have any space centered antagonists. The closest we have are
Space Dragons, but they have to go deep into the station anyway. I'm
also quite fond of simpler antagonists, like revenant and nightmare.
Give people the tools, and they'll make the fun themselves.

I've been comparing the Voidwalker with the Nightmare. Both are goalles,
simple antagonists, but where the Nightmare's gimmick is darkness, the
Voidwalker's gimmick is space.

They also get a dark tentacle arm so they can murderize people, but it
only gets them to crit. After that they can drag people into the "void"
to kidnap them. This is mostly to encourage the Voidwalker not to just
space them cause that's kinda lame. They still can though, just in-case
it would be very funny

## Changelog
🆑 Time-Green, Justice12354, Rex9001
add: Adds the Voidwalker, a new rare space based midround antagonist!
code: Adds the ability to texture limbs and bodypart_overlays
Sprite: Cosmic skull sprites by Justice12354 and Rex9001
/🆑

- [x] Add a better kidnapping mechanic, instead of just teleporting
someone to a station turf
- [x] Add an armblade or weapon or something, unarmed combat is kinda
ass for this
- [x] Fix the antag preview not rendering textures
- [x] Prevent them from space phasing when in combat so they can
actually be killed in space combat, even if really fucking hard
- [x] Nerf visibility for people with space parallax disabled, probably
also something to improve camo with colored parallax
- [x] Replace the stamina damage stuff
- [x] Cool rework of space phase idea I have
- [x] Update/implement vidual effects
- [x] Implement names

## Considerations
There's a few things that I might change or implement later, depending
on how it actually plays.

It's a space focused antag, but there might not be enough people near
space in a given round. An ability to let them "capture" area's or let
them turn into a meteor or something might be needed later if they turn
out to be too passive.

They might also be _too_ oppressive in space. I designed them for
near-space combat, but may've made them insanely overpowered in in raw
space combat.

Probably wont do biddle, but might add more powers that you can reroll
every few minutes or something (like blob). Either wat it wont be this
PR

---------

Co-authored-by: carlarctg <53100513+carlarctg@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-07-14 18:57:44 +00:00
carlarctgandGitHub 0863a5d7df Fixed new charger power not working (#84897)
## About The Pull Request

Fixed new charger power not working

## Why It's Good For The Game

I think bugs are bad for the game sometimes

## Changelog

🆑
fix: Fixed new charger power not working fior strange objects
/🆑
2024-07-13 02:04:21 +01:00
necromanceranneandGitHub eaa4d71c3c Adds the Herculean Gravitronic Spinal Implant; An Athletics focused implant. (#84532)
## About The Pull Request

Adds the Herculean Gravitronic Spinal Implant. A personal gravity
dampener that affords the user improved physical performance without all
the effort of actually working out.

This implant improves the user's ability in a variety of minor but
useful ways Including;

1) Faster climbing speeds with climbing hooks and ladders. (Athletics
now also influences this time)
2) Slightly less damage from falling from a height.
3) Faster fireman lifting and placing onto tables.
4) An easier time working out and stronger in boxing.
5) Standing up just a bit faster.
6) Throwing things just a little further.
7) Tackle performance, including offense, defense and safety if you
miss.

You can improve the implant by using a gravity anomaly core on it,
transforming it into an Atlas implant. This implant has considerably
better bonuses compared to the baselines fairly minor even if numerous
benefits. It also forces personal gravity to normal values.

As a result, the total number of gravity anomaly cores is now 6.


![image](https://github.com/tgstation/tgstation/assets/40847847/11180524-9e5a-4146-922f-1b935ff34764)

Has some little floating rocks around your head while active.

## Why It's Good For The Game

I attempted to add something fairly similar in the past, but didn't
quite like simply making an entirely combat related implant. Instead,
I've changed the concept towards generally improving some minor physical
world interactions. Things that you may not really think about or
notice.

I really enjoy getting just slight tweaks to the small little gameplay
activities that come up every so often, and even if this won't appeal to
most players, I know someone will see this and think to find a way to
make the most of the implant in some way that I didn't even think about.

## Changelog
🆑
add: Adds the Herculean Gravitronic Spinal Implant; an implant that
makes you better at athletics. You can upgrade it into an Atlas implant
using a gravity anomaly core.
balance: Gravity anomaly cores have had their max number of cores
reduces from 8 to 6.
balance: Your athletic ability allows you to climb faster.
/🆑
2024-07-12 22:36:26 +02:00
SmArtKarandGitHub 5759758cae Experimentor malfunction reduction chance is now multiplicative. Copying is now slightly rarer. (#84858)
## About The Pull Request

Alternative / supplementary to #84855. Currently Experimentor's
malfunction reduction chance is additive instead of multiplicative,
allowing to completely babyproof it. Chance to copy an object also has
been lowered from 35% to 20%

## Why It's Good For The Game

Copying critical items is a niche but cool thing. Removal of
babyproofing will keep some risk of having your item destroyed, as
bringing it down low enough to babyproof experimentor again is not
possible by standard round's time constraints.

## Changelog
🆑
balance: Experimentor's reduction chance is multiplicative, and chance
to copy an object has been slightly lowered.
/🆑
2024-07-11 22:14:04 -04:00
RedbertandGitHub bf39b4a66d Medical research nodes adjustment (#84783)
## About The Pull Request
Moves XL beaker from Chemical Synthesis to Medbay Equipment
Removes Plumbing node and moves most items to Chemical synthesis node
Moves piercing syringe from Plumbing node to Advanced Medbay Equipment


![346569359-1dfa219c-85eb-4842-a47c-a1556c3dea61](https://github.com/tgstation/tgstation/assets/109347230/e4dc5ddc-8b1c-4782-ad91-12177d8cd6c1)

## Why It's Good For The Game
Love the science rework, there's just a few things that need to be moved
around.

I've got two reasons for ya.
Bluespace beakers are often researched before metamaterial beakers due
to the different node paths and the value of bluespace research being
greater than plumbing research. It's a little weird that the higher
volume beaker is so often available sooner
XL-beakers are pretty simple and are already locked behind plastic, they
should probably be available to chemists at round start, just like they
were before the research rework.

## Changelog
🆑
balance: Moves XL beaker from Chemical Synthesis to Medbay Equipment
balance: Removes Plumbing node and moves most items to Chemical
synthesis node
balance: Moves piercing syringe from Plumbing node to Advanced Medbay
Equipment
/🆑
2024-07-12 00:21:22 +02:00
JackEnoffandGitHub 1dde5aff0e Experimentor will no longer duplicate Bags of Holding (#84851)
## About The Pull Request

This feature of the experimentor is ~6 years old, back when BoHs didn't
need anomaly cores, but now that BoHs need anomaly cores this just
bypasses the anomaly core limit. And now it will not.

Closes #84849 

## Why It's Good For The Game

Limits to the amount of anomaly core items that can exist aren't
supposed to be able to be bypassed this easily.

## Changelog

🆑
balance: Experimentor will no longer duplicate Bags of Holding
/🆑
2024-07-12 08:50:54 +12:00
GPeckmanandGitHub b30faed7ab The techweb no longer erroneously refers to MODsuits as exosuits (#84800)
## About The Pull Request

At some point, some of the techweb node descriptions were changed, so
that it referred to certain modsuits as exosuits. This just changes it
back.
## Why It's Good For The Game

The term "exosuit" is generally used for mechs, not modsuits. The
techweb descriptions should refer to modsuits as modsuits.
## Changelog
🆑
spellcheck: The techweb no longer erroneously refers to MODsuits as
exosuits.
/🆑
2024-07-10 23:05:01 -06:00
carlarctgandGitHub 63b94cd307 Adds six new strange object powers! (#84775)
## About The Pull Request

DESIGN CONCEPT: Strange Devices are at their best when they're odd tools
which can help a department out, with some strange drawbacks that make
them interesting and unique. Foam for the Janitor, Flashbang for
Security, Teleporter for tiders, Corgimaker for the chef. They're also
ambiguous enough that they can really be used by anyone for silly
hijinks.

Drink Dispenser: Creates a glass, then fills it up with a random drink.

Bioscrambler: After a noticeable warning, bioscrambles people nearby.
33% chance to be used up on use.

Recharger: Shocks you, but recharges one random item to max battery.

Hugger: Hugs everyone in range as if you had the friendly trait.

DImensional: Converts the surroundings to a random material-theme. Each
use increases cooldown by two seconds.

Disguiser: Drops your clothing to the ground and replaces it with a
delete-on-drop costume and a randomly assigned cardboard ID.

Removed an unused and unusable shock flag.

Removed an unused dumb ghost item.

Added a proc that returns a hex color with the # attached.

## Why It's Good For The Game

> DESIGN CONCEPT: Strange Devices are at their best when they're odd
tools which can help a department out, with some strange drawbacks that
make them interesting and unique. Foam for the Janitor, Flashbang for
Security, Teleporter for tiders, Corgimaker for the chef. They're also
ambiguous enough that they can really be used by anyone for silly
hijinks.

Request by ArcaneMusic! He wanted new abilities to go along with the new
sprites, and approved these.

> Removed an unused dumb ghost item.

please stop using costume subtypes for OP items. whats the damn point of
the subtype if youre just going to screw with it

> Added a proc that returns a hex color with the # attached.

idk why it didnt have this tbh

## Changelog

🆑
add: Adds six new strange object powers! Drink dispenser, bioscrambler,
recharger, hugger, dimensional, disguiser.
code: Removed some unused code and items, and added a proc that returns
a random #colorstring.
/🆑
2024-07-10 22:05:00 -04:00
43e62163fe Adds a Contraband trait, and implements contraband as a mechanic to security bounties. (#84003)
## About The Pull Request

This PR does a few things but centrally it's all centered around
mechanically enforcing what items are and are-not considered contraband
in-game.

### What does something being contraband MEAN?

Contraband items are visually indistinguishable from non-contraband. If
an item is Contraband, it can only be detected in two ways:
* After being scanned by an N-Spect scanner, which is a standard item
security item, assuming it still has a charge to do so.
* Via a scanner gate, which can now be upgraded with an N-spect scanner
to allow for it to scan a person and all their contents for contraband.

### What items ARE contraband?

Contraband items are intended to be determined both logically and
through other relevant examine text. However, here's the short list of
items that are considered contraband, reserving the right to expand the
list.

<details>
  <summary>In hindsight it's kind of a long list.</summary>
  
* Items that have "contraband" or "illegal" in the name or description.
* Items that allow for the player to obtain other illegal items, that
are NOT particularly stealthy.
* This means that a syndicate uplink is NOT considered contraband, as
they're typically hidden on your person as something else.
* Stealth items under the syndicate uplink, the revolutionary flash, and
some mapped in dangerous items that can come from both syndicate and
company-aligned resources are not considered dangerous.
* Items that are purchased from cargo after emagging or switching to
extended cargo range.
* Items purchased FROM syndicate uplinks, the wizard knowledge scroll,
or other antagonist shops.
* Cursed artifacts/tools magically produced by cultists or heretics.
* Items purchased from the blackmarket.
* Items purchased from the contraband section of vending machines.
* Some drugs and overtly dangerous or criminal byproducts.
  
</details>

### How does this interact with the round?
Well, primarily, this is an aid for in-game enforcement of space law.
Based on the length of the above list, we have a LONG, LONG list of
items in-game that are technically considered, in one way or another,
illegal to have on the station, and yet without either metaknowledge of
what those items are, or how they're used, security officers lack some
of the certainty of how to deal with these kinds of encounters.

Additionally to the knowledge aspect of this trait, security officers
may now receive a new civilian bounty to collect items that are
considered contraband, also giving them an incentive to look for and
confiscate contraband that's been found across the station while
upholding space law.

### Other minor changes that I rolled into this

Security has a bounty for 3 different rechargers, and considering access
limitations, most security players aren't going to make this exchange,
so I've lowered the required amount down to 1.

Adjusted the N-spect scanner's description to match it's new
functionality.

The Civilian bounty TGUI now has an additional 1 point of padding to
make it feel less cramped.



https://github.com/tgstation/tgstation/assets/41715314/c3cd4752-b03a-4e0b-959e-1252fcc2369d

**Updated as of 6/19/2024:**
Additionally, some storage items will block the presence of contraband
when going through a contraband aligned scanning gate. These items
include the infiltrator modsuit core, storage implant, void cloak, the
aptly named smuggler's satchel, and the chameleon kit's backpack.

**Updated as of 6/23/2024:**
N-spect scanner now has contextual screentips.

**Updated as of 6/29/2024:**
Scanner gates are now available in all lathes that have a feature
specific to how scanner gates function. So, includes cargo (contraband),
security (weapons), and medbay (diseases).

## Why It's Good For The Game

Originally, this started out as a way to be able to provide more
in-character and in-flavor bounties for security officers, because they
suck! Most security bounties as they exist right now do the worst
possible things from all respective bounties:
* They detract away from a job's actual responsibilities as opposed to
working with them.
* They're best completed while sitting next to your lathe and running
items back to the bounty pad.
* They exist with such esoteric rarity of high quantity of items that
it's miserable to fulfil.

As a result, I started work on this as a framework to allow security
officers to be further incentivized to collect contraband across the
station, either as a result of the gamemode or just through routine
patrols across the station.

Implementing it as a learning tool for security as well just happened to
work out as an additional bonus, and having a function in-game allowing
newer or less experienced players to know if an item is considered
dangerous or conspicuous also works as a particularly good way to
provide information where a player may not know what they're up against.

If nothing else, this might be interesting to try, and if not, I'll just
snip out the QOL changes from it and we'll see how it goes.

Going forward, I am a bit hesitant about the contraband scanner gate
mode, and as such, will try working with the admin team to determine if
that's a good feature to keep around for game health, while hoping to
give it a chance in the fullness of time.

## Changelog

🆑
add: Items spawned via traitor uplinks or are known illegal contraband
on the station can now be scanned and identified as such by the N-spect
scanners in security. These only applies to overt traitor or antagonist
items, and "stealth" items will not be seen as such.
add: Scanner gates can now be upgraded by using an N-spect scanner on it
to unlock "contraband scanning" mode.
add: Security officers can now be offered a bounty to turn in pieces of
contraband.
add: Some stealthy storage items like storage implants, smuggler's
satchels, void cloaks, the infiltrator modsuit, and the chameleon
backpack will block the presence of contraband on your person when
placed inside.
qol: N-spect scanner contextual screentips.
balance: Recharger security bounties ask for a quantity of 1, down from
3.
qol: security, cargo, and medbay have access to scanner gate boards.
/🆑

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2024-07-11 03:08:25 +02:00
zoomachinaandGitHub 6ab5274b2d Makes gigabeacon easier to research (#84823)
## About The Pull Request
This changes the bluespace navigation gigabeacon to be unlocked with
Applied Bluespace Research (T2) research node, instead of
Telecommunications (T5).
## Why It's Good For The Game
Gigabeacon used to be its own node which nobody researched. #77223
changed that by tying it up with Telecommunications. After the techweb
tree update, Telecommunications has become a tier 5 research, meaning
that nobody researches gigabeacons again. This PR is meant to amend
that, making gigabeacons more accessible again.
I have to admit that putting this item unlock on Applied Bluespace node
is quite generous, since that node should be researched early on every
round. However, I don't believe that to be an issue, but if needed I can
move it to Bluespace Travel (prerequisite to t4 parts).
## Changelog
🆑
balance: bluespace navigation gigabeacons are now unlocked with Applied
Bluespace Research
/🆑
2024-07-11 02:24:47 +02:00
EnterTheJakeandGitHub 0cb765a5e0 Creates an EMP act for Jetpacks + minor buffs to sec modsuits (#84582)
## About The Pull Request

Jetpacks are now vulnerable to EMP, they get disabled for a few seconds
after getting hit by an EMP blast.

Sec modsuits now start with the jetpack module preinstalled instead of
the mirage module, and their starting powercell has been upgraded.

## Why It's Good For The Game

It's no secret that regular jetpacks and your run of the mill eva suit
see far more use than actual security issued equipment.

Having your best option available from the start of the shift is just
boring, and doesn't encourage the crew to even engage with Modsuits in
any way.

With this PR i'm introducing a weakness to jetties by having em turn of
for 4 seconds if you get hit by a pulse.

In exchange sec mods are now a bit more suited for their job, Mirage
module has been swapped with Jetpack module and they now spawn with a
better cell.

## Changelog

🆑

balance: Jetpacks are now briefly disabled by EMP.
balance: Mirage module has been removed from Sec modsuits.
balance: Security modsuits now spawn with a better cell and the jetpack
module preinstalled.
/🆑
2024-07-08 22:06:23 +02:00
lessthanthreeandGitHub 264e6c486c Adjusts medical techweb nodes (#84706)
## About The Pull Request

Swaps 'advanced medbay equipment' and 'cryostasis' on the medbay tech
tree, adjusting the required experiments and prerequisites as necessary.

## Why It's Good For The Game

Items like health analyzers, pinpointers, defibs and medical beds are
lower tech, commonly used items and should come before advanced cryo
technology, not the other way around.

## Changelog

🆑 LT3
balance: Advanced Medbay Equipment research node lowered to tier 3
balance: Advanced Medbay Equipment now requires haloperidol scan
experiment
balance: Haloperidol and cryostylane experiments can be performed
roundstart
balance: Cryostasis research node raised to tier 4
balance: Cryostasis now has Fusion instead of Controlled Plasma as a
prerequisite
balance: Cryostasis cryostylane scan is now a discount experiment
balance: Crystallizer moved from Controlled Plasma to Fusion
/🆑
2024-07-07 15:09:10 -04:00
carlarctgandGitHub b83b169603 Renames the organ thrower to the 'organizer' and clears up its description (#84534)
## About The Pull Request

Renames the organ thrower to the 'organizer' and clears up its
description.

## Why It's Good For The Game

The organ thrower is a very silly module, and i do like it, but did you
know that it instantly replaces organs? As in, the organ is removed and
swapped instantly? And it can store multiple, making organ manipulation
surgeries eerily instant?

The description is funny, but it forsakes accuracy for amusement's sake.
I did my best to keep it both funny and accurate, accurately describing
its actual function now.

I also changed the name, because similarly, it wasn't very descriptive.
Jacquerel suggested 'organizer' which is a hilarious pun and I'm all for
it, even if it does also lack some accuracy which was supposed to be the
intention of the PR.

## Changelog

🆑
spellcheck: Renamed the organ thrower module to the 'organizer'
spellcheck: Made its description more accurate. Did you know it
instantly replaces up to 5 organs in active surgery?
/🆑
2024-07-07 03:40:03 +02:00
Da Cool BossandGitHub 6aa646c2d7 Cleans up relic code & adds new relic theme (#84511)
## About The Pull Request
Cleaned up crusty old code and made it more readable, removed single
letter variables, camel case, etc.

Improved naming for strange objects. Unidentified objects are "Strange
[thing]", activating the item replaces the word "strange" with a new
prefix. Improved the list of strings.

Added cosmetic themes for artefacts. All current strange objects are now
"prototype" artefacts, reflecting their man-made origin in space.
Artefacts with different themes pick from different sprite and name
pools, reflecting who made them.

New "necrotech" theme for relics. These are strange objects from
lavaland. Instead of getting half-multitool-half-gun-blows-up-when-used
monstrosities crafted by insane maint dwellers, you will now get strange
relics that look like this.
![strange relics from boulders](https://i.imgur.com/Qr5uz6q.png)
And they're called something like "ruined instrument" or "dark relic".
## Why It's Good For The Game
Code needed cleaned up. It was in a bad state. Years of neglect.

Themes add more flavour to these items. I really didn't like how the
boulder machine looked when it produced lots of relics, so now it
produces more appropriate ones.

Lets admins and mappers use variable editing to decide what relics do
and what cooldown they should have before they are activated.
Previously, this would be overwritten when the relic was activated.
## Changelog
🆑
code: Cleaned up relic code.
image: Added necrotech themed relics.
/🆑
2024-07-05 20:27:58 +02:00
AndrewandGitHub 0cb6e7f354 More techweb tweaks [NO GBP] (#84574)
## About The Pull Request

More QoL tweaks and rebalance towards easier unlocking of high tier
nodes by doing discount experiments.

## Why It's Good For The Game

More ways to unlock desired nodes.

## Changelog

🆑
balance: Techweb: High yield explosive is now a discount experiment for
Exotic Ammo node, giving more free points
balance: Techweb: Replaced the botany/xenobio discount experiments with
a new mutant scan experiment for the Gene Engineering node
balance: Techweb: Damaged mech scan is a discount experiment for tier 4
Mech Energy Guns node, giving twice more free points
balance: Techweb: Added a new anomaly scan experiment that gives full
discount for the Advanced Anomaly Shells, also moving the node to tier 5
balance: Techweb: Moved mech RCD to the Experimental Tools node
balance: Techweb: Moved handcuffs to T2 security node, leaving only
zipties in T1
balance: Techweb: Non-human Autopsy is a discount experiment instead of
a required one now
balance: Techweb: Parts scan experiments require 6 machines instead of 4
del: Techweb: Removed the New Toys node moving contents to sec and
medbay trees
qol: Made air horn craftable from a spraycan and a bikehorn
qol: Techweb: Better wording on the slime scan experiment
/🆑
2024-07-04 12:06:07 -07:00
AndrewandGitHub d4765c0657 Cytology without plumbing (#84235)
## About The Pull Request

Makes Growing Vat work as a normal machine akin hydrotray. 
Doesn't need plunger to clear reagents, doesn't need plumbing to input
reagents.
Still has the plumbing port, but can be used without it.
Also made the examine text a bit more compact.

Removed science plumbing RCD from the game.
Removed plumbing tools from cytology equipment, and added a protein
powder jug instead.


![image](https://github.com/tgstation/tgstation/assets/3625094/40d2d33e-f78d-4dc9-96e6-4b0fd231035f)

Automatically fixes #84573

## Why It's Good For The Game

Plumbing was an unnecessary complication for Cytology.

Growing vat is a relatively simple machine that shouldn't require
plumbing knowledge.
Now it works more like hydrotray, and you can pour reagents directly,
and clear them out with a right click.

## Changelog

🆑
refactor: Vat grower is a normal machine now that doesn't need plumbing
qol: Cytology petri dish smartfridge starts with 3 random samples
add: Added protein powder condiment bottle, available in the cytology
supplies locker and the cargo pack
del: Removed science variant of plumbing RCD
fix: Fixed a bug when machines without stock parts didn't spawn frames
on deconstruction
fix: Fixed vat grower not growing
/🆑
2024-07-04 12:04:31 -07:00
AndrewandGitHub 464c6e905d Portable atmos machines` circuitboards (#84201)
## About The Pull Request

Made portable atmospheric machines buildable as any other machines.


![image](https://github.com/tgstation/tgstation/assets/3625094/57c09495-85f7-4417-a109-aedebc723048)

## Why It's Good For The Game

These are simple machines that are limited by the map spawn amounts and
cargo orders for no good reason. While much more complex machinery can
be built.

Also allows for the construction of pipe scrubber introduced in #84187

## Changelog

🆑
qol: portable scubber, pump and pipe scrubber are buildable as any other
machines
/🆑
2024-07-04 12:02:53 -07:00
82f92cb983 New Traitor mech: Justice. (#84097)
## About The Pull Request

Adds new mech that can be created from emaged fabricator. To craft this
mech you need:
1. Emag Fabricator to recive Justice disgine(done this, fabricator will
emit a text and sound signal that can reveal you).
2. You need to craft it like any other mech but you also need 8
telecrystals to finish constraction.
3. To board a mech you need syndicate access (traitor can get it by
purchasing an agent card).
About Mech:
Video:
https://youtu.be/QwJfO_lbLK0
Text:
Health 200
Damage 60
Only melee attacks(can't attach range weapons(can't attach anything in
his arms at all))
Block chanse 60
Speed - in safty mode 2.5 in combat mode 4.5
Attack effects:
In addition to damage, it has a 50 percent chance of cutting off an arm
or leg (does not put you to sleep or give a knockdown
effect when hit like regular combat mechs do).
If a target in crit or stun makes a finishing attack instead of a
regular attack, the mech says an epic phrase and after a second cuts off
the target's head by dashing through the target.

Special actions(can't be used if mech in safty mode):

Invisability - Makes the mech invisible for 20 seconds. If the mech is
pushed or collides with someone or if the pilot presses the invisibility
button again, the mech will no longer be invisible and will go into a 5
second cooldown (the same will happen after 20 seconds). If you attack
in invisibility, then instead of a normal attack the mech will make an
AoE 3x3 attack 1 second after pressing (the attack will be accompanied
by a sound and visual effect and for a second the mech will not be able
to move, which gives enemies time to run away from the attack). Upon
completion AoE attack, everyone( except peoples in crit and in stunned
condition) in a 3x3 radius will receive 35 damage and a 25 chance of
having one of their limbs cut off.

Charge Attack - Mech makes a dash towards the cursor at a distance of up
to 7 cells, breaking all obstacles in its path. If the obstacle is a
living person (and he is not in crit and is not stunned) then he will
receive 35 damage and a 25 chance of cutting off a limb. Cooldown 5
Seconds.
P.S.
Also added emag_act on fabricator so you can put any new secret traitor
mechs on it.
Also made the sounds of mech melee attacks to vars so that it would be
more convenient to change them.

Also fix a runtime error where if you set something in the mech's
max_equip_by_category to 0, the mech UI panel doesn't load.

## Why It's Good For The Game

Adds a traitor mech with fun and interesting mechanics. This is a new
mech with new unique abilities that turns the battle with you into a
boss fight.

## Changelog

🆑
add: New traitor mech: Justice. Emag fabricator to get it.
/🆑

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-07-04 12:01:42 -07:00
ArcaneMusicandGitHub 3512821314 Adds a new anomaly core item to Illumination technology, the photon cannon. (#84368)
## About The Pull Request
This PR adds a new gunkit to the **Illumination Applications** tech node
acquired via BEPIS techs. For years, this funny little tech node has
been one of the lamer results from the BEPIS tech pool, only offering
constructable unique hardhats and access to a micro RLD. Well, lets just
say, badda bing


https://github.com/tgstation/tgstation/assets/41715314/bd869d7f-449a-4563-871a-b90f550e0bda

The photon cannon is craftable via a lathed gunkit obtained from the
security lathe, which fires 4 shots per recharge. Each shot, on direct
contact with a mob, acts like a severity 3 flash. The shot also
distinctly slows down after traveling, so you can more effectively gauge
where it's going to stop moving, as when it reaches it's travel
distance, it will perform a weaker AOE severity 1 flash. Direct hits
will effect silicons, while the AOE flash will not. Direct hits only
deal 5 ***STAMINA* damage.

The Gunkit requires a flux anomaly core to be crafted, completing with
the tesla gun in this respect.

## Why It's Good For The Game

There's been some discussion about how we've hoping to offer higher
power features and options to the game at large using anomaly cores, and
flux anomalies are currently only used for guns, which is rather
unfortunate. The bigger issue, I'd suppose, is that every gun that flux
anomalies can produce are considered lethal, with the event horizon gun
and tesla gun. And honestly, by comparison, the tesla is not lethal
enough to use to any real effect, or practical enough to bother science
enough for the core.

The photon cannon, however, works as a rather effective crowd control
weapon for breaching and incapacitating crewmates, making it ideal for
wardens dealing with large tides of crewmates, officers breaking into
bases, or ~~the captain trying to burn down your library dnd game,
DOUGLAS~~

Overall, it's still a fairly low power weapon, and sits in a niche place
somewhere between a dragNET, flashbang-loaded grenade launcher, the
flash, and the ion-cannon, with it's versatility coming from core rarity
and requiring a BEPIS tech.
**I have since updated this PR so that this gun deals stamina damage
instead of energy damage, and contact with the energy ball deals a short
period of confusion.**

## Changelog

🆑
add: The Illumination Applications technode now includes a gunkit for a
new gun, the Photon Cannon.
/🆑
2024-07-04 15:12:15 +02:00
AndrewandGitHub cc998b1cfa Moved data disks to lathes (#84516)
## About The Pull Request

Moved all 3 versions of data disks to protolathe and autolathe.

## Why It's Good For The Game

It was confusing that you can't print it in lathe and they were
considered circuitboards.

## Changelog

🆑
qol: Data disks are now printed in lathes instead of circuit imprinter 
/🆑
2024-07-03 23:02:31 -04:00
AndrewandGitHub 4ba10ab4db Scan an android to get 200 point discount on the final augmentation node [NO GBP] (#84502)
## About The Pull Request

Provides an alternative way to get the 200 points for the final
augmentation node.

Also reduced the tier of the prior tech node, it was put to tier 4 by
mistake

## Why It's Good For The Game

More options to get the desired node.

## Changelog

🆑
fix: Techweb: Moved upgraded cyber organs to tier 3 from tier 4
qol: Techweb: Added fully augmented android scan discount experiment for
Advanced Cybernetic Organs techweb node
/🆑
2024-07-03 17:56:13 -07:00
e4c5c2fc2a Allows for proxy atoms in object melee attack chain (#83860)
## About The Pull Request
1. Objects now have an `get_proxy_for()` proc. This returns an atom that
will participate in the object melee attack chain on behalf of your
atom. Allows for general purpose polymorphism per object interaction
2. Cleaned up some multitool acts to accommodate proxy behaviour
3. You can pry tiles as an Engiborg with crowbar in hand & do other
similar behaviour with crowbar
5. Improves & Depends on #83880. We don't need a hidden omni toolbox &
can create the tools directly in the omnitool and pass them in the
attack chain as a proxy rather than calling the attack chain manually.
All tools are on the borg directly
   - Fixes #84355
   - Fixes #84359
   - Fixes #84393

## Changelog 
SyncIt21,zxaber
🆑
fix: omni crowbar tool interaction for replacing tiles has been fixed 
fix: techfab screentip does not runtime when you hover over it with an
omnitool multitool
fix: medi borgs can do brain surgery again
code: improved multitool & general tool code for some machines
/🆑

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2024-07-03 15:47:18 -07:00
GhomandGitHub d1e5e61eb1 Converts glasses client colour into an element, appliable to other worn items. (#84542)
## About The Pull Request
The title barely does justice to the content.

This PR turns a snowflake, neigh-unused, broken feature for glasses into
a rock-hard, functional, badass feature which can be applied to any
item, and also brings back the halloween screen tint, inside the pumpkin
hardhat, and also a polaroid tint for the helmet of the flash suit,
because the define was just there, unused.


![immagine](https://github.com/tgstation/tgstation/assets/42542238/367504dd-8828-4518-b8d5-afbc6b9dfa35)

for reference, the normal brightness/saturation is somewhere in the
middle. Also the pumpkin hardhat's effect is only there when it's lit

## Why It's Good For The Game
Less hardcoded implementation of the client colours for items, which
also doubles as a fix because the old code was checking for the trait on
the mob but was adding it to the item.

## Changelog

🆑
fix: Fixed toggleable screen colors for glasses.
code: De-hardcoded, refactored the above, now-fixed feature.
add: Pumpkin hardhats and the hood of the flash suit now affect the
color of your screen.
add: Prism glasses, obtainable through xenobiology crossbreeding, now
also affect the color of your screen.
/🆑
2024-07-03 11:45:15 -04:00
AndrewandGitHub d1f3fc3fdf Oldstation (Charlie) experiments tweaks [NO GBP] (#84379)
## About The Pull Request

There was a feedback that the new techweb made it harder to do science
on ghost roles, namely Charlie station crew.

This PR makes a few tweaks to oldstation to lower the bar on the
experiments:

- Added a pure N2O tank for easier BZ creation
- Added one diamond to the ai sat to create artificial BS crystal
- Added research console to ai sat with frontier app pre-installed
- Added a gas compressor to Beta station atmos area

Also moved the NTNet relay back to tcomms node as it requires tcomms
parts. And moved chem pack/blood pack from tier 1 to tier 0 per players`
request.

Also fixed the dissection experiments giving the old amount of bonus
points, before the recent point denomination.

Made a few other minor changes to the map.

## Why It's Good For The Game

Charlie is supposed to be friendly for the beginner players, yet the new
experiments are hard to do with the limited resources on Charlie.

## Changelog

🆑
qol: It is easier to do some required techweb experiments on Charlie
station now
fix: Fixed experimental dissection surgeries giving too many points
balance: Techweb: Moved NTNet relay back to tcomms node
balance: Techweb: Moved blood pack and chem pack to the starting node
/🆑
2024-07-01 17:48:19 -07:00
SmArtKarandGitHub f578442ed6 Slime extracts can now be ground once again (#84482)
## About The Pull Request

Slime extracts now have reagents by default and lose them when used
instead of only acquiring them **upon** being blended.
Closes #84444

## Changelog
🆑
fix: You can grind slime extracts in reagent grinders once more.
/🆑
2024-06-30 22:37:42 +02:00
e421f8e7c4 Moved loose tiles and wallframes to crafting (#84210)
## About The Pull Request

There were some tiles and wallframes in lathe designs, while most of
these are already in the crafting menu. Moved all of them into the
crafting menu to avoid confusion, when you can't find some wallframe in
the menu because it must be built in lathe.

Made the light tile craftable in menu, instead of slap-crafting, and
made the circuit tiles use similar recipe (since they both are emissive
tiles). And the circuit tiles can now be cycled in-hand:


![image](https://github.com/tgstation/tgstation/assets/3625094/c7caa5fb-54dd-44d7-8f71-cd02ad740eee)

## Why It's Good For The Game

Centralized place for tiles and wallframes.

## Changelog

🆑
qol: Made light tiles available in the crafting menu
qol: Circuit tile variants can be cycled in-hand
add: Moved loose tiles and wall frames from lathe designs to other tiles
and frames in the crafting menu
/🆑

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2024-06-30 17:39:38 +00:00
Da Cool BossandGitHub 3d0c19c559 Custom sprites for relics (#84464)
## About The Pull Request
These items never had sprites of their own, they just reused sprites of
seemingly random assemblies as placeholders since they were added 9 and
a half years ago. So now they do. New sprites are based heavily on the
placeholders and designed to look like crude gadgets jury-rigged out of
common items in maints.

Old:
![the old sprites](https://i.imgur.com/66BkgVe.png)

New:
![the new sprites](https://i.imgur.com/802n1qn.png)
## Why It's Good For The Game
This looks better I believe.
## Changelog
🆑
image: Relics ("strange objects") now have unique sprites.
/🆑
2024-06-30 10:07:28 -07:00
grungussussandGitHub e1bbf378b8 Lathe sounds (#84081)
## About The Pull Request
Adds a looping sound during printing items on:
- Autolathe
- Techfabs
- Exosuit fabricator

<details>
  <summary>~~Demo~~ [OUTDATED]</summary>

https://github.com/tgstation/tgstation/assets/96586172/15f89efc-7bbf-4228-a38a-48e78bad5f1a
</details>

<details>
  <summary>~~Demo~~ [AFTER REVIEW]</summary>


https://github.com/tgstation/tgstation/assets/96586172/1e6fb486-90d7-4e6e-a4cb-e26a1af1a018


</details>

## Why It's Good For The Game
Printing items being noisy is more realistic and gives feedback to the
player when it's finished or busy.

## Changelog
🆑 grungussuss , Kayozz
sound: exosuit fabricators, Autolathes and Techfabs will now produce
sounds when printing items
/🆑
2024-06-29 19:26:28 +02:00
MrMelbertandGitHub 4aa7bae77a Moves tool use back higher in the chain, but makes it so tool acts are only called on non-combat-mode (#84083)
## About The Pull Request

### Dilemma 

So we've been running into a dilemma recently as we move more and more
items over (#84070, #83910)

Some things like modsuits, tables, washing machines, storage items want
to do their tool acts before their item interactions

In the past this was perfectly fine, because it was `tool_act` ->
`attack`, but now it's a problem, because it's `item_interaction` ->
`tool_act` -> `attack`.

Rather than resort to snowflaking, my idea is that we can move tools
back up the chain so deconstruction and other similar effects are
handled first, before anything else like putting the tool onto the
table.

### So why does it require non-combat-mode?

A large amount of tool acts early return if the user's on combat mode to
allow the user to smack the thing instead of using the tool on it. So
I've decided to walk back on what I said like a week ago and make this
standardized behavior.

### Misc

Reintroducing `tool_act` as a proc that exist means that atoms can
easily hook certain interactions that must happen very high in the click
chain, such as doing something that block storage insertion. Moves some
of the behaviors I put on the (admittedly rather hacky) new proc to
that.

(Also cleaned up a bit of lockbox and medbot code)

## Changelog

🆑 Melbert
fix: Fixed modsuit interactions slightly. No longer requires combat mode
to use tools on it, plasma core works as intended as well. (Using combat
mode, however, will make you insert the item)
refactor: Refactored lockboxes
refactor: Refactored medbot skin application
/🆑
2024-06-28 16:18:50 -06:00
EnterTheJakeandGitHub 20a41e8ee3 Voltaic Combat Cybernetic Heart. (#84174)
## About The Pull Request
Introduces the first anomalocked organ, a heart that makes you immune to
shocks and emps, while granting you the tenacity trait when you fall
into crit.


https://github.com/tgstation/tgstation/assets/102721711/b602dbb0-52ae-4b18-b3bc-9d19258ec3f8


## Why It's Good For The Game

You can find my player_dev_project on the tg discord.

https://discord.com/channels/326822144233439242/1249735775734468619

Essentially, this exists as an item to justify a heavy investment into
cybernetics and augmentations.

EMP is far too common to justify using them in a combat scenario, nukies
have lessened this issue with their shield module, and the crew can now
do so through late tech anomaly research.

*Features*

- locked behind anomaly tech (duh), you need a refined flux core
combined with the shell.
- Can be manually installed, it will however fuck you up if you do so.
- provides total immunity to shocks and emps.
- Increases your passive blood regeneration.
- Recharges any electrical devices on your person (stabilized yellow
slime).
- If you fall into crit, grants the tenacity (you can keep fighting
while you are in crit basically) and no damage slowdown trait for 30
seconds, you will also keep on regenerating health, it won't heal past
crit treshold however, (5 minutes cooldown).
- If removed through surgery or evisceration, it gets vaporized while
releasing a Tesla shock.

## Changelog

🆑
add: A new Anomaly organ has been introduced, The Voltaic Combat
Cyberheart!
/🆑
2024-06-28 09:48:05 +01:00
0e32b0c19f New Microscope UI (#84298)
## About The Pull Request

Continuing the QoL things for Cytology, updated Microscope UI to be more
user-friendly.


![image](https://github.com/tgstation/tgstation/assets/3625094/c1740cd9-1371-4e15-b658-4dd468e45b7a)

Before:

![image](https://github.com/tgstation/tgstation/assets/3625094/e67f147a-07b9-45b6-b4ad-886227bc8132)

Plus some maintenance in micro organism code and QOL things for
microscope (removing sample with right click, dish swapping, balloon
alerts).

## Why It's Good For The Game

The UX for cytology got better.

## Changelog

🆑
qol: Updated Microscope UI
qol: Microscope is easier to use - you can remove dish with right click
and swap dishes
/🆑

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2024-06-27 13:11:16 -07:00
d59f5ad806 Techweb nodes DEFINED & bug fix (#84177)
## About The Pull Request

1. Techweb strings are now defined in
`code/__DEFINES/research/techweb_nodes.dm` many thanks to @ShizCalev
2. All places that used those strings have been updated with the
definitions as well.
3. `code/modules/research/ordnance/scipaper_partner.dm` had some old
boosted ids, they have been updated as well along
with their values.

## Why It's Good For The Game

fixes #84153 

- I found this through a runtime, but basically the boosted nodes missed
unit test checks. Having them defined should in future ensure that any
changes to them alert the maintainers. This will help in furthur
modularizing the code.

- As for the nodes themselves, I have put the exact nodes as much as
possible so they dont differ much from previous gameplay and how they
worked. Researched nodes that used to give points to those experiments,
will continue to do so, but albeit at a slower rate. This is because the
research point generation rate overall now has been increased.

## Changelog
🆑 ShizCalev, SpaceLove
refactor: Techweb strings are defined now so to maintain modularity
balance: Research papers will have less overall point generation.
/🆑

---------

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2024-06-27 01:14:57 -04:00
GPeckmanandGitHub 87c3b1599c Protolathe printing speed is affected by parts again (#84349)
## About The Pull Request

Prior to a refactor of protolathe code, the time needed for a protolathe
to print items was affected by the tier of parts it had, just like
material usage. Said refactor removed this behavior, and given that this
removal was not mentioned in the changelog and that comments in the code
still refer to this behavior, I have to assume that this was a mistake.
So this PR just re-adds that old behavior.
## Why It's Good For The Game

Bugs are bad.
## Changelog
🆑
fix: Protolathes/Circuit Imprinters/Techfabs with better parts should
now print items faster again.
/🆑
2024-06-27 00:02:04 -04:00
SyncIt21andGitHub 9c9a5d28ff Some alt & ctrl click improvements (#84203)
## About The Pull Request
Improved code quality of both so they resemble each other. Some of the
new specs are as follows

1. Moved` COMSIG_CLICK_ALT` & `COMSIG_CLICK_ALT_SECONDARY` up i.e.
before `can_perform_action()` making them pure hooks not bound by any
action checks giving components full control over them
2. Removed range check(`CAN_I_SEE`) & view check(`is_blind()`) out of
the base alt click proc. They now only apply to living mobs and don't
apply to ghosts(ghosts don't get blind & see everything) & revenants
(the range check still applies for revenants though).

This was actually a bug because these 2 checks were only meant to see if
the loot panel could be opened (as stated in
https://github.com/tgstation/tgstation/pull/83736#discussion_r1628097941)
but because they are at the top of the proc they also apply to all alt
click actions which is not intended. Also, by moving these checks down
to mob subtype levels some of the snowflake checks like this
https://github.com/tgstation/tgstation/blob/7579e0e1734ee40b33ce1fd3fc5c2dd08fe30404/code/_onclick/click_alt.dm#L23
can be removed. We should not check for subtypes within the parent type
proc but instead have subtypes override their parent procs to implement
custom behaviour
3. Removed redundant signals like` COMSIG_XENO_SLIME_CLICK_ALT` in
favour of just `COMSIG_MOB_ALTCLICKON`
4. While looking for alt click signal overrides I found alt click for
style meter was run timing, that's fixed now

## Changelog
🆑
fix: alt click runtime no more when using style meter
code: improved alt & ctrl click code
/🆑
2024-06-25 16:06:59 -07:00
VekterandGitHub 6d9dbb9897 Requires Unregulated Bluespace Research for the Event Horizon Anti-Existential Beam Rifle (#84312)
## About The Pull Request

The Event Horizon Anti-Existential Beam Rifle now requires Unregulated
Bluespace Research, which itself requires both Bluespace Parts and
Illegal Tech. This puts it in the same tier as the Desynchronizer.


![image](https://github.com/tgstation/tgstation/assets/7019927/90ce5fd8-bc0e-4d97-828e-a9daf368d06a)

## Why It's Good For The Game

The original intent for the weapon was for it to be an extremely
late-game option as the end-all, be-all gun where only one really could
exist at a time. This thing is an absolute _monster_ in that it has very
little cooldown, can hit things multiple screens away, and gibs whoever
it hits. I'm down for it - it's fun and stupid and goofy and something I
would love to see _sometimes_.

I saw it in like 4 rounds in a row earlier today. Fuck.

I feel like it's either "make it harder to get" or "nerf it into
obscurity" and I really don't want what we replaced the meme rifle with
to end up being as shitty as the meme rifle was.

Worth noting that a lot of people were recommending a change that would
make the rifle require only a single vortex core, but would require and
consume a vortex core when it fires, meaning it can only be fired a
total of like 4-5 times in a round. That sounds great but I don't know
how to go about coding it and I feel like a change needs to be made
sooner rather than later, so we're doing this for now. If someone comes
back and implements that instead before this gets merged, I'll close
this PR.

Also @optimumtact told me to ping him when I post this.
## Changelog
🆑 Vekter
balance: The Event Horizon Anti-Existential Beam Rifle now requires
Unregulated Bluespace Research to be constructed.
/🆑
2024-06-25 23:06:41 +00:00
9d3ad2b7a6 Adds a means to clean up multiple monkey bodies using the xenobio console. (#83810)
## About The Pull Request
This adds a functionality to the 'feed slimes' ctrl-click action for the
xenobio console. Before placing a monkey, it checks for dead and
therefore recycleable monkies, and then calls the proc to recycle said
monkeys. It will also not place a monkey if it clears dead monkeys,
meaning you can avoid adding more monkeys if you want to empty the pen.
## Why It's Good For The Game
Pixel hunting for dead monkeys is just dogshit and this is way better.
It's so easy to accidentally place monkeys while trying to clear ONE
dead monkey.
## Changelog
🆑
qol: The xenobio console's monkey placing command also clears dead
monkeys on the tile.
/🆑

---------

Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
2024-06-25 07:11:50 -04:00
SmArtKarandGitHub 5b25331e7a Adds rounding to research points to prevent floating point errors from occuring (#84282)
## About The Pull Request

Right now research points sometimes bug out and get additional .000...1
added to them due to a floating point error. I just added rounding to
only keep one digit after the point.

## Why It's Good For The Game

No more annoying numbers in the RND console

## Changelog
🆑
fix: RND console now properly rounds research points
/🆑
2024-06-25 00:18:16 -04:00
0db2a23faf Adds a new power storage type: The Megacell. Drastically reduces power cell consumption/storage. [MDB Ignore] (#84079)
## About The Pull Request
As the title says. A standard power cell now only stores 10 KJ and
drains power similar to how it did before the refactor to all power
appliances.

The new standard megacell stock part stores 1 MJ (what cells store right
now). APCs and SMESs have had their power cells replaced with these
megacell stock parts instead. Megacells can only be used in APCs and
SMESs. It shouldn't be possible to use megacells in any typical
appliance.

This shouldn't change anything about how much 'use' you can get out of a
power cell in regular practice. Most should operate the same and you
should still get the same amount of shots out of a laser gun, and we can
look at expanding what can be switched over to megacells, e.g. if we
want mechs to require significantly more power than a typical appliance.

Thanks to Meyhazah for the megacell icon sprites.

## Why It's Good For The Game
Power cell consumption is way too high ever since the power appliance
refactor that converted most things to be in joules. It's a bit
ridiculous for most of our machinery to drain the station's power supply
this early on.

The reason it's like this is because regular appliances (laser guns,
borgs, lights) all have a cell type that is identical to the APC/SMES
cell type. And it means that if we want to provide an easy way to charge
these appliances without making it easy to charge APCs/SMESs through a
power bug exploit, we need to introduce a new cell type to differentiate
between what supplies power and regular appliances that use power. This
is primarily what the megacell stock part does.

This moves us back to what it was originally like before the power
refactor, where recharging power cells wouldn't drain an exorbitant
amount of energy. However, it maintains the goal of the original
refactor which was to prevent people from cheesing power generation to
produce an infinite amount of power, as the power that APCs and SMESs
operate at is drastically different from the power that a regular
appliance uses.

## Changelog
🆑 Watermelon, Mayhazah
balance: Drastically reduces the power consumption and max charge of
power cells
balance: Added a new stock part called the battery, used primarily in
the construction of APCs and SMESs.
add: Suiciding with a cell/battery will shock you and potentially dust
you/shock the people around you if the charge is great enough.
/🆑

---------

Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com>
2024-06-25 00:32:19 +00:00
GoatandGitHub a0060f8820 Adds boards for the book binder and scanner (#83863)
## About The Pull Request
Adds boards for the book binder and scanner. The scanner requires one
scanning module while the binder requires one servo to make. Research
for the board was added to the computer tech research node as that's
where the other book related research was. Boards are available to print
at the service techfab.

![libraryboards](https://github.com/tgstation/tgstation/assets/126099705/ce6f4174-9939-4020-a7d4-c0c6593479f3)

## Why It's Good For The Game
Being able to (re)make the library is good. Irreparable machine is bad.
Writing down your work and being unable to scan it into the archive is
not good. Also allows the machine to be moved if needed.
2024-06-24 16:53:11 -05:00
IsaacExistsandGitHub 937e8b82e2 Embedding and Nutriment Pump Typos (#84239)
## About The Pull Request
Fixes small typo errors in the embedding text when removing shrapnel
from patients, or yourself. Added the closing parenthesis to the
messages missing them, and removed the unnecessary punctuation inside
them.

Also fixes a typo in the nutriment pump cybernetic implant description,
saying "with" instead of "will".
2024-06-24 16:38:23 -05:00
AndrewandGitHub 42e4941f31 Autopsy experiments available roundstart [NO GBP] (#84198)
## About The Pull Request

Made tecweb mark autopsy experiments as completed while the node with
the experiments is not yet unlocked.

## Why It's Good For The Game

Oversight in my tech tree update.
2024-06-24 16:05:18 -05:00
FlufflesTheDogandGitHub 5c6e837dee Fix printed structures/machines having a random offset (#84272)
## About The Pull Request
Checks for isitem() when printing at a lathe, to avoid offsetting things
that can't be picked up.
Also removes a redundant nullcheck in machine/powered(), get_area
already covers being in nullspace, and setting a machine that doesn't
use power to be unpowered is erroneous- the area based power updating
early returns for such machines, leaving them forever unusuable.
## Why It's Good For The Game
Having structures (or possibly machines) offset on their tile looks
really not good, and can't generally be fixed in-game.
2024-06-24 15:41:17 -05:00
881dd195f1 Techweb tweaks [NO GBP] (#84086)
## About The Pull Request

PR for collecting techweb feedback post merge and address valid issues
of #84024.

People seem to dislike the abundance of new experiments in the middle of
the tree, so reducing some requirements for those for now.

Also updated NT frontier app a bit, as people are confused with the
shell experiments.


![image](https://github.com/tgstation/tgstation/assets/3625094/8ce91935-c374-443c-84b4-ebee14d6bac1)

## Why It's Good For The Game

Balancing out the new tree.

## Changelog

🆑
balance: Added ordnance to extra access of geneticists and roboticists
balance: Reduced parts scanning tests' machine count to 4 from 8
balance: Reduced augmented organs scanning tests mob count to 1 from 2
balance: Reduced equipped mech scanning test count to 1 from 2
balance: Added polycrystal option to bluespace crystal scan test 
fix: Allowed NTNet relay in away circuit imprinter for NT Frontier app
qol: NT Frontier app installed on RD and Scientists` PDAs by default
qol: Updated NT Frontier app to be more user-friendly
/🆑

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
2024-06-20 19:15:30 +01:00
RhialsandGitHub 7b1a0daad2 DRAGnet snares now use a dedicated beacon instead of the station teleporter (#84118)
## About The Pull Request

This sets up an alternative to the DRAGnet snares using the teleporter
to determine the destination of their snare teleport -- The DRAGnet
beacon.

![drag
net](https://github.com/tgstation/tgstation/assets/28870487/0084d4d9-378f-4896-bc88-0685d6407999)

Rather than using a convoluted system that routes via the teleporter,
DRAGnets can now by synced with a DRAGnet beacon. When snare rounds are
fired and successfully teleport a target, they will instead be sent to
the synced beacon. Syncing can be done by either pressing the gun to the
beacon or vice-versa.

These beacons can be wrenched into place, then swiped with a security ID
to block them from being unwrenched. An emag will unlock and unwrench
the beacon, and fry its access control.

To facilitate this change, roundstart DRAGnet armory spawns are now done
through spawners (like the other weapons), which includes a single
beacon to be used by the two guns. You can print more with basic sec
tech, and one is included in the DRAGnet crate from cargo.

The teleport is also slightly more accurate, to make it more consistent.
As usual, if not synced to a beacon, DRAGnets will just teleport your
target willy-nilly.
## Why It's Good For The Game

The current system is both clunky and prone to mishaps, dissuading
players from engaging with it. The "active" teleporter concept has
always been a bit of a mystery to players, and when a system for
properly using the DRAGnet teleport is set up, it's incredibly easy to
break even on accident. Every time you teleport a prisoner you have to
pray that no bumbling space explorer decided to reroute the teleporter
to the abandoned satellite.

This system is much more clear and reliable. It's also more versatile,
allowing for multiple teleport networks to be set up simultaneously.
Security is starved for creativity at times. They deserve to be able to
do some wacky dynamic stuff with their tools.
## Changelog
🆑 Rhials
balance: DRAGnets now come with a beacon they can be synced to, which
will set the destination for the snare round's teleport ability.
/🆑
2024-06-20 10:19:30 -07:00