* Standardizes attack chain signal returns and fixes a tk bug (#54475)
The attack chain is a bit of a mess, and the introduction of signals hasn't helped in simplifying it.
In order to take a step into untangling this, I re-ordered the attack signals to no longer be by source type and instead to be grouped more modularly, as they are all members of the attack chain and function similarly. They all share the trait of potentially ending the attack chain via a return, but had several different names for it. I joined it into one.
Additionally, fixed a tk bug reported by @ Timberpoes by adding a signal return check at the base of /mob/proc/RangedAttack
Lastly, removed the async call of /datum/mutation/human/telekinesis/proc/on_ranged_attack, which was added as a lazy patch to appease the linter complaining about a sleep on a signal handler (namely in /obj/singularity/attack_tk). Fixed the problem using timers.
Also cleaned some code here and there.
* Standardizes attack chain signal returns and fixes a tk bug
Co-authored-by: Rohesie <rohesie@gmail.com>
* Converts A && A.B into A?.B (#54342)
Implements the ?. operator, replacing code like A && A.B with A?.B
BYOND Ref:
When reading A?.B, it's equivalent to A && A.B except that A is only evaluated once, even if it's a complex expression like a proc call.
* Converts all A && A.B into A?.B
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
* Gateway refactor core stuff
* Updates gateways on aways.
* Boxstation gateway & control
* Deltastation gateway & control.
* Kilo gateway & control
* Meta gateway & control.
* Pubby gateway & control.
* makes away gateways easier to use.
* Makes gateway names bit better.
* No need for two dmis
* Autolinkup & description
* Docs formatting.
* Donutstation gateway & control
* Icon and init fixups
* ui fixups
* Better var name
* Use roundstart time instead of server time.
* sets dir properly, and locks bumper to south entry only.
* Cleans up gateway sprite a bit ?
* tgui build
* Removed from code
* Removes cloners from maps
* Some more references, now compiles.
* Reduces availability of replica pods
* DNA scanner and tech disk rebranding
* pubby door name, cargo pack description
cl Skoglol
code: New helper proc for alt-click turf listing, bypasses any interaction overrides.
code: Ghosts and revenants now use the new proc.
fix: Ghosts can no longer toggleopen sleepers, adjust skateboard speed or close laptops
fix: Revenant can now alt-click turf to list contents.
tweak: Revenant now slightly less nosy, use shift click to examine.
tweak: Alt-clicking the same turf again no longer closes the turf listing tab.
/cl
Fixes#22410
Use the new helper when you want something to have alt-click turf content listing, but no other world interaction.
* Ports paradise's modular buildmode
* Axes logout callback of buildmode
* AnturK's changes
- Code formatting
- Gives mob to throw args
- Selection overlays are on ABOVE_LIGHTING_PLANE to be visible on space
Other:
- Doubleclicks of observers and AI no longer "double-tap" click
intercepts
* big batch of loc assignments
* Update emergency.dm
* Update spiders.dm
* Update parrot.dm
* Update ripley.dm
* Update firealarm.dm
* seems to work
* this maybe works?
* brainmemes, again
* stuff
* fix brainmob, camera runtimes
* THE PORTAL UPDATE
* portal gun checks
* damn functions
* o_range(s)
* Atmos Portals (#12)
* Rod Form's damage now scales with how much it's upgraded
* buffs chem grenades
* Fix getrev runtime
* Automatic changelog generation for PR #27948 [ci skip]
* Automatic changelog generation for PR #27951 [ci skip]
* Fixes admiral recall (#27861)
* the man with the 2 shotguns that blasted me to the end of the world with dualwielding. nerf (#27978)
* Beam rifles now slowdown while scoped (#27898)
* Update beam_rifle.dm
* Update beam_rifle.dm
* Update beam_rifle.dm
* Fixes a very silly clockwork false wall trick (#27996)
* Fixes#27979 (#28002)
* Automatic changelog generation for PR #28002 [ci skip]
* Fixes#27989 : Riot suits no longer hide jumpsuits (#28003)
* Fixes#27989
* remove tag
* Automatic changelog generation for PR #28003 [ci skip]
* Refactors a cooldown var to not require a spawn or sleep (#28011)
* wat (#28012)
* Remove spawns in favour of stacktrace calls, which don't stop the called (#28013)
proc
* Refactor another spawned cooldown var (#28014)
* Come on, pathetic (#28015)
* Refactor another spawn cooldown (#28016)
* Goodbye spawn (#28017)
* Another spawn timer (#28018)
* Remove a commented out function (#28019)
* Gotta go with the fro2.0 (#28010)
* This doesn't do anything (#28020)
* refactor another spawn cooldown (#28022)
* Refactors another spawn cooldown var (#28023)
* Refactor another spawn (#28024)
* Refactor another spawn var (#28027)
* woops
* woops2
* atmos links!
* unused
* wew
* ffs!
* Forced updates
* update
* Update portals.dm
* adjacent/atmospass checks
* Create portals.dm
* Update portals.dm
* Update other_tools.dm
* stuff
* crossed
* documentation
* reee
* no portal stacking!
* woops
* Ports Space Parallax from vg/yogs
* KILL ME
* fuck shit
* fixes
* rgfkbjhkefrhjkfrejhkfds
* Parallax, part 2.
* Gotta get these defines in before remie notices!
* DAMN IT! SHE FOUND ONE!
* fixes orbits
* fix orbits take 2
* Fixes some things with parallax
* Refactors parallax shuttle animations.
🆑
rscadd: If you are an observer, you can click on transition edges of a
Z-level in order to move as a mob would.
/🆑
Also removed some trailing returns.
