Commit Graph

4538 Commits

Author SHA1 Message Date
oranges
1f204cf008 Merge pull request #44172 from wesoda25/bruhmoment
Removes Physically Obstructive Quirk
2019-05-30 21:05:16 +12:00
py01
f8423cf0a7 CQC and Sleeping carp fix (#44084)
* adds check for cooks in grab, removes unnecessary else

* fixes cqc neckgrab reincreasing grab state on cancel

* makes changes to carp as well

* fixes carp flags

* fixes missing carp variable

* cqc can_use documentation

* spelling

* replaces 1/0's with TRUE/FALSE's

* code cleanup, combined if statements
2019-05-30 10:43:58 +02:00
Ghom
17b3091867 Merges tinfoil (hat) protection into the anti_magic component. Implements it on Hivemind gamemode and telepathy. (#43978)
About The Pull Request

Was fairly shocked to find out hiveminds never took tinfoil hat protection in account, so decided to implement the factor in the game mode. Might have overdone it and probably erroneously changed a couple logics while getting rid of some really indented passages that could easily early return.
So what's said on the tin, this is lot more preferable than clunky is_type() checks on headwear anyway.
Also expanded tinfoil protection to hivemind and (non-revenant) telepathy.
Why It's Good For The Game

Let us remember the "purpose" of tinfoil hats.
Changelog

cl
code: Merged tinfoil hat kind of protection into the anti_magic component.
add: Tinfoil hats can also be warped up from excessive dampening of mindray/though control/psicotronic anomalies, or by simply being microwaved in an oven, and become useless.
add: Immortality Talisman and Paranormal Hardsuit helmets now come with tinfoil protection too (minus the paranoia and limited charges).
balance: Rebalanced many hivemind effects to be dampened/delayed by tinfoil shielding. Bruteforced Assimilate Vessel, One mind and Awake Vessel abilities will consume more tinfoil charges compared to others.
balance: Genetics/Slime/Alien Telepathy and Slime Link are now stopped by tinfoil protection.
/cl
2019-05-30 20:29:30 +12:00
Akrilla
55ed0ebf35 Fedoras hold small and gimmick items (#44139)
* This was probably originally intended...

* Fedoras hold small items, and exceptions for gimmicks

* Only create cache once

* Cache exception_hold, and adds other katana type
2019-05-28 09:57:59 -04:00
ShizCalev
920b0e7d44 Merge pull request #43941 from tralezab/feels-like-i-didn't-even-try
[READY][:(] code improvements and fixes to fugitive events
2019-05-28 02:34:10 -04:00
ShizCalev
c19b36b729 Merge pull request #44112 from vuonojenmustaturska/mousemove
Removes /client/mousemove, changes beamrifles
2019-05-28 02:02:54 -04:00
wesoda25
6a71ec923a Update negative.dm 2019-05-27 23:38:03 -04:00
tralezab
a2cf51bc3c Merge branch 'master' of https://github.com/tgstation/tgstation into feels-like-i-didn't-even-try 2019-05-27 08:54:14 -07:00
Garen Crownguard
c69a359f20 ling fixes (#44055)
About The Pull Request

Fixes #37273
Fixes #37507
Changelog

cl Garen7
tweak: Lesser form lings can now toggle augmented vision
fix: You can no longer turn back into human form as a lesser form ling while ventcrawling
fix: Stuns and Reagents are now passed when transforming into a monkey or human
/cl

It didn't seem like augmented vision was meant to only be usable as a human so I made it usable as a monkey, if the original creator wanted it to be only usable as a human they would have assigned the var req_human of the augmented vision ability to TRUE since thats where this behavior is usually handled.
2019-05-27 22:36:08 +12:00
XDTM
5020a59565 Adds a communication remote that can send custom messages to some nanite programs (#43673)
About The Pull Request

Adds a new device, the nanite communication remote, which can be built from any protolathe once Basic Nanite Research is completed.
The Skull Echo, Forced Speech, and Hallucination programs can now be signaled by this new device to receive custom messages, instead of having to set them manually every time.
To do so, these programs must be set with a Comm Code, which will have to be signaled by a comm remote with the same Comm Code. A Comm Code of 0 is not signalable by remotes and will only work in the old way. If instead you want the program to be only activatable by remote, you must set the trigger code to 0.
Why It's Good For The Game

Makes these programs more elastic in use, allowing for example nanite-delivered private communication via Skull Echo, or actively messing up conversations with forced speech.
Changelog

clXDTM
add: Added a new device, the nanite communication remote, which can be used to send custom messages to message-based nanite programs.
add: Comm remotes use separate Comm Codes: for a message to be received, the signal's comm code must be the same as the program's.
/cl
2019-05-27 22:21:49 +12:00
vuonojenmustaturska
0a0fbeef53 Update lockon_aiming.dm 2019-05-24 21:47:28 +03:00
RaveRadbury
7c9576c6e2 Puts medical record quirks in Medical Record "Important Notes", gives each quirk a medical record, cleans up subjects into patients. (#44009)
* Gives each quirk a medical record, cleans up subjects into patients.

* Update code/datums/traits/good.dm

adds a period I missed

Co-Authored-By: loser <loser@nonagon.host>

* Dumps medical quirk string into medical "Notes"

* Implements bgobandit's suggestions

* ~Comma, comma, comma, comma, comma, commits from Cobby~

Also I missed an A.

Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2019-05-24 12:45:33 -04:00
vuonojenmustaturska
2219250476 remove /client/mousemove 2019-05-23 22:28:01 +03:00
Emmett Gaines
66cab55f28 Replaces the rpg loot datum with a component and makes some suffixes have real effects (#44044)
* Replaces the rpg loot datum with a component

* Makes bane accept species types

And cleans up some other code
2019-05-22 08:47:42 +02:00
RaveRadbury
9ab2ad72ca Reworks "Religiously Comforted" mood_event (#43995)
* Initial poking around

* adds a message to let you know the examine proc'ed

* converts time to minutes

* removes old on_process() code

* Nests procs under if(!appears_dead)

* nests blocks under src != user
2019-05-21 18:53:13 -04:00
vuonojenmustaturska
e123400d00 Removes the mutation on_move hook (#44060)
Why It's Good For The Game

This

for(var/datum/mutation/human/HM in dna.mutations)
	HM.on_move(NewLoc)

pattern is just awful, especially when only one mutation out of all of them implements it.
Changelog

cl Naksu
code: removed /datum/mutation/human/proc/on_move in favor of having the chameleon mutation register for a signal
/cl
2019-05-22 10:49:28 +12:00
vuonojenmustaturska
300e663f32 Nukies get two kinds of shared team discounts rather than individual discounts (#44027 )
About The Pull Request

This replaces the 3 individual discounts on each nukie uplink with two shared pools of discounts. There are 5 unlimited stock discounts and 10 limited stock discounts. Amounts subject to change and debate.
Why It's Good For The Game
Changelog

cl Naksu
balance: nukeop uplinks now have 5 unlimited discounts and 10 limited discounts shared between the team, rather than 3 individual discounts like traitor uplinks
/cl
2019-05-22 10:48:32 +12:00
Incoming5643
1d42d5abaa Syndicate bomb bugfixes and Quality of Death changes (#43996) 2019-05-21 11:30:45 +02:00
vuonojenmustaturska
a844611ff4 removes an explicit uplink component check in favor of a signal in detomatix carts (#44023)
* yeets a GET_COMPONENT_FROM

* signal rather than component

* Update code/game/objects/items/devices/PDA/virus_cart.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
2019-05-20 19:43:42 -04:00
vuonojenmustaturska
7bb73bcfb8 Fixes a bunch of harddels and weirdness. (#44012)
* grabbag of random things

* followup

* deleet
2019-05-19 17:52:59 +02:00
Jordan Brown
7a61ee6901 Merge pull request #44034 from ninjanomnom/squeaky-source
Adds a source var to a signal receiver that should have it
2019-05-19 11:22:59 -04:00
tralezab
2d7ec6bd92 removes testing lines 2019-05-18 17:38:58 -07:00
tralezab
3a76050cd3 i want to get off mr bones wild ride, desc
todo: more map instance work, make it actually move, do all this for the russian ship. then and only then it'll be fine
2019-05-18 17:37:43 -07:00
RaveRadbury
ade1a97e7c [READY] pAI HUD Overhaul (#43741)
* Initial overhaul work and some fixes.

Running into a bug with getting healthanalyzer variables to pass.

Signed-off-by: RaveRadbury <risforradbury@gmail.com>

* Fixes some typos, shortens a message

* Update pai.dm

* Prevents pAI OS from coming up in other windows.

* Moved around some camera stuff, trying to fix lost pAI zoom

* Fixes pAI zoom, adds camera flash

* PAI buttons grey out if they need software first

* Better greying out of buttons in PAI

* Removes unimplemented HUD stuff

* Should make pAI Host Scan require being held (like DNA check)

* Includes host scan as a greyed out hud

* Improved button loop

* Fixes pda icon off-set

* Fixed inconsistent indentation

* Replaces outdated and innacurate checks for scans

Thanks to Cobblestone for the help

* Refactor pAI hud button grey out

* Changes browse to browser

* cleans up the code, gets rid of an error

* Removes indent from #undef

* Removes an unneeded text-align:right
2019-05-18 23:06:29 +02:00
AnturK
4b259d87fb can i have -Wall for dm already (#44008) 2019-05-18 15:27:06 -04:00
ninjanomnom
539a17dc21 Adds a source var to a signal receiver that should have it 2019-05-18 14:56:00 -04:00
oranges
1bc9a6c871 Merge pull request #43987 from AnturK/mood_runtime
Fixes mood events keeping hard references in category
2019-05-17 14:41:24 +12:00
vuonojenmustaturska
b2c848bac8 Removes /datum/topic_input, a helper datum for assoc lists (#43970)
* oh no

* henk
2019-05-16 14:47:47 +02:00
vuonojenmustaturska
1009d008de mistakes were made (#43957) 2019-05-16 14:42:19 +02:00
AnturK
5d2b572450 Fixes mood events keeping hard references in category 2019-05-15 21:29:29 +02:00
tralezab
169b66f43b Merge branch 'master' into feels-like-i-didn't-even-try 2019-05-13 18:58:08 -07:00
RaveRadbury
1bcefc7156 Clean up mood events from deciseconds into MINUTES and SECONDS (#43908)
We have defines for times to save us from the horrid decisecond. Inspired
by the singular use of defines for the "clean laundry" moodlet I have
converted all other mood_event timeouts from deciseconds to appropriate
MINUTES and SECONDS.

It hurts to look at raw time outputs. Code is now a little less maddening
to look at.
2019-05-13 18:13:00 -07:00
oranges
7e9ddc2fe4 Merge pull request #43893 from Flatgub/RCL_GUI_candidate
Implements RCL radial wiring menu
2019-05-14 11:15:57 +12:00
WJohn
85cfd2318b New Boxstation mining shuttle (#43920)
* Larger mining shuttle with power connection when docked with the station. Only in use on boxstation right now.

* Whoops, forgot to add the actual shuttle!

* Fixes cable connections across shuttles

* Unlocks the APC in the mining shuttle.
2019-05-13 23:08:22 +02:00
skoglol
9f575d56d3 Shock touch no longer shocks yourself (#43939) 2019-05-13 16:54:36 -04:00
tralezab
e50ef24030 a lot of the fixes minus ship spawning
fix names
2019-05-11 23:21:55 -07:00
Mickyan
3b5c9b5a34 [READY] Moves mood quirk checks to their respective quirk process (#43845)
* quirk process

* does the same for hygiene

* un-breaks miasma generation

* so how's your day going
2019-05-12 10:52:25 +12:00
AnturK
68bb4fefa5 Fixes holocall static remaining. (#43888)
* Fixes holocall static remaining.

* codegolf
2019-05-12 10:51:41 +12:00
vuonojenmustaturska
f5fdf4fa65 Makes vending machines use spritesheets over artisanal handwritten getflaticon memes (#43914)
About The Pull Request

Pretty much what it says on the tin.

Oh yeah I also removed the string concatenation nonsense in favor of multiline strings and a list.
Why It's Good For The Game

Removes many getFlatIcon calls during the round, also some runtimes from ephemeral items being created and immediately deleted when the vending machines are used.
Changelog

cl Naksu
tweak: vending machines now use spritesheets
/cl
2019-05-12 10:51:03 +12:00
4dplanner
fb758443d6 Add newline to spiritual mood message (#43905) 2019-05-10 16:19:11 -07:00
Flatgub
14e68bd66a Implements RCL radial wiring menu 2019-05-09 22:25:34 +10:00
py01
4da18b9c43 CQC/Carp Fixes, logging, code rewrites, and changes (#43750)
This PR removes some odd quirks in carp and cqc grabbing, and makes them both function the same. Technically a cqc buff as users are able to not aggressive grab now, for quicker body dragging, but I'm not sure that was ever intended behavior.
In addition, the special combos are now properly logged, and added some more informative chat messages for certain moves.

Current behavior:

    Carp can perform aggressive grabs while on grab intent, or passive grabs with CTRL+Click on any other intent. Passive grabs drop the targets items, and count towards combo's.
    CQC only aggressive grabs, prevents the user from ever passive grabbing. For some reason, CQC aggressive grabs do not disarm the target until a few seconds after the grab.

New behavior:

    Both CQC and carp grabs work the same. Grabs on grab intent function the same, and disarm as expected of an aggressive grab. Grabs on other intents do a passive grab, and do not disarm or count towards combo's.
2019-05-09 09:32:10 +12:00
Okand37
6643b26972 Advanced Syndicate Infiltrator, Kilo-pattern Emergency and additional shuttles. (#43735)
About The Pull Request

Includes a set of kilo pattern shuttles for the arrival, cargo, ferry, labour, and mining types along with a new and purchasable emergency shuttle. Additionally, it adds a new type of syndicate infiltrator, codenamed the tortoise. All of these shuttles are accessible via the shuttle loader and work on any station barring the arrival and cargo variants. Shuttles in order from most important to least important:

emergency_kilo; a fully modeled shuttle including two small cargo bays, a more spacious infirmary, and regular security and E.V.A. amenities. Main bay seats 40, 2 E.V.A., 7 Holding Area, 6 Cockpit, 2 Infirmary.
"A fully functional shuttle including a complete infirmary, storage facilties and regular amenities." Priced at 5000 credits.
image

infiltrator_advanced; nicknamed the "tortoise," this syndicate shuttle includes a beefier redesign of the original syndicate infiltrator complete with medical bay, armory, power systems, dual airlocks and a centralized preparation room. Important access-way doors function off of syndicate access (req_access=150). Design helps mitigate bomb damage while allowing for more close-quarters boarding combat. Currently accessible from the shuttle loader, may see itself added with a new syndicate shuttle selector depending on reception.
image

mining_kilo; modernized mining shuttle interior with a small bundle of emergency supplies. With the new(er) directional shuttle docking system, should work on any station.
image

labour_kilo; slightly reskinned labour shuttle, compatible replacement for any standard gulag shuttle. Features an additional seat and modernized interior.
image

ferry_kilo; in addition to regular seating, features two rechargers, emergency supplies and radios, and a rear-placed ferry shuttle request console. Compatible with the universal ferry dock.
image

cargo_kilo; a regular, run-of-the-mill cargo shuttle with a fancier interior. Crates are onloaded through the bottom blast door, and offloaded at the top. May be incompatible with certain docks or conveyors.
image

arrival_kilo; a standard sized arrival shuttle meant for low to medium populations. Closets and arcade machine replace by conventional emergency supplies, easily accessible for new players.
image
Why It's Good For The Game

The kilo-pattern emergency shuttle provides a new and fresh design to the choice of available, fully functional shuttles for purchase by the crew. In addition, the syndicate advanced infiltrator adds a new venue for syndicate operatives and opens up the possibility of various shuttles being added to the syndicate's arsenal for use to help compliment their unique gimmicks or operative styles.
2019-05-09 09:27:31 +12:00
vuonojenmustaturska
c5784e3471 Fixes a runtime in mutations (#43858)
power is a typepath and not a number. Trying to instantiate a number via new runtimes.
Changelog
2019-05-09 09:21:20 +12:00
vuonojenmustaturska
4ffd89a0a9 remove, not improve (#43874) 2019-05-08 22:58:07 +02:00
vuonojenmustaturska
99aab93afd unbreaks master (#43873) 2019-05-08 22:53:29 +02:00
4dplanner
99c17510b9 Blood drunk eye gives ignoredamageslowdown (#43787) 2019-05-08 14:52:09 -04:00
JJRcop
6aa8cebfe4 [READY] Replaces sleepers with stasis beds (Lifeform Stasis Unit) (#43075)
* Adds stasis beds

Needs sprites, using placeholder ones

* Adds stasis beds to techwebs
Cryostasis Technology

* Adds sprites for stasis bed

* Stasis beds support economy/ancap

* Stasis bed can be deconstructed

* Stasis bed requires cable coil

* New stasis bed sprites by @Kmc2000

Made by Kmc2000 <bluekorben2000@yahoo.com>
Not currently functional

* Add unique to SSvis_overlay.add_vis_overlay

will return the overlay object itself and not reuse it

* Make stasis bed art function

can enable/disable with alt click
makes sounds when powering up/down

* The tubes go over the mob now

* Remove sleepers from techweb tree

* Fix stasis bed lying

* Modified stasis bed build requirements

* Survival pod version of stasis bed

Map spawned sleepers delete their circuit boards
Added stasis beds to 'doctors' phobia
NanoMed for survival pod which is always free, not refillable

* Replace sleepers with stasis beds on all station maps

removed all sleeper machine boards from maps
one sleeper machine board intentionally left alone in oldstation

* Fix stasis bed tube overlay capturing clicks

Give power up and down noise freq variation

* Remove stat check from living Life

* Remove vis overlay assertions from stasis bed
2019-05-07 13:16:18 -04:00
vuonojenmustaturska
fb45b7a017 Turns trait accessors into defines, fixes some bugs (#43820)
It's free performance.
2019-05-06 19:44:05 -04:00
4dplanner
2a23295947 Summon item fails on station loving items (#43786)
* Summon item fails on station loving items

* missing bracket

* Uses DM

* Uses signal

* BLOCK_MARK_RETRIEVAL define
2019-05-06 09:23:16 +02:00