Commit Graph

32364 Commits

Author SHA1 Message Date
oranges
ab01ac18e4 Merge pull request #22694 from ChangelingRain/windowfix
Centcom's indestructible windows are now indistinguishable from normal windows
2017-01-05 19:07:24 +13:00
CPTANT
a60172ecf5 Rebalances matter cartridge cost (#22687)
* fixes blocks being applied twice

* revert

* Rebalances matter cartridge cost to prevent material duplication
2017-01-05 19:07:08 +13:00
Haevacht
98215fc336 Fixes being able to screw the taser into ED209s multiple times (#22680)
* sleepisthedevil

* thekorfix hehe, core fix

* no more turf check, my bad
2017-01-05 19:06:00 +13:00
Haevacht
2e93eeea51 Offhand backup plan (#22679)
* no longer asks the offhand to neatly unwield

should fix the issues??

* re-callbacks the sky bulge

* revert the qdel
2017-01-05 19:05:25 +13:00
Firecage
8dab2c9c34 Changes the names of Circuit Boards so they are easier on players. (#22688) 2017-01-04 17:20:53 -05:00
coiax
66f6ac7dcc Positronic brains no longer override examine() (#22686)
It was weird that you didn't see the size of the item when you examined
it. Now its messages are added after the usual examine stuff.
2017-01-04 12:17:09 +01:00
Nabski89
1124374de1 Vitiligo Level Bugfix (#22664)
🆑 Baby's first PR
fix: Vitiligo and Revitiligo were listed as level 5, but had level 4.
/🆑
2017-01-04 10:57:24 +01:00
Core0verload
5faaa4a4af Unfucks SMES construction/deconstruction (#22657)
* Unfucks SMES construction/deconstruction

* fixes
2017-01-04 10:52:43 +01:00
Firecage
50bbf5aa50 Allows syringes and droppers to show their reagents when examined while wearing things such as Science Goggles. (#22618)
* Allows syringes and droppers to show their reagents when examined.

* rearranges my logic

* replaces SEMIOPENCONTAINER with TRANSPARENT

* Silly spelling error fix.

* Moves the defines from flags to container_type to avoid issues with conflicting flags

* changes it back to obj/item/O

* Moves the OPENCONTAINER and TRANSPARENT defines to the reagents.dm
2017-01-04 20:00:46 +13:00
oranges
4d7695a27e Merge pull request #22683 from MrStonedOne/patch-278
fixes botcall's callbot not releasing control of ai's clicks.
2017-01-04 19:43:21 +13:00
Mervill
422d869a40 [s] Fixes spraycans being silent (#22682)
* The regular spraycan makes noise again, also spraying someone in the face is loud

* There are more then 80 columns in the world today, friends
2017-01-04 19:42:39 +13:00
oranges
3607645380 Merge pull request #22693 from MrStonedOne/revert-22577-ACKACK
Revert "Fixes AIs being able to see cult runes"
2017-01-04 18:38:16 +13:00
oranges
3c22fcffcc Merge pull request #21948 from Shadowlight213/feedbackchange
Seperates shuttle purchasing feedback from admin shuttle loading
2017-01-04 18:24:07 +13:00
TehZombehz
a051081a79 Fixes missing materials upon deconstruction/retrieval (#22667)
* Fixes missing materials upon retrieval

Fixes attempts to retrieve materials resulting in missing stacks if
there is more than one full stack of a material in the machine.

* Alternative Fix

This is what actually needed fixing. M.amount would always equal 0, so
round would always result in 0, thus sheet remainders would never get
outputted. This resolves that.
2017-01-04 18:21:52 +13:00
Joan Lung
40986132d2 Merge pull request #22596 from XDTM/NowListenClosely
[Ready]Several Voice of God fixes
2017-01-03 22:27:57 -05:00
Joan Lung
c0bdb982f3 Merge pull request #22671 from Mervill/owo_whats_this
Makes parcel descriptions less confusing
2017-01-03 22:25:29 -05:00
Kyle Spier-Swenson
bee4b132a3 [READY]Makes addtimer use callbacks (#22660)
* Makes addtimer use callbacks

* I broke the comment

* I fucked up the regex

* this was a silly idea.
2017-01-04 16:02:56 +13:00
Cheridan
fd337f0741 Merge pull request #22658 from MrStonedOne/patch-277
Updates sdql2 to work on datums much quicker by ignoring atoms
2017-01-03 18:57:50 -06:00
XDTM
9337cea937 defines 2017-01-04 00:22:19 +01:00
Kyle Spier-Swenson
e9b7bfb389 Fixes sdql2 applying comparison operators to lists incorrectly (#22627)
* Fixes sdql2 applying comparison operators to lists incorrectly

* Add a comment to prevent future reverts

Just in case

* Removes oranges comment

I'm fucking sick and tired of this shit where people touch code they don't understand.

By adding the comment, you imply that every bit of code thats the same without the same comment is safe to change, but thats not true.

These landmines are important for teaching new coders not to fuck with shit they don't understand.

When you see something and go "why is it doing it that way". the answer is not to go "fuck it, it seems to still work when i change it" the answer is to leave it the fuck alone until it doing it that way is actually an issue.

How many god damn bugs have we had this last year from non-changes like that. I'm sick of them.
2017-01-04 10:11:36 +13:00
Joan Lung
0509392ed3 Centcom's indestructible windows are now indistinguishable from normal windows 2017-01-03 15:54:32 -05:00
Kyle Spier-Swenson
bb9c1cb98e Revert "Fixes AIs being able to see cult runes" 2017-01-03 12:28:56 -08:00
Cyberboss
ed461afed5 Fixes AIs being able to see cult runes (#22577)
* Remove this shit so fast

* Runes are now stored in a global list

* Readd this shit to properly work

* Refactor rune invisification into a proc

* Fixes #17426

* Use the blood decals

* Less garbage + removal

* COMPILE BEFORE PUSH YOU SPERGLORD

* Refactor into a datum

* Added to crayon runes

* Refactor AI's vision to a slightly lower level

* Actually make the shit invisible to ais

* Nevermind, fixed it

* Fixes it being on the wrong layer
2017-01-04 08:09:34 +13:00
Joan Lung
36eeb75770 Indestructible turfs are no longer affected by necropolis tendrils or the lava staff (#22641)
* Indestructible turfs are no longer affected by necropolis tendrils or the lava staff

* a better proc name
2017-01-04 07:59:39 +13:00
Mervill
01202447df Can't kick racks if weakened, resting or lying (#22640)
* Can't kick racks if weakened, resting or lying

* you gotta have two legs, too
2017-01-04 07:59:21 +13:00
TehZombehz
96b6cd36d7 Adds key logging to abandoned crate explosions (#22644)
* Adds key logging to abandoned crate explosions

Adds key logging to abandoned crate explosions in order to determine who
detonated an abandoned crate.

* Moves logging under user check

User logging only occurs if there's a user to log.

* Minor grammer update

The potential for 'has detonated a abandoned crate' bothered me.
2017-01-04 07:56:02 +13:00
Joan Lung
624ea1352c Adds a wrapper for flick_overlay() (#22642)
* Adds a wrapper for flick_overlay()

* are you sure
2017-01-04 07:55:45 +13:00
Mervill
00f6fdd1f2 Removes two instances of nonlatin characters in name/desc text (#22659)
* Removes two instances of nonlatin characters in name/desc text

* avoids trademarks, eh
2017-01-03 13:52:05 -05:00
Haevacht
b0e26a798e Flan Refactor + spellaftereffects (#22589)
* Splits the water flan away from the base and adds spellaftereffects

* updates the tomb

* fixes them dying in spess thanks joan

* slowly learning how procs work

now with 100% less trailing returns, fire flans extinguishing and 100%
more comments about varedits
2017-01-04 07:31:06 +13:00
Joan Lung
feede86b09 Adds a proc for duplicate-avoiding associated list keys (#22608)
* Adds a proc for duplicate-avoiding associated list keys

* neat
2017-01-04 07:30:46 +13:00
Cruix
9a612633f2 Fixed synths being invisible if they assumed the disguise of a species with a limbs_id (#22647) 2017-01-03 10:10:30 -05:00
Kyle Spier-Swenson
2ed26127f3 Lets reset the toggle before we block 2017-01-02 23:01:51 -08:00
Mervill
49d51da5c5 adds weightclass2text(), updates package names based on item size 2017-01-02 18:02:40 -08:00
XDTM
a9e62ab70a Merge branch 'NowListenClosely' of https://github.com/XDTM/tgstation into VossOfGodd 2017-01-03 01:00:14 +01:00
XDTM
e001582161 more stuff 2017-01-03 00:53:57 +01:00
Mervill
9cd5ab554e Makes parcel descriptions less confusing 2017-01-02 15:35:39 -08:00
Cruix
ba1ff745b1 Fixed being able to pull lockers out of wrapping paper (#22648) 2017-01-02 16:58:01 -05:00
Kyle Spier-Swenson
e105e72065 Updates sqdl2 to work on datums much quicker by ignoring atoms
Also makes it use a typecache for more speed.
2017-01-02 06:51:59 -08:00
Cheridan
d92c8aaa8d Merge pull request #22635 from Mervill/bibleupdate
Basic canUseTopic check for the bible, removed dead code
2017-01-02 08:18:42 -06:00
KorPhaeron
40d347b2de Adding a player to the watchlist adds a note as well (#22544)
* Watchlist

* Secret note
2017-01-02 15:09:05 +01:00
KorPhaeron
010f305ee2 Fixes portals moving anchored atoms (#22587)
* Fixes portals moving anchored objects

* Missing a letter

* Mecha
2017-01-02 15:07:11 +01:00
Kyle Spier-Swenson
280dbe20c3 [Ready] SSthrowing + callbacks! (#22476)
* SSthrowing + callbacks!
Throwing is now a subsystem.
It's low priority, but is a ticker subsystem so is ran before most other subsystems.
To allow for shit to run after the throw finishes, throwing now supports a callback.
A callback datum system was created, conversion of addtimer is planned for another PR.
Throwing now has a limit of 2048 turfs (was 600)
Throwing now ticks every world.tick, and properly converts the speed arg from 1ds to what ever tick_lag is.
Throwing now properly accounts for missed ticks.
Throwing no longer uses sleep.
Throwing should no longer lag since it's not filling the sleep queue up

* Smoother tentacles

* Some improvements

* Missed a spot.

* Makes shit quicker.
Inlines the thrownthing.tick() proc.
Raises missed ticks value
Lowers max dist value
Inlines the two sister overrides for /atom/movable/Moved() because that just seemed like a waste

* >PRs open that use procs i'm removing.

* STOP THE PRESSES!

* throw_at now runs the first throw tick() immediately
This will help some with throwing while running.

* Item throwing now imparts the momentum of the user throwing.

(ie, running in the direction you are throwing makes you throw faster, running away from the direction you are throwing makes you throw the item slower)

* Moves throwing momentum from carbon/throw_item to movable/throw_at.
There are other things that cause a mob to "throw" an item, I figured we keep this universal since thrower is already an arg.

* Explosions throw shit faster.
This was stupid, "Hey, lets set the item's throw_speed to 4 so embedding works, but lets make it throw at the base 2 throw speed for no reason."

* Fixes explosion embedding.
This also acts as a nice example of how to override a callback in an override of throw_at properly.
2017-01-02 20:08:03 +11:00
Cheridan
d69f10003d Merge pull request #22621 from Firecage/None_of_them_there_swarmers_on_my_field!!!
Disallows swarmers from deconstructing soil plots.
2017-01-02 00:53:52 -06:00
Cheridan
531a410d4b Merge pull request #22614 from ChangelingRain/lensfix
Interdiction Lenses must potentially be able to return power to be able to drain power
2017-01-02 00:45:42 -06:00
Cheridan
e9b66c7c7e Merge pull request #22600 from Supermichael777/FUCK
Tesla shocks from grilles now consume power
2017-01-02 00:19:57 -06:00
Joan Lung
1a067f5944 Ratvar no longer converts corpses or sets corpses on fire (#22615) 2017-01-01 23:32:00 -05:00
AnturK
be9069ff1b Fixes turret lethal mode not targeting lying/handcuffed/critted humans (#22613) 2017-01-01 12:03:08 -05:00
Mervill
0c1fce9987 organize the code a bit better 2017-01-01 06:07:49 -08:00
Mervill
94a5a4be10 Basic canUseTopic check for the bible, removed dead code 2017-01-01 05:53:49 -08:00
oranges
ee09487f55 Merge pull request #22605 from Firecage/be_seen_cardborg_lights
Fixes the overlays on cardborg disguise.
2017-01-02 02:15:37 +13:00